From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BF5DA04FF; Tue, 24 May 2022 07:39:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E73594014F; Tue, 24 May 2022 07:39:15 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id AB4C4400D6; Tue, 24 May 2022 07:39:14 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24NK72ci009194; Mon, 23 May 2022 22:39:13 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g6ykm142n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 May 2022 22:39:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lwKt1RGDT9aOZ0g077VmbuxLuK6sK61VUS2OmifPInuBtmh/IdLFo2HpdEpB5kBUpnCIt5l7VNmQsyxVHiLmtl+0VWxAtmCA+G3LbrEM5ilrjZ2FvAHABzNqppBrYJa9u251BVLoTUvOiP3U7uSayrKQ49kkv7eEpAmGDGDR43e97ydoAsZ0cdT27gDMaIDj60q+UJvYa/TUQpDtWVYN3hkiafuvbd9KthQ1Pzg8z256u/0X9rpveJB511kRseJKoupjBKciXs7UypxW0s5eVvicnW70BJ6jJKvbLDd0oIDQnZjxXwgftZ/kxUiex9v04iC0U0GWBHKdUbLlsrxBcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kfGPyi4OCYQ8demriBVPRVsrsj338N3aJz/ltlIaTx4=; b=OpENwbJwQXI6wvkB5VgtKbZDSYZbTLtrl1BHUMYf2VSRx0idaU3pWKQhBeYarGIpZQ/1zATe7PGi23HqiCvNnHgXBMStKbMadJJJLxwfnlQn6Z5RxXfqx3fS7aFj0DOpLznMVeNALZ6wgX0TRv9l0YrUiT3YDjuYYE8/FL8kYz+FNqiD1w2XR9jB5tigRG5jVerPAZjvMsiJFs/TaxG0hG20UhJn0nonAaLDfxXKwrqWepoML7WaNwXMpvUubtDSuCOEksCuv9jLcO6evN2cD5V4+ssaY5txfTXjaPkq1Kyrvdj2PtbPYiXKAWN6WPEZOrLho6l4gPg3ZwXGUcuCsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kfGPyi4OCYQ8demriBVPRVsrsj338N3aJz/ltlIaTx4=; b=aDEPjU/POPIt7BwFjZvRKfzBmnu9kE4v+5mCBjEphj8SqhFFksKPVNue9mkh7kg4cALE2n7EluBPPESj9O3Q2ZgnoTmcQZ+NcYi5BOnH+0l0me80TWei0IBSzWINKJcJhEvPvXrHQInQUqQN14SnodKNGvw3CUmZLF8qdBxBd7I= Received: from BN8PR18MB2482.namprd18.prod.outlook.com (2603:10b6:408:9b::23) by BN8PR18MB2882.namprd18.prod.outlook.com (2603:10b6:408:a2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 05:39:11 +0000 Received: from BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::d409:66d2:1a81:ee6d]) by BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::d409:66d2:1a81:ee6d%7]) with mapi id 15.20.5273.022; Tue, 24 May 2022 05:39:10 +0000 From: Rakesh Kudurumalla To: Thomas Monjalon , Jerin Jacob Kollanukkaran CC: "stable@dpdk.org" , "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "ajit.khaparde@broadcom.com" Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Topic: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Index: AQHXfYd7L4dTcIZ+J0yRnIum/STvbqwAdsEAgA94qwCAABO0AIAK+z4ggAAJdACAFc2x4IAsMZVQgCJoOxCAABTHgIAUPxbwgIRYgvCAF0phwA== Date: Tue, 24 May 2022 05:39:10 +0000 Message-ID: References: <20210720124713.603674-1-rkudurumalla@marvell.com> <3120644.AJdgDx1Vlc@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1bc8afae-fb68-4aa5-b58c-08da3d47ba3c x-ms-traffictypediagnostic: BN8PR18MB2882:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1/96SfZ2ci+6iWjw/t7KsGdroO4e1ogmb2tOgg3aUeTTPWX0aAU+L7QX5FgDoENagqxQUfR0AGfe8S98GFr5i0xt5BJ8ZjZSW1jv/DiEAqvIu28i4ZVEA+ArdaMdMLrwC97iWOPpGo3g8N1Lrqj1PuWKb6WS7yRAGUVmpFjimJlx5iExDdKnVSnyUnecNYFJhakEjXoXsUugTGVEbyjzdWQUPNHGd+a9yqzJGc/t6yqrdrSd2mGBfPnXhofHRCbAb5EvmpjjNq8pPmiD/3//Kuapj2a0FbiUZFuDxYmp+gTjiZnPiCUGDpcSajqUsVWtDjYrKY6YlLsyCCY6CYVq4P9rOEUzExbYPqMArJtNrG2wKoy2gjrM8wyuBtpvMzXFmQg0YjTLFTXK1DuI0ijde8lxXr94rehMQ0xmxoMCIHC4eeHEXzxJg8ol9/AjwIqLsyhhRzkcnBhhLEP0zJxOuRJPhcol88ak9dXs1x+qPXANM5FN1E5ZZnFhmlEUx9LtbfIfQlg0eR+0FE4N5gcAPzDTsEtPYxSmYUYnv89ZAoVRXEz3ngxQLbVGInjrLlVRarsvkYSkuAXnKJoIkMAk9i1i1xCn/xSLYJnZ4dZoeLgSsduZmDQcoGogj8jm9FOoNzaJ+8qewuTovDYnEDCDEqPNzw4eezqbtiqTzJ5zbLS5RXs+jk72KP1/cxVI/8FCm56yTnd+oLCkXgOcY1UnEg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2482.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(33656002)(38070700005)(122000001)(38100700002)(83380400001)(26005)(86362001)(6636002)(110136005)(55016003)(316002)(54906003)(52536014)(2906002)(4326008)(5660300002)(8676002)(76116006)(66476007)(66446008)(64756008)(66946007)(66556008)(8936002)(71200400001)(508600001)(7696005)(6506007)(9686003)(55236004)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Eeuv9maS09pKzuvUsyTSHLLld9XM4bzkVhclSgnhK/I6GbHJGtYX3zFb1pJ7?= =?us-ascii?Q?bKuRlLaINVregJvhxVb064bcAVCpG16hjaJ98DmNpD2K7dXEQW/pQKCqU+/A?= =?us-ascii?Q?08HLmmqr+SQLNOfw8L1Xd8cwONEkYEOwHLQqPVyKtU+12D5Zmc6Zvxy9uuPe?= =?us-ascii?Q?JTUcjnjM6XIgWHTqXqZ2/hITx6jKnLwmg2YJU8JFJlQ+ygl/klpeNQDBO/rv?= =?us-ascii?Q?41me/2s8yVawwHm4CzKfU9YXon+YEwZmVyLPEPI3aPkEFJdUPHznk/oQFvY7?= =?us-ascii?Q?9JechaO7z/xWbCfjPR7OZbf0ZeNb+7Fqoh2lSs2uD8yRQMc9xMKUuzWlh2g8?= =?us-ascii?Q?S3WjaavinKSnh19HE3Ex9v1taPBTwx1r9m+/tVN7O+lzB+O8w3E4/+bRXRIC?= =?us-ascii?Q?Vj/dlqaJcj/RG6o6Ssid/JJZMBA87wrgKDkwhsd03kkGt8RnksjP3G05SYnu?= =?us-ascii?Q?g5rDvf/DrDzIFM9HwmGQMspl9WnDJyzop2bxJ5/NoZO1KJ/7oR+vzvG7u/2w?= =?us-ascii?Q?dNNllLAhUleAJViAnnNuRrhw68qjS591cgV1SBsq7UFWfKcQnc/AMoaNupRk?= =?us-ascii?Q?gprG300KpQI+L+6trcGbMpA5sA7QsWr0na6ZtyRVMixPlepR41PjuRs4X9Wh?= =?us-ascii?Q?ph1HTwLqxKUoz9L3LSHuvQ+U5RFQDZnRNUmdofViLUPtUJ3xU9tHufCXpiXz?= =?us-ascii?Q?Db1gwTjDUbd4MyenK4tzC53XcKhRwMfr4h+s9RzOLgc6pKpOXXmKQCrssb1C?= =?us-ascii?Q?9R9fCzmJ5NlO3MjdLcISCgYj777EwgMXQRGijVlxXFXGeSv4KjR07GP1P4vd?= =?us-ascii?Q?n/fsa2yR1pjAjTKP/hSVH9P4ymJytBv03jpPUDjXKnVis1MmMWTVxre27M7J?= =?us-ascii?Q?OQihhlBJ8Atv1kGEqGZGqIuNWqY7CRU7aovLiojjXqW7/xdgliqCw23tqZrr?= =?us-ascii?Q?JdnjYVM7XXN2dUfTIFidwQ9fKEpZkkfdTG+oDJSg1p7LIugpk9zc974CE0k5?= =?us-ascii?Q?+Qo7dLcPPMJ87BVwbs2NzLZejyIE3HBSZVB1A0I7zNwtkoUZZBTd07afwm61?= =?us-ascii?Q?HdpEolm3eJj0TGw+H2bm1RmZ1C83XzJb16Vs20ZhMRK4bEwkXwAs9gTXUUC5?= =?us-ascii?Q?FEFTlWAjAECnzV0mLv94O+5SBLKvsB3rdK2unIlDoj3/IIToAWuPr2QCe/sE?= =?us-ascii?Q?WReTuoV+DfPZT/nU9UFsm4zPkxUSKWT7uR7avdYhx2uQGhowTxhJ4JGBVjEm?= =?us-ascii?Q?ksTanzx8Hip7yeayUF9YbaaUALeqqMNiUwFWw3ECwqn1dlPfMV7jSpAKRxww?= =?us-ascii?Q?Tw/O7ICSFuovAX1Qp7yaIP/gBnvknFVgQjbnSHbd1WD7+CV4u7nGIhKolOFW?= =?us-ascii?Q?s14M7Yadm/kfbbhsdXSOWH8R9LZ1TOZkSy2ZkpeE5OKEkT/tcUgTy6jVK7vQ?= =?us-ascii?Q?0egPQ06S1V+GyWMFwd5LRAnC1ZkNO/DhQlsUie+brZlmAQO2gCxRqzVB8dgn?= =?us-ascii?Q?xtedKv99Yck2KRnBPBNrd9Oj3JBNjkCpBuvm4Dg0pskIYEjMLt5euE2Le0vJ?= =?us-ascii?Q?bAQ7QzIOKM29NADTpVwTGRV1HM1M4jO7MelpUPsgc5qAwhi9gFCRVH3KAasw?= =?us-ascii?Q?3akRWM4pvPGBGN9TI9DAfm7KUTK2HIGYxYbzC0x3kPgX6JIHa2KqbASAx4tT?= =?us-ascii?Q?bT0xbHRSUcGNizc2qP9jchg9MSB99uciTz/KjlhCebm1d0yICszYjoBqeJNB?= =?us-ascii?Q?zBJSUfovgQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2482.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc8afae-fb68-4aa5-b58c-08da3d47ba3c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 05:39:10.2390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9unyQ6FOq9Pqiqk8G3uw5r5wSpgCuUVMeOj3XVxx3wHVmgriIuGVvBmG1thuScgpxFHlBEaKAMBT0l8CVqzBLoaNVsAdUgcz91E1IVFP+FE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2882 X-Proofpoint-GUID: QuUg9AFQsaTEQg1Uu-FHKXqOlJ4dXCF_ X-Proofpoint-ORIG-GUID: QuUg9AFQsaTEQg1Uu-FHKXqOlJ4dXCF_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-24_01,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ping > -----Original Message----- > From: Rakesh Kudurumalla > Sent: Monday, May 9, 2022 3:32 PM > To: 'Thomas Monjalon' ; Jerin Jacob Kollanukkaran > > Cc: 'stable@dpdk.org' ; 'dev@dpdk.org' > ; 'david.marchand@redhat.com' > ; 'ferruh.yigit@intel.com' > ; 'andrew.rybchenko@oktetlabs.ru' > ; 'ajit.khaparde@broadcom.com' > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queue= s are > full and Tx fails >=20 > Hi Thomas Monjalon, >=20 > Same behavior is observed in cnxk driver as well. > Can we please get this patch merged ? >=20 > Regards, > Rakesh > > -----Original Message----- > > From: Rakesh Kudurumalla > > Sent: Monday, February 14, 2022 10:27 AM > > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > ajit.khaparde@broadcom.com > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if > > queues are full and Tx fails > > > > > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Tuesday, February 1, 2022 1:15 PM > > > To: Jerin Jacob Kollanukkaran ; Rakesh > > > Kudurumalla > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > ajit.khaparde@broadcom.com > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if > > > queues are full and Tx fails > > > > > > octeontx2 driver is removed > > > Can we close this patch? > > Same behavior is observed with cnxk driver, so we need this patch > > > > > > > > > 01/02/2022 07:30, Rakesh Kudurumalla: > > > > ping > > > > > > > > > -----Original Message----- > > > > > From: Rakesh Kudurumalla > > > > > Sent: Monday, January 10, 2022 2:35 PM > > > > > To: Thomas Monjalon ; Jerin Jacob > > > Kollanukkaran > > > > > > > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > > > ajit.khaparde@broadcom.com > > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang > > > > > if queues are full and Tx fails > > > > > > > > > > ping > > > > > > > > > > > -----Original Message----- > > > > > > From: Rakesh Kudurumalla > > > > > > Sent: Monday, December 13, 2021 12:10 PM > > > > > > To: Thomas Monjalon ; Jerin Jacob > > > > > > Kollanukkaran > > > > > > Cc: stable@dpdk.org; dev@dpdk.org; > david.marchand@redhat.com; > > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > > > > ajit.khaparde@broadcom.com > > > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid > > > > > > hang if queues are full and Tx fails > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Thomas Monjalon > > > > > > > Sent: Monday, November 29, 2021 2:44 PM > > > > > > > To: Rakesh Kudurumalla ; Jerin > > > > > > > Jacob Kollanukkaran > > > > > > > Cc: stable@dpdk.org; dev@dpdk.org; > > david.marchand@redhat.com; > > > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > > > > > ajit.khaparde@broadcom.com > > > > > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid > > > > > > > hang if queues are full and Tx fails > > > > > > > > > > > > > > 29/11/2021 09:52, Rakesh Kudurumalla: > > > > > > > > From: Thomas Monjalon > > > > > > > > > 22/11/2021 08:59, Rakesh Kudurumalla: > > > > > > > > > > From: Thomas Monjalon > > > > > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla: > > > > > > > > > > > > Current pmd_perf_autotest() in continuous mode > > > > > > > > > > > > tries to enqueue MAX_TRAFFIC_BURST completely > > > > > > > > > > > > before starting the > > > > > test. > > > > > > > > > > > > Some drivers cannot accept complete > > > > > > > > > > > > MAX_TRAFFIC_BURST even though > > > > > > > > > rx+tx > > > > > > > > > > > > desc > > > > > > > > > > > count > > > > > > > > > > > > can fit it. > > > > > > > > > > > > > > > > > > > > > > Which driver is failing to do so? > > > > > > > > > > > Why it cannot enqueue 32 packets? > > > > > > > > > > > > > > > > > > > > Octeontx2 driver is failing to enqueue because > > > > > > > > > > hardware buffers are full > > > > > > > > > before test. > > > > > > > > > > > > > > Aren't you stopping the support of octeontx2? > > > > > > > Why do you care now? > > > > > > > yes we are not supporting octeontx2,but this issue is > > > > > > > observed in cnxk driver ,current patch fixes the same > > > > > > > > > > > > > > > > > > Why hardware buffers are full? > > > > > > > > Hardware buffers are full because number of number of > > > > > > > > descriptors in continuous mode Is less than > > > > > > > > MAX_TRAFFIC_BURST, so if enque fails , there is no way > > > > > > > > hardware > > can drop the Packets . > > > > > > > > pmd_per_autotest application evaluates performance after > > > > > > > > enqueueing > > > > > packets Initially. > > > > > > > > > > > > > > > > > > > pmd_perf_autotest() in continuous mode tries to > > > > > > > > > > enqueue MAX_TRAFFIC_BURST (2048) before starting the > test. > > > > > > > > > > > > > > > > > > > > > > This patch changes behaviour to stop enqueuing > > > > > > > > > > > > after few > > > > > retries. > > > > > > > > > > > > > > > > > > > > > > If there is a real limitation, there will be issues > > > > > > > > > > > in more places than this test program. > > > > > > > > > > > I feel it should be addressed either in the driver > > > > > > > > > > > or at ethdev > > > level. > > > > > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void > > > *args) > > > > > > > > > > > > nb_tx =3D RTE_MIN(MAX_PKT_BURST, > > > num); > > > > > > > > > > > > nb_tx =3D rte_eth_tx_burst(portid, 0, > > > > > > > > > > > > > > > &tx_burst[idx], > > > > > > > nb_tx); > > > > > > > > > > > > + if (nb_tx =3D=3D 0) > > > > > > > > > > > > + retry_cnt++; > > > > > > > > > > > > num -=3D nb_tx; > > > > > > > > > > > > idx +=3D nb_tx; > > > > > > > > > > > > + if (retry_cnt =3D=3D MAX_RETRY_COUNT) > > > { > > > > > > > > > > > > + retry_cnt =3D 0; > > > > > > > > > > > > + break; > > > > > > > > > > > > + } > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >