From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27394A0471 for ; Tue, 16 Jul 2019 14:07:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 277002BF4; Tue, 16 Jul 2019 14:07:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 919B82BAB for ; Tue, 16 Jul 2019 14:07:00 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6GC4jbb002305; Tue, 16 Jul 2019 05:06:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=TipWrEN6e5hs6LitKPSwl8MtRXLowqUvPGMUZS86CiQ=; b=r5lQnabWwRFkDC23W1Bvy1UW+I6ZVTJesoI/OdM1kwl4SU8q77WHiaO3c53SkS3cpOx8 Zl0uVrwue5ktkvvfYjH2Myj9YAyxFGEqeYdvxT/Q/DxNmdYVo30ZCrK2WIcOMoXvOanu XgCWR4qZkB5U6ILldlVv75NLfSZlB1Ukn1e4gyRWCuzarXVyLX5DGRN51yM/6yC6WtTm VK/mcvriEpxyqyNMSeipK5eHKAanMO6knKVAZjm9mCVBW46JpJeGw/K+wCsGX5NBMieo wmGqcQ3fsgmUvA1t64iepFCpU6dfH0ub1RiQofjoCPZO2ZF4ky2UbcWUppM3v5buUw73 Mw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2ts0a22xca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 16 Jul 2019 05:06:59 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 16 Jul 2019 05:06:57 -0700 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.56) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 16 Jul 2019 05:06:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Za5lq2l31L4SgIhz2119BnRXpNejJWcED2TD7C6cZddoMnOaWVyACAaJEtH4PLzz21zbmaeJnrfVijETn0R15cA4Bn5l/dtKw8g7oWyJrs7vOlzapMK/I3VZhc56FKOywocadK1YiBkzLImjjeykDETbE5XKZGw1n87hllK9Dzk5lz33bl5oyyNi/8LTYAirgnRdrrnqqXeBRxJYmcM5HOMObJnGuDNnkakHeDqh0FqlqV5WDQFRziz8JH7UpsQdbWk/FhLV1QmED3r+ZOLTQ1oqoeHiKInqafK61M2aWpoxqHpIQli9tkO23wRht4/p9GFctXVZbqK63grXMSr5cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TipWrEN6e5hs6LitKPSwl8MtRXLowqUvPGMUZS86CiQ=; b=PRNJuOxiRHezxxNHNiBoKBlrLLHnLW3jSVztBvm2SkXNh1jV/uxs9C1GWQySJ7hpQIPqPMYI5Xkuc0gNngIlWb/2lvvg749LS1omYyLPqAIAee44VvaHMnsPNO2D0UcfsIyZQvlvNDsrShCXvwiIGsHtmFmSBvwi4IhpvDeEo3xn+m3S4WE/6BEqoK6Ix4v6AMtNVFpKkm48NsAR3MPmD1CHrAufsoQ4XuSkA6qWKjkG8y1Pk+XhLRhXqzlfDRVQ9WIZ0SizPIDyujz+KGZbvaY1JQieSUaYEAqmKEsxFZo+JfaoWpvFwt3aPNBbeTiDbI2VCYUQT1CA/6NGAR8vDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TipWrEN6e5hs6LitKPSwl8MtRXLowqUvPGMUZS86CiQ=; b=IfRGYBI6akUO/3pT+68h3W7ehHLbYevciyLJp/ZGIL9aC04xht1C0T1OmOVirW6EphttkTgiYbF7kxW4TFV9QJw83Wp8pm4qEysPzi4grrbctvyBUTi5x0aZjN7Jfinc/lg9OJcippXUyfLurT3NXkWLOF39Az2YLw0zJI9FcdE= Received: from BN8PR18MB2691.namprd18.prod.outlook.com (20.179.72.94) by BN8PR18MB2788.namprd18.prod.outlook.com (20.179.73.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Tue, 16 Jul 2019 12:06:32 +0000 Received: from BN8PR18MB2691.namprd18.prod.outlook.com ([fe80::d47d:48af:a340:403e]) by BN8PR18MB2691.namprd18.prod.outlook.com ([fe80::d47d:48af:a340:403e%7]) with mapi id 15.20.2073.012; Tue, 16 Jul 2019 12:06:32 +0000 From: Sunil Kumar Kori To: Thomas Monjalon CC: "dev@dpdk.org" , Konstantin Ananyev , Jerin Jacob Kollanukkaran Thread-Topic: [dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Thread-Index: AQHVO58Az58jY2/DoEmia3z7Xn3KyabNGg6AgAAL92A= Date: Tue, 16 Jul 2019 12:06:31 +0000 Message-ID: References: <1563258209-2114-1-git-send-email-skori@marvell.com> <26077215.QO4oM8pdKP@xps> In-Reply-To: <26077215.QO4oM8pdKP@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b57cff4c-34ab-4642-c5de-08d709e60a94 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN8PR18MB2788; x-ms-traffictypediagnostic: BN8PR18MB2788: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(4636009)(346002)(396003)(376002)(366004)(136003)(39860400002)(43544003)(54534003)(13464003)(189003)(199004)(64756008)(8676002)(66476007)(6116002)(7696005)(76176011)(66556008)(66946007)(66446008)(71190400001)(8936002)(486006)(966005)(81156014)(71200400001)(4326008)(33656002)(81166006)(446003)(3846002)(6506007)(256004)(5660300002)(68736007)(76116006)(478600001)(14454004)(186003)(53936002)(316002)(6436002)(52536014)(99286004)(55016002)(102836004)(107886003)(6246003)(25786009)(305945005)(229853002)(74316002)(7736002)(9686003)(6916009)(6306002)(2906002)(66066001)(86362001)(11346002)(476003)(26005)(55236004)(54906003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR18MB2788; H:BN8PR18MB2691.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: pm2VqJuCWXzRoYcx99hE73Pw4cPmYrDbghBobA0XhmQBtx9iZmZ66DnfoK6Q7fcxfkHBwK/vZG9OhwwKP6hJ29iAupn3TeWRUzAUYTv+mIEJ8w1s5R32m31+W3Ea30Io9pqLAQ6vbnTSTRHesgVAn3fiI6FZWrn4Y8VlGDbqyjL43xa1+C8V+gLnWrIskGRz7xYr5igEpSGiFp6NKvAnErY+dHhEEmUONRNIDjsZB+dNXGgrzr9YedwSoXE9adxifJIWIspTmNorNDSHovKkcfIsbD8XkPRoCGixGdODPAZYMMoWMgm1F5fPSfEUMCJV+Y+Cq4kMRWTLZsO1KiYGty03UuXNXiCk3S7TBmhq8YaSuzjjRNH88HvbgZcydViFc4hvs6TDcZHnXKi5tk0Z5zby67Qyb35u96174uggONU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b57cff4c-34ab-4642-c5de-08d709e60a94 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2019 12:06:31.8655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: skori@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2788 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-16_03:2019-07-16,2019-07-16 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Regards Sunil Kumar Kori >-----Original Message----- >From: Thomas Monjalon >Sent: Tuesday, July 16, 2019 4:52 PM >To: Sunil Kumar Kori >Cc: dev@dpdk.org; Konstantin Ananyev ; >Jerin Jacob Kollanukkaran >Subject: Re: [dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove >PKT_TX_IP_CKSUM offload flags > >16/07/2019 08:23, Sunil Kumar Kori: >> Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during >> fragmentation operation implicitly by the library. Because of this, >> application is forced to use checksum offload whether it is supported >> by platform or not. >> >> Also documentation does not provide any expected value of ol_flags in >> returned fragmented mbufs so application will never come to know that >> which offloads are enabled. So transmission may be failed for the >> platforms which does not support checksum offload. >> >> So removing mentioned flag from the library. >> >> Mentioned changeset is part of http://patches.dpdk.org/patch/53475/ >> Changes for reassembly operation is already accepcted. This patch set >> implements the similar change for fragmentation operation. >> >> Signed-off-by: Sunil Kumar Kori > >Sunil, I would really appreciate you take care of the formatting. >The previous patch had a changed title to comply some coding style: > e29fc4437 ip_frag: remove IP checkum offload flag >It requires also this line: > Fixes: e29fc44370c2 ("ip_frag: remove IP checkum offload flag") When >sending a new version, you are supposed to: > - add a changelog > - use --in-reply-to > >Applied > Thanks. Its my bad that I forgot to send next version with "--in-reply-to" and shar= ed as a new patch. I will take care of suggestions in future patches.