From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAAC5A0471 for ; Tue, 16 Jul 2019 08:28:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2ACE2C18; Tue, 16 Jul 2019 08:28:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C7E8E2BF5 for ; Tue, 16 Jul 2019 08:28:24 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6G6QYwU026768; Mon, 15 Jul 2019 23:28:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=klpUIVNLsDpJW+QwnDGhoMv88mcvq7FJqzCDV4pSpFM=; b=oS6AYDvU21698yUR4tN40dRiPIjmNrez8hOq7nKFpSy9D254XdPSFcjtw/1yX8zy9PVk 0RCkExglRg1EOqtWs82rW1GNXS9Mq+WGRajmeEt1JVf0bsXqOdR8kwQ7M1LSAIASLbZ2 3AGvKe/exdqgvZdQsw0W+rVh01V1tjpvnfzCfrxi0N3WMMSECgQCJDmjYPA4q1PnVwwo BA8kkJUld4VPW3FYmugHuuYMCTl8r7fHcawdxCQnefEpEgp/e45wgWrJKXU4uqLCI5ga /Xbdj/1CPH/7iG4jVomjky3kkk2rNokWKdM/iJKFte78OmN/kuV/6mEs7S5rULcn+jCD iw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07v9wyw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 15 Jul 2019 23:28:23 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 15 Jul 2019 23:28:22 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.59) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 15 Jul 2019 23:28:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WscoPOP92Tin6525sTgaCZPR4CYY1lZ+v4s+M/eo8Ar1DHviULaKhF7TzCqlh//mtq48r2g3J9epRGQTDIEs5s9QbZex8ANcwZ4fyMr0JxZyiWRYKCoJ6HfMDds0ZisTM8CxFXWJRJBXkpXngLKrmq+GcXa/HMzCRhXObVJzmJ7ZJvAqUJNKk6Ovd81/hT1k9NhkqxS2qmuteoGiHv60gtAZ6eYW+A612f1vGddIKjq2tv/0nqWYgxfn0q6Wf3X8rJQdA2oI+gq8Wh0gzqOr2pUcebQnvnHmai0cTEdqLuMOWhzIXYqqiOvJ/3p8SrS4z1CKxvK4exAZeGonJ9eZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=klpUIVNLsDpJW+QwnDGhoMv88mcvq7FJqzCDV4pSpFM=; b=gCCqvbgCfRNqWsv9D37oFWIROXdNH7u1tOKzRAOWl/5BLrvR7QsgdIZPjAPIpK/0jgVwHmDgXqLFiYyC3Hr7wKgkqTLrqWlN0X7rhZFi6K2t2EdcXWBFijkgCqKXoIsLZ6XiI78ILczBnPFospb4Cd1RT6Y8UfCV9bmzdxiXd3PQfWAiPrxj/OWOUGFQBtmrxI4RKoov0XgrHPIXO66Usa5FVw96IXTx7ZXX64y+OAhHiNYRtoqPgDwaa8b4QMyXmoTVeNRygDYxwdteviTjZ/uf6qA+uNgOvVt5NVeDrDMMxl5tlRhJ7OhVb6lbLWMAd5oFU4vlAjBbnXpIlZJ1xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=klpUIVNLsDpJW+QwnDGhoMv88mcvq7FJqzCDV4pSpFM=; b=mSscBCjfZQ2++xYaYmjZI0XFBt2KySS4yXTq2+WDAGzGAvlCBmrchn3G7PLRlzy+NIXpZ81F37JAl9ZGGqBOFk+Y8xt3fA4t3ArfKEuVCYyv9NBU4Zt3UerTSx/auc4DcAlnHhJLGO6yWFxeyA8ECaKl4+I+RQEnA8wuQyL6EB8= Received: from BN8PR18MB2691.namprd18.prod.outlook.com (20.179.72.94) by BN8PR18MB2962.namprd18.prod.outlook.com (20.179.76.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Tue, 16 Jul 2019 06:28:17 +0000 Received: from BN8PR18MB2691.namprd18.prod.outlook.com ([fe80::d47d:48af:a340:403e]) by BN8PR18MB2691.namprd18.prod.outlook.com ([fe80::d47d:48af:a340:403e%7]) with mapi id 15.20.2073.012; Tue, 16 Jul 2019 06:28:17 +0000 From: Sunil Kumar Kori To: Jerin Jacob Kollanukkaran , Thomas Monjalon CC: "dev@dpdk.org" , Konstantin Ananyev Thread-Topic: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Thread-Index: AQHVOuXir/LsFjcVkUm58UdBzgmj3qbMPPgAgAB/loCAAAyu0A== Date: Tue, 16 Jul 2019 06:28:17 +0000 Message-ID: References: <1563178677-16356-1-git-send-email-skori@marvell.com> <1710765.olV4FGjhGL@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36a1f800-1c52-4b2a-248c-08d709b6ca22 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN8PR18MB2962; x-ms-traffictypediagnostic: BN8PR18MB2962: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:428; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(13464003)(199004)(189003)(476003)(76176011)(76116006)(66946007)(446003)(66446008)(66476007)(55236004)(53546011)(26005)(64756008)(66556008)(486006)(11346002)(102836004)(7696005)(86362001)(6246003)(52536014)(8936002)(5660300002)(81166006)(81156014)(6306002)(256004)(53936002)(55016002)(6436002)(2906002)(9686003)(6506007)(186003)(68736007)(25786009)(110136005)(33656002)(99286004)(54906003)(316002)(966005)(71200400001)(71190400001)(8676002)(4326008)(14454004)(478600001)(229853002)(7736002)(74316002)(6116002)(66066001)(3846002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR18MB2962; H:BN8PR18MB2691.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YONcC+Ufxoq9jQ/gaNO3vB5ygsrs1M6sWnflslucb9Up7SBjoCMhBdAcGhZnwYAUhN3hBdT5K+JX1TNnldDM675/EAfwtaaYgC88YSN4vhABrpSMnGE9+t0S+fA7VxI2EEi4ZTk5EWggxm37BbFltmstL37ghLKVeOV7hGN8wda5B9lfBvAmCPRmSxfnw8GeJi6LLE2wqufwoGDETQgxeRh5dwhLw0W6AV2vGijEBBK4c8wV+G7onDTbGMhZ2PQKwGW3CqUGFG7qcRY02v6C05VBBEApWs0mSMze0WagDFui11K8VMLauVhq0zb7hGChBunoQoQsUWl6MLZ2ZLRzRGmajkLt5mAZWrR7zVVUZdTGFmV8ramIQ+9cebvOJjwdV2ou0p97PD+QPVFU+dHTeP/22CcLc/apekclQiJkZFw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 36a1f800-1c52-4b2a-248c-08d709b6ca22 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2019 06:28:17.4008 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: skori@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2962 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-16_02:2019-07-16,2019-07-16 signatures=0 Subject: Re: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Regards Sunil Kumar Kori >-----Original Message----- >From: Jerin Jacob Kollanukkaran >Sent: Tuesday, July 16, 2019 11:12 AM >To: Thomas Monjalon ; Sunil Kumar Kori > >Cc: dev@dpdk.org; Konstantin Ananyev >Subject: RE: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM >offload flags > >> -----Original Message----- >> From: Thomas Monjalon >> Sent: Tuesday, July 16, 2019 3:35 AM >> To: Sunil Kumar Kori ; Jerin Jacob Kollanukkaran >> >> Cc: dev@dpdk.org; Konstantin Ananyev >> Subject: Re: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove >> PKT_TX_IP_CKSUM offload flags >> >> 15/07/2019 10:17, Sunil Kumar Kori: >> > Current patch is part of following patchset >> > http://patches.dpdk.org/patch/53475/ >> > which is missed to be merged into upstream because of accepted >> > version of this patch does not contain this change. >> > >> > Accepted patchset is given below: >> > http://patches.dpdk.org/patch/56202/ >> > >> > Patchset is already reviewed and acked on maillist. Also >> > corrersponding release notes are updated. >> [..] >> > --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c >> > +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c >> > - out_pkt->ol_flags |=3D PKT_TX_IP_CKSUM; >> > out_pkt->l3_len =3D sizeof(struct rte_ipv4_hdr); >> >> Jerin, what happened? A part of the patch was missing? > >Yes. It was my bad. On rebase to top of tree, due to rename of ipv4_hdr to >rte_ipv4_hdr and similar, Those patches need to be manually rebased. > >> Is this patch really required? > >Yes. > >> If this patch is required, the commit log must be changed. > >Yes. Next version is updated for this patch after modifying the commit message. > >>