From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94CB6A04FD; Tue, 14 Jan 2020 07:44:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39AAC1C2AD; Tue, 14 Jan 2020 07:44:30 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id AEC461C2AC for ; Tue, 14 Jan 2020 07:44:28 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00E6h15v023833; Mon, 13 Jan 2020 22:44:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=u3mLXqTS1sLTKodVWnoYkdCepS1pReg4z2MQS6t8SLk=; b=OoXyOlgKRoulNGBfAfzk7M7fa5dRhn/6y4+/ivqbOGwyvYETEkJWjf71GYmdypPjM4eh JY8nn7wWpvgUvDVmZUpEbXFJrzPDHySM1GFVlz9ACTvkO2mljYMyoekiTNNIMMyJleSc 0Zz50/nq+gBChZ5zIgAk/x71YwufMMPAF437p/ReTEvcYApvZaHg+6mPYxASo+lT0b0K uU2fe46xEt5hiNO6CTLoAwutbfn3FNBK7alzftV2vRkK9Mg/NntkIXRJkupU1sK81YWb eZahJ1EjHonAKqAg7mniO8UVKoxhY4NwdlT2/o+JCDKmcDOG4eRYkT0Z+JJ2G7h7Ikf3 Fg== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2xgng4uj2d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2020 22:44:28 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 13 Jan 2020 22:44:25 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 13 Jan 2020 22:44:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bbbDTm9qFizESTJVRw551souPwQqCBxlA7/aJKsdjJP4XnIA9Tq9uObt/wt9Qc3y7f/5Jz60kAn9xgdSVtLovoYG1kRHdDD86gPM2+8sgi3YfrwXFpm91pikg4fKcr/v8Bq+eV8neVuW2M8vOhClrzPOdYPqVrH4gC7ANWnWiApFyCAtRQCB1feUnbsk747KT6fz3RIKLBRMzAkgg171pAhgP+tzZLCR3ZnZN0stA/B7mhtNxfbpsigmUCrBlooryILDvOfoUOCCv0qrLpkhhkIaMmCgDapa20/uAnyH1lAz0OJOeiKk+z1obE/rVKGJ0X0TuhLxwGckG/b1SBtVQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3mLXqTS1sLTKodVWnoYkdCepS1pReg4z2MQS6t8SLk=; b=DHDEXb7AsKUme3UEkTfF/YMRj+bH6NEhwzRbU/I3E6BhwfoyAAtr9AoriXqLWKIA9yeT6H8CpGZfWFjA51dvJ9iwJ+EVl8nDLGoO4bWkoWpmzejLJrMOjt4AIcHKIHLuZ4wgrhrvBsvxMO7tg0ioejPSlr6q9hGEivWVNyRvufVWL3/1hYlU6CpcfM9JVaraNzMeYK7WhTm6QHRH0G8evQ4+V96GnRNmxoah67DHE3EOkSUA4GC6mxxQb3MjWG0atQuMlPp0hHI8qUdPBqmitSX7uXOREpzog+8i8nDn2d5P8qh5SPIdPIM69u7AUTx6fhkwe+xG3JrLv7FuQosT+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3mLXqTS1sLTKodVWnoYkdCepS1pReg4z2MQS6t8SLk=; b=NQCigDGJVb7sDkjW22pIop6AUdGYgBZUX3/BubFIEHOci2Om4h5hlAOHooGeE7QMlXu3btYWgHAzksmn3eoXsSboiqQIiHXbe6z+9mowW1+Pauzgj9MkMJ9h1/fXM8YDcqrk1CdSfvRASVQvKbixKAlfsZohlk81rsiDd51mDuk= Received: from BN8PR18MB2868.namprd18.prod.outlook.com (20.179.74.155) by BN8PR18MB2529.namprd18.prod.outlook.com (20.178.223.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.10; Tue, 14 Jan 2020 06:44:24 +0000 Received: from BN8PR18MB2868.namprd18.prod.outlook.com ([fe80::503f:b089:d457:5aa0]) by BN8PR18MB2868.namprd18.prod.outlook.com ([fe80::503f:b089:d457:5aa0%5]) with mapi id 15.20.2623.015; Tue, 14 Jan 2020 06:44:24 +0000 From: Anoob Joseph To: Akhil Goyal , Declan Doherty , Pablo de Lara CC: Balakrishna Bhamidipati , Fiona Trahe , Arek Kusztal , "Jerin Jacob Kollanukkaran" , Narayana Prasad Raju Athreya , Shally Verma , Ankur Dwivedi , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 1/4] lib/crypto: add support for EC Point Multiplication Thread-Index: AQHVq4JElbUNLhAh5EeH6SZyyV7YMKfoxzaAgAEtewA= Date: Tue, 14 Jan 2020 06:44:24 +0000 Message-ID: References: <1575560280-3261-1-git-send-email-anoobj@marvell.com> <1575560280-3261-2-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2e88f92-c0b9-44cb-4758-08d798bd31b0 x-ms-traffictypediagnostic: BN8PR18MB2529: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 028256169F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(136003)(39850400004)(366004)(189003)(199004)(5660300002)(53546011)(6506007)(55236004)(316002)(7696005)(86362001)(52536014)(8936002)(66946007)(64756008)(66446008)(66476007)(110136005)(2906002)(76116006)(66556008)(54906003)(4326008)(71200400001)(55016002)(33656002)(9686003)(26005)(81156014)(8676002)(478600001)(186003)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR18MB2529; H:BN8PR18MB2868.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2zN7TfwobZPqypV+fZ5GfZInX0bL8chaWmJgJx7irImUI0QdbL+id7iIqAnSeWci9mlGkuUmxHhrZQJXuURFnQ6aqMJgsCASkVndrNkAd89+EGWcuwvezuZGzixmhKMxGyqXbjmPVPPhm+zEVi2jcj+rKVt6hmzxk86gKttBrxfZXYXg4QOISL3E2ov2GKSHiDInLrwDe55oRPGuCw434ps8KkdLcAEoWnr9MKDyAUSOaOigOITTmex+duEBTWX33/wzJkNsBeH+tyZOj6zjOTRAB6Fh679AtOiCBUXyRCFkpxU4jnRMCXq7TN4zu8cBJ8IUX8j65LkqKx446QAxV17EuZo6RNIS6jHmFOgkN/yOkl+3oOvGa4K2A9vB5Xwbo2k77Ysqz2IAK7AR50/+LsKv5BjcZ7kagR732sX2T65NxMhUReR104/KIqm/0aX/ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a2e88f92-c0b9-44cb-4758-08d798bd31b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2020 06:44:24.5112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 82Xm9ZOyBKrAJkfp9uXRP/SGEN4lOn5g4sk6oMkm+s9zQn41NJ4fGn3vF9A3sIzkLmu9fCSuM0v8YWH9ZPSIYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2529 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-14_01:2020-01-13, 2020-01-14 signatures=0 Subject: Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for EC Point Multiplication X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Monday, January 13, 2020 6:14 PM > To: Anoob Joseph ; Declan Doherty > ; Pablo de Lara > > Cc: Balakrishna Bhamidipati ; Fiona Trahe > ; Arek Kusztal ; > Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Shally Verma ; > Ankur Dwivedi ; Sunila Sahu > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH 1/4] lib/crypto: add support for EC Point > Multiplication >=20 > External Email >=20 > ---------------------------------------------------------------------- >=20 > > > > From: Balakrishna Bhamidipati > > > > Elliptic Curve Point Multiplication xform type and op parameters are > > added. >=20 > Description should convey that it is an asymmetric crypto feature. [Anoob] Will update in v2. =20 >=20 > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Balakrishna Bhamidipati > > Signed-off-by: Sunila Sahu >=20 > Title should be cryptodev: support ECPM [Anoob] Will update in v2.=20 >=20 > > --- > > doc/guides/cryptodevs/features/default.ini | 1 + > > lib/librte_cryptodev/rte_crypto_asym.h | 17 +++++++++++++++++ > > lib/librte_cryptodev/rte_cryptodev.c | 1 + > > 3 files changed, 19 insertions(+) > > > > diff --git a/doc/guides/cryptodevs/features/default.ini > > b/doc/guides/cryptodevs/features/default.ini > > index 2f6c785..3a54b07 100644 > > --- a/doc/guides/cryptodevs/features/default.ini > > +++ b/doc/guides/cryptodevs/features/default.ini > > @@ -109,3 +109,4 @@ Modular Exponentiation =3D > > Modular Inversion =3D > > Diffie-hellman =3D > > ECDSA =3D > > +EC Point Multiplication =3D >=20 > I think it is better to have ECPM instead of EC Point Multiplication as i= t is the > case with ECDSA. [Anoob] Agreed. Will update in v2. =20 >=20 >=20 > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > > b/lib/librte_cryptodev/rte_crypto_asym.h > > index dd5e6e3..b98ce6c 100644 > > --- a/lib/librte_cryptodev/rte_crypto_asym.h > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > > @@ -85,6 +85,8 @@ enum rte_crypto_asym_xform_type { > > /**< Elliptic Curve Digital Signature Algorithm > > * Perform Signature Generation and Verification. > > */ > > + RTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL, > Should be RTE_CRYPTO_ASYM_XFORM_ECPM >=20 > > + /**< Elliptic Curve Point Multiplication */ > > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > > /**< End of list */ > > }; > > @@ -598,6 +600,20 @@ struct rte_crypto_ecdsa_op_param { }; > > > > /** > > + * Structure for EC point operation param */ struct > > +rte_crypto_ec_point_mul_param { >=20 > Better to have rte_crypto_ecpm_param [Anoob] Agreed. Will update in v2. =20 >=20 > > + struct rte_crypto_ec_point p; > > + /**< x and y coordinates of input point */ > > + > > + struct rte_crypto_ec_point r; > > + /**< x and y coordinates of resultant point */ > > + > > + rte_crypto_param scalar; > > + /**< Scalar to multiply the input point */ }; > > + > > +/** > > * Asymmetric Cryptographic Operation. > > * > > * Structure describing asymmetric crypto operation params. > > @@ -620,6 +636,7 @@ struct rte_crypto_asym_op { > > struct rte_crypto_dh_op_param dh; > > struct rte_crypto_dsa_op_param dsa; > > struct rte_crypto_ecdsa_op_param ecdsa; > > + struct rte_crypto_ec_point_mul_param ecpm; > > }; > > }; > > > > diff --git a/lib/librte_cryptodev/rte_cryptodev.c > > b/lib/librte_cryptodev/rte_cryptodev.c > > index 0d6babb..eea57c6 100644 > > --- a/lib/librte_cryptodev/rte_cryptodev.c > > +++ b/lib/librte_cryptodev/rte_cryptodev.c > > @@ -174,6 +174,7 @@ const char *rte_crypto_asym_xform_strings[] =3D { > > [RTE_CRYPTO_ASYM_XFORM_DH] =3D "dh", > > [RTE_CRYPTO_ASYM_XFORM_DSA] =3D "dsa", > > [RTE_CRYPTO_ASYM_XFORM_ECDSA] =3D "ecdsa", > > + [RTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL] =3D "ecpm", > > }; > > > > /** > > -- > > 2.7.4