From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A10B4A09E9; Fri, 11 Dec 2020 21:05:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 383B0AC9E; Fri, 11 Dec 2020 21:05:29 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2108.outbound.protection.outlook.com [40.107.92.108]) by dpdk.org (Postfix) with ESMTP id A0D95AC9A; Fri, 11 Dec 2020 21:05:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoNsqWCYL7xwqTwsirYB2RI7Fkp6ja1AfKigixVEWQOMNU5zhhIhJ2x7fCGg1YOeCCRrjlld8si2nCQ2UogG37YytO3b6maGc3DTc8qhzCUnIMO/pB1rrfdQqtBKR3pUF8aHozeDjrigQndOxoFhuHtMRgK6Q7wKIfkJP7NQHkZhINBpNdxKnTtRnwCm5k5eXpWApJ39eAFKtzPIWOQm8u0QxNONZgtNHzh+80NSTFgt1HjnTT6vbbBoq8xYFWbLplQNPstxhPXROQg06Jqzqy1uyRfCU1Fkqwvm+rWimL8nxdKoqKUFm4bSJw5ElPwZ/UhZ6tn+KFYar/UBoOt+Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3XnGljgPiC/kGHBx/ksLuEvosERrZGS8w8uqSJlVV2I=; b=CUUxe6DfrssoAJi2yGw7ApIjV11T8GWaemshv3ArNGTvLNj3KgeSpyayv5C3UH3DQhtqCCNwjpszKuzmps3h2y4CJl90AsnSedlLcJwdsFpN5CFJNu+dejdCo603Dr37Ze33Cdi36KuxyZXowpgoTb/LTQVJ8uzua/Bt1RwHdLoEjGtSqzqf6QfmAsI0UODPdDA1wNwOFIkzy5kSEwh9tqqjCryumZFBvcUGUjRxT85tBqX5bL6MqrONTfT3qMevbgi8jbdsfBj8SXKierXo9Iwuso5s0JFRXKtHbzt5dRK08fpr8MnmoEUlXf+QfWmJPg8W4SDj76DGc010A3IXsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3XnGljgPiC/kGHBx/ksLuEvosERrZGS8w8uqSJlVV2I=; b=erZumRWhVSC59g/g/oJrsr8yaI/bUs+6wo1+7jBZsJYrOFjN0lrF3cmeBdzHAZoVAwm4JoQHwn5Xn9jOHjlkCkIuADwlDw8VAwhfZ80ia7l2o9Z2S8+LAtzOa2jQpIroIAKIK0pzqxmWXGpUOP3yVTBMfdcvLLaEZLH2YUf2Xxg= Received: from (2603:10b6:408:73::10) by BN8PR21MB1284.namprd21.prod.outlook.com (2603:10b6:408:a2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.5; Fri, 11 Dec 2020 20:05:24 +0000 Received: from BN8PR21MB1155.namprd21.prod.outlook.com ([fe80::113b:feec:27f5:5ef0]) by BN8PR21MB1155.namprd21.prod.outlook.com ([fe80::113b:feec:27f5:5ef0%9]) with mapi id 15.20.3654.014; Fri, 11 Dec 2020 20:05:24 +0000 From: Long Li To: Stephen Hemminger , Long Li CC: Stephen Hemminger , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command Thread-Index: AQHWz5KkJDIXOZIZmk6fQWrzoqtmdqnyJQIAgAAtlkA= Date: Fri, 11 Dec 2020 20:05:24 +0000 Message-ID: References: <1607673164-3683-1-git-send-email-longli@linuxonhyperv.com> <20201211092136.4de4e248@hermes.local> In-Reply-To: <20201211092136.4de4e248@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=23b1683a-0122-48d8-a0df-35bcfeec369f; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-12-11T20:04:44Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [67.168.111.68] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a35578d2-cf88-409f-1ad6-08d89e1018a3 x-ms-traffictypediagnostic: BN8PR21MB1284: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: APc37HMTrEyNyjKKkKUthSEERSzMX/0R5TLaeT+EwNWVILNAJuHwfSQ2B3euH2wV3FLwColU/DRUkq6jyS5jfFTtLkBqYcV21/6wwHe4UBxV+W09GLujY+A2yIw+22GsrfvBC3e/wd4pQ1md0wuOBBXmaD2sUnSs+YXzoY2HGqFi29/p8aAJMpA44CuNt7yCSNj5TX4TXaUqq1kd49wmzrsZja0jzKwyKHkoLiSedEuUdiwgxCiR3iOs9o4NasMfkBvEtCRYav8XhzapoUEJmm7LhXk6NK8XfHJwVLrUqQPeFxTUubD2ofiwSK+rrhhj x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR21MB1155.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(366004)(64756008)(66946007)(186003)(33656002)(7696005)(55016002)(6506007)(86362001)(66476007)(5660300002)(82960400001)(82950400001)(10290500003)(52536014)(54906003)(71200400001)(76116006)(66556008)(8990500004)(8936002)(26005)(8676002)(110136005)(66446008)(9686003)(4326008)(508600001)(83380400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?PUNC9VdeQU8mEzGoIT2fDPGbVf8JrgNQxeur0MWFKTDhCBEvnzrj4UlirAyS?= =?us-ascii?Q?xW66eoDjWpCco34qIPu/xV9Y2abzewHaBVOUV1Gh0J0B6z72h/LnJaumRSKF?= =?us-ascii?Q?fvy/YSORQDc/aowTbiC5FZLVJsLIFhwngEHO8RUnjpbRo3Bp3fgaZcGme7in?= =?us-ascii?Q?3Sq/BqBrat56JUJkfjgKjGBE6934UgivfEEDcvlnZM7XLmS3IeDm+rWbmQ+P?= =?us-ascii?Q?r9EKBw5AQ4XsG3t8UrVIS+WeKj9PvXDTC2TZpQzqPDL4IlY7L5mn7D7jIFQU?= =?us-ascii?Q?PT4ErK7lersD9uFhaVjAR2DBpfafmxYjsQuXaSOkddNg7B5S27o2pn9VMSSg?= =?us-ascii?Q?JuH4dSi569aTB+3bczobXEcASXS4jZm0RZM14Sdz1PIIb8UaLPNu5zT9t+2A?= =?us-ascii?Q?rgbCrUpuqme7huOw68W4M5kkJM4aLi6TeIq9kb5D/wAkuqEC/VZwFGSzYkHX?= =?us-ascii?Q?M4YOKyt1UjZWYymlkmaLN7B/MivA3LB1LeSoZgSDIps/gfYyiKQx4Dm73Lok?= =?us-ascii?Q?FrzRk9upkge4Wn7ctctcCqSZSYIQFAYkWcG0cXKzQEdA3Fg4mZXMt+Mg6DVz?= =?us-ascii?Q?d/R4HjnUXvdb3nCaQ6WasPiGsn1VNPk7LBCuXu5M4qZrSuAPI5bbQBvZWvh9?= =?us-ascii?Q?occM30939QUvZx53ZyYxGjpmcp7gmQtU/koWBq0YpGLCUXNq6Q5CdKbsbrf8?= =?us-ascii?Q?uLTBIEarVp8/RHgllJzS0SWjOyo3lzuw1oGmfhQucfmXzoyuAb+EBGNYC7lw?= =?us-ascii?Q?lVbfjQHNO9CnJes3K/6H2BMEaFeAaU0F0xRxaJmpYJvGwDuXRn7Uiu+neQ+R?= =?us-ascii?Q?PjulMHaP4c4c4b9qdXfJ5xlVZK0a8FXo6/KKlIeRuTdvIAKvJInA2KAWmaks?= =?us-ascii?Q?oeDuyJDt5PmY0UIAQxQlgkAlhMP/AAVtrhSFoNkY+DiMSmS6IapeiGKITe6e?= =?us-ascii?Q?q6NnlYfeoi5/IYQleeBFF7KK+4kWsb82CN/aFOwWimk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR21MB1155.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a35578d2-cf88-409f-1ad6-08d89e1018a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2020 20:05:24.1913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mlZLmLg0ogJ2uvPQkk12c3STnzktZuhN4CCIx5NPlrsb9GkiHrlXATKlBlYVp3TEm+aw1Hd/LwqOyejC62cZzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR21MB1284 Subject: Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE > while executing a sync command >=20 > On Thu, 10 Dec 2020 23:52:44 -0800 > Long Li wrote: >=20 > > From: Long Li > > > > On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE > > packet while executing a VSP command synchronously. > > > > Ignore this packet as we don't use it for DPDK. > > > > Cc: stable@dpdk.org > > Signed-off-by: Long Li > > --- > > drivers/net/netvsc/hn_nvs.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c > > index a0ee7d8bfa..b6aa07cc5f 100644 > > --- a/drivers/net/netvsc/hn_nvs.c > > +++ b/drivers/net/netvsc/hn_nvs.c > > @@ -97,8 +97,13 @@ __hn_nvs_execute(struct hn_data *hv, > > hdr =3D (struct hn_nvs_hdr *)buffer; > > > > /* Silently drop received packets while waiting for response */ > > - if (hdr->type =3D=3D NVS_TYPE_RNDIS) { > > + switch (hdr->type) { > > + case NVS_TYPE_RNDIS: > > hn_nvs_ack_rxbuf(chan, xactid); > > + /* fallthrough */ > > + > > + case NVS_TYPE_TXTBL_NOTE: > > + PMD_DRV_LOG(NOTICE, "discard packet type %x", hdr- > >type); > > goto retry; > > } > > >=20 > Could you change that log message to DEBUG (or INFO) level? > Users probably don't need to see it. Sure, I'm sending a v2. >=20 > Acked-by: Stephen Hemminger