From: Long Li <longli@microsoft.com>
To: "Dey, Souvik" <sodey@rbbn.com>,
Kevin Traynor <ktraynor@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9
Date: Wed, 16 Sep 2020 17:43:59 +0000 [thread overview]
Message-ID: <BN8PR21MB115598E7FEA8C1A3F5064C08CE210@BN8PR21MB1155.namprd21.prod.outlook.com> (raw)
In-Reply-To: <DM6PR03MB47770FCDAB221388CC75119ACD210@DM6PR03MB4777.namprd03.prod.outlook.com>
Hi Souvik,
Please also pick up this patch:
https://patchwork.dpdk.org/patch/75341/
This patch didn’t make it to 18.11.
Let me know if you are still seeing failures. If you can reproduce the failure with testpmd or other tools in DPDK, please also share the command you used.
Thanks,
Long
From: Dey, Souvik <sodey@rbbn.com>
Sent: Wednesday, September 16, 2020 7:41 AM
To: Kevin Traynor <ktraynor@redhat.com>; dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>; Long Li <longli@microsoft.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Stephen Hemminger <sthemmin@microsoft.com>
Subject: RE: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9
Yes the patch solves the seg fault issue, but even after backporting the patch we are not able to send packets with size higher than 512. The packets not being transmitted is the real problem here. I have also tried to take the 18.11.10rc1 build but faced similar issues in transmitting the packets.
--
Regards,
Souvik
From: dev <dev-bounces@dpdk.org<mailto:dev-bounces@dpdk.org>> On Behalf Of Kevin Traynor
Sent: Wednesday, September 16, 2020 10:18 AM
To: Dey, Souvik <sodey@rbbn.com<mailto:sodey@rbbn.com>>; dev@dpdk.org<mailto:dev@dpdk.org>
Cc: Stephen Hemminger <stephen@networkplumber.org<mailto:stephen@networkplumber.org>>; longli@microsoft.com<mailto:longli@microsoft.com>; Yigit, Ferruh <ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>>; sthemmin@microsoft.com<mailto:sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9
________________________________
NOTICE: This email was received from an EXTERNAL sender
________________________________
On 16/09/2020 13:00, Dey, Souvik wrote:
> Hi All,
> I updated from dpdk 18.11.6 to 18.11.9 and my netvsc pmd stopped working as expected. Firstly, I saw a crash in tx packets as soon as the dpdk app comes up. In doing some googling found a bug that was fixed after 18.11.9 https://patches.dpdk.org/patch/75001/<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.dpdk.org%2Fpatch%2F75001&data=02%7C01%7Clongli%40microsoft.com%7C1f1640e423394eb94f6e08d85a4ee081%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637358642130122587&sdata=Y9OdJYjrfRA2uDr%2Bs%2FMyqmYFZjPwsXPWV%2BvYWVTSy04%3D&reserved=0> . Ported this fix and was able to get rid of the seg fault, but now stuck at another issue. When we are transmitting packets of size within HN_TXCOPY_THRESHOLD we
Hi,
The patch mentioned is merged to the 18.11 branch in dpdk-stable repo
and part of 18.11.10-rc1, so expected to be in 18.11.10. ETA 28th September.
In case it's already fixed, you can try the 18.11.10-rc1 release. These
netvsc backports were added since 18.11.9. The corresponding dpdk main
commit id's are in the full log.
$ git log --oneline v18.11.9..HEAD .
363bdf0f49 net/netvsc: fix chimney index
5b3a327709 net/netvsc: fix crash during Tx
77cf88c0c6 net/netvsc: fix underflow when Rx external mbuf
59257aaaa1 net/netvsc: do not spin forever waiting for reply
The list of fixes that were tagged for stable but not backported is
here:
http://inbox.dpdk.org/stable/20200901100115.72365-1-ktraynor@redhat.com/<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Finbox.dpdk.org%2Fstable%2F20200901100115.72365-1-ktraynor%40redhat.com&data=02%7C01%7Clongli%40microsoft.com%7C1f1640e423394eb94f6e08d85a4ee081%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637358642130132583&sdata=BkEMWpgwjXSKZaZTTr3XN1fGWzuwv3%2BEQQOxyzy0SEc%3D&reserved=0>
are all good but any larger packets/fragmented packets are getting
dropped after some time. As soon as we start to receive the transmit
completion event NVS_TYPE_RNDIS_ACK as failed, packets with size greater
than HN_TXCOPY_THRESHOLD starts to drop and never recovers. Packets less
than HN_TXCOPY_THRESHOLD works properly there after though. Any idea why
this is happening and is there is some fix which is already there which
is done after 18.11.9 release ?
Maybe you can bisect the 18.11 branch to find where it stops working,
there is only ~10 netvsc commits between 18.11.6 and 18.11.9. The
release notes [1] or git history will tell you which commits are in
which releases. Bear in mind that some commits were rebased for 18.11,
so if you find the offending commit, you might want to check that it was
correctly backported too.
Kevin.
[1] http://doc.dpdk.org/guides-18.11/rel_notes/release_18_11.html<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdoc.dpdk.org%2Fguides-18.11%2Frel_notes%2Frelease_18_11.html&data=02%7C01%7Clongli%40microsoft.com%7C1f1640e423394eb94f6e08d85a4ee081%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637358642130132583&sdata=Nv6Fp%2BzkErUTsZbzHZbXi8NA7bDLAEPzIEnHLLejb6c%3D&reserved=0>
> We are at the critical part of our release, so any help in this regard will be highly appreciated. Thanks in advance for all the help.
>
> PS: I also tried to put the net/netvsc: return the correct chimney index <https://patches.dpdk.org/patch/75118/<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.dpdk.org%2Fpatch%2F75118&data=02%7C01%7Clongli%40microsoft.com%7C1f1640e423394eb94f6e08d85a4ee081%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637358642130142578&sdata=aiz%2FzHqmsH%2F8WbKSpsCalybZPZqBXgw1FWJJuYnLfgE%3D&reserved=0>> fix in but nothing changed.
>
> --
> Regards,
> Souvik
>
> Log Snippet:
> I can see the below errors coming after some transmitting.
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_flush_txagg() tx: port 2:0 tx 2048 size 302
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 2048 packets 1 bytes 242
>
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_flush_txagg() tx: port 2:0 tx 2624 size 302
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 packets 1 bytes 1514
> hn_nvs_send_completed() tx: port 2:0 complete tx 2624 packets 1 bytes 242
>
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 3 size 0
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_flush_txagg() tx: port 2:0 tx 2688 size 302
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_nvs_send_completed() tx: port 2:0 complete tx 2688 packets 1 bytes 242
> hn_flush_txagg() tx: port 2:0 tx 3264 size 571
> hn_nvs_send_completed() tx: port 2:0 complete tx 3264 packets 1 bytes 511
> hn_rxpkt() rx: port 2:0 RX id 3 size 511 type 0x11 ol_flags 0x2
> hn_flush_txagg() tx: port 2:0 tx 3328 size 571
> hn_nvs_send_completed() tx: port 2:0 complete tx 3328 packets 1 bytes 511
> hn_rxpkt() rx: port 2:0 RX id 3 size 512 type 0x11 ol_flags 0x2
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_rxpkt() rx: port 2:0 RX id 3 size 512 type 0x11 ol_flags 0x2
> hn_xmit_sg() tx: port 2:0 tx 4294967295 segs 2 size 0
> hn_nvs_send_completed() tx: port 2:0 complete tx 4294967295 failed status 2
> hn_flush_txagg() tx: port 2:0 tx 3392 size 120
> hn_nvs_send_completed() tx: port 2:0 complete tx 3392 packets 1 bytes 60
> hn_rxpkt() rx: port 2:0 RX id 3 size 42 type 0x1 ol_flags 0
>
________________________________
Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.
________________________________
next prev parent reply other threads:[~2020-09-16 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 12:00 Dey, Souvik
2020-09-16 14:18 ` Kevin Traynor
2020-09-16 14:41 ` Dey, Souvik
2020-09-16 17:43 ` Long Li [this message]
2020-09-16 19:43 ` Dey, Souvik
2020-09-16 20:32 ` Dey, Souvik
2020-09-16 22:07 ` Dey, Souvik
2020-09-17 6:57 ` Long Li
2020-09-17 14:54 ` Dey, Souvik
2020-09-18 7:08 ` Long Li
2020-09-18 12:20 ` Dey, Souvik
2020-09-18 19:05 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR21MB115598E7FEA8C1A3F5064C08CE210@BN8PR21MB1155.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ktraynor@redhat.com \
--cc=sodey@rbbn.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).