From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCDF8A0579; Thu, 8 Apr 2021 04:03:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5430D40698; Thu, 8 Apr 2021 04:03:57 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2111.outbound.protection.outlook.com [40.107.92.111]) by mails.dpdk.org (Postfix) with ESMTP id B803A40138 for ; Thu, 8 Apr 2021 04:03:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OEDBr+HA1V3O2Q3xnRAWEHz+ZdSbTrSR1196QX+CrJ6BYnRcVCoZHhRX2oHZ4ZDCRBwGVl/6EDnM+udmC9sk/1e1w8GXOA2DsmyJpFEnMBXuAXzM+uRJOBScPkFJ2uoDQywO4rBZn2vAWWUqnNew7kWFCoPYt1mx2LKxYMQU65XXlZhTx5Zf3vga3oLwsQeLsrgmKRMvJlSrVomiGV0VjSy9SJrj16lKLBQYr35aIdSEZ5qG44u/Bs5lhksCIhnOYmw5qfNnqzTXu36rocxD5lSjFMlJm6RhqE8VxskgpNlaewD6UVJWVuNMqWkYeZB52SCIWyD4u9qXlyyT94Lxfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xHGB21Bp8EQ5I6UnFnU30J57XiOqHRF1eAE5PhN30XM=; b=F/+kvwgKhQvQ2mHp6s5sb8yTx1sO9p5QSagFWLKT9r7QFN3EbQzqpRu0XSrBELxJSA/TplDjY7Qnjc+4RiKzSS/UMLphKXhwoUIysjmeE4DhYN4tG8A2WQbDattBxqKxVMvxmuWIWIp/ZytKzt/+iJWfZ61sRoJbHQF9a+73gNQVcSYMVL+JxfZQAkk5oJhsZGg/xGttPm+auRg4MUEMHBSWYsN8qWm9h+tnZEdFMhR3QG5+jJNCeaJeGhmYzPdTPU7P89Oq9FjwRS1pCJP2Em6nfksxiYGoBcdln25Zy6UMgPSKIVI7GSSD4R3YfXXGuojZUivE87S9SnZTmkF/Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xHGB21Bp8EQ5I6UnFnU30J57XiOqHRF1eAE5PhN30XM=; b=inutuSw8LkUmkaXD4cwjp55Oo+wP4dKaskA6KELnNZ3GTbjs2yC24MpEoL2GOwa91QwyILWuk70Rm0Y82atR9W4QY35ozoiB+XvzD7dY4jQrYeBCIsJRiOJ6T9+Yz1U5lLgOt5K09pVaWgXUJfEXcq2N2iIUYtdcdEZdX4TAhQc= Received: from BN8PR21MB1155.namprd21.prod.outlook.com (2603:10b6:408:73::10) by BN6PR21MB0468.namprd21.prod.outlook.com (2603:10b6:404:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.4; Thu, 8 Apr 2021 02:03:54 +0000 Received: from BN8PR21MB1155.namprd21.prod.outlook.com ([fe80::5511:ca34:360d:411a]) by BN8PR21MB1155.namprd21.prod.outlook.com ([fe80::5511:ca34:360d:411a%6]) with mapi id 15.20.4042.006; Thu, 8 Apr 2021 02:03:54 +0000 From: Long Li To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/netvsc: fix log double spaced messages Thread-Index: AQHXLBr8j/tDfnr3RkG4sQSBJj6Y7qqp3pXw Date: Thu, 8 Apr 2021 02:03:54 +0000 Message-ID: References: <20210408020034.293271-1-stephen@networkplumber.org> In-Reply-To: <20210408020034.293271-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=215b3bc5-caf5-4c2f-966a-0accd1732cb7; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-08T02:03:41Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [76.22.9.184] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8026f4ee-acb8-4b5f-060f-08d8fa328fdd x-ms-traffictypediagnostic: BN6PR21MB0468: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 43tcnDDCPmqL+V859nCaR0BcciUglWE2w0LMMo/vGk49pl6sqnTCjrITdMwKcpF+72qS4kLPv11YIlZGGzcOa00xelPv3QpoO5nzXNk5irzzCVW1jGCZOT/U/3oZy9UykrP2UDUJpQx9nBKaWXWArwSvS+PlEp+7n1IpkNdHafbe09Eyds+WQLRR8oqMgcyWA/NKSIOlC34VqhyuY++itqaXBg0H6D57HEQzmJTO/WnQZTNUuxyIAaF6bYEtWbVSq0s2MpAQ1R7kyIoDloPJmO0lRFuQ2omyIXj6UuJYXtA/rtryRMD+6xyc9wKRc0zPjC6EX8y/9H6vnqqqxjLEzsEPlu3oXNC/kkdR/kx13UQfoBBy+7dOA6c4zMtNPK5mfoO6HRGZ0iEfn4VzdchMrYjhImsJINz40nO8Y0y8LH6pFLZ4LBlQiDbTDvmv1hRROgwuP0q8NrfqJ7Ocp5jCr4lZ/yBnB8CMBdnGta3n/wOcmHdk/jis6SCVt62tNFaYJcjZ3vR3jG8o+pPJR+SeoUhjoN8Lk/SorQLA3KInny2qTeo0kf6x3uLgFOji1fFvdEoApTMiQ43rUbQw5gokMMUI7S0Ya9TEZxUW8PL9b3fa8XuZW9N2h8BKW4y1aH2pVR4ONKD4IN5Pp+sF6C+saQovc1nB5JlQrZJ7fB1eVXY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR21MB1155.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(366004)(346002)(376002)(39860400002)(6916009)(26005)(8936002)(186003)(33656002)(15650500001)(86362001)(52536014)(9686003)(83380400001)(55016002)(10290500003)(6506007)(53546011)(8990500004)(316002)(4326008)(66446008)(478600001)(82960400001)(71200400001)(38100700001)(7696005)(82950400001)(76116006)(8676002)(64756008)(2906002)(66556008)(5660300002)(66946007)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?fdbfFeN4L9Y8ut0swuTyMpJx302VTGOj8oz5rADAvbLkHcF98p16xn5GkSP7?= =?us-ascii?Q?H5yvS9WaYmQopiDnXqAaMcE4pIhmxQ68s+7ApTWytaNfaLqU6z1z8CLuvaRW?= =?us-ascii?Q?D2HTO7Mz4T6MFuCs7L3zSnIs2AC6hTSerc53nbVwhH4QMy2rGeWw4AjIP6sC?= =?us-ascii?Q?phjHA04on0MYNkymIgpu+JIeE0yVGpWSwekMtYkftZFiqOXBpnDEYGfyrr2W?= =?us-ascii?Q?O45HBL51qiziVwSgQF1ATAsY6oUKNcYhADRbwWstOv0OVaZZA3MJ19EjlWFJ?= =?us-ascii?Q?fm0XckfAfeoY1ZT/tfEDig3zUDcgjoZ2y8GhU6Ic4FUMZK9k/T7sbIBVZqSO?= =?us-ascii?Q?627/ynLjhcBJxLC7akfmmvQ1sZEf0H6/8ZTDx6edUfFBfp2CCatmo8wDxvQQ?= =?us-ascii?Q?QlXS0yStcSmpIW/7980Aj4OXQ42LsckmwVwB6Mbhuo8Be7c6bADQww9sdyUa?= =?us-ascii?Q?WhyHqaiDPo2TrHKo8Lsrh7oBQdEvBpNYRQdmicvyR9LdPWITz29M61p1IXBq?= =?us-ascii?Q?czo9eK/FfedWbFfD8Fi8mBjA2sl2aTyjgQxkpDIwABopOmZ7QDZLXt9c32mw?= =?us-ascii?Q?bWuMFfYexhH6Qf+5mxePIyJ7zgCimHyiOkSGSFJ+Hw89nCkjL4oQEfu6xS+2?= =?us-ascii?Q?gpjORhx6aprKLb1MC2AT630sgjxRLj8/VGJsH65+0PwtqN8BFGR87YcQ6fLr?= =?us-ascii?Q?OOvXECHKRc50u4xndOYoj3mS6xBG8+ahakhw3BABzPlp+4earYnEnbka2lDp?= =?us-ascii?Q?uM1Ctq4r+sNsS52ZBTMozK5GhXaZguXNtPibKnAuxJy39D9DinFFKGDKT+R0?= =?us-ascii?Q?oRSRV2zPloVHpoqPhQFz8v/pR+EaSdrFeoWP5fRw8fuqg+xEdf10fW+Mbc5D?= =?us-ascii?Q?elDs6HKZmiW0BLuYiYoxboRs6XPFZNXd+zhrWUHJW8fmKuKzHj34xQxHopo3?= =?us-ascii?Q?c45dUU7pvu3glEGvB6xYMKUaOf45zpd0Sk+1RWNslYlR6G7IRQ7rEu6ZvoVq?= =?us-ascii?Q?2Ir24KxfeOc0tvw9niLIBxcMjp1qkMKZuJflcYPOxBeiU2S/zOJBskfunlub?= =?us-ascii?Q?jhiIiFIME/FJjGXAMf8lyqJq/bvfmdiF+3AHegpT8U4sx8OAfkg4n22QT2r4?= =?us-ascii?Q?aZQ4m0zh/y8BC6jarNeX4BTtRM+42A6x2ghmOvswxJu068SrqKyVWKXv4VzI?= =?us-ascii?Q?cbNWa+mi36/fBUmuiq9UEpakQEpTtbyh+D7RcUlQXsWKksH4epY4In9aI7B4?= =?us-ascii?Q?yTXJJtj3zXzmHbE2RewzSGgpXAGlMb6Bxgvy38O+H+n8/mjyNsg45uQVfBHR?= =?us-ascii?Q?Hn8=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR21MB1155.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8026f4ee-acb8-4b5f-060f-08d8fa328fdd X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 02:03:54.0631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j/VKvDG4wYSrfOycOSkkeUKShE9bUo7wXxxG/lkulnkbP5k/ZOwrb7QkVHj4SovpYFCK63SMIDyGPh7G/D+/zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR21MB0468 Subject: Re: [dpdk-dev] [PATCH] net/netvsc: fix log double spaced messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, April 7, 2021 7:01 PM > To: Long Li > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH] net/netvsc: fix log double spaced messages >=20 > The PMD_DRV_LOG macro in netvsc (like other drivers) adds a newline to > the log message as part of the macro expansion; therefore the message > should not have its own newline. >=20 > In a couple places, log messages were split across source lines which can > make looking them up in the source tree harder. >=20 > Signed-off-by: Stephen Hemminger Acked-by: Long Li > --- > Note: did not add stable or fixes line since this is only impacts log mes= sages >=20 > drivers/net/netvsc/hn_ethdev.c | 25 ++++++++++++------------ > drivers/net/netvsc/hn_vf.c | 35 +++++++++++++++++----------------- > 2 files changed, 30 insertions(+), 30 deletions(-) >=20 > diff --git a/drivers/net/netvsc/hn_ethdev.c > b/drivers/net/netvsc/hn_ethdev.c index 04904b151441..51e950413c88 > 100644 > --- a/drivers/net/netvsc/hn_ethdev.c > +++ b/drivers/net/netvsc/hn_ethdev.c > @@ -564,7 +564,7 @@ static void netvsc_hotplug_retry(void *args) > struct rte_ether_addr eth_addr; > int s; >=20 > - PMD_DRV_LOG(DEBUG, "%s: retry count %d\n", > + PMD_DRV_LOG(DEBUG, "%s: retry count %d", > __func__, hv->eal_hot_plug_retry); >=20 > if (hv->eal_hot_plug_retry++ > NETVSC_MAX_HOTADD_RETRY) @@ > -574,7 +574,7 @@ static void netvsc_hotplug_retry(void *args) > di =3D opendir(buf); > if (!di) { > PMD_DRV_LOG(DEBUG, "%s: can't open directory %s, " > - "retrying in 1 second\n", __func__, buf); > + "retrying in 1 second", __func__, buf); > goto retry; > } >=20 > @@ -586,7 +586,7 @@ static void netvsc_hotplug_retry(void *args) > /* trying to get mac address if this is a network device*/ > s =3D socket(PF_INET, SOCK_DGRAM, IPPROTO_IP); > if (s =3D=3D -1) { > - PMD_DRV_LOG(ERR, "Failed to create socket > errno %d\n", > + PMD_DRV_LOG(ERR, "Failed to create socket > errno %d", > errno); > break; > } > @@ -594,8 +594,9 @@ static void netvsc_hotplug_retry(void *args) > ret =3D ioctl(s, SIOCGIFHWADDR, &req); > close(s); > if (ret =3D=3D -1) { > - PMD_DRV_LOG(ERR, "Failed to send > SIOCGIFHWADDR for " > - "device %s\n", dir->d_name); > + PMD_DRV_LOG(ERR, > + "Failed to send SIOCGIFHWADDR for > device %s", > + dir->d_name); > break; > } > if (req.ifr_hwaddr.sa_family !=3D ARPHRD_ETHER) { @@ - > 606,14 +607,14 @@ static void netvsc_hotplug_retry(void *args) > RTE_DIM(eth_addr.addr_bytes)); >=20 > if (rte_is_same_ether_addr(ð_addr, dev->data- > >mac_addrs)) { > - PMD_DRV_LOG(NOTICE, "Found matching MAC > address, " > - "adding device %s network name %s\n", > + PMD_DRV_LOG(NOTICE, > + "Found matching MAC address, adding > device %s network name %s", > d->name, dir->d_name); > ret =3D rte_eal_hotplug_add(d->bus->name, d->name, > d->args); > if (ret) { > PMD_DRV_LOG(ERR, > - "Failed to add PCI device %s\n", > + "Failed to add PCI device %s", > d->name); > break; > } > @@ -638,7 +639,7 @@ netvsc_hotadd_callback(const char *device_name, > enum rte_dev_event_type type, > struct rte_devargs *d =3D &hv->devargs; > int ret; >=20 > - PMD_DRV_LOG(INFO, "Device notification type=3D%d > device_name=3D%s\n", > + PMD_DRV_LOG(INFO, "Device notification type=3D%d > device_name=3D%s", > type, device_name); >=20 > switch (type) { > @@ -650,7 +651,7 @@ netvsc_hotadd_callback(const char *device_name, > enum rte_dev_event_type type, > ret =3D rte_devargs_parse(d, device_name); > if (ret) { > PMD_DRV_LOG(ERR, > - "devargs parsing failed ret=3D%d\n", ret); > + "devargs parsing failed ret=3D%d", ret); > return; > } >=20 > @@ -961,7 +962,7 @@ hn_dev_start(struct rte_eth_dev *dev) > error =3D rte_dev_event_callback_register(NULL, > netvsc_hotadd_callback, > hv); > if (error) { > - PMD_DRV_LOG(ERR, "failed to register device event > callback\n"); > + PMD_DRV_LOG(ERR, "failed to register device event > callback"); > return error; > } >=20 > @@ -1240,7 +1241,7 @@ static int eth_hn_probe(struct rte_vmbus_driver > *drv __rte_unused, >=20 > ret =3D rte_dev_event_monitor_start(); > if (ret) { > - PMD_DRV_LOG(ERR, "Failed to start device event > monitoring\n"); > + PMD_DRV_LOG(ERR, "Failed to start device event > monitoring"); > return ret; > } >=20 > diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c inde= x > 2dc7abe354ad..75192e631978 100644 > --- a/drivers/net/netvsc/hn_vf.c > +++ b/drivers/net/netvsc/hn_vf.c > @@ -69,7 +69,7 @@ static int hn_vf_attach(struct rte_eth_dev *dev, struct > hn_data *hv) > return port; > } >=20 > - PMD_DRV_LOG(NOTICE, "found matching VF port %d\n", port); > + PMD_DRV_LOG(NOTICE, "found matching VF port %d", port); > ret =3D rte_eth_dev_owner_get(port, &owner); > if (ret < 0) { > PMD_DRV_LOG(ERR, "Can not find owner for port %d", port); > @@ -106,13 +106,13 @@ static void hn_remove_delayed(void *args) > /* Tell VSP to switch data path to synthentic */ > hn_vf_remove(hv); >=20 > - PMD_DRV_LOG(NOTICE, "Start to remove port %d\n", port_id); > + PMD_DRV_LOG(NOTICE, "Start to remove port %d", port_id); > rte_rwlock_write_lock(&hv->vf_lock); >=20 > /* Give back ownership */ > ret =3D rte_eth_dev_owner_unset(port_id, hv->owner.id); > if (ret) > - PMD_DRV_LOG(ERR, "rte_eth_dev_owner_unset failed > ret=3D%d\n", > + PMD_DRV_LOG(ERR, "rte_eth_dev_owner_unset failed > ret=3D%d", > ret); > hv->vf_ctx.vf_attached =3D false; >=20 > @@ -120,18 +120,18 @@ static void hn_remove_delayed(void *args) > hn_eth_rmv_event_callback, hv); > if (ret) > PMD_DRV_LOG(ERR, > - "rte_eth_dev_callback_unregister failed > ret=3D%d\n", > + "rte_eth_dev_callback_unregister failed ret=3D%d", > ret); >=20 > /* Detach and release port_id from system */ > ret =3D rte_eth_dev_stop(port_id); > if (ret) > - PMD_DRV_LOG(ERR, "rte_eth_dev_stop failed port_id=3D%u > ret=3D%d\n", > + PMD_DRV_LOG(ERR, "rte_eth_dev_stop failed port_id=3D%u > ret=3D%d", > port_id, ret); >=20 > ret =3D rte_eth_dev_close(port_id); > if (ret) > - PMD_DRV_LOG(ERR, "rte_eth_dev_close failed port_id=3D%u > ret=3D%d\n", > + PMD_DRV_LOG(ERR, "rte_eth_dev_close failed port_id=3D%u > ret=3D%d", > port_id, ret); >=20 > ret =3D rte_dev_remove(dev); > @@ -146,7 +146,7 @@ int hn_eth_rmv_event_callback(uint16_t port_id, { > struct hn_data *hv =3D cb_arg; >=20 > - PMD_DRV_LOG(NOTICE, "Removing VF portid %d\n", port_id); > + PMD_DRV_LOG(NOTICE, "Removing VF portid %d", port_id); > rte_eal_alarm_set(1, hn_remove_delayed, hv); >=20 > return 0; > @@ -163,7 +163,7 @@ static int hn_setup_vf_queues(int port, struct > rte_eth_dev *dev) > ret =3D rte_eth_tx_queue_info_get(dev->data->port_id, i, > &txinfo); > if (ret) { > PMD_DRV_LOG(ERR, > - "rte_eth_tx_queue_info_get failed > ret=3D%d\n", > + "rte_eth_tx_queue_info_get failed > ret=3D%d", > ret); > return ret; > } > @@ -172,7 +172,7 @@ static int hn_setup_vf_queues(int port, struct > rte_eth_dev *dev) > &txinfo.conf); > if (ret) { > PMD_DRV_LOG(ERR, > - "rte_eth_tx_queue_setup failed > ret=3D%d\n", > + "rte_eth_tx_queue_setup failed ret=3D%d", > ret); > return ret; > } > @@ -182,7 +182,7 @@ static int hn_setup_vf_queues(int port, struct > rte_eth_dev *dev) > ret =3D rte_eth_rx_queue_info_get(dev->data->port_id, i, > &rxinfo); > if (ret) { > PMD_DRV_LOG(ERR, > - "rte_eth_rx_queue_info_get failed > ret=3D%d\n", > + "rte_eth_rx_queue_info_get failed > ret=3D%d", > ret); > return ret; > } > @@ -193,7 +193,7 @@ static int hn_setup_vf_queues(int port, struct > rte_eth_dev *dev) > &rxinfo.conf, rx_queue- > >mb_pool); > if (ret) { > PMD_DRV_LOG(ERR, > - "rte_eth_rx_queue_setup failed > ret=3D%d\n", > + "rte_eth_rx_queue_setup failed ret=3D%d", > ret); > return ret; > } > @@ -244,10 +244,10 @@ int hn_vf_add(struct rte_eth_dev *dev, struct > hn_data *hv) > goto exit; > } >=20 > - PMD_DRV_LOG(NOTICE, "configuring VF port %d\n", port); > + PMD_DRV_LOG(NOTICE, "configuring VF port %d", port); > ret =3D hn_vf_configure(dev, &dev->data->dev_conf); > if (ret) { > - PMD_DRV_LOG(ERR, "Failed to configure VF > port %d\n", > + PMD_DRV_LOG(ERR, "Failed to configure VF > port %d", > port); > goto exit; > } > @@ -255,15 +255,15 @@ int hn_vf_add(struct rte_eth_dev *dev, struct > hn_data *hv) > ret =3D hn_setup_vf_queues(port, dev); > if (ret) { > PMD_DRV_LOG(ERR, > - "Failed to configure VF queues port %d\n", > + "Failed to configure VF queues port %d", > port); > goto exit; > } >=20 > - PMD_DRV_LOG(NOTICE, "Starting VF port %d\n", port); > + PMD_DRV_LOG(NOTICE, "Starting VF port %d", port); > ret =3D rte_eth_dev_start(port); > if (ret) { > - PMD_DRV_LOG(ERR, "rte_eth_dev_start failed > ret=3D%d\n", > + PMD_DRV_LOG(ERR, "rte_eth_dev_start failed > ret=3D%d", > ret); > goto exit; > } > @@ -414,8 +414,7 @@ int hn_vf_configure(struct rte_eth_dev *dev, > hv); > if (ret) { > PMD_DRV_LOG(ERR, > - "Registering callback failed for " > - "vf port %d ret %d\n", > + "Registering callback failed for vf port %d > ret %d", > hv->vf_ctx.vf_port, ret); > return ret; > } > -- > 2.30.2