DPDK patches and discussions
 help / color / mirror / Atom feed
From: Long Li <longli@microsoft.com>
To: Matan Azrad <matan@nvidia.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: "matan@mellanox.com" <matan@mellanox.com>,
	"grive@u246.net" <grive@u246.net>, "dev@dpdk.org" <dev@dpdk.org>,
	Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: handle removal of associated pci device
Date: Tue, 15 Sep 2020 04:53:14 +0000
Message-ID: <BN8PR21MB1155A925CB59954DB1B09806CE200@BN8PR21MB1155.namprd21.prod.outlook.com> (raw)
In-Reply-To: <MW2PR12MB2492E2C60BCBA327C194731ADF280@MW2PR12MB2492.namprd12.prod.outlook.com>

>Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: handle removal of
>associated pci device
>Hi Stephen
>From: Stephen Hemminger:
>> On Sun, 6 Sep 2020 12:38:18 +0000
>> Matan Azrad <matan@nvidia.com> wrote:
>> > Hi Stephen
>> >
>> > From: Stephen Hemminger:
>> > > The vdev_netvsc was not detecting when the associated PCI device
>> > > (SRIOV) was removed. Because of that it would keep feeding the
>> > > same
>> > > (removed) device to failsafe PMD which would then unsuccessfully
>> > > try and probe for it.
>> > >
>> > > Change to use a mark/sweep method to detect that PCI device was
>> > > removed, and also only tell failsafe about new PCI devices.
>> > > Vdev_netvsc does not have to keep stuffing the pipe with the same
>> > > already existing PCI device.
>> >
>> > As I know, the vdev_netvsc driver doesn't call to failsafe if the
>> > PCI device is
>> not detected by the readlink command(considered as removed)...
>> > Am I missing something?
>> The original code is broken because ctx_yield is not cleared, it keeps
>> sending the same value.
>Looking on the code again, It looks like ctx->yield has no effect on the next
>pipe write, It is just used for log.
>After the PCI interface matching to the netvsc interface, the pipe write is
>triggered only if the readlink commands success to see the plugged-in PCI
>readlink /sys/class/net/[iface]/device/subsystem shows "pci"
>readlink /sys/class/net/[iface]/device shows the pci device ID.
>So, the assumption is when the above readlink failed on the interface the
>device is removed(plugged-out) and the fd write will not happen.
>The code will continue to retry probe again and again until success only for
>plugged-in pci device matched the netvsc device.

Hi Matan,

The original code keeps writing to pipe even it's the same PCI device. The new code writes to pipe for a new device, only once. See the following code:

+	/* Skip if this is same device already sent to failsafe */
+	if (strcmp(addr, ctx->yield) == 0)
+		return 0;

This patch also saves lots of CPU since it no longer writes to pipe all the time. You are correct about the code will continue to probe on a new PCI device. But someone has to do it to handle hot-add.


>> It looks like device removal and add was never tested.
>This is basic test we have to test plug-in plug-out and it passed every day in
>the last years.
>Maybe something new and special in your setup?
>> If you test removal you will see that vdev_netvsc:
>>  1. Sends same PCI device repeatedly to failsafe (every alarm call)
>>     This is harmless, but useless.
>>  2. When device is removed, keeps doing #1

  reply	other threads:[~2020-09-15  4:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 17:53 Stephen Hemminger
2020-09-06  8:11 ` Long Li
2020-09-06 12:38 ` Matan Azrad
2020-09-06 18:33   ` Stephen Hemminger
2020-09-07  8:09     ` Matan Azrad
2020-09-15  4:53       ` Long Li [this message]
2020-09-15  7:00         ` Matan Azrad
2020-09-25 20:30           ` Long Li
2020-10-19 22:33             ` Thomas Monjalon
2020-10-19 22:36               ` Thomas Monjalon
2020-10-20  9:13                 ` Gaëtan Rivet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR21MB1155A925CB59954DB1B09806CE200@BN8PR21MB1155.namprd21.prod.outlook.com \
    --to=longli@microsoft.com \
    --cc=dev@dpdk.org \
    --cc=grive@u246.net \
    --cc=matan@mellanox.com \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stephen@networkplumber.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git