DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Yu, DapengX" <dapengx.yu@intel.com>,
	"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/softnic: fix memory leak as profile is freed
Date: Wed, 14 Jul 2021 11:17:37 +0000	[thread overview]
Message-ID: <BN9PR11MB5258A432D0192D98187C28F8E0139@BN9PR11MB5258.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210713082709.465481-1-dapengx.yu@intel.com>



> -----Original Message-----
> From: Yu, DapengX <dapengx.yu@intel.com>
> Sent: Tuesday, July 13, 2021 9:27 AM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/softnic: fix memory leak as profile is freed
> 
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> In function softnic_table_action_profile_free(), the memory referenced by
> pointer "ap" in the instance of "struct softnic_table_action_profile"
> is not freed.
> 
> This patch fixes it.
> 
> Fixes: a737dd4e5863 ("net/softnic: add table action profile")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
>  drivers/net/softnic/rte_eth_softnic_action.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/softnic/rte_eth_softnic_action.c
> b/drivers/net/softnic/rte_eth_softnic_action.c
> index 92c744dc9a..33be9552a6 100644
> --- a/drivers/net/softnic/rte_eth_softnic_action.c
> +++ b/drivers/net/softnic/rte_eth_softnic_action.c
> @@ -183,6 +183,7 @@ softnic_table_action_profile_free(struct
> pmd_internals *p)
>  			break;
> 
>  		TAILQ_REMOVE(&p->table_action_profile_list, profile,
> node);
> +		rte_table_action_profile_free(profile->ap);
>  		free(profile);
>  	}
>  }
> --
> 2.27.0

Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>


  reply	other threads:[~2021-07-14 11:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  8:27 dapengx.yu
2021-07-14 11:17 ` Singh, Jasvinder [this message]
2021-07-28  6:05 ` [dpdk-dev] [PATCH v2] " dapengx.yu
2021-07-30 11:53   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB5258A432D0192D98187C28F8E0139@BN9PR11MB5258.namprd11.prod.outlook.com \
    --to=jasvinder.singh@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dapengx.yu@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).