From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36EDEA0093; Fri, 17 Jun 2022 10:58:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C2F9410E7; Fri, 17 Jun 2022 10:58:32 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id B3C9040698; Fri, 17 Jun 2022 10:58:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655456310; x=1686992310; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DrtIxzDMmB48r68wZOfJ4vhoPS20Luz/NBr6vLLoxHE=; b=XnuGhece4m6qsLhJWy2YnxQZ/KDoLc0nyVR2IA8jDUHhCoWRkEdeHt+i HJys6soFTm770E/R6khmKA4YegfCfFuoJ9Bf9Lah2QDL7s+kbUkLtBiiC BFV3rQpoa6kwwmRz+KEIO6nxalRIcUXXFMXis96H8lrs5YY2h7CoTMhCW hgLiXnE+PHmZ4I0aQ39sXDeuV31+d2QYPlKKodMbh9luYI53PtlxLQvgE TZLhR29iWIrsrBvwIcvbcs8DcNfBtYtx7ksUPo8V/XDd716NPJ0HM6uE3 EawyG0N5xY526SBPJ59HTubgrUTJpGGzT5eOt6hu3+NbKyYqq9d1UX3wD A==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="268147842" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="268147842" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 01:58:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="912535169" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 17 Jun 2022 01:58:28 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 17 Jun 2022 01:58:27 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 17 Jun 2022 01:58:27 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 17 Jun 2022 01:58:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GHGipGi/04l6QPq2T1QeTmcAvlL4FcRf2S65QDJn/zUKI20S+Pt8lXBRwuE3xxLceKg9X34d1ABYEo+4oejEDav0DOOj/Zh0VjNl9wfR9u52ZzhTTi03LeJRRHEE38Xk8HyQyUsJQ5dfsXYzRzGWBpEWxoqKwzb8FUvTpFAg1L3sNrmwAGv/7zAu4xfmvH7pY8wQ2RAe9WK1t9xxWN25rTI9OQy8BmG8hoKKNAfypxFZHP6rHlWN04A9fyBHPUIryiCbWL+TKs/dDxt0VcEQ0R0uBu7wN8p44bxCZfnLjXbKo2VpKfCKwN9v/1qLaQMMnende8+nYfgpSYBOZHURzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JyPeHCWi+D/pEOp0wN93t4ql3XiC7bxqW9DyeuGgiNM=; b=iDiDIkjr9xwHfnSWBMEAxwS4LzCBPfrERctr1KVpvcLWL6t3bzjAl2zBsLzFGeFbTQfvks5lrJmVDlIobTAJ7zw3vKR9NBb8lLZGyMDeErdVRGVYt46dEseari/J52kqNoZiq1qipAhj21hvO7Q9k22nMY3HZApMUONLQNVtGdak56Xq7qdcWHbLsHcooQQxEjYftuSKskCjlDMYrdNso92Gke4TAvRqhKVvGPbHRuTdWKpY1ehqFWLUKxw/WrrW1JYOwYjWJ9DvgBQoEEbaxGWqkS8UHkowkR3MtOfEpQlWe64MfiTIlTrjVs5LWlv2HfOsBvVAceCkQXFOSnUrFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM4PR11MB6237.namprd11.prod.outlook.com (2603:10b6:8:a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.19; Fri, 17 Jun 2022 08:58:21 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::a113:c892:d94:dd10]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::a113:c892:d94:dd10%7]) with mapi id 15.20.5353.015; Fri, 17 Jun 2022 08:58:21 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "thomas@monjalon.net" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" CC: "stable@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" Subject: RE: [PATCH v3 3/4] raw/ifpga/base: update flash operation interface Thread-Topic: [PATCH v3 3/4] raw/ifpga/base: update flash operation interface Thread-Index: AQHYghmKdGDstjXYJUaRpVdVZxd5Ka1TTIiQ Date: Fri, 17 Jun 2022 08:58:21 +0000 Message-ID: References: <1654827900-10023-1-git-send-email-wei.huang@intel.com> <1655450375-10739-1-git-send-email-wei.huang@intel.com> <1655450375-10739-4-git-send-email-wei.huang@intel.com> In-Reply-To: <1655450375-10739-4-git-send-email-wei.huang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: affc1b66-6d2c-4bc7-5434-08da503f8777 x-ms-traffictypediagnostic: DM4PR11MB6237:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BiyKLf0Im0VMqb41zCfUpTcyytlu6tQvNsjogWcR1SYYC0bGHxnxMW/SUj0MpelGf9sEsOOgvfLjuocSSy6wrtZ0zt6MVxJVHLcgqYtlFLembm1DWGRMM/T5LQsIs+f7y4AWrMhqGQH59SdP8o/5l5WA3ryhM2tms0QNb/ynjB55SWS2+U69F1ltJLzKZDzpgGMysHnT0z1yxNdnozllW4pdB5k/P1YL2eTAbT3ftGWgMA9XmaeDDFshaPbzMIJLhBj+JBV5Nt40FlS6EZbA4NvdbqzG10sH9zniMnA27YKTXfUb2NoBySwrsjjLNKwWD90X5bl6h1koyeUDN/37bXFSH/VGMW/3OGL3XeYaCqcIEv0mhLa0qRq1vfj1UZB60IZfjIzKnYLg8J+djMiiEwfIoCS5MtH26ZuUph1Yjic9KgN/4/ZXwsYGsbZiKVQA3l0lZaXt6YVHIpCTSEMWBOR+DEKTQbMTKflj9arGcThXc2YhbthgkU54IN+kXzUHbYFzLxW4LAkWryRBKq7x4uY8cFRw6CHXT2iVrxQLpG40slmzjnF1Sacww0mYvRL1X7v082FgvNmvRsBurshdQuqF4I3ODqk5yO2intgDefi5czFGKMm6FRRoIowMfqh1LoAnBePshsK1+p0gHWVpKqQmwvs7kUE1Mw6lUjcKRc3qNBDJ1UMage7ltpXS4KFBAByRCBQZYTFtC9h4ibYMQQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5483.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(53546011)(2906002)(64756008)(186003)(76116006)(9686003)(122000001)(66476007)(15650500001)(66556008)(82960400001)(38100700002)(110136005)(6506007)(66946007)(8676002)(55016003)(7696005)(83380400001)(316002)(5660300002)(66446008)(8936002)(52536014)(30864003)(71200400001)(4326008)(38070700005)(107886003)(86362001)(33656002)(54906003)(498600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bQ21lP+2esX9Eoa4pXraVZ5eIJjeFy+dm2b2t2YIrS+kKB1KNF9FlDp2yCmq?= =?us-ascii?Q?8dSROppSDOH/3CXTw+G/LlX0X9XCGBLbX4/9ZUvI6Dv8iDaQL/XwQw95hSIQ?= =?us-ascii?Q?I6lAlifE9bDmTEhWbo71e6wBhsh0aJExOxTC1CUiyQsibKL9K7EQoACdcM9g?= =?us-ascii?Q?yoBxRVHiLR0b59cYm3vhvbubfZYy9Ue4TaGkn6lnOs99gm9rxXFkqTtf4aQA?= =?us-ascii?Q?zVjaHiyi5ymewFw9xrcA9xTBt+8DnxRpnLliBLFMf/mBXVEylL6mrTN9+1qX?= =?us-ascii?Q?p2gIQBJz5QsrmmeyZL2y80DbTalXKK8dZyGMqZv03QorwA+9hgQd4eRMiVFO?= =?us-ascii?Q?gHVQEX85LVSXNUsvuDjDvnl05JBo61yYZugcMJAbjchYY9/7wUy3eNHZgfOB?= =?us-ascii?Q?YlAh99sRg3YudW7t/8Fob9Is9CXm3E+jjI6Nw75i59EZQqJliOQ0I9iFrrDK?= =?us-ascii?Q?iU1lLl8IPUIsYAEyrajkRqJE+5brvxZ0nhcCUG36X1bKzi1SYLmvVhNACHlE?= =?us-ascii?Q?kNHN1ryRUg5srqeYW/nnFL8Z4D9W5rUNSunpQlZ/nF8r6UUiQ3qZcx3CpTeU?= =?us-ascii?Q?QLMrq/timp5NwHDkdcZpkXSy88t3Ylqt1KQfHNY1uX5hafpBAMgjaKrFjOuU?= =?us-ascii?Q?EcHa7LSs1wqKOh1XbfeZw9ddZqU3Q5RIiLOXUEEfngzj7W/ephRN9Ugn9BVF?= =?us-ascii?Q?KEL6nvbmFZbyu5DDT5AviAwtqvj24Cq9b07B5EQyzadiMcT66se8+7xRh6zl?= =?us-ascii?Q?4m+tLwW4+dxHaSybTpwcdTORMZMn5Bk458znXUl5Y1ho7fsrygSnXXrz5yM3?= =?us-ascii?Q?j66k1Adzh/omwt3rWin4eCuGOv7Wl5/Y4A1C8zbksLWyQLvUCqLn9aGDs4x/?= =?us-ascii?Q?JsVQSB7gE9yFZ6mdQyNxPhj7z/6xCG4GhTO1T2b5jV55kaa9H5zAnuHSfOhs?= =?us-ascii?Q?0dEEJ1t3Cq2G4hn3a3CIyakRK2InagZknU7h9RbXYYRggTLrMYQF7Y16bwRw?= =?us-ascii?Q?wzdk69Cbajmy0U2nerwJIOrBM4nTv+k8T4QiQ+GSXKx01F5KWrBbEK8wFnQG?= =?us-ascii?Q?9R2s/q+LnoxCKTLOIxETKmRk6JrrrtJRY7GsO0TNYVe+KKw5sFUI6DAQJEd6?= =?us-ascii?Q?SQ58UTaUW+/eTetD1dj32teAmV0hafbll/P3HtLsLMiw54dfe/eYe7CULha0?= =?us-ascii?Q?3ppS490CDUrA+RfHcj2PYPYwSAu0bMu/NOgn/46Kdqs7hb7JxKeXh2bfHV3E?= =?us-ascii?Q?FFgcTtG5SuDkIPY9y+25NCvJzpMT+sOTaBQSxB4U7PptQKbLEDvst1yUex7B?= =?us-ascii?Q?JIpyXxXr03t+hbgmdGvGs2c6wO65Mk2bdRGQFsgzHdgutX2JhcKQ723K+zLI?= =?us-ascii?Q?YbA3fFun4HOS1OMuU4cmw3Tc8p0VyQldWMLK1dl27lQCmDpGZfR6nbhsyqrt?= =?us-ascii?Q?2scuiKJnPnHkfBxkmz3EugT7paUgHfIAcpYSnyA6gQwpa/EGHlMk569/stbG?= =?us-ascii?Q?SnBwRLEFD7kbANrZjf++aZPawpuWJheAOiHPGez8a3a7kmMb0Q+l79pQUwit?= =?us-ascii?Q?R7Ni2t3r39Q4+Pkp8SKG6vHdTNK9+gHrm6T96sgACa4oIq+jlfFff8mED8sq?= =?us-ascii?Q?HBHo7I8dyT5RSKTCeZ/1jzrhfXElH1FHtBFzfiJSUmtafP1I9MJHYnmRxrcO?= =?us-ascii?Q?ycf6B/B31oiyYT3Pj2uyvfthyfR0KlxcUaDl9kWfXXC8xEKqd2UFMefK4Wjj?= =?us-ascii?Q?FUNFK2pZTTI6joto+I7CZDXdj8fo7hu4oxxcNbMCcjxj2/BBP04cLIutJ7Y+?= x-ms-exchange-antispam-messagedata-1: D/om9MyuVqbiuozB4gGU+qGwkyBXme4WKHw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: affc1b66-6d2c-4bc7-5434-08da503f8777 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 08:58:21.1783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BUfpd+vM1IoNwPb6Sa14881GCRIijL8hCwe1RwTyVwj+Xh1HkkJWyh5vwkM5fFH5mvTnlV0PWaQAjUzOItApvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6237 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Huang, Wei > Sent: Friday, June 17, 2022 3:20 PM > To: dev@dpdk.org; thomas@monjalon.net; nipun.gupta@nxp.com; > hemant.agrawal@nxp.com > Cc: stable@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 3/4] raw/ifpga/base: update flash operation interface >=20 > In N6000 ADP platform, SPI protocol, master and QSPI flash are transparen= t to > host software. The SPI master implemented in PMCI automatically converts = the > mailbox commands to the SPI protocol required by SPI slave. > That means flash operation is different from old platform, new interfaces= are > introduced to adapt these changes. >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/base/ifpga_api.c | 9 + > drivers/raw/ifpga/base/ifpga_feature_dev.h | 2 + > drivers/raw/ifpga/base/ifpga_fme.c | 8 + > drivers/raw/ifpga/base/opae_hw_api.c | 20 ++ > drivers/raw/ifpga/base/opae_hw_api.h | 2 + > drivers/raw/ifpga/base/opae_intel_max10.c | 282 > +++++++++++++++++++++++ > drivers/raw/ifpga/base/opae_intel_max10.h | 46 ++++ > drivers/raw/ifpga/base/osdep_rte/osdep_generic.h | 10 + > 8 files changed, 379 insertions(+) >=20 > diff --git a/drivers/raw/ifpga/base/ifpga_api.c > b/drivers/raw/ifpga/base/ifpga_api.c > index f19cc26..098de0c 100644 > --- a/drivers/raw/ifpga/base/ifpga_api.c > +++ b/drivers/raw/ifpga/base/ifpga_api.c > @@ -268,6 +268,14 @@ static int ifpga_mgr_reload(struct opae_manager > *mgr, int type, int page) > return fpga_reload(fme, type, page); > } >=20 > +static int ifpga_mgr_read_flash(struct opae_manager *mgr, u32 address, > + u32 size, void *buf) > +{ > + struct ifpga_fme_hw *fme =3D mgr->data; > + > + return fme_mgr_read_flash(fme, address, size, buf); } > + > struct opae_manager_ops ifpga_mgr_ops =3D { > .flash =3D ifpga_mgr_flash, > .get_eth_group_region_info =3D ifpga_mgr_get_eth_group_region_info, > @@ -277,6 +285,7 @@ struct opae_manager_ops ifpga_mgr_ops =3D { > .update_flash =3D ifpga_mgr_update_flash, > .stop_flash_update =3D ifpga_mgr_stop_flash_update, > .reload =3D ifpga_mgr_reload, > + .read_flash =3D ifpga_mgr_read_flash > }; >=20 > static int ifpga_mgr_read_mac_rom(struct opae_manager *mgr, int offset, = diff > --git a/drivers/raw/ifpga/base/ifpga_feature_dev.h > b/drivers/raw/ifpga/base/ifpga_feature_dev.h > index a637eb5..7a2f2e5 100644 > --- a/drivers/raw/ifpga/base/ifpga_feature_dev.h > +++ b/drivers/raw/ifpga/base/ifpga_feature_dev.h > @@ -223,4 +223,6 @@ int fme_mgr_get_retimer_status(struct ifpga_fme_hw > *fme, int fme_mgr_get_sensor_value(struct ifpga_fme_hw *fme, > struct opae_sensor_info *sensor, > unsigned int *value); > +int fme_mgr_read_flash(struct ifpga_fme_hw *fme, u32 address, > + u32 size, void *buf); > #endif /* _IFPGA_FEATURE_DEV_H_ */ > diff --git a/drivers/raw/ifpga/base/ifpga_fme.c > b/drivers/raw/ifpga/base/ifpga_fme.c > index 608a352..25ff819 100644 > --- a/drivers/raw/ifpga/base/ifpga_fme.c > +++ b/drivers/raw/ifpga/base/ifpga_fme.c > @@ -1658,3 +1658,11 @@ struct ifpga_feature_ops fme_pmci_ops =3D { > .init =3D fme_pmci_init, > .uinit =3D fme_pmci_uinit, > }; > + > +int fme_mgr_read_flash(struct ifpga_fme_hw *fme, u32 address, > + u32 size, void *buf) > +{ > + struct intel_max10_device *max10 =3D fme->max10_dev; > + > + return opae_read_flash(max10, address, size, buf); } > diff --git a/drivers/raw/ifpga/base/opae_hw_api.c > b/drivers/raw/ifpga/base/opae_hw_api.c > index 87256fc..fd08326 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.c > +++ b/drivers/raw/ifpga/base/opae_hw_api.c > @@ -1041,3 +1041,23 @@ int opae_mgr_reload(struct opae_manager *mgr, > int type, int page) >=20 > return -ENOENT; > } > +/** > + * opae_mgr_read_flash - read flash content > + * @mgr: targeted manager > + * @address: the start address of flash > + * @size: the size of flash > + * @buf: the read buffer > + * > + * Return: 0 on success, otherwise error code. > + */ > +int opae_mgr_read_flash(struct opae_manager *mgr, u32 address, > + u32 size, void *buf) > +{ > + if (!mgr) > + return -EINVAL; > + > + if (mgr->ops && mgr->ops->read_flash) > + return mgr->ops->read_flash(mgr, address, size, buf); > + > + return -ENOENT; > +} > diff --git a/drivers/raw/ifpga/base/opae_hw_api.h > b/drivers/raw/ifpga/base/opae_hw_api.h > index fd40e09..de1e984 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.h > +++ b/drivers/raw/ifpga/base/opae_hw_api.h > @@ -60,6 +60,7 @@ struct opae_manager_ops { > u64 *status); > int (*stop_flash_update)(struct opae_manager *mgr, int force); > int (*reload)(struct opae_manager *mgr, int type, int page); > + int (*read_flash)(struct opae_manager *mgr, u32 address, u32 size, > +void *buf); > }; >=20 > /* networking management ops in FME */ > @@ -368,4 +369,5 @@ int opae_mgr_update_flash(struct opae_manager *mgr, > const char *image, > uint64_t *status); > int opae_mgr_stop_flash_update(struct opae_manager *mgr, int force); in= t > opae_mgr_reload(struct opae_manager *mgr, int type, int page); > +int opae_mgr_read_flash(struct opae_manager *mgr, u32 address, u32 > +size, void *buf); > #endif /* _OPAE_HW_API_H_*/ > diff --git a/drivers/raw/ifpga/base/opae_intel_max10.c > b/drivers/raw/ifpga/base/opae_intel_max10.c > index 26f323c..9c01729 100644 > --- a/drivers/raw/ifpga/base/opae_intel_max10.c > +++ b/drivers/raw/ifpga/base/opae_intel_max10.c > @@ -58,6 +58,279 @@ int max10_sys_update_bits(struct intel_max10_device > *dev, unsigned int offset, > return max10_sys_write(dev, offset, temp); } >=20 > +static int n3000_bulk_raw_write(struct intel_max10_device *dev, uint32_t > addr, > + void *buf, uint32_t len) > +{ > + uint32_t v =3D 0; > + uint32_t i =3D 0; > + char *p =3D buf; > + int ret =3D 0; > + > + len =3D IFPGA_ALIGN(len, 4); > + > + for (i =3D 0; i < len; i +=3D 4) { > + v =3D *(uint32_t *)(p + i); > + ret =3D max10_reg_write(dev, addr + i, v); > + if (ret < 0) { > + dev_err(dev, > + "Failed to write to staging area 0x%08x > [e:%d]\n", > + addr + i, ret); > + return ret; > + } > + } > + > + return 0; > +} > + > +static int n3000_bulk_raw_read(struct intel_max10_device *dev, > + uint32_t addr, void *buf, uint32_t len) { > + u32 v, i; > + char *p =3D buf; > + int ret; > + > + len =3D IFPGA_ALIGN(len, 4); > + > + for (i =3D 0; i < len; i +=3D 4) { > + ret =3D max10_reg_read(dev, addr + i, &v); > + if (ret < 0) { > + dev_err(dev, > + "Failed to write to staging area 0x%08x > [e:%d]\n", > + addr + i, ret); > + return ret; > + } > + *(u32 *)(p + i) =3D v; > + } > + > + return 0; > +} > + > +static int n3000_flash_read(struct intel_max10_device *dev, > + u32 addr, void *buf, u32 size) > +{ > + if (!dev->raw_blk_ops.read_blk) > + return -ENODEV; > + > + return dev->raw_blk_ops.read_blk(dev, addr, buf, size); } > + > +static int n3000_flash_write(struct intel_max10_device *dev, > + u32 addr, void *buf, u32 size) > +{ > + if (!dev->raw_blk_ops.write_blk) > + return -ENODEV; > + > + return dev->raw_blk_ops.write_blk(dev, addr, buf, size); } > + > +static u32 > +pmci_get_write_space(struct intel_max10_device *dev, u32 size) { > + u32 count, val; > + int ret; > + > + ret =3D opae_readl_poll_timeout(dev->mmio + PMCI_FLASH_CTRL, val, > + GET_FIELD(PMCI_FLASH_FIFO_SPACE, val) =3D=3D > + PMCI_FIFO_MAX_WORDS, > + PMCI_FLASH_INT_US, > PMCI_FLASH_TIMEOUT_US); > + if (ret =3D=3D -ETIMEDOUT) > + return 0; > + > + count =3D GET_FIELD(PMCI_FLASH_FIFO_SPACE, val) * 4; > + > + return (size > count) ? count : size; > +} > + > +static void pmci_write_fifo(void __iomem *base, char *buf, size_t > +count) { > + size_t i; > + u32 val; > + > + for (i =3D 0; i < count/4 ; i++) { > + val =3D *(u32 *)(buf + i * 4); > + writel(val, base); > + } > +} > + > +static void pmci_read_fifo(void __iomem *base, char *buf, size_t count) > +{ > + size_t i; > + u32 val; > + > + for (i =3D 0; i < count/4; i++) { > + val =3D readl(base); > + *(u32 *)(buf + i * 4) =3D val; > + } > +} > + > +static int > +__pmci_flash_bulk_write(struct intel_max10_device *dev, u32 addr, > + void *buf, u32 size) > +{ > + UNUSED(addr); > + u32 blk_size, n_offset =3D 0; > + > + while (size) { > + blk_size =3D pmci_get_write_space(dev, size); > + if (blk_size =3D=3D 0) { > + dev_err(pmci->dev, "get FIFO available size fail\n"); > + return -EIO; > + } > + size -=3D blk_size; > + pmci_write_fifo(dev->mmio + PMCI_FLASH_FIFO, (char *)buf + > n_offset, > + blk_size); > + n_offset +=3D blk_size; > + } > + > + return 0; > +} > + > +static int > +pmci_flash_bulk_write(struct intel_max10_device *dev, u32 addr, > + void *buf, u32 size) > +{ > + int ret; > + > + pthread_mutex_lock(dev->bmc_ops.mutex); > + > + ret =3D __pmci_flash_bulk_write(dev, addr, buf, size); > + > + pthread_mutex_unlock(dev->bmc_ops.mutex); > + return ret; > +} > + > +static int > +pmci_set_flash_host_mux(struct intel_max10_device *dev, bool request) { > + u32 ctrl; > + int ret; > + > + ret =3D max10_sys_update_bits(dev, > + m10bmc_base(dev) + M10BMC_PMCI_FLASH_CTRL, > + FLASH_HOST_REQUEST, > + SET_FIELD(FLASH_HOST_REQUEST, request)); > + if (ret) > + return ret; > + > + return opae_max10_read_poll_timeout(dev, m10bmc_base(dev) + > M10BMC_PMCI_FLASH_CTRL, > + ctrl, request ? (get_flash_mux(ctrl) =3D=3D > FLASH_MUX_HOST) : > + (get_flash_mux(ctrl) !=3D FLASH_MUX_HOST), > + PMCI_FLASH_INT_US, PMCI_FLASH_TIMEOUT_US); } > + > +static int > +pmci_get_mux(struct intel_max10_device *dev) { > + pthread_mutex_lock(dev->bmc_ops.mutex); > + return pmci_set_flash_host_mux(dev, true); } > + > +static int > +pmci_put_mux(struct intel_max10_device *dev) { > + int ret; > + > + ret =3D pmci_set_flash_host_mux(dev, false); > + pthread_mutex_unlock(dev->bmc_ops.mutex); > + return ret; > +} > + > +static int > +__pmci_flash_bulk_read(struct intel_max10_device *dev, u32 addr, > + void *buf, u32 size) > +{ > + u32 blk_size, offset =3D 0, val; > + int ret; > + > + while (size) { > + blk_size =3D min_t(u32, size, PMCI_READ_BLOCK_SIZE); > + > + opae_writel(addr + offset, dev->mmio + PMCI_FLASH_ADDR); > + > + opae_writel(SET_FIELD(PMCI_FLASH_READ_COUNT, blk_size / > 4) > + | PMCI_FLASH_RD_MODE, > + dev->mmio + PMCI_FLASH_CTRL); > + > + ret =3D opae_readl_poll_timeout((dev->mmio + > PMCI_FLASH_CTRL), > + val, !(val & PMCI_FLASH_BUSY), > + PMCI_FLASH_INT_US, > + PMCI_FLASH_TIMEOUT_US); > + if (ret) { > + dev_err(dev, "%s timed out on reading flash 0x%xn", > + __func__, val); > + return ret; > + } > + > + pmci_read_fifo(dev->mmio + PMCI_FLASH_FIFO, (char *)buf + > offset, > + blk_size); > + > + size -=3D blk_size; > + offset +=3D blk_size; > + > + opae_writel(0, dev->mmio + PMCI_FLASH_CTRL); > + } > + > + return 0; > +} > + > +static int > +pmci_flash_bulk_read(struct intel_max10_device *dev, u32 addr, > + void *buf, u32 size) > +{ > + int ret; > + > + ret =3D pmci_get_mux(dev); > + if (ret) > + goto fail; > + > + ret =3D __pmci_flash_bulk_read(dev, addr, buf, size); > + if (ret) > + goto fail; > + > + return pmci_put_mux(dev); > + > +fail: > + pmci_put_mux(dev); > + return ret; > +} > + > +static int pmci_check_flash_address(u32 start, u32 end) { > + if (start < PMCI_FLASH_START || end > PMCI_FLASH_END) > + return -EINVAL; > + > + return 0; > +} > + > +int opae_read_flash(struct intel_max10_device *dev, u32 addr, > + u32 size, void *buf) > +{ > + int ret; > + > + if (!dev->bmc_ops.flash_read) > + return -ENODEV; > + > + if (!buf) > + return -EINVAL; > + > + if (dev->bmc_ops.check_flash_range) { > + ret =3D dev->bmc_ops.check_flash_range(addr, addr + size); > + if (ret) > + return ret; > + } else { > + u32 top_addr =3D dev->staging_area_base + dev- > >staging_area_size; > + if ((addr < dev->staging_area_base) || > + ((addr + size) >=3D top_addr)) > + return -EINVAL; > + } > + > + ret =3D dev->bmc_ops.flash_read(dev, addr, buf, size); > + if (ret) > + return ret; > + > + return 0; > +} > + > static int max10_spi_read(struct intel_max10_device *dev, > unsigned int addr, unsigned int *val) > { > @@ -841,6 +1114,11 @@ int max10_get_bmcfw_version(struct > intel_max10_device *dev, unsigned int *val) > dev->ops =3D &m10bmc_n3000_regmap; > dev->csr =3D &m10bmc_spi_csr; >=20 > + dev->raw_blk_ops.write_blk =3D n3000_bulk_raw_write; > + dev->raw_blk_ops.read_blk =3D n3000_bulk_raw_read; > + dev->bmc_ops.flash_read =3D n3000_flash_read; > + dev->bmc_ops.flash_write =3D n3000_flash_write; > + > /* check the max10 version */ > ret =3D check_max10_version(dev); > if (ret) { > @@ -871,6 +1149,10 @@ int max10_get_bmcfw_version(struct > intel_max10_device *dev, unsigned int *val) > dev->staging_area_size =3D MAX_STAGING_AREA_SIZE; > dev->flags |=3D MAX10_FLAGS_SECURE; >=20 > + dev->bmc_ops.flash_read =3D pmci_flash_bulk_read; > + dev->bmc_ops.flash_write =3D pmci_flash_bulk_write; > + dev->bmc_ops.check_flash_range =3D pmci_check_flash_address; > + > ret =3D pthread_mutex_init(&dev->bmc_ops.lock, NULL); > if (ret) > return ret; > diff --git a/drivers/raw/ifpga/base/opae_intel_max10.h > b/drivers/raw/ifpga/base/opae_intel_max10.h > index 6a1b122..0f3360e 100644 > --- a/drivers/raw/ifpga/base/opae_intel_max10.h > +++ b/drivers/raw/ifpga/base/opae_intel_max10.h > @@ -62,9 +62,22 @@ struct m10bmc_csr { > }; >=20 > /** > + * struct flash_raw_blk_ops - device specific operations for flash R/W > + * @write_blk: write a block of data to flash > + * @read_blk: read a block of data from flash */ struct > +flash_raw_blk_ops { > + int (*write_blk)(struct intel_max10_device *dev, uint32_t addr, > + void *buf, uint32_t size); > + int (*read_blk)(struct intel_max10_device *dev, uint32_t addr, > + void *buf, uint32_t size); > +}; > + > +/** > * struct m10bmc_ops - device specific operations > * @lock: prevent concurrent flash read/write > * @mutex: prevent concurrent bmc read/write > + * @check_flash_range: validate flash address > * @flash_read: read a block of data from flash > * @flash_write: write a block of data to flash > */ > @@ -92,6 +105,7 @@ struct intel_max10_device { > enum m10bmc_type type; > const struct m10bmc_regmap *ops; > const struct m10bmc_csr *csr; > + struct flash_raw_blk_ops raw_blk_ops; > struct m10bmc_ops bmc_ops; > u8 *mmio; /* mmio address for PMCI */ > }; > @@ -431,6 +445,22 @@ struct opae_sensor_info { #define > PMCI_FPGA_RECONF_PAGE GENMASK(22, 20) > #define PMCI_FPGA_RP_LOAD BIT(23) >=20 > +#define PMCI_FLASH_CTRL 0x40 > +#define PMCI_FLASH_WR_MODE BIT(0) > +#define PMCI_FLASH_RD_MODE BIT(1) > +#define PMCI_FLASH_BUSY BIT(2) > +#define PMCI_FLASH_FIFO_SPACE GENMASK(13, 4) #define > +PMCI_FLASH_READ_COUNT GENMASK(25, 16) > + > +#define PMCI_FLASH_INT_US 1 > +#define PMCI_FLASH_TIMEOUT_US 10000 > + > +#define PMCI_FLASH_ADDR 0x44 > +#define PMCI_FLASH_FIFO 0x800 > +#define PMCI_READ_BLOCK_SIZE 0x800 > +#define PMCI_FIFO_MAX_BYTES 0x800 > +#define PMCI_FIFO_MAX_WORDS (PMCI_FIFO_MAX_BYTES / 4) > + > #define M10BMC_PMCI_FPGA_POC 0xb0 > #define PMCI_FPGA_POC BIT(0) > #define PMCI_NIOS_REQ_CLEAR BIT(1) > @@ -447,6 +477,16 @@ struct opae_sensor_info { #define > PMCI_FPGA_BOOT_PAGE GENMASK(2, 0) #define PMCI_FPGA_CONFIGURED > BIT(3) >=20 > +#define M10BMC_PMCI_FLASH_CTRL 0x1d0 > +#define FLASH_MUX_SELECTION GENMASK(2, 0) #define FLASH_MUX_IDLE 0 > +#define FLASH_MUX_NIOS 1 #define FLASH_MUX_HOST 2 #define > FLASH_MUX_PFL > +4 #define get_flash_mux(mux) GET_FIELD(FLASH_MUX_SELECTION, mux) > +#define FLASH_NIOS_REQUEST BIT(4) #define FLASH_HOST_REQUEST BIT(5) > + > #define M10BMC_PMCI_SDM_CTRL_STS 0x230 > #define PMCI_SDM_IMG_REQ BIT(0) > #define PMCI_SDM_STAT GENMASK(23, 16) > @@ -472,4 +512,10 @@ struct opae_sensor_info { > #define SDM_STAT_CS_MIS 0x12 > #define SDM_STAT_PR_MIS 0x13 > #define SDM_STAT_MAX SDM_STAT_PR_MIS > + > +#define PMCI_FLASH_START 0x10000 > +#define PMCI_FLASH_END 0xC7FFFFF > + > +int opae_read_flash(struct intel_max10_device *dev, u32 addr, > + u32 size, void *buf); > #endif > diff --git a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > index 3ff49a8..68499e6 100644 > --- a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > +++ b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > @@ -39,6 +39,16 @@ > #define min(a, b) RTE_MIN(a, b) > #define max(a, b) RTE_MAX(a, b) >=20 > +#define min_t(type, x, y) ({ \ > + type __min1 =3D (x); \ > + type __min2 =3D (y); \ > + __min1 < __min2 ? __min1 : __min2; }) > + > +#define max_t(type, x, y) ({ \ > + type __max1 =3D (x); \ > + type __max2 =3D (y); \ > + __max1 > __max2 ? __max1 : __max2; }) > + > #define spinlock_t rte_spinlock_t > #define spinlock_init(x) rte_spinlock_init(x) #define spinlock_lock(x) > rte_spinlock_lock(x) > -- > 1.8.3.1 It looks good for me. Acked-by: Tianfei Zhang