From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E008BA0093; Fri, 17 Jun 2022 10:58:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD104427F3; Fri, 17 Jun 2022 10:58:51 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 2461D40698; Fri, 17 Jun 2022 10:58:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655456330; x=1686992330; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LlhKcpSKweenJr8P8bAEh1MBS6sHzH/uMppRUW6/0Oc=; b=LQUNEwsGR2vEOTCLOcJNSJ2QO/lMlN/AlVoM99R96Zl40GVutIGHoxlg t6F4TkJAAxTUhOfb2R0C4Xh593j6AqrzL8d9mw8pqlwgutojL3ABpsLR7 q3D9ZNUxT5A+PsjNvpfeWWgHWxElKinH0ZhWFvt/Xsyj/bGQ1Tw05l0jx bgmd5J9hzggrHux4G4UTDNRXfMJc76R+2QaIYdKkX8qKuQhZoEWt3SCkn QXrOaUFCgWvLpO/xWf6ru/MN+V/DcR2v+9+AGHAIXjKSiqOgOa0zfSxlL MixMa6l5k9koFj4NtmvDB/ON4Atb8uj7NQV3gEhWtRIrHxl2U29mRQcSq Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="259916943" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="259916943" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 01:58:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="912535251" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 17 Jun 2022 01:58:49 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 17 Jun 2022 01:58:48 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 17 Jun 2022 01:58:48 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 17 Jun 2022 01:58:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZuXrX/SI3XP7K5PN574AQLmdwUN1WZve3VjlY2YnS89QU2V8hjKXK2H1el4BzByw2lQ1cdaHkCGtJFYvFlQKrwmax+g6OQpyCjmWn16FH/CUznd+8vOSFJrqRUMSYv9iHyrX8uK55sDYAVtXkA3ftqBO5nCGMXrIDkftW7YaAWtBfPwoUoW5NWVKgMH3WDe+GmT07Jo1+JZihTYscT5eSUyFZaQ4W+ME3eKMuBk4VsNVi627xsdMmptV1TKFtwolPfEF7xH7n7APmndV5s/v18mSTAiRfRXJGInWP2d8VHbPkL2laOXw8jJVsMHAQrNgkEb2lb6HpTyf4u7K759Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aAHfVspqdpCbKMic4qBBPLbOEBdwBmJDDBzgzkyRjU4=; b=ezPovmEN06BolSKlk8ihUiq+03jkQkFm9WCI7s/UzW5ABO96TOyoj/rYmazq4lcKZC1bIiNkNNiHZ/HiUG4HJvpCll5u1sTgAetYvFbUtkB1Fhy8gcUZDdDxlsSqg1GsFhLDmvHtsfyMmofGqM7Yevk4rtcVH2z+Okro0+ToV+UnMpBULQUhvnBLyp9LucXG22/Vcws4MKEuq7yFP9dbUI0fb1kwqQamceyOwszENfOE2eWGPhJB2Q69J2NKQDIEl3yZYCfKJn18Qg+8Sv9fopEniN3yMG2Siak0QtMZwppvUEJlCTo0iSjvQaTTGNELw366vH824Zj/TnmOXYdXuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM4PR11MB6237.namprd11.prod.outlook.com (2603:10b6:8:a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.19; Fri, 17 Jun 2022 08:58:41 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::a113:c892:d94:dd10]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::a113:c892:d94:dd10%7]) with mapi id 15.20.5353.015; Fri, 17 Jun 2022 08:58:41 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "thomas@monjalon.net" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" CC: "stable@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" Subject: RE: [PATCH v3 4/4] raw/ifpga/base: add PMCI sensor driver Thread-Topic: [PATCH v3 4/4] raw/ifpga/base: add PMCI sensor driver Thread-Index: AQHYghmNNJmXwwy0FkqH7GyvCVwYqq1TTKHQ Date: Fri, 17 Jun 2022 08:58:41 +0000 Message-ID: References: <1654827900-10023-1-git-send-email-wei.huang@intel.com> <1655450375-10739-1-git-send-email-wei.huang@intel.com> <1655450375-10739-5-git-send-email-wei.huang@intel.com> In-Reply-To: <1655450375-10739-5-git-send-email-wei.huang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d344e9a7-54de-498e-f5f9-08da503f9363 x-ms-traffictypediagnostic: DM4PR11MB6237:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S00ZDU8jMA3s/W4eg+2rmmkRvQZ3yCjzn6tI0ftNN2KwJzVLgv0soW7NAU/vFpLi6woEu9qjLpF2h23lzkfiDZAYmi2n2w+x6g7Ql7JTvKrLxnEDSw2elRLnlrZJnYdS9jx5mJt3ZYrKM2SyvTCZZWhw1qZfkpPcAEJvvrvS6hZmbhdeJDDj92kk4UZFOe0cyde1f4e1QC2jrEGihW02eph3atrkR8kYxpBQbAmLTlaEAVKdlktFr6b9w9Wd594agvpL2cIM90tblYxwQcdq6KX1J5UKEON1mjl49G+bXcnRKBsVSxCKkv5wSWBMmq25Nu8VGM4Wa5bdVKEfeWpcEF0whbkidwkbq3ViCnW9HDB/doKqjfK9UYlzM1Y9Xa2xDsH4I/Rd9nWLQCP2dy/iC5jbxfoHp0bZNTs5QUGeUrFD2CuRl5jg7fwQsHssNry1EmCNDH8RbEad0PPtW+aUSyB7VUC1zd+qKUesEOxldzy3GhH6JQGhLuues+hzCmUNwGjrewLKXOijnYSvo3gtJC0bJ0fRqLSlzdTpE0wvYBG30qfmrpYCdk3I6enMd/ug9wNdF/tWxZPfpHJM9BRWnauftkufEGh10roDHh+K7geuXWvf4kFR0Qvex8FSyQDEuWRFQ+XlkVtWAgsSJ5Q4FqgYgvTqkLQb4AJv1NPA1wyGFZo2cPDlrSMsdjo34eE1eNkwU/9IG0nq+sSl0juz2g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5483.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(53546011)(2906002)(64756008)(186003)(76116006)(9686003)(122000001)(66476007)(66556008)(82960400001)(38100700002)(110136005)(6506007)(66946007)(8676002)(55016003)(7696005)(83380400001)(316002)(5660300002)(66446008)(8936002)(52536014)(30864003)(71200400001)(4326008)(38070700005)(107886003)(86362001)(33656002)(54906003)(498600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4nVHPm8sKUVkTPBz+hsn+wlCnr9poTmosSHZW2pHyxqJEuF+wZHmyaeYM3ox?= =?us-ascii?Q?X/S67jnu7Suz7fX4nzOwgjx+ZBHJcr/wacvWjpiV7OTrnTpS3dSm9r0rcTQJ?= =?us-ascii?Q?eR9YwPUPeDY01jCqhYficzgC07kc5ZwcjWyO/Hr9H5/2jgcgX2uDUSTswWiz?= =?us-ascii?Q?i7iXKU+5OkACFN2IflcTgii5Yqk4gaWN4DxjEwVQYmUoszmHsXlmCMC9fBb/?= =?us-ascii?Q?hShs1M8pH+qBc/+Ud763H007p4ePbrh9UboNo+kQrFt7BXSgTM6FUcVUexs7?= =?us-ascii?Q?mQIgDaIgPR8D3qwGndnwPNioTvMx8RH0pwjhDjCtELv+OHZG7XlkZ0G44kcN?= =?us-ascii?Q?XZYm/twjZ6YKGaNt2pEsnb+kO5IY2riautm5qx1eH6dbwh9pcK3EA40uYnyW?= =?us-ascii?Q?VX6jHrm6fFQkG3HLPoWfuKzkSC3w0jSdEE5ssd1wXnH1bte/3zqzZnBxu6tx?= =?us-ascii?Q?VNTceIlv+bi1mYkvvSf6hSrOmHk56IKO9cOjUuV16aQl5rtmXy/fb6VFZEWk?= =?us-ascii?Q?6HEqjRw2r+7pwpGWgiHgT7Se7xu9ftYGIuNIdrVScDdwavZVHOPWwFogtMm3?= =?us-ascii?Q?iSlGwB8O0gv3NBpHEmvSqbHKkdIYqF5Q0UE7xly7lnNnyKDOyjHEwZdFd5jk?= =?us-ascii?Q?w+qgy3V1rJVMIRFVKMO2xq/BcsUv3Pp7bA26g55x3P0TuhExOwQF8kA8BlC4?= =?us-ascii?Q?4l6rTsmYUGaozzKZDan650LA58ESqJr586jTjg62olP+W2XVk6Vkku/wcMGW?= =?us-ascii?Q?v+7QbMFYmBwEOt0C+WAdSgmgTUMI4aDHAvGQGhnuQeI4KfvUg0zJ/Rw+4g8P?= =?us-ascii?Q?i8n9XMB+o66p07/bfeVxY676/K92+DHWBmk4LO3iLC4L5FbUJ34y9xE2PH3s?= =?us-ascii?Q?i1TRJoBKwqsZCxxZcV9hq1Ec8G8nniLVWHgmbOIMzTriuQNxeu9qhIotcety?= =?us-ascii?Q?FhMjKCokW6nB+lUGAdjyAAIxHrcPdMIjEr2cnmUt/6DFXM0bm1izkztkowJk?= =?us-ascii?Q?Zl1QEoEAW9b7ePMFulZ8JX8D1l+kT7Tb7iah5Ijcw/ULv3Ns9oiuhont6U5i?= =?us-ascii?Q?t/lRZcdFsa6yieSI/pb8M7YTYDhrAUyn4boHO7xkAwJUKlPeoYlDQQK/ogZ2?= =?us-ascii?Q?jfQuoKrHmKgUQWXJo+RJjipyZnQLbxG7puEUPn2h0RG6SDf0KTfLSjY6fthV?= =?us-ascii?Q?u5XJ7p5XIREhE29TqyBm/zUe9ZTy5orsodC/u/0V1hsvZQRR8bos/7n+D26a?= =?us-ascii?Q?aYCA6n4lXeSktp8JLFgsl7DJ6BmnpxMimRUY/T+IiB+CCBZHyDLxbeCTrBBG?= =?us-ascii?Q?QPLaFRXbamWB/f6YsJiYXN6F2EbpaSEquCGupuPkdEf40APozZOKSDR1MhIx?= =?us-ascii?Q?ucpZC7Sc7dZ7m9TbP9pHcIxOVIbPA9bD2+eu7h1nxDAFVkDrg7Ujkqv6jURa?= =?us-ascii?Q?2iip6By2ibbwhdZX5RqRCZHiS859B6xCkvMigIGns8C7u+BeGNzymMVPeXK/?= =?us-ascii?Q?VQKu2RvSgANqEBUtMB+jpVBulcKgil6VQoWvK+NembhcDQWVT0vJ2vfryztm?= =?us-ascii?Q?WAA4foqkGC9AYNr5DeeIfxbS5NQOxfLOvfgSeXlilABRqZM0BofxuBztsycp?= =?us-ascii?Q?WvcISUljTR34ThSVVPP8Wc+6uF0LV1ph9jR/p/tN88tuhBbXHcBQcUn3p9uG?= =?us-ascii?Q?QrukwKZz9TMEo/rDxOho3t+KLyxbvtuCnOQ5R0UYNJjAsnOPypt//oqx8UXR?= =?us-ascii?Q?AXtlJkVz6m11Xt3Yu0Gr6aDJmXK4Zq6q15B6A2+B8I1uY4UOv9dBo9aycMjj?= x-ms-exchange-antispam-messagedata-1: GEEB6uufWyJBmwOZFwLwTlbzPky9do9LM7c= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d344e9a7-54de-498e-f5f9-08da503f9363 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 08:58:41.1841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y8VAwQtAAPzYFJSx2VXZazs3M5CEA8bhqBxvBbljZLjlsRAGLJXZvIEtrsEk4Tg1VsN58if8HUmHTTiqVGH/9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6237 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Huang, Wei > Sent: Friday, June 17, 2022 3:20 PM > To: dev@dpdk.org; thomas@monjalon.net; nipun.gupta@nxp.com; > hemant.agrawal@nxp.com > Cc: stable@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 4/4] raw/ifpga/base: add PMCI sensor driver >=20 > N6000 ADP platform support more sensors than N3000, they are accessed wit= h > the help of PMCI sensor driver. >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/base/opae_hw_api.c | 29 +++ > drivers/raw/ifpga/base/opae_hw_api.h | 1 + > drivers/raw/ifpga/base/opae_intel_max10.c | 326 > ++++++++++++++++++++++++++++++ > drivers/raw/ifpga/base/opae_intel_max10.h | 35 ++++ > 4 files changed, 391 insertions(+) >=20 > diff --git a/drivers/raw/ifpga/base/opae_hw_api.c > b/drivers/raw/ifpga/base/opae_hw_api.c > index fd08326..1117c3e 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.c > +++ b/drivers/raw/ifpga/base/opae_hw_api.c > @@ -831,6 +831,35 @@ int opae_manager_get_retimer_status(struct > opae_manager *mgr, } >=20 > /** > + * opae_manager_get_sensor_list - get sensor name list > + * @mgr: opae_manager of sensors > + * @buf: buffer to accommodate name list separated by semicolon > + * @size: size of buffer > + * > + * Return: the pointer of the opae_sensor_info */ int > +opae_mgr_get_sensor_list(struct opae_manager *mgr, char *buf, size_t > +size) { > + struct opae_sensor_info *sensor; > + uint32_t offset =3D 0; > + > + opae_mgr_for_each_sensor(mgr, sensor) { > + if (sensor->name) { > + if (buf && (offset < size)) > + snprintf(buf + offset, size - offset, "%s;", > + sensor->name); > + offset +=3D strlen(sensor->name) + 1; > + } > + } > + > + if (buf && (offset > 0) && (offset <=3D size)) > + buf[offset-1] =3D 0; > + > + return offset; > +} > + > +/** > * opae_manager_get_sensor_by_id - get sensor device > * @id: the id of the sensor > * > diff --git a/drivers/raw/ifpga/base/opae_hw_api.h > b/drivers/raw/ifpga/base/opae_hw_api.h > index de1e984..613563a 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.h > +++ b/drivers/raw/ifpga/base/opae_hw_api.h > @@ -94,6 +94,7 @@ int opae_manager_flash(struct opae_manager *mgr, int > acc_id, const char *buf, > u32 size, u64 *status); > int opae_manager_get_eth_group_region_info(struct opae_manager *mgr, > u8 group_id, struct opae_eth_group_region_info *info); > +int opae_mgr_get_sensor_list(struct opae_manager *mgr, char *buf, > +size_t size); > struct opae_sensor_info *opae_mgr_get_sensor_by_name(struct > opae_manager *mgr, > const char *name); > struct opae_sensor_info *opae_mgr_get_sensor_by_id(struct opae_manager > *mgr, diff --git a/drivers/raw/ifpga/base/opae_intel_max10.c > b/drivers/raw/ifpga/base/opae_intel_max10.c > index 9c01729..dd97a5f 100644 > --- a/drivers/raw/ifpga/base/opae_intel_max10.c > +++ b/drivers/raw/ifpga/base/opae_intel_max10.c > @@ -1102,6 +1102,328 @@ int max10_get_bmcfw_version(struct > intel_max10_device *dev, unsigned int *val) > .auth_result =3D M10BMC_PMCI_AUTH_RESULT, }; >=20 > +static const struct max10_sensor_raw_data n6000bmc_temp_tbl[] =3D { > + { 0x444, 0x448, 0x44c, 0x0, 0x0, 500, > + "FPGA E-TILE Temperature #1" }, > + { 0x450, 0x454, 0x458, 0x0, 0x0, 500, > + "FPGA E-TILE Temperature #2" }, > + { 0x45c, 0x460, 0x464, 0x0, 0x0, 500, > + "FPGA E-TILE Temperature #3" }, > + { 0x468, 0x46c, 0x470, 0x0, 0x0, 500, > + "FPGA E-TILE Temperature #4" }, > + { 0x474, 0x478, 0x47c, 0x0, 0x0, 500, > + "FPGA P-TILE Temperature" }, > + { 0x484, 0x488, 0x48c, 0x0, 0x0, 500, > + "FPGA FABRIC Digital Temperature#1" }, > + { 0x490, 0x494, 0x498, 0x0, 0x0, 500, > + "FPGA FABRIC Digital Temperature#2" }, > + { 0x49c, 0x4a0, 0x4a4, 0x0, 0x0, 500, > + "FPGA FABRIC Digital Temperature#3" }, > + { 0x4a8, 0x4ac, 0x4b0, 0x0, 0x0, 500, > + "FPGA FABRIC Digital Temperature#4" }, > + { 0x4b4, 0x4b8, 0x4bc, 0x0, 0x0, 500, > + "FPGA FABRIC Digital Temperature#5" }, > + { 0x4c0, 0x4c4, 0x4c8, 0x0, 0x0, 500, > + "FPGA FABRIC Remote Digital Temperature#1" }, > + { 0x4cc, 0x4d0, 0x4d4, 0x0, 0x0, 500, > + "FPGA FABRIC Remote Digital Temperature#2" }, > + { 0x4d8, 0x4dc, 0x4e0, 0x0, 0x0, 500, > + "FPGA FABRIC Remote Digital Temperature#3" }, > + { 0x4e4, 0x4e8, 0x4ec, 0x0, 0x0, 500, > + "FPGA FABRIC Remote Digital Temperature#4" }, > + { 0x4f0, 0x4f4, 0x4f8, 0x0, 0x0, 500, > + "Board Top Near FPGA Temperature" }, > + { 0x4fc, 0x500, 0x504, 0x52c, 0x0, 500, > + "Board Bottom Near CVL Temperature" }, > + { 0x508, 0x50c, 0x510, 0x52c, 0x0, 500, > + "Board Top East Near VRs Temperature" }, > + { 0x514, 0x518, 0x51c, 0x52c, 0x0, 500, > + "Columbiaville Die Temperature" }, > + { 0x520, 0x524, 0x528, 0x52c, 0x0, 500, > + "Board Rear Side Temperature" }, > + { 0x530, 0x534, 0x538, 0x52c, 0x0, 500, > + "Board Front Side Temperature" }, > + { 0x53c, 0x540, 0x544, 0x0, 0x0, 500, > + "QSFP1 Temperature" }, > + { 0x548, 0x54c, 0x550, 0x0, 0x0, 500, > + "QSFP2 Temperature" }, > + { 0x554, 0x0, 0x0, 0x0, 0x0, 500, > + "FPGA Core Voltage Phase 0 VR Temperature" }, > + { 0x560, 0x0, 0x0, 0x0, 0x0, 500, > + "FPGA Core Voltage Phase 1 VR Temperature" }, > + { 0x56c, 0x0, 0x0, 0x0, 0x0, 500, > + "FPGA Core Voltage Phase 2 VR Temperature" }, > + { 0x578, 0x0, 0x0, 0x0, 0x0, 500, > + "FPGA Core Voltage VR Controller Temperature" }, > + { 0x584, 0x0, 0x0, 0x0, 0x0, 500, > + "FPGA VCCH VR Temperature" }, > + { 0x590, 0x0, 0x0, 0x0, 0x0, 500, > + "FPGA VCC_1V2 VR Temperature" }, > + { 0x59c, 0x0, 0x0, 0x0, 0x0, 500, > + "FPGA VCCH, VCC_1V2 VR Controller Temperature" }, > + { 0x5a8, 0x0, 0x0, 0x0, 0x0, 500, > + "3V3 VR Temperature" }, > + { 0x5b4, 0x5b8, 0x5bc, 0x0, 0x0, 500, > + "CVL Core Voltage VR Temperature" }, > + { 0x5c4, 0x5c8, 0x5cc, 0x5c0, 0x0, 500, > + "FPGA P-Tile Temperature [Remote]" }, > + { 0x5d0, 0x5d4, 0x5d8, 0x5c0, 0x0, 500, > + "FPGA E-Tile Temperature [Remote]" }, > + { 0x5dc, 0x5e0, 0x5e4, 0x5c0, 0x0, 500, > + "FPGA SDM Temperature [Remote]" }, > + { 0x5e8, 0x5ec, 0x5f0, 0x5c0, 0x0, 500, > + "FPGA Corner Temperature [Remote]" }, }; > + > +static const struct max10_sensor_data n6000bmc_tmp_data =3D { > + .type =3D SENSOR_TMP_NAME, > + .number =3D ARRAY_SIZE(n6000bmc_temp_tbl), > + .table =3D n6000bmc_temp_tbl, > +}; > + > +static const struct max10_sensor_raw_data n6000bmc_in_tbl[] =3D { > + { 0x5f4, 0x0, 0x0, 0x0, 0x0, 1, > + "Inlet 12V PCIe Rail Voltage" }, > + { 0x60c, 0x0, 0x0, 0x0, 0x0, 1, > + "Inlet 12V Aux Rail Voltage" }, > + { 0x624, 0x0, 0x0, 0x0, 0x0, 1, > + "Inlet 3V3 PCIe Rail Voltage" }, > + { 0x63c, 0x0, 0x0, 0x0, 0x0, 1, > + "FPGA Core Voltage Rail Voltage" }, > + { 0x644, 0x0, 0x0, 0x0, 0x0, 1, > + "FPGA VCCH Rail Voltage" }, > + { 0x64c, 0x0, 0x0, 0x0, 0x0, 1, > + "FPGA VCC_1V2 Rail Voltage" }, > + { 0x654, 0x0, 0x0, 0x0, 0x0, 1, > + "FPGA VCCH_GXER_1V1, VCCA_1V8 Voltage" }, > + { 0x664, 0x0, 0x0, 0x0, 0x0, 1, > + "FPGA VCCIO_1V2 Voltage" }, > + { 0x674, 0x0, 0x0, 0x0, 0x0, 1, > + "CVL Non Core Rails Inlet Voltage" }, > + { 0x684, 0x0, 0x0, 0x0, 0x0, 1, > + "MAX10 & Board CLK PWR 3V3 Inlet Voltage" }, > + { 0x694, 0x0, 0x0, 0x0, 0x0, 1, > + "CVL Core Voltage Rail Voltage" }, > + { 0x6ac, 0x0, 0x0, 0x0, 0x0, 1, > + "Board 3V3 VR Voltage" }, > + { 0x6b4, 0x0, 0x0, 0x0, 0x0, 1, > + "QSFP 3V3 Rail Voltage" }, > + { 0x6c4, 0x0, 0x0, 0x0, 0x0, 1, > + "QSFP (Primary) Supply Rail Voltage" }, > + { 0x6c8, 0x0, 0x0, 0x0, 0x0, 1, > + "QSFP (Secondary) Supply Rail Voltage" }, > + { 0x6cc, 0x0, 0x0, 0x0, 0x0, 1, > + "VCCCLK_GXER_2V5 Voltage" }, > + { 0x6d0, 0x0, 0x0, 0x0, 0x0, 1, > + "AVDDH_1V1_CVL Voltage" }, > + { 0x6d4, 0x0, 0x0, 0x0, 0x0, 1, > + "VDDH_1V8_CVL Voltage" }, > + { 0x6d8, 0x0, 0x0, 0x0, 0x0, 1, > + "VCCA_PLL Voltage" }, > + { 0x6e0, 0x0, 0x0, 0x0, 0x0, 1, > + "VCCRT_GXER_0V9 Voltage" }, > + { 0x6e8, 0x0, 0x0, 0x0, 0x0, 1, > + "VCCRT_GXEL_0V9 Voltage" }, > + { 0x6f0, 0x0, 0x0, 0x0, 0x0, 1, > + "VCCH_GXPL_1V8 Voltage" }, > + { 0x6f4, 0x0, 0x0, 0x0, 0x0, 1, > + "VCCPT_1V8 Voltage" }, > + { 0x6fc, 0x0, 0x0, 0x0, 0x0, 1, > + "VCC_3V3_M10 Voltage" }, > + { 0x700, 0x0, 0x0, 0x0, 0x0, 1, > + "VCC_1V8_M10 Voltage" }, > + { 0x704, 0x0, 0x0, 0x0, 0x0, 1, > + "VCC_1V2_EMIF1_2_3 Voltage" }, > + { 0x70c, 0x0, 0x0, 0x0, 0x0, 1, > + "VCC_1V2_EMIF4_5 Voltage" }, > + { 0x714, 0x0, 0x0, 0x0, 0x0, 1, > + "VCCA_1V8 Voltage" }, > + { 0x718, 0x0, 0x0, 0x0, 0x0, 1, > + "VCCH_GXER_1V1 Voltage" }, > + { 0x71c, 0x0, 0x0, 0x0, 0x0, 1, > + "AVDD_ETH_0V9_CVL Voltage" }, > + { 0x720, 0x0, 0x0, 0x0, 0x0, 1, > + "AVDD_PCIE_0V9_CVL Voltage" }, > +}; > + > +static const struct max10_sensor_data n6000bmc_in_data =3D { > + .type =3D SENSOR_IN_NAME, > + .number =3D ARRAY_SIZE(n6000bmc_in_tbl), > + .table =3D n6000bmc_in_tbl, > +}; > + > +static const struct max10_sensor_raw_data n6000bmc_curr_tbl[] =3D { > + { 0x600, 0x604, 0x608, 0x0, 0x0, 1, > + "Inlet 12V PCIe Rail Current" }, > + { 0x618, 0x61c, 0x620, 0x0, 0x0, 1, > + "Inlet 12V Aux Rail Current" }, > + { 0x630, 0x634, 0x638, 0x0, 0x0, 1, > + "Inlet 3V3 PCIe Rail Current" }, > + { 0x640, 0x0, 0x0, 0x0, 0x0, 1, > + "FPGA Core Voltage Rail Current" }, > + { 0x648, 0x0, 0x0, 0x0, 0x0, 1, > + "FPGA VCCH Rail Current" }, > + { 0x650, 0x0, 0x0, 0x0, 0x0, 1, > + "FPGA VCC_1V2 Rail Current" }, > + { 0x658, 0x65c, 0x660, 0x0, 0x0, 1, > + "FPGA VCCH_GXER_1V1, VCCA_1V8 Current" }, > + { 0x668, 0x66c, 0x670, 0x0, 0x0, 1, > + "FPGA VCCIO_1V2 Current" }, > + { 0x678, 0x67c, 0x680, 0x0, 0x0, 1, > + "CVL Non Core Rails Inlet Current" }, > + { 0x688, 0x68c, 0x680, 0x0, 0x0, 1, > + "MAX10 & Board CLK PWR 3V3 Inlet Current" }, > + { 0x690, 0x0, 0x0, 0x0, 0x0, 1, > + "CVL Core Voltage Rail Current" }, > + { 0x6b0, 0x0, 0x0, 0x0, 0x0, 1, > + "Board 3V3 VR Current" }, > + { 0x6b8, 0x6bc, 0x670, 0x0, 0x0, 1, > + "QSFP 3V3 Rail Current" }, > +}; > + > +static const struct max10_sensor_data n6000bmc_curr_data =3D { > + .type =3D SENSOR_CURR_NAME, > + .number =3D ARRAY_SIZE(n6000bmc_curr_tbl), > + .table =3D n6000bmc_curr_tbl, > +}; > + > +static const struct max10_sensor_raw_data n6000bmc_power_tbl[] =3D { > + { 0x724, 0x0, 0x0, 0x0, 0x0, 1000, "Board Power" }, }; > + > +static const struct max10_sensor_data n6000bmc_power_data =3D { > + .type =3D SENSOR_POWER_NAME, > + .number =3D ARRAY_SIZE(n6000bmc_power_tbl), > + .table =3D n6000bmc_power_tbl, > +}; > + > +static const struct max10_sensor_board_data n6000bmc_sensor_board_data = =3D > { > + .tables =3D { > + [sensor_temp] =3D &n6000bmc_tmp_data, > + [sensor_in] =3D &n6000bmc_in_data, > + [sensor_curr] =3D &n6000bmc_curr_data, > + [sensor_power] =3D &n6000bmc_power_data, > + }, > +}; > + > +static int get_sensor_data(struct intel_max10_device *dev, > + struct opae_sensor_info *sensor, > + unsigned int *value, > + unsigned int reg, > + unsigned int flags) > +{ > + int ret; > + unsigned int data; > + > + if (!reg) > + return 0; > + > + ret =3D max10_sys_read(dev, reg, &data); > + if (ret) > + return ret; > + > + if (data =3D=3D SENSOR_INVALID) { > + dev_debug(dev, "%s: sensor:%s invalid 0x%x at:%d\n", > + __func__, sensor->name, data, reg); > + return ret; > + } > + > + *value =3D data * sensor->multiplier; > + sensor->flags |=3D flags; > + > + return 0; > +} > + > +static int max10_parse_sensor_data(struct intel_max10_device *dev, > + const struct max10_sensor_data *sdata) { > + struct opae_sensor_info *sensor; > + const struct max10_sensor_raw_data *raw; > + const struct max10_sensor_raw_data *table =3D > + (const struct max10_sensor_raw_data *)sdata->table; > + unsigned int i; > + static unsigned int sensor_id; > + int ret =3D 0; > + > + for (i =3D 0; i < sdata->number; i++) { > + raw =3D &table[i]; > + > + sensor =3D opae_zmalloc(sizeof(*sensor)); > + if (!sensor) { > + ret =3D -EINVAL; > + goto free_sensor; > + } > + > + sensor->type =3D sdata->type; > + sensor->id =3D sensor_id++; > + > + if (!raw->reg_input) > + continue; > + > + sensor->value_reg =3D raw->reg_input; > + sensor->multiplier =3D raw->multiplier; > + sensor->name =3D raw->label; > + > + ret =3D get_sensor_data(dev, sensor, > + &sensor->high_warn, > + raw->reg_high_warn, > + OPAE_SENSOR_HIGH_WARN_VALID); > + if (ret) > + break; > + > + ret =3D get_sensor_data(dev, sensor, > + &sensor->high_fatal, > + raw->reg_high_fatal, > + OPAE_SENSOR_HIGH_FATAL_VALID); > + if (ret) > + break; > + > + ret =3D get_sensor_data(dev, sensor, > + &sensor->hysteresis, > + raw->reg_hyst, > + OPAE_SENSOR_HYSTERESIS_VALID); > + if (ret) > + break; > + > + ret =3D get_sensor_data(dev, sensor, > + &sensor->low_warn, > + raw->reg_low_warn, > + OPAE_SENSOR_LOW_WARN_VALID); > + if (ret) > + break; > + > + sensor->flags |=3D OPAE_SENSOR_VALID; > + > + TAILQ_INSERT_TAIL(&dev->opae_sensor_list, sensor, node); > + dev_info(dev, "found valid sensor: %s\n", sensor->name); > + } > + > + return ret; > + > +free_sensor: > + max10_sensor_uinit(dev); > + return ret; > +} > + > +static int max10_sensor_init_table(struct intel_max10_device *dev, > + const struct max10_sensor_board_data *data) { > + int ret =3D 0; > + unsigned int i; > + const struct max10_sensor_data *sdata; > + > + for (i =3D 0; i < ARRAY_SIZE(data->tables); i++) { > + sdata =3D data->tables[i]; > + if (!sdata) > + continue; > + ret =3D max10_parse_sensor_data(dev, sdata); > + if (ret) > + break; > + } > + > + return ret; > +} > + > int > intel_max10_device_init(struct intel_max10_device *dev) { @@ -1153,6 > +1475,10 @@ int max10_get_bmcfw_version(struct intel_max10_device *dev, > unsigned int *val) > dev->bmc_ops.flash_write =3D pmci_flash_bulk_write; > dev->bmc_ops.check_flash_range =3D pmci_check_flash_address; >=20 > + ret =3D max10_sensor_init_table(dev, > &n6000bmc_sensor_board_data); > + if (ret) > + return ret; > + > ret =3D pthread_mutex_init(&dev->bmc_ops.lock, NULL); > if (ret) > return ret; > diff --git a/drivers/raw/ifpga/base/opae_intel_max10.h > b/drivers/raw/ifpga/base/opae_intel_max10.h > index 0f3360e..7841df1 100644 > --- a/drivers/raw/ifpga/base/opae_intel_max10.h > +++ b/drivers/raw/ifpga/base/opae_intel_max10.h > @@ -410,6 +410,41 @@ struct opae_sensor_info { > unsigned int value_reg; > }; >=20 > +#define SENSOR_INVALID 0xdeadbeef > + > +struct max10_sensor_raw_data { > + unsigned int reg_input; > + unsigned int reg_high_warn; > + unsigned int reg_high_fatal; > + unsigned int reg_hyst; > + unsigned int reg_low_warn; > + unsigned int multiplier; > + const char *label; > +}; > + > +struct max10_sensor_data { > + const char *type; > + unsigned int number; > + const struct max10_sensor_raw_data *table; }; > + > +enum max10_sensor_types { > + sensor_temp, > + sensor_in, > + sensor_curr, > + sensor_power, > + sensor_max, > +}; > + > +#define SENSOR_TMP_NAME "Temperature" > +#define SENSOR_IN_NAME "Voltage" > +#define SENSOR_CURR_NAME "Current" > +#define SENSOR_POWER_NAME "Power" > + > +struct max10_sensor_board_data { > + const struct max10_sensor_data *tables[sensor_max]; }; > + > /* indirect access for PMCI */ > #define PMCI_INDIRECT_BASE 0x400 > #define INDIRECT_CMD_OFF (PMCI_INDIRECT_BASE + 0x0) > -- > 1.8.3.1 It looks good for me. Acked-by: Tianfei Zhang