From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68E24A0093; Mon, 20 Jun 2022 04:08:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E491740223; Mon, 20 Jun 2022 04:08:12 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id ECBCC40150 for ; Mon, 20 Jun 2022 04:08:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655690891; x=1687226891; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=quRvNUekMvjPZjyxloJJOSHAj9cPrfydWC/iXVypfCo=; b=L2WVw7I3EIBKX+voLH3t/gvP3N/B0gq0cHZ3N/BwyysEEifxNg7vL5bV 4b3TyZc9uUWyt1pUT/khnUXRhyTGwNv0WCHdAmosFUPtnB9k0tWjOj1XF LIo63gx5g1FllQSqRAUefAkvuOtulLiSf0/NtZBrxHYxSEUmt817OBsAK k6fuK9NSKg2iUfP6Vsq2gZ6ha+PQcCRfsAEEiUT58NNRFerGXw0yFsoBI GLfKoKfbQo8VvV3DkdSLYBgwQM6ALK3IzutA1qz+mknzTE0Dj72nLtoXZ Ea+KuMWgekP0epJ1xoNzm3BjoLes3DFCZEl7N+LpSyJcGBf0shz/LFFX/ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="262818925" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="262818925" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2022 19:08:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="584701532" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 19 Jun 2022 19:08:09 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 19 Jun 2022 19:08:09 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 19 Jun 2022 19:08:08 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 19 Jun 2022 19:08:08 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 19 Jun 2022 19:08:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=huUSiBGCLWfkLNg1d0Ra+HQ+Zlr5HrslT6lj++b0iELHSm6urmjRCHIFHB4shb7bAyEM6TmqnN/d933tNYDQXcybw4UbnxvnOuOoJWv/gvgfsptssu044uKmskm4JJqjxDXyLsliilku5BNRnq3Nt7QUk/JFo3l5Ut591jMx5eFjq0h8QdHucdhO5s8hmlfCjl/sDEab29oP9bT805b4Oym2Rn/1ULKe1kTnb+vN5mOYZHlBe1nSwQiaDN8K+BNChZsQL5lnecxhp1UG95jtklvAI7WdQxSLHL1bkckQ130WAWw8INHDVIezCRabWLDewVtsnnuqCjyPCXoFHaMTAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJwyrWns9KbTe8gDJ87SDJLSIAxt9438IJ5Gz5P12Oc=; b=fMFWgEeJ7Ipeoc9ulOVntvjZaRAC8ihF7PeY6pICx6LHOOSuo4JBe5FNCDNhqTmA5GJCCGVak+t0NhkNlfFqrjFMKcReY2h7ESRn26PdYOAYGVo0HOMAKPqzGsvLGsQZ2WGY4eEfKRRPSSL7Bg9nVchBkHTZMVJVle4lcDKnIjrAYowL0xbvddu35oLnDflYqApgO1aBApF3yt2M3JZBNeBkAck94lVpDxokCyW7vITc4aUlOFSzXXszs7YqkWyD2qaxDB/gZYt2ojBVyo3miTryf7jFgci7Mw+KEq0Scj7UIiRT9eyEVUZGFBxhPG77GV26aEKlqtlGVeTY4kS/JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5513.namprd11.prod.outlook.com (2603:10b6:408:102::11) by MN2PR11MB4221.namprd11.prod.outlook.com (2603:10b6:208:18d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Mon, 20 Jun 2022 02:08:05 +0000 Received: from BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::31c6:2ec8:2f71:42da]) by BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::31c6:2ec8:2f71:42da%2]) with mapi id 15.20.5353.021; Mon, 20 Jun 2022 02:08:05 +0000 From: "Ding, Xuan" To: "Hu, Jiayu" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" CC: "dev@dpdk.org" Subject: RE: [PATCH] doc: update async enqueue API usage Thread-Topic: [PATCH] doc: update async enqueue API usage Thread-Index: AQHYgi3hp1PjB/185E2t7Hzfl58/e61XidKAgAAFqpA= Date: Mon, 20 Jun 2022 02:08:05 +0000 Message-ID: References: <20220617093413.94960-1-xuan.ding@intel.com> <64663b8d8c0c4a99b34438c3ccc3ba67@intel.com> In-Reply-To: <64663b8d8c0c4a99b34438c3ccc3ba67@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ea7cd22-4ac9-4318-b20d-08da5261b699 x-ms-traffictypediagnostic: MN2PR11MB4221:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KP8PqzKSUL8x8uHAIuwYpG1f9Wh6/TBeHfAVwoY2EQvjBE+L7wumJ4b9HC0DJXKGp83fz+ixBRuK1+r1f9LlIFanlASuAd/ypKomK99sQtb9eUy1xLgfBErGNQwKumOvz2H6uYWWH6cwdmL93Z5Rll1qAPscv6gSa//WUBE0au247jhhT2KNMqO+GYmDP/bexUsI+htzo5Q+XTtHYUuP27LcmTxJjcO7E48DkoMY89m7X91yyV5ix1oZUThDj0evnzvgjrygYcJozszOsR7EZzeHfCTYsUfoGhfg9lcIDnJSWNn5S9auBGjRaT/zpikQLTc9WXzFUHHgRp2w8ei13SUovYUtZqEYJULuZmIMzz4ySqfrwSzYy+jvf2IgoRe4R8RhEn3dzvYO935f8lX5eUy8giZXuFaJ5NerbO49CPf7k0yAHF3RgeTF/UGgj2RgSEWpH8lBWMpeak/uvgcgU+DqN84c5LY+7TQgmOy7aBdeV+/KpEyyF0rgoH2jbp5r8wvsQ5WHvTk0bfHm+SvYVmcWYt+3+sQSeVmVvETO+/gx/XB5prdj8kJshmezsK1rUThFajbNz9rkAZhwmF9bBpiUh7sf+OBqLx4nzx7k0AAPLOq62hIXlKegNrJUBd6BDzcQAgLHgLq45Ns41/xLBUQpFvC5QgS9icKDjUbeJ4tM68MBqOq9D0TkMsGcoJNeH2AJQNXvoMFAlJfqnWu+KA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5513.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(9686003)(26005)(53546011)(66556008)(66476007)(66446008)(64756008)(66946007)(7696005)(86362001)(6506007)(2906002)(38070700005)(316002)(38100700002)(110136005)(8676002)(4326008)(76116006)(6636002)(71200400001)(122000001)(498600001)(33656002)(8936002)(15650500001)(5660300002)(55016003)(186003)(83380400001)(82960400001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a5zXNZ1pbm+c2IIEzCWnRSiFbl/+WQFsk+pbGlhCkYnlvNV8TYkPoKRweKLZ?= =?us-ascii?Q?io74F9aRSGPal32gVUlqR/Yh5ZJ6EEtP34Wcqlu21FTm64cMkAs6RsFsbL21?= =?us-ascii?Q?Jpce2zA60y7cSjpfn4L6hY0NNMxqT+K8332EIw+ar+wK1jUnRef+VdXvNb/X?= =?us-ascii?Q?0BM4W3jlPsfoCPjn0xEFRu8VAo2Y4xZYLf8mHFc0vECeJaJhxlAp4pJH5gDY?= =?us-ascii?Q?YR+3sk/+Xn1e2RCtJD2NlEskjCFnRmwVh2mjPjK3tzkmLTO9SlAOadhZfJ10?= =?us-ascii?Q?vBjM52cD54M+BHZFc3QvVxdFlcq71GVtkgG7wkxqazj2b7/14XEi1x64ePxK?= =?us-ascii?Q?zoeGlqVNTcqtJAhXkcxb3BkgXNOVxot3cCVtCu6MMy7jdc3v0SQCjbPR/g7v?= =?us-ascii?Q?uf2kv/ZJQLoPiTmNNE64uonIJs3nof1MH+4MawunI8rFHLV6+TsQQ2I7IoCE?= =?us-ascii?Q?6rIYv7ZarQNsxbc5gNtDdl18btgZ5eH7tdfPXHrxBPtH8QDxRw88x1vo4hXo?= =?us-ascii?Q?D4PAPFbc0+hOXY6+OHceiaIkZiPrdLlI4cE6il3Eu+SSKgcOG28xFYU/MCP5?= =?us-ascii?Q?4azgwcIlV/5emT0Veg+pwTylESRShPnjoZZ3YDP87A+rPPWYz4D9sU3QvDdU?= =?us-ascii?Q?1IbWIr7eHwbjz9s9v7UJ9ZBJ2mZBvU/7lmuDNgjALgvBFZm2itWhgrHwyyCy?= =?us-ascii?Q?cqD8FzJuNEUsrm7IrkP9Layq6SeDpPYrhBMLiH4i2WLnd5ewztn0jKM1+WXW?= =?us-ascii?Q?L+G5Bp73TFp2LlQPrzJEu8s0JxiCcaf0YZNRj9owBtKHVl6o8/Aah0kDaJpX?= =?us-ascii?Q?SpnomLJW8rRECAG9ul3TIKag5ivtpmyKejBDnvtSYfWibVZF7hGjkZT3zul8?= =?us-ascii?Q?fH/QWaUEKeDlyFBx9fYNEWxVWiPriotWGbXyc3VMSUIHBdPHp8xiamsdPOOm?= =?us-ascii?Q?jq8Gscaxj8yQXqnnRArASyoQGzz7utEooTZn+IN3fBrU3BJUfC3M8Leth0S3?= =?us-ascii?Q?WoZeQXSBGAR+8QDK4GL/hqCLZyNDCfGQAQtTbSa6o6PrdUr8etIcifPjgxKC?= =?us-ascii?Q?N2ZGsBAU1C3G00w1eZov0zORhIpc6A5vL0USw0VoMv6+R6ofGEs+yY6N1wkw?= =?us-ascii?Q?zwd8u5EFwflWvGjgxdzZRVh8QN6GQk/g7zuJPd+ZCVoelXBQAfZ5VAw7P6d6?= =?us-ascii?Q?aI+GMWvyqT0LeUA7ehhj3V8gE4EkJ3sIGFpR2dmXBT5eNA79WbPhWdJpdb9i?= =?us-ascii?Q?b/jRzGeV7N63zOesEJCJdLlIMZHx5jsErB9+UJH7mMEpNi91HSR7sBwDg9L2?= =?us-ascii?Q?ZNBvPO+rPje8m/GoWFBdinWqTdXnTQmRoRa3iEEv/CVoSRL5Ze+/4EQYM8a3?= =?us-ascii?Q?qMG0BHryIim+5l2JCC0DwLFGPnNB9xVZRFbrgDcVkPuqJAyb9/t/DGBTaaX4?= =?us-ascii?Q?r8x27XxJRctQVDGmedyBtFFyaLOn02UR5qCkdtDpKdjcm+ngUmqq6sR7VK5N?= =?us-ascii?Q?6M2ogRQvJZeaAR/AABHc/ySYsysux7ouEYklF5cTyCgvQBaTyF/wDM7ZxlQf?= =?us-ascii?Q?4rMJc9+WblrLJOHBxTstzL4sfJBwwb+JfFyWCJfXsZVZRXYW7sE6AMzZLVFo?= =?us-ascii?Q?aGlCDbhYMSv+uurBzNYbw/7BtWzP+TXRoy6bWhGWXuXhGQMggwDp3W93Pbm7?= =?us-ascii?Q?zRieW28xON5AWpZ5Apn7wQMgMtZelD+MAxk5zeKB8CmLIjVdWaXANtA7q7nE?= =?us-ascii?Q?hsDMIPRCJw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5513.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea7cd22-4ac9-4318-b20d-08da5261b699 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2022 02:08:05.4709 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Huqbuhvh1Mscg3StplEB0OPzm8FEkg3T8eru8vrx/v/G4Mq19b1+pCkzak07GKVZ6APsXrmUqcl/zCwihHKCUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4221 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Jiayu, > -----Original Message----- > From: Hu, Jiayu > Sent: Monday, June 20, 2022 9:43 AM > To: Ding, Xuan ; maxime.coquelin@redhat.com; Xia, > Chenbo > Cc: dev@dpdk.org > Subject: RE: [PATCH] doc: update async enqueue API usage >=20 > Hi Xuan, >=20 > > -----Original Message----- > > From: Ding, Xuan > > Sent: Friday, June 17, 2022 5:34 PM > > To: maxime.coquelin@redhat.com; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > > > Subject: [PATCH] doc: update async enqueue API usage > > > > From: Xuan Ding > > > > This patch updates the correct usage for async enqueue APIs. > > The rte_vhost_poll_enqueue_completed() needs to be called in time to > > avoid packet loss due to full dma ring. > > > > Signed-off-by: Xuan Ding > > --- > > doc/guides/prog_guide/vhost_lib.rst | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/doc/guides/prog_guide/vhost_lib.rst > > b/doc/guides/prog_guide/vhost_lib.rst > > index cd3f6caa9a..9cdd7da154 100644 > > --- a/doc/guides/prog_guide/vhost_lib.rst > > +++ b/doc/guides/prog_guide/vhost_lib.rst > > @@ -488,3 +488,12 @@ For PA mode, page by page mapping may exceed > > IOMMU's max capability, better to use 1G guest hugepage. > > > > For UIO driver, any VFIO related error message can be ignored. > > + > > +Async enqueue API usage > > +----------------------- >=20 > I think it's better to make it as a sub-section of "Vhost asynchronous da= ta > path". That's a good idea, I will add this section as a sub-section accordingly. >=20 > > + > > +In async enqueue path, rte_vhost_poll_enqueue_completed() needs to be > > +called in time. Otherwise, calling rte_vhost_submit_enqueue_burst() > > +all the time will cause the DMA ring to be full, which will result in > > +packet loss eventually. >=20 > There are two main reasons of calling rte_vhost_poll_enqueue_completed() > timely, IMO: > 1. notify the guest of DMA copy completed packets; 2. in case of DMA ring > size is smaller than vring size, it can avoid packet drop caused by DMA r= ing > full. Please see doc enriched in next version. Thanks, Xuan >=20 > Thanks, > Jiayu >=20 >=20 > > + > > -- > > 2.17.1 >=20