From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87E2CA00C3; Wed, 22 Jun 2022 03:13:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DEFD4069C; Wed, 22 Jun 2022 03:13:40 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9362240151 for ; Wed, 22 Jun 2022 03:13:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655860418; x=1687396418; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jwiovYSMDEkPgBzGKBuhJTqfIDEoLw6tqLnRhJPtjq4=; b=ia50NXDuW0VonED/CURb2qGmKor5afIaO5D/ANqphOhT4dFB++53jhKV ufdDQUe+NDeqVe3ET3eJNmRn/TIkasers5A261L+S+Hp+D4AFfawkhxuV kHSBKk7zFOwnGq3Chppy42EfHGh1zKIrwXMho8x79B+Woev9WvosmKQnM BBaFsXIjUsyoaAQxSo4kiOvySVgos3y68mJeqY3zLbCHxiL6jebD2WBpK XyvprVqKztP+aTQjLsirpzMABEoyl6T9ipaiKoiMQMyIAI5fljjSgibdp HuRJbw6ZskjDbVLU8yBqIT37IZSD2ualhc+q2nDoSeb1hahaqaM+5f34r g==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="344272124" X-IronPort-AV: E=Sophos;i="5.92,211,1650956400"; d="scan'208";a="344272124" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 18:13:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,211,1650956400"; d="scan'208";a="586533542" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga002.jf.intel.com with ESMTP; 21 Jun 2022 18:13:36 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 18:13:36 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 21 Jun 2022 18:13:36 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 21 Jun 2022 18:13:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a/OeoVp2ozPGokJl9srecIEXIsdc4YuMMoLhqQ8rCQBzuk1taLY3WOWYSTd/xvBCm9CA6mA6kEci9U+hZWOU50Gdx1wpHPeRwOY32GAY6aWggeOLRhVkXomTqIZXyssyY48TylZ2T+0H/WyqT8sVHVRlTkd73ORD3/N5liBUhx8bDRkDVIKudUbcJdV+6KSXAyk16QsLQwR23BZ7y5rvdNrVvQPiluO4ooI2z/uT5gm19IQ2Z6hDXeKu6UAvTVm/kY4Pfcmsa3ll03Iy5NMzkeVWlO8uQfQMD4cWpu6AKWlNB8+bhBgn4W0TsG6G+XVu0Cnfg74o4ynDkNUOjTkdPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2LJvMuxjT2OWW+ZLHhIrbnZVbA6X7t0f6Ho4056dZkk=; b=linkY2gyeTkVT5Q4nN62V0vL022qM48Py0oWkDOpaTgVwZt/hUD8SqbxKv/l5bIYkQqr8uiI/Oh2HkGlj0WFlru/hy2ZmyqY2MNrTZ6i5U3AkaoBoOg7AtVPM4xYnW2qIuaCfeE3mPkm90xXJ6zYVXPEijcCBniI0onOouBPXdiSfr3trcrehEdWgJwRNkDPE+7D8ifRGtTVk8rfri848/n187t4qbpvEtKZ68im+FXcjVJYDfR/AiDSh1C8CQ66FEgYHLqmkyEWepv1JQ9la3xzQwgWFIT6FY9xuao/jHoZigSMQU2avAeS+ZBCsVYtVor6Zg2G83gJjSV9txRwhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5513.namprd11.prod.outlook.com (2603:10b6:408:102::11) by SA2PR11MB4988.namprd11.prod.outlook.com (2603:10b6:806:f8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Wed, 22 Jun 2022 01:13:34 +0000 Received: from BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::31c6:2ec8:2f71:42da]) by BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::31c6:2ec8:2f71:42da%2]) with mapi id 15.20.5353.022; Wed, 22 Jun 2022 01:13:34 +0000 From: "Ding, Xuan" To: "Xia, Chenbo" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "Hu, Jiayu" Subject: RE: [PATCH v2] doc: update async enqueue API usage Thread-Topic: [PATCH v2] doc: update async enqueue API usage Thread-Index: AQHYhUAUHf5+haHR6EGxdQAdqGwFEa1Z2XMAgADFV4A= Date: Wed, 22 Jun 2022 01:13:34 +0000 Message-ID: References: <20220617093413.94960-1-xuan.ding@intel.com> <20220621072131.14756-1-xuan.ding@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 878b1779-3f52-4f66-f397-08da53ec6d9b x-ms-traffictypediagnostic: SA2PR11MB4988:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KWPeNygsh+3prKVIT2bmpEd3vy1hMY1Xg7YenoR5bjZFiLy/LKxiMfP8yVq8uL2Hh5Wk2bdhf5lhZUQajIj1K7Q+crf1EmCUufWjIXC83dctJQhSQHUMLPiwmhEOfaSpABMuzXLZwDVTmJNn5ViA+lg4QbHgkztFmrottwhCkIBJCMIEM4uq0sKlp6JQ7FqIkVLjQcuqPaNyNUOzyx5tA8Mdt3y9F51wE2SLfHw5H5i31D9JOw+9dMLDPvP3oZUhSfuDGjVW+h5cFdzeO/S7V1rU+LeQXeMIyGVYTO7UCfzMu7ARDmbM5hOKs0eJOVrWNVYZTXSbKh+SKlt2zTD0/9t2cHRCqJP6RFnubshaAHhRF8GQNJpW75hpDU17JJi0uS5j1XKTw2aqg5amwBJ8/iivV0PlUiHegzZhdEbh6pfSNh/tMwaNaMP2K2f4bHF31VSeOhm5q246qPHuGnJy3gsMCUs+diZxvXS56WITHTLLqFfh86+ScfuHRjv8+SJoR+OLriN0+TMOyR+4YOrBFwmXFvqtH6qgXpX7BvdoLxHmbZ2tBY/CzWXTxnNr8xMqWh5pgsznBXiVs4RUeqB+CjDKc4H96tANmBBRI3N7bWT54KVPc5oQfv+Ivb4JH4pGjg7tpbvDRuyu5tEbLitFwHT8GdNmxz5KOqjB3yVETfa4S+W1vbkcV4ubI5DLHOK4ukESLfBzGjIcW4NlRKNM+A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5513.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(39860400002)(376002)(346002)(136003)(366004)(82960400001)(122000001)(38100700002)(86362001)(83380400001)(186003)(6506007)(41300700001)(107886003)(53546011)(7696005)(66556008)(478600001)(66446008)(66946007)(76116006)(38070700005)(26005)(9686003)(71200400001)(316002)(55016003)(64756008)(66476007)(33656002)(52536014)(8676002)(8936002)(5660300002)(4326008)(2906002)(15650500001)(110136005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ikb1WNP9IosztPapH7aDYd4eDlhuZCxXQpkFtHVEJ75QGJVttTPmG01zmAVl?= =?us-ascii?Q?t4cfNY60kfl9NTvzHEZMoofQQuZWCYa+SxksJ5SKaP9EWFDchVBjDNUv68Jl?= =?us-ascii?Q?NrjCgxwD1FxNFCm85qCwDIX8Y0UIhHshsVNFw0FRnKzPVdQ0Rs8WsLGI3yOc?= =?us-ascii?Q?C9TlDSuTYMFQXD7DN4Jruvz0yGgiWAGLpl9WTFmpnaApTHkrTDR7b8Emik89?= =?us-ascii?Q?Wo4IdUC7RVc8hSmUfDpdWFyGCcTHOU2Gdx/N/GF/VEJwTA6xRARe/Y9ZTwJH?= =?us-ascii?Q?bKApPTAcJ/7n4wQrdkJ80RWJeoXbKe/vDzpWalpv67FGJtVlyGNkdxlwowDb?= =?us-ascii?Q?J1KrOfrfUn0WXtUEqx/hZSVDjcA75s78+Npg+/4pBOYNw0ay3A9GwEbmec/4?= =?us-ascii?Q?zl4p4ybOSa7kNNBsgOaA/kHUoRw24kSlO25WfA9YvaifxVs1lpKONJxNY3n1?= =?us-ascii?Q?5QhC9+vB1yM5diPjOj0BZaPczpct5kIRDQYrvmGCC6XcRdgxUk024UkL5XIx?= =?us-ascii?Q?bch0N5Nklv5pnwukuN7xST8ph+BTX0JSM3aB1eEvati37ah84rmez372vARL?= =?us-ascii?Q?UR+ADINl3/RHmVOmRbGTDAxyURWQ+Jq2ISYBFMUssXY+x9lexUsNroJfhEL/?= =?us-ascii?Q?x+BJGxhLmHeUjRIFgawQJWHnp7UQe0NUqOlfEcf9aUIU8x81pYQaDxFMPFgM?= =?us-ascii?Q?db8CcyhRfv5nxeTpDBrw13Sfd3HUYBiTjxThJHxA3DujuvXPz4q4VTxiqPXs?= =?us-ascii?Q?PeTXtONf0acahtUDiQIPAkixG5MsaZ9FomuE7Mo0Y6jKTXLrxkrIxm2djLPW?= =?us-ascii?Q?/EFNojtXKiCCnuwg3o+C+6vCnX32Ht554hxchV/8jdSdF4/CSPLC2waPXD06?= =?us-ascii?Q?4s3jCP+p/lpjlf4oFcsEj6F/cLjeqhxQSRcg2ngYCi+ImcdbWrgoj1+o+j8A?= =?us-ascii?Q?sO0wpPoUtSwp+EYAg2CoHupEq253UnZJK3AoDDa70hT8eyGPa6zbMRgeRwmD?= =?us-ascii?Q?bXtpwYriTV4TX5PVmX/nGyd7yaJFDcdaH3m+OV8nDljj6bbKvpjfYnVA0coU?= =?us-ascii?Q?5qxSroQ98OCivnoMxVkLNqWZDpAz3VCPOP/QoPRjoHuBRW/d/E85RgaOP7K8?= =?us-ascii?Q?BNPYJtTyAFzFGaMwTCpip0bIm2aVyxvlKA6BZwR+QSfRRIMHyzZe405QcuUq?= =?us-ascii?Q?MJJI192N+r2hkS2Ty8UlfdmnHJkJ3XglYBIe9ySYyNwvcv5DoqLsUEqTFByw?= =?us-ascii?Q?80dnmMWdSJyu2r5OXIBkmcNhI0heg5R47iGdAvKx1O9wcKKz9R0oFOQyNbKs?= =?us-ascii?Q?asgsf7Lkzrcni+HOhEwMkbJS6jySIus7AQO0jvSnPucK/Eh0AQQ5w9j9+c2F?= =?us-ascii?Q?fq7twv/6SRIv4UB4uVHiLbRYvn1tGleYnRY/FeDxMVNOAcv/iRGtsnbVwBOT?= =?us-ascii?Q?2tsb96vggkiOMLTM1wV6Iq6uTVesYbyX7rFTC3wRnlJbsAarSP6t0X4sTIBG?= =?us-ascii?Q?NVSPP/OEQUyiPyCDgbLnmoI2TQT1TW8+Q18q9tVza6kTKd8n3QTi1yAaqmTy?= =?us-ascii?Q?fKr6iQdkTzAkawokyiFjJVIGIoWR7D9/jpT0rqQ6DBUZHvdZXwTUyjUn8FlD?= =?us-ascii?Q?Vvlu5CJl3zJZyOSRhv03CMmkI+1HfkegOprHZT4vEaumP5rERXYW89KBaXlm?= =?us-ascii?Q?kHbNIiQspsQ3bXxG8ecSqEVHCJvuHMqm8KEq3Q/2S81jpQyAAV8y0UO5H6f7?= =?us-ascii?Q?JVYy7gMf8Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5513.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 878b1779-3f52-4f66-f397-08da53ec6d9b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2022 01:13:34.2045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WAXHOli7wslxu0FK1BAHkGddfpbc8lc53lzJG6LMtxjQYfIODh/s2nxGxnJriNJH+KK1Y3t2niGAibh/SIIZoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4988 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, > -----Original Message----- > From: Xia, Chenbo > Sent: Tuesday, June 21, 2022 9:23 PM > To: Ding, Xuan ; maxime.coquelin@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu > Subject: RE: [PATCH v2] doc: update async enqueue API usage >=20 > Hi Xuan, >=20 > > -----Original Message----- > > From: Ding, Xuan > > Sent: Tuesday, June 21, 2022 3:22 PM > > To: maxime.coquelin@redhat.com; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > > > Subject: [PATCH v2] doc: update async enqueue API usage > > > > From: Xuan Ding > > > > This patch updates the correct usage for async enqueue APIs. > > The rte_vhost_poll_enqueue_completed() needs to be called in time to > > notify the guest of completed packets and avoid packet loss. > > > > Signed-off-by: Xuan Ding > > --- > > v2: > > * refine doc and commit log > > --- > > doc/guides/prog_guide/vhost_lib.rst | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/doc/guides/prog_guide/vhost_lib.rst > > b/doc/guides/prog_guide/vhost_lib.rst > > index cd3f6caa9a..628db3fc38 100644 > > --- a/doc/guides/prog_guide/vhost_lib.rst > > +++ b/doc/guides/prog_guide/vhost_lib.rst > > @@ -480,6 +480,14 @@ the same vring with their own DMA virtual > channels. > > Besides, the number > > of DMA devices is limited. For the purpose of scaling, it's necessary > > to support sharing DMA channels among vrings. > > > > +* Async enqueue API usage > > + > > + In async enqueue path, rte_vhost_poll_enqueue_completed() needs to > > + be called in time to notify the guest of DMA copy completed packets. > > + Moreover, calling rte_vhost_submit_enqueue_burst() all the time but > > + not poll completed will cause the DMA ring to be full, which will > > + result in packet loss eventually. > > + >=20 > This subsection seems cleaner, could you also help to make 'Recommended > IOVA mode in async datapath' as a sub-section? >=20 > Another patch or not, either works for me. I will send a separate patch to move 'Recommended IOVA mode in async datapa= th' as a sub-section. Thanks, Xuan >=20 > Thanks, > Chenbo >=20 > > Recommended IOVA mode in async datapath > > --------------------------------------- > > > > -- > > 2.17.1