From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0976A0032; Thu, 14 Jul 2022 16:08:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 880C642B93; Thu, 14 Jul 2022 16:08:20 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5464A42B7E for ; Thu, 14 Jul 2022 16:08:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657807698; x=1689343698; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=z5SKwNzg+RI9iA44TbE8jsHNC7rKoxYBOJR/e6lINaI=; b=CkSx7z/AEybUjOm4n83Qa68y33QpvG93dOdSZ8Sspy+XJYi0Uno7FBAu b0RY91nMcj25DMOrgXGheFFI8A11erPlW3+2xwCHQpviVTWzUAVqOLBTG tyG09kSAs2VbLPvxvSU+dPi11tnhfdKhrHWAnvWHRjQXfZVXVsIJQhstA wLDXvu/9BeBXrfhhH0ZU0nV8eMGrTSsefv5msIU3kdR7xuzmw1id+n6WC nqalhf2LRB6BoQc/exPVAMjU7FU77GteTGHEoKj39bE5aZavan7tZDe/c Ggq4HpXwl/v4P1wwIOv4bgKn3Sk/IBN5zgq/tD8J9GZ1JaVyiHVE6v8DW A==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="286262004" X-IronPort-AV: E=Sophos;i="5.92,271,1650956400"; d="scan'208";a="286262004" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 07:07:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,271,1650956400"; d="scan'208";a="663797618" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 14 Jul 2022 07:07:54 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Jul 2022 07:07:54 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Jul 2022 07:07:53 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 14 Jul 2022 07:07:53 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 14 Jul 2022 07:07:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nmGmqHNVvNowBxNp/2PYVjYwP3hsu5ETUcoH3X++nBhCa/inEk6ntK0hFI/EmCgCd+3oaEcy09Y8w9GHVMpYQbEPb3lAIKjACepQxgOTIv51FKMnnsJcPIHo0VTSigodtwTtlyUn6TzQnRKDdPwuxILiXE0WiLUWl6rKIqw6lYdMcRwdQwY41LH2vPKArKRI0zH83E+0dBimAPVvFSbFZEYX9sBiivqxzo9JAUv0Q7wMfDHSwon4ZZ7ujZA+8jjjedK+k4dl7hZDUbqLlx4i1AEziXVcaZBfTTTtYr7xi+aHFn5OE09enbrsNP761NP7JMBmQX+ad+jIABAnOIlHXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pe6ZZHdALgNjzNo+x/nm1s5g45vzcHQazABFFT3vZVo=; b=B0GwRP2W4GL7c8hQWo51orCLQ/CB8E5LKGam4LOKLjPctSKBKOgrDTHfchtbWLvqbqf2M/WRSTGQEaLD6NzImaPs+X0j6VO0YHNzglWf1T2Ozf6J33wR1sfzxW2XlyMK5Pl7bL5q96xiQLXoYLacuaqTlthVfGLy3SWxA6maHaGJ3nmXS6IuJA1J1MI3ZLiZ95EojulEao+Ruzt0JJIZgKzSsSxIBtKDc0RETzl6spCcYV9OraV4f1MuGQZtw/l599NWY6G8Sj7Ao2Nlr/PqIEXDIe5CsHl5MRI8pne/Rd+ux2JeKafLsBwffsu1fsF3VOdt7NN1oo5Devg1JVMkaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5513.namprd11.prod.outlook.com (2603:10b6:408:102::11) by CY4PR11MB1446.namprd11.prod.outlook.com (2603:10b6:910:a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 14:07:51 +0000 Received: from BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::e0da:195a:2906:2c2]) by BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::e0da:195a:2906:2c2%9]) with mapi id 15.20.5438.013; Thu, 14 Jul 2022 14:07:51 +0000 From: "Ding, Xuan" To: Thomas Monjalon , "andrew.rybchenko@oktetlabs.ru" , "ferruh.yigit@xilinx.com" CC: "mdr@ashroe.eu" , "dev@dpdk.org" , "stephen@networkplumber.org" , "mb@smartsharesystems.com" , "dev@dpdk.org" , "Zhang, Qi Z" , "asekhar@marvell.com" , "pbhagavatula@marvell.com" , "grive@u256.net" Subject: RE: [PATCH] doc: announce header split deprecation Thread-Topic: [PATCH] doc: announce header split deprecation Thread-Index: AQHYbrEPAF9vEYkQVkaCTd0XF6IG4K18XmiAgAFEOOCAADHmAIAASG0wgAAQBYCAAAR4EA== Date: Thu, 14 Jul 2022 14:07:51 +0000 Message-ID: References: <20220523142016.44451-1-xuan.ding@intel.com> <6226385.mzcYPaeBD7@thomas> <5613126.F5Vx1aKkY9@thomas> In-Reply-To: <5613126.F5Vx1aKkY9@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 21e1a2f5-de4d-4d2d-2e17-08da65a23d7f x-ms-traffictypediagnostic: CY4PR11MB1446:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 38jNPtkg/V+bzJ+2OYFQKvnEuRbj8u1SFME83Y2GW7O7Fap4a+8U34GQIDI/sQ8j2Js+bPUIwkUAkeH3jgfznJlrL0sQK67R+rOb/TSF9bomHCb425m3gEboucGEEzgCUXdgaUbB3jWAlcn8pX30oERf2nxzWW6f2VykuDjZzi44Vvw9s+TMxXwy/SfO5/8lNInYhkXyu7E12GEopnY7Z4vK8Rh5+6XF+hQglQeOULy4rSOTcMNxRrO1eviNP1EurWy0stjiClHOO61hAOynsqRN8AjlSmb/Epx+q0Q8xtkX62F/XHzhyUXxvFtkLpvEDbesLP+YdCDcY5OcmCTiO/MrnFmTm1lLCoej5QEstyQGElEXbP4nfAk/QOqBvEY8W00EPkm+Ysl8Vx74DjfxX+YEWHigCnnUN3TqBD/H9f6shhKhK1LL3T3YynC1+7P6cET9qxaQi2KFowdOZ2q7tg/5eFBjH01VpVcpvqahnCp/6wax0xga/Mwewp/1s8LIPPqBmbuwPUxSM7Vka+tuFcdHocAgBhfdEVb2DqeN0yrDzHO35NR43Gj2+SzTiB0PG/gxvbm7MV1xfMscQ358etovh8aGjzDyoXpKjvNMQ1qdox9xNAhJmHQIDOq+efpE99D2eTqDMUluHQseb5f9MyUBK4eU0/hZMfiHDbbJEdUhH8XB5HcdItFTd5HiaNLfjr83/NMnTz2Ctfc3u6qEn8bJpE4K/FU4qJhNmaOqeSihWzXKJw3hBdvKx3XQ8SFFk1cJpT4d3SmC/xLdVOijZVr5FG+fj6QTjGmtGG7mFmgNMn5HwlkXZS/PKKPhYoq4qDF96fA1JZud8cFgwyBh4kuU90Tiu4TAtXH6w/9mvV8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5513.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(396003)(376002)(346002)(366004)(136003)(54906003)(9686003)(26005)(110136005)(6506007)(7696005)(41300700001)(71200400001)(66476007)(66946007)(53546011)(478600001)(2906002)(966005)(55016003)(64756008)(66446008)(66556008)(8676002)(4326008)(76116006)(316002)(52536014)(7416002)(8936002)(5660300002)(38100700002)(122000001)(33656002)(38070700005)(86362001)(82960400001)(83380400001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8ocvgHMo+XWAZEuwFkfS5J4hZjAguOUnPbLvGMX84PsdRye6NDSdmKlCr/Cc?= =?us-ascii?Q?Hu3EYwHSYSQlXaCb1W0V9qSVu9G/Vdn6/93zLtwZVT1Cug2pUFsqkDz/JWQ2?= =?us-ascii?Q?SHKUJEBJtaODY3A25qoCQvzEpgOIAMKp8T1XG3uEdzFZGkiQxWu6RpeKHC3D?= =?us-ascii?Q?zL55dzrwdfFPn8W+4baItUq0ZkwHZrDboEmHd8FyCqWB9C/6jCVChHuNXRJc?= =?us-ascii?Q?iZqZ4Z5GE4B4sZWjJVbfSg30tIbbxJJEst2SHNttgGxTOmAY9sOchUE6NV6o?= =?us-ascii?Q?ZusnbroDTzk+1uXHmbIyBuEYGrvYoXSWJ/AwZkcgUMcmB43Jpoa62efn4ztE?= =?us-ascii?Q?EpykVy2jrl7Cql9oTGuSpKlHKp2K8d83VTaOGM8R1P/va3MJhL3NJmjHoO2z?= =?us-ascii?Q?ZdVfMp2iOoLbWg+AMSxPERWMyXHx61S8W5CYLvRpoCinWcaNLhnajXOSuzIz?= =?us-ascii?Q?Qk68iXZ1vzrpFEDEFMyxipF9sqcOPPoPK4vU0rkV3avSb4yX3SemAX/ekn/1?= =?us-ascii?Q?GdphF3+JXK+Dr0spVqGn47pFPrCAX96sFiq+s4UlESv1qZLUayhCWjTzOoDV?= =?us-ascii?Q?YDeqcUwVfjMdshCjbunfe3AlpISrn2nu5yojLQg1r7mqtanvQ3n6Z/E8i0ZV?= =?us-ascii?Q?WYCfn6ydnF+FBPChYxcmVrCNewqDGxFJwXaszvtD9m2Lht78EFVv2bsWvnOc?= =?us-ascii?Q?02F5izirHAb56DsvLTXJG8yKf5spJ6htFivact+SKWQx3hMHRAdBvvDIK84K?= =?us-ascii?Q?Vy4JQQqtqVQYBxWlsMn6ZlrQuU27/e5m0Oih8Nf+BjfpwEQoZU7hUCO7R9Xs?= =?us-ascii?Q?j19hfnomsMsZdDvlh/TD65vY2ztLiq+GCXd0uSVt0P4D1CfPJkEm81c8461K?= =?us-ascii?Q?4ckelgc6H/KQzesLogf3uztXI6sQFTb2Ly9SnFLP2LpoO0azUl2eHZvKeNgh?= =?us-ascii?Q?220No+pKnvqrYmjQyvvAWMa9JcQK3dizNSPj2s1vSjW0ubN4OpEOVa9egJg7?= =?us-ascii?Q?1+JXv9SR+uNHin0M4xP2URXHZyQ4kOC1o9CE2mV3dloxhK/tqM09a5CYsNB6?= =?us-ascii?Q?QSbWVRP/1k4hex0pdXVylJtNV0YpmdfKpBoYRr5Pz67hoXYsgi6swaEpYG97?= =?us-ascii?Q?Rd25jGiR9xMdeJ+6mpIx8G7cvHygweMypJlAv5PQShRrmR35MN5Lth9wXifS?= =?us-ascii?Q?NChtgLy6KpdPkjujBEtQ7GullnYJKCwZyJROf4IMIYjgj/4TPnfP9XC/dV5V?= =?us-ascii?Q?zZABrJsPiUfjRl+vpl1CXZWdY6p62rzgK/LDJ8JANeIjdfz+Q0JkNAZKZ3bF?= =?us-ascii?Q?uAHOZ2CHZ3Ao97IKczSa3NHZLJWSv6VNCKcEMwCHObJEBAPsk7t3mBFp9TpP?= =?us-ascii?Q?87j253cBCWcbGrpZeSvyQRR3GQ3rV+lS5llLbBuTDMMPYWQp4W1YjcBxJP45?= =?us-ascii?Q?wgffzdxpjMkhyvN7y84wwBZYXCdGCxpQb5tAChAPMyEdhZ3CMgIsZHPEgCB2?= =?us-ascii?Q?OAle/Cq15A1ECM/9SH40Obl2U2qi4qc96JIXzcYQEOFMyxdnCKYpTkHJn2MW?= =?us-ascii?Q?D9UFvkkmSzRlXjefXl5a/pQRB/+5JwX5RIs1elVO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5513.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21e1a2f5-de4d-4d2d-2e17-08da65a23d7f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 14:07:51.6729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5DFOxTUOjtTyNn6RNESAb6mj2ZD/ZUK2zsiFXGBI0Qdn53+NYn40QNJhhNpic8GYYxeuM9XD/c7j5ht6d5TGeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1446 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, July 14, 2022 9:25 PM > To: Ding, Xuan ; andrew.rybchenko@oktetlabs.ru; > ferruh.yigit@xilinx.com > Cc: mdr@ashroe.eu; dev@dpdk.org; stephen@networkplumber.org; > mb@smartsharesystems.com; dev@dpdk.org; Zhang, Qi Z > ; asekhar@marvell.com; pbhagavatula@marvell.com; > grive@u256.net > Subject: Re: [PATCH] doc: announce header split deprecation >=20 > 14/07/2022 14:54, Ding, Xuan: > > Hi, > > > > From: Thomas Monjalon > > > 14/07/2022 07:50, Ding, Xuan: > > > > From: Thomas Monjalon > > > > > 23/05/2022 16:20, xuan.ding@intel.com: > > > > > > From: Xuan Ding > > > > > > > > > > > > RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced > some > > > time > > > > > ago > > > > > > to substitute bit-field header_split in struct rte_eth_rxmode. > > > > > > It allows to enable header split offload with the header size > > > > > > controlled using split_hdr_size in the same structure. > > > > > > > > > > > > Right now, no single PMD actually supports > > > > > > RTE_ETH_RX_OFFLOAD_HEADER_SPLIT with above definition. Many > > > > > > examples and test apps initialize the field to 0 explicitly. > > > > > > The most of drivers simply ignore split_hdr_size since the > > > > > > offload is not advertised, but > > > > > some double-check that its value is 0. > > > > > > > > > > > > So the RTE_ETH_RX_OFFLOAD_HEADER_SPLIT and split_header_size > > > field > > > > > > will be removed in DPDK 22.11. > > > > > > > > > > > > Signed-off-by: Xuan Ding > > > > > > --- > > > > > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > > > > > 1 file changed, 4 insertions(+) > > > > > > > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > > > > b/doc/guides/rel_notes/deprecation.rst > > > > > > index 4e5b23c53d..b8114f29ed 100644 > > > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > > > @@ -125,3 +125,7 @@ Deprecation Notices > > > > > > applications should be updated to use the ``dmadev`` library > instead, > > > > > > with the underlying HW-functionality being provided by the `= `ioat`` > or > > > > > > ``idxd`` dma drivers > > > > > > + > > > > > > +* ethdev: After bit-field header split was removed, the > > > > > > +``RTE_ETH_RX_OFFLOAD_HEADER_SPLIT`` > > > > > > +offload and the ``split_hdr_size`` field in structure > > > > > > +``rte_eth_rxmode`` to enable header split offload are not > > > > > > +supported in any > > > > > PMDs. They will be removed in DPDK 22.11. > > > > > > > > > > It would have been good to talk about rte_eth_rxseg_split which > > > > > is similar and configured per-queue. > > > > > > > > Thanks for your suggestion. > > > > > > > > But I'm a little confused, are you referring that I need to > > > > involve protocol > > > based buffer split? > > > > About the deprecation of header split, I haven't realized its > > > > connection to > > > rte_eth_rxseg_split. > > > > > > What??? > > > In old versions of your patch "ethdev: introduce protocol type based > > > header split" > > > you wrote: > > > " > > > A new proto field is introduced in the rte_eth_rxseg_split structure > > > reserved field to specify header protocol type. > > > With Rx offload flag RTE_ETH_RX_OFFLOAD_HEADER_SPLIT enabled and > > > protocol type configured, PMD will split the ingress packets into > > > two separate regions. > > > " > > > > It has a long history... > > It was corrected in v4 that RTE_ETH_RX_OFFLOAD_HEADER_SPLIT is used to > > enable header split offload with the header size controlled using > "split_hdr_size". > > But no single PMD actually supports RTE_ETH_RX_OFFLOAD_HEADER_SPLIT > for this purpose. > > So we finally decide to deprecate this flag. > > > > http://patchwork.dpdk.org/project/dpdk/patch/20220402104109.472078- > 2-w > > enxuanx.wu@intel.com/ > > > > In following series, I use RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT instead. It > > is for multi-segments packet split. And it still needs a "proto_hdr" fi= eld in > rte_eth_rxmode to configure split location. >=20 > I know this history because I was the one asking you to deprecate this. > But it seems you didn't get the big picture. >=20 > > > > Currently there are 2 acks, add more PMD maintainers to help > > > > review this deprecation notice for header split, thanks a lot! > > > > > > I cannot say my feeling strong enough. > > > > So IMO the deprecation for header split is not relevant with buffer spl= it. But > we can still clean the code. > > Hope it make things clearer. >=20 > They are almost the same features. > So when deprecating one, it is important to mention what remains. > If needed RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT can still be used and it is > configured per-queue, while RTE_ETH_RX_OFFLOAD_HEADER_SPLIT was > configurable per-port. Thanks for your clarification. It's clearer now. I was trying to figure out the whole history of header split, seems it is not enough. >=20 > Andrew, Ferruh, do you agree to improve this deprecation notice by adding > above information? Agree. It is better to point out the remaining per queue rx offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT for splitting packets. Please see v2 after I add more header split background. Regards, Xuan >=20