From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6294DA0C4C; Fri, 23 Jul 2021 16:01:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4B8940040; Fri, 23 Jul 2021 16:01:58 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2069.outbound.protection.outlook.com [40.107.92.69]) by mails.dpdk.org (Postfix) with ESMTP id C391B4003C; Fri, 23 Jul 2021 16:01:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQw71vS3ymruEjSoSRGPB2j29nGxfOrZj0n8eGzmlTXp8NV94yrUIoIZd5I4RuRgWax5KenF4aECWQLJzWBAtobIEv6nBTargOusj1VTTScF2Ol3Saf+QXxCxvzq3W++gTeQCoSjy8yAMp5SWLRX/OpNAMbRw6Nf4DcC5GLSTCA6HLGWrgmkqzeNGFx1I6fPoztdlkHDBIt0KfeL+qCBl4dKFTrWvOA8U83jaMHAHIV5RbSSwg6QIadcODIrArgaB3LJOOkJl1/nrvHHliqgSrn1Hm+egc0O4b7j7odbw4u7hJSHpffkPAo5Zpz/V26ocjpnQYG9LwGyt2bkB86dQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J3juI6KmXVKRSNX+RPl48IZMVdAQAzs8QNZvHH5K+RY=; b=R0hWdYFtDjUUX0UB0bj643uFKVZzW2YYqKDMANycZf+2BM7URAwTFIeL6wR97HUXiErnIUT0EHJmYImEIolH8F3kvr+GtrlS5e3soDKJctmoIBoLimvweNxvkUxuLEpGHvRPRNIDg1klL/4ruPgdCwiUkRuUsyd6UEwz9qQAgu1V6bJnwVlburM0fJibcxmsSQCvUOzSk/9+JFn+vtcIdVNUuFfUfSTXp3vNc/i4NO23t3dbFAhKzvlDGk2a2yVga00kJu7hA3oX7QDW7G9AeseUuDpVpkE9pLajH4LEOqXTfEKuYdsb/tiIQqerF4mc0RsP0q7nfKpuIQ1hFVSXjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J3juI6KmXVKRSNX+RPl48IZMVdAQAzs8QNZvHH5K+RY=; b=RUrMCwUvEa1RliB69kJd5cNdaR5loMkn0gscxIqCoer2cn+He5JzgNzlLb7Db/IsfqhgfYUlnIbRNSf5zbw+ZFAi0ysXKPsa8kk1/YR0PcNNsjwmBwyT6Hz9B20dKFKTkXef7xVByBzfHJ+F+c4B13T0fbU8rtRW+J2vbzDOPd5yyv/ge3RLnNMni8KYgTOnUjcUVcj7d/n/+2DFDDzY/I9jerezN50un3jLWdH9Jj0StPa3XEdN8sM32MRWsnMH4tjXonVjwr1XXboqtbQf4KnG0Efk2RlU8av21qoufvjfAdgAmymHsoUZaZYypFkohvwKwAkCfV3erWbc0FxCNg== Received: from BN9PR12MB5034.namprd12.prod.outlook.com (2603:10b6:408:104::17) by BN9PR12MB5130.namprd12.prod.outlook.com (2603:10b6:408:137::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.28; Fri, 23 Jul 2021 14:01:56 +0000 Received: from BN9PR12MB5034.namprd12.prod.outlook.com ([fe80::29b3:651c:7f0:4756]) by BN9PR12MB5034.namprd12.prod.outlook.com ([fe80::29b3:651c:7f0:4756%6]) with mapi id 15.20.4352.029; Fri, 23 Jul 2021 14:01:56 +0000 From: "Jiawei(Jonny) Wang" To: NBU-Contact-Thomas Monjalon , Slava Ovsiienko CC: Matan Azrad , Ori Kam , Shahaf Shuler , "dev@dpdk.org" , Raslan Darawsheh , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation Thread-Index: AQHXf8I/8ZzLaBZ6SEKIjcpYUB2B2atQkqTg Date: Fri, 23 Jul 2021 14:01:56 +0000 Message-ID: References: <20210723124338.18269-1-jiaweiw@nvidia.com> <5536161.f2duC4C3qX@thomas> In-Reply-To: <5536161.f2duC4C3qX@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e7d9dd61-93e9-4f2f-57d3-08d94de26ed3 x-ms-traffictypediagnostic: BN9PR12MB5130: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hkI2jpnVzJmcBHO1pR2dwOHQGmzoe8WkUvKmi2AewG15p+WAIPy5beJy0CIhm11IPzIBxLOb+Q4VZ8MWPOsfDbG3WpZX3ZshXIvtaNJSlWX0Pu6XV2yHsAW8yzPW5WKlHruuBR7jQNigAZ9zEIjwghCKwZkJB63eaVv45ufsuKogfkgFCXPKmvWM1dDlOQZWcgvnBf4IUQOcuK5GUIVGQJNPICt4Rssz8KoL8yPPFjCMf+6MEgjOiHSEcNUvlAV0sPcB+HpKIveU5hBAZiJk3+DfU76o2ZogYrI92a71t9oG+Rd36jJxt3MO4da/1g0h/vwM77YM2Jt3MLyHFXHNj9HD3zgBICUL+qSbeou3FieykNzB5AhQnyrZn8nRdAkww8giaLDg1eJPt9moaWyfMZx30nXznn7rM4IGySPVF6gkqgpa0l4MOSCCnnWULHRnYeMajBOrWSuSQhhZgdKHrbflOI4AZ010J7EuOOD6jfHUhp7wwoPMVSfzVkFuL8aCwt26/KxWmAxuH/Ppow8kPrvt5qpRUPddFHnclquXlo5meyyhuhfxCnYUJKsS4CsK/m+ETnOILAGZy7NBsG3M6QRqntZQqPuoqpIiXa89sdisyCdlxtNID0/j0e/5jbJveBACi4+7IZRKchRBlB1+mEdn1uK4bdQqfbs92+1GxHiYRvoNz28DQElb4bOxd5uiFB2sCm8z45Y2G0fBofu5fQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5034.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(76116006)(55016002)(6506007)(86362001)(122000001)(53546011)(66946007)(7696005)(71200400001)(66556008)(66476007)(83380400001)(4326008)(316002)(478600001)(6636002)(52536014)(8936002)(54906003)(110136005)(38100700002)(2906002)(8676002)(5660300002)(64756008)(9686003)(66446008)(26005)(33656002)(186003)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dSUMAGADbFWFgNAek+RiUfsNfAkfhCiH6lKIIOyLv9iiVNX/lDgjO+6ZOnLK?= =?us-ascii?Q?XPwz7bAoVYpmIc1G8oWCQOHbZKmnxVEj5hiyEWbwX2F/sFwN55UGASCC52cn?= =?us-ascii?Q?6JKWgKSIlcAGv3hup7Amz7mW8B3Nzjgrl8veH6gjZYMQpdUMHN9PyNAzhsCA?= =?us-ascii?Q?kxWGKMly9lnf7OMsxft/M+qAGBKUoBkCq55BESSDAGmd0ADASV9xCNmHH0dH?= =?us-ascii?Q?ewC5H2PG6wFPrUwiEpjd1iMGUXEiHBSz26VTJDDq54L/Z1nerzxfMEf2aJ+m?= =?us-ascii?Q?r0AJ8p/oL91XCnSp5QHBSik7Ucg7xd6XijsF6UbMkSPfTHabLHdlSDH1T5oV?= =?us-ascii?Q?Bi54UZxRUGNK6wgOF+sUbKXoHD8hmVagPilrV8BaNswqP5+GDFBM05IZPjRN?= =?us-ascii?Q?Q3Ugyx/j/yYTJKzvAUJeG2LCyjI8LduFER63Yl2JmLJckf6q/KVemFcdbJiH?= =?us-ascii?Q?OM+iN+9pir6vomOkGulJxLjErWdtTWMu7lbfGJiPDSLs8NsvCy5hkPpoDns7?= =?us-ascii?Q?uSdvMdXgEhZLgSo1X1sQcWCkMgWIO0AWChQVFAZGj5RxhCuD9MzPQ0FpD44a?= =?us-ascii?Q?TnFQoNT9P48ehjxyAFz0d0tL2tJfBB36Oi/3vFCQtUtHMl0yFqAXmPLFvohv?= =?us-ascii?Q?29+aDjNU+1ojWoCjD/p67XlnaRQY75y0xICiUT9sQJvYlfuNj3Xo5fSdNsXh?= =?us-ascii?Q?wnilHbVZs+B18jPL7GEH+hS8jK9ejkWFD/obcRAkr7IJyD00BEB0YU95iMYO?= =?us-ascii?Q?vUDQCMGuEkRMoA9014zkgiXZGwM3II+V7UzBg2EY8rcDwUTy118GGFEwgG1s?= =?us-ascii?Q?3E7vdJmgGHTxmUQxaK6tGFbO0AfGcvMGpgl1Na9JmVPKRuvmV3Joo7oPcQHf?= =?us-ascii?Q?UuehUr88ioqham4svPiegAQZKJuurzwBqbkatxs/LKq1cmnpyX6xxXxsf7A4?= =?us-ascii?Q?hQIWI6NsVgfw0zkTCh6myut+IhV77UJQGTwArHXwYUsfcbOuO9xCtsl7nFh9?= =?us-ascii?Q?kGWC/vsj9lcUUGT8fd2aCgqxNarG71l3/kvmY2ShNDqhURUGG4B2Ol++UayW?= =?us-ascii?Q?JARVYcQntnQ1KisVZ7Oi7JgLrD4Jeh2mAuzZD6ua5laUkEr/Lw2Ul9rerbg+?= =?us-ascii?Q?NfDmuILuWFDW25tGava/X+b4LThxMxiG7Up+bFwGNsGxdnmuZ/6ligS3e4ZW?= =?us-ascii?Q?qCSyx9TCQCANXjrYhpb5Fuw/0aEnGNPj7ETNjz8RKfUtWXcf3fGIEgdWij5M?= =?us-ascii?Q?3dJ3VWx+GbfaasCndqyx0C3sdNULeZ5oYtWdL2Dc/p0NgaREopD3L8Fz0Ete?= =?us-ascii?Q?oSc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5034.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7d9dd61-93e9-4f2f-57d3-08d94de26ed3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 14:01:56.4757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dd50FaN9ZH3s91HQZG42F+rQhdekN05Sc7UUAKcVWOMKlA2NRhM+XGWqoSoGtbpagt5hk9NQX9WKkjGw+qNHrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5130 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello,=20 > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, July 23, 2021 8:57 PM > To: Slava Ovsiienko ; Jiawei(Jonny) Wang > > Cc: Matan Azrad ; Ori Kam ; > Shahaf Shuler ; dev@dpdk.org; Raslan Darawsheh > ; stable@dpdk.org > Subject: Re: [PATCH] net/mlx5: fix mirror flow split with L3 encapsulatio= n >=20 > 23/07/2021 14:43, Jiawei Wang: > > Due to hardware limitations, the decap action can't follow the >=20 > Which decap action? Pleas be more specific. All of decap, vxlan_decap, nvgre_decap and raw_decap. Will update details. >=20 > > sample action in the same flow, to keep the original action order of > > sample and decap actions the flow was internally split by PMD, and > > decap action was moved into suffix subflow in the new table. >=20 > "the" new table? which one? " sample and decap actions the flow was internally split by PMD, " means that PMD split internally into two flows:prefix subflow with sample action = in original table; suffix subflow with decap action in the new table; >=20 > Was there an issue? Above seems to say all is fine. >=20 The issue is mentioned below that 'L3 encapsulation' case (raw_decap+raw_en= cap),=20 the previous code not consier the combination decap/encap case. And under this case flow don't need split. > > There is a specific combination of raw decap and raw encap actions to > > specify "L3 encapsulation" packet transformation - raw decap action to > > remove L2 header and raw encap to add the tunnel header. >=20 > Is this combination the problem? It was not working before this patch? > Please describe what happened. >=20 L3 encap is working without sample action or sample is working without L3 e= ncap; > > This specific L3 encapsulation is encoded as a single packet reformat > > hardware transaction and is supported by hardware after sample action > > (no hardware limitations for packet reformat). > > > > The patch checks whether the decap action is the part of "L3 > encapsulation" >=20 > I think you mean "is part of". Thanks, will fix in new version. >=20 > > and does not move the decap action into suffix subflow for the case. > > > > Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions > > with mirror") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jiawei Wang > > Acked-by: Viacheslav Ovsiienko >=20 >=20 Thanks.