From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67B6E41BA5; Thu, 2 Feb 2023 03:12:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F33E3406A2; Thu, 2 Feb 2023 03:12:43 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67]) by mails.dpdk.org (Postfix) with ESMTP id 52A4E4067B for ; Thu, 2 Feb 2023 03:12:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NYRvYt5rMZlogrRpdo0+Vit6PsOGMoU4EsE9TQCxPqNtFwzfR3vFc8Mv4L451c/jvLD0QFy64F2ZQin4d2dqxdUOXx/PuA0YTBkSdn2JtFPgNOoX8zdFLJJNvUg0bCq8R9Wjt7VvHBCDHJe9vETaIvaI/nkaFkoyLRzKIm8MG1mn9uo4WriCOUyuqASD+s1er1NNEKH1CqEf0hRRY9ZjUui1tftb/ZHmH9NhQylL7wtRCPx3CslnUK2zTeu52HfB3x00jvulBjZS7z1EZNzcpm2Eb12lxpqFUNH1bXtGMwhal3FiXyAufww5NUK0H9sfpRq+6uh3t0cJ8LUzXx2jYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cNhMDZgoAc+F9mGac/0WCXvLyWq8SjmtVXb1/t4x4tQ=; b=YdwbYeIJG9j2DLXQUMfMlhvQU+dFw6jaDKbNYqGajIWCU+QTkK1YJz4689pBUuUTKUBt6qkuhhwqRvFeblkvAeg3FVGgMjD8q8r2oJSYlq15cCNUYkDot1THgMs3993EHRezy9PMaGlOEAKln9iQ/FngJrEq3+RLGYAHOA5uFdOuGjTsqoqkzmb4IfS4bQC5+swSKo7YbeUBSjo/XPpO6BwxUngYR8ErmfGVRzKmPN2ZR5wKvJVNHk6Qps1G+27WfuINcAdZkEqeTdr8s9l00MoANsYUzlALB/QvYSQPGVbUJcWi48NJw9Zl3wp3PT+TtU+t3uj1Buxu3VVXQyubLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cNhMDZgoAc+F9mGac/0WCXvLyWq8SjmtVXb1/t4x4tQ=; b=SOFJZyarLnug46X5JAjdhoHtIX5JyALFpos+/1DIQAl73JNVEzwKG6xbJyBSYnCc+VDM6w3MOUQ3KV4+AS5Vl5I5DivGqfbxw24O6gQeyeAyFV/WO6TZFvcc6aF1VkFRTrwvmAnsUtwEFIV2kV/bf857NgxXz+giBofNpOCv4cncEKKWwaz0qlTklEM+H7+daoizuhozmdc5dNWESRoV7n/CUWzv4o+Xf1sylYp9hZapS5F62+4x4uahg7s2w5H/yghmMfTD1OL52qzV3ZG96mdNl8FJSF3NHofoibTiyseXm20tJ2MlvXyxqAYL2+yVhv9RD8pLT9FZLe2IMzeSmQ== Received: from BN9PR12MB5273.namprd12.prod.outlook.com (2603:10b6:408:11e::22) by CH3PR12MB7715.namprd12.prod.outlook.com (2603:10b6:610:151::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Thu, 2 Feb 2023 02:12:40 +0000 Received: from BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795]) by BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795%5]) with mapi id 15.20.6064.027; Thu, 2 Feb 2023 02:12:40 +0000 From: Rongwei Liu To: Stephen Hemminger CC: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Raslan Darawsheh , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: RE: [PATCH v5 2/3] ethdev: add modify IPv6 protocol field Thread-Topic: [PATCH v5 2/3] ethdev: add modify IPv6 protocol field Thread-Index: AQHZNjFaTLyi1iyzSU+UeDQqPmNUda66T7aAgACaaMA= Date: Thu, 2 Feb 2023 02:12:39 +0000 Message-ID: References: <0c02f3bb-f733-b534-86e5-0cd047d927ee@oktetlabs.ru> <20230201113511.2362188-1-rongweil@nvidia.com> <20230201113511.2362188-3-rongweil@nvidia.com> <20230201085555.3946bda3@hermes.local> In-Reply-To: <20230201085555.3946bda3@hermes.local> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR12MB5273:EE_|CH3PR12MB7715:EE_ x-ms-office365-filtering-correlation-id: 7e9ec4e2-5a92-4fbd-b84c-08db04c2f5e9 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ysFWilrdfAfekX4GxQscbmAd874OpmhYPtuRUWrIrBTivkGUVdyszKyV+EIv7uJs72ALHGJT2kV+NvXTVit5jPaMr/FIuGBKVZC1hyMc8eHM2gwW+GDPWYl72frShxxCLjW2Nu5ThCKrwyFfNrwzrqLCEFFw0/jmeNledKxLtURqELPP69TrYg1VxK+fxRI/TRv+HhHJ9t7rv/IELN/UyJzXO34kNqgA7IjWAcrOT/eMb6zhN4klrKSy+APUXsQ8r51FBxUp39KencgAAp+hsLH+4agaVEJJH2KbpWchkn/TfnAOzVs9FymfEz0b/uXmZ5xBfDRL7DYSxSZpo+jWMiDYbPihsby+114VWP+abSJMpvxSa1JpkQdlhwu/Mhk6qJDoMNgf280DbuIUUPRM5MiA/SeJW0r4gpTRlSS64cPPGZpAcZMiav+ekjLenw/tIorSBK+ua+ouCUuWbF8qq2CI8H0WvkGtwdAtfdyTACZQQa90dslxumpawL87oXzKpmFgbeL5KSKS6X/CZq4PQR+EvGvopDssOp7mrJxPegyzQXtKEqDwQD3V10qhVv/pQQ8asq0mjekyToBQF0oJUKGq04/HDuF7buPzPSgc+CNhXA7SlAOT0H9r7U3CJ0v4fZkHsp1KEoi5Sbq75KaCkrS7lcenszRPo6Q36Tso1pDBq9CQXCsC27qIU7vaqAHcV4hvM19yQecmssOOUQXLBOSXC3Cdf6l0ZntYPTNTcdU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5273.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199018)(86362001)(6506007)(66446008)(66556008)(83380400001)(54906003)(316002)(8936002)(52536014)(66476007)(8676002)(64756008)(66946007)(76116006)(4326008)(41300700001)(53546011)(71200400001)(26005)(478600001)(186003)(38070700005)(9686003)(7696005)(6916009)(55016003)(5660300002)(2906002)(38100700002)(122000001)(33656002)(87944009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uORKsvmAAbW39dsqriS5d82zHKi2I1d0zPGJndCwTxMBL1SkR+QDabyAUnzn?= =?us-ascii?Q?NlY2sVjbCzysTDusVBmD/tQD4/3Bex+NVwl7ekriIrfLl7nrumE/0OEBWACa?= =?us-ascii?Q?1/BscJFQmb/7HPdC7ke9khfg8LpcDXx82Fs8BeqopXc55NRNEy/gegeFHB5T?= =?us-ascii?Q?4Nmdq1TtAogla7TJ7+CaF8ID32pqdFUcCVcP5b5qDi0eGuKJIpacnunRyNU8?= =?us-ascii?Q?3h2xl3Od9Q5U7p4JIMMenPbrvmJw+O+S4OiLL2gou51eCeFR9kMmzssGtPn+?= =?us-ascii?Q?K9he9tbv41N5pYFVokeoTuGTJ+g962973S0YyvUZ3nRiCiMn23Bj54bfqROs?= =?us-ascii?Q?+GFmMfBtPJ55FNZJVLCq4pdsanKoLB8e/u/Okbg/oX4Go8SjByKehCPPoN37?= =?us-ascii?Q?SscShj0qU9ohLBT/M0HPIP1VAc8aef8DAXJTeqWW0bVNt/tA18P/1DTJJm83?= =?us-ascii?Q?sr0yDK7JfPRJJfPxdlt4IGxutwBN/P1XV1WcwnWRx9rg/VEmbyGfCOncQ6Sz?= =?us-ascii?Q?px8HwxkVKY/NKWSAkDSQplemQDSLJxlhZ4RIqTo7IdOEG1tKQhHgdJVYoily?= =?us-ascii?Q?IctMqmoAHkZ2rGgu1lARmFXGEvCfs3fMvNz9t3qJWdAxCzRqebvk4fsv9iSz?= =?us-ascii?Q?Al3Ew0cL0iucGbfZtznyQ+KNpFeV/E7tyIfNgIaKB+4Z5kMuLQgqJqBjeCXT?= =?us-ascii?Q?/ZkmOgV7Ct5lgBbch7HXo/qwbV7vqf5CPzfbt0+dRZiQaTtF0y68cJF56SgU?= =?us-ascii?Q?tI28rmBomFltTRneTFppK3lbwxeYhGbCvShAWcXf56tDaKBBjMqhpnusOZ9h?= =?us-ascii?Q?Gir/uRmiXWBI+Xli4WVQpFQV9gIcv0LI037nqnfiC9/ODjsoANrvUYbSDDnP?= =?us-ascii?Q?v3A0yPAoLo3RWY5x51VEwhTdau6vEgbv9EsMIZ9LiK5IYBD1Y3wyZ4JSCqFn?= =?us-ascii?Q?ltytqQL5VngZ8cDffPUtV8j95HJ6wv+Rwd7u0J45SUItQHNBtDU7ky9Lwtih?= =?us-ascii?Q?tAcy6i2Bx/NS4PgkY4wfqAzfYtNnqIjDNE5qticQVDutEIAQOI+8/M1ogZ02?= =?us-ascii?Q?a4xQ+0pSEjOVcOC2p6B1/wXnPAxLgQoTuf4ty8Jf7LsjWMxUW8/+AywE8U7I?= =?us-ascii?Q?IpDLQ2aG6jqti6OaiHnn5zLxPtZkkF66OsiWRWCUWq4qhiCoLU9QdycbPd7E?= =?us-ascii?Q?kFbJspxzHX2y4UGVT8XIh45VS8y+SiC5VrgVNRRYHJElN1aCWuYEvyJ03CoG?= =?us-ascii?Q?UUNwku/Tad1sIQ9M0Vky8KXU+e3xW1v7Ym4+quZqlisowOhi1v5DTlzbmBHN?= =?us-ascii?Q?nR6r5KZh5mD94zKMO2QUk6wQrn6i7OktNxulnZGrAdSV8hlv1BZULn+v6PDe?= =?us-ascii?Q?SktA9HutjJ894oAQFDguMStVORNE8yzkvLzuthS8cgFU2b+FWHAT/U7oYacm?= =?us-ascii?Q?NUSeUpanL7jJfKf/60kvdjuQC5u1lLdAsoZ4fHD80A39H7eoCvNljzWiAD+2?= =?us-ascii?Q?NLdc4kGSSCVKOAcW7a7ygch3HdH9sDCRbw+GAh3bQKTskVQg9NINTL4NPfbB?= =?us-ascii?Q?GrC+Ux79LpBK0AN0lrc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5273.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e9ec4e2-5a92-4fbd-b84c-08db04c2f5e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 02:12:39.8802 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GoxQLMn3RkX+4dNa6Tph2hh+SJNKzhTOl3gni9F30h2FPUt4M9P5Eb2m5i1tbXMVSeytfdwR2d7vsBVKvslMvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7715 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen BR Rongwei > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, February 2, 2023 00:56 > To: Rongwei Liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Raslan Darawsheh > ; Aman Singh ; Yuying > Zhang ; Ferruh Yigit ; > Andrew Rybchenko > Subject: Re: [PATCH v5 2/3] ethdev: add modify IPv6 protocol field >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Wed, 1 Feb 2023 13:35:10 +0200 > Rongwei Liu wrote: >=20 > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 7a8516829c..b8156ebca2 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -811,7 +811,8 @@ static const char *const modify_field_ids[] =3D { > > "udp_port_src", "udp_port_dst", > > "vxlan_vni", "geneve_vni", "gtp_teid", > > "tag", "mark", "meta", "pointer", "value", > > - "ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", "meter_color", NULL > > + "ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", "meter_color", > > + "ipv6_proto", NULL > > }; > > >=20 > Would it be better to keep the table in alphabetical order here? There are two arrays related to modify_filed resources: one for enumeration= definition and the other is string for testpmd cli. The sequence is strictly same. " keep the table in alphabetical " needs to change both the array and make = sure the new comer is the same index. IMO, current approach is more friendly for new coming fields.