RE: [PATCH v1] net/mlx5: add test for hot upgrade

[Rongwei Liu <rongweil@nvidia.com>]

Hi Thomas:

BR
Rongwei

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, June 27, 2023 04:23
> To: Rongwei Liu <rongweil@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>
> Cc: dev@dpdk.org; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Maayan Kashani
> <mkashani@nvidia.com>
> Subject: Re: [PATCH v1] net/mlx5: add test for hot upgrade
> 
> External email: Use caution opening links or attachments
> 
> 
> 16/05/2023 07:41, Rongwei Liu:
> > This patch adds testpmd app a runtime function to test the hot upgrade
> > API.
> >
> >     testpmd> mlx5 set flow_engine <0|1> (flag)
> > 0 stands for active mode while 1 for standby mode.
> >
> > Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > ---
> > --- a/doc/guides/nics/mlx5.rst
> > +++ b/doc/guides/nics/mlx5.rst
> > @@ -2057,3 +2057,13 @@ where:
> >  * ``sw_queue_id``: queue index in range [64536, 65535].
> >    This range is the highest 1000 numbers.
> >  * ``hw_queue_id``: queue index given by HW in queue creation.
> > +
> > +Set Flow Engine Mode
> > +^^^^^^^^^^^^^^^^^^^^
> 
> The title is made as a sub-section of "port map external Rx queue", which
> looks wrong.
>
Will change the "^^^^" to "~~~~", totally in parallel with " port map external Rx queue "
> > +
> > +Set the flow engine to active(0) or standby(1) mode with specific flags::
> > +   testpmd> mlx5 set flow_engine <0|1> (flags)
> 
> It should be said it is for testing live migration.
> 
Sure.
> Also the flags are not described. Should we pass an integer?
> 
There is information to describe mode, like active(0)/standby(1).
Or we can change to this style:  "mlx5 set flow_engine <active|standby> [<flag>]"
> > +
> > +This command works for software steering only.
> > +Default FDB jump should be disabled if switchdev is enabled.
> > +The mode will propagate to all the probed ports.
> 
> For the reasons above, I prefer not pulling this patch in the main branch.
> 
This command line is a good starting point to play with mlx5 live migration feature.
Keeping it is user-friendly per my view.