From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80717A0547; Wed, 21 Apr 2021 04:49:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B98E418AA; Wed, 21 Apr 2021 04:49:22 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2049.outbound.protection.outlook.com [40.107.244.49]) by mails.dpdk.org (Postfix) with ESMTP id 4666241385 for ; Wed, 21 Apr 2021 04:49:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANw2lwCaDmy82+W90S9JJaUQLm9qjuKeuoQ/yROueRs+QIdxiQL5Hbl6JnlU2gC1d01gCPmkSKlDGxiMOn9UIE7xZySSwOS2rGl9sCmLaIsQ8BkpV8SyYLqBtHfoeexLFY4qVekrf9NEF7AdGErfO8E5YkHCEEvL7oH/1QALXBaQQ9BR4RLitnfN1KlJfwwwtHPNcadS4ZI0zsT7/TER2kwElbx1MmPtPWZ/v8t88brhM4B8K26QIsB+bNcqTUni524eZJ+35rcBsLN+Ro4SoabRqY4XFNhEB92wHPDu0pHCe8nJF/8Y+zF0+UGOk69r038vKBPTrQGjGITyAhAYaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+vZSOo+rt1sBAjtaxXL11HUd8C5MzJMb0slWdSH35HM=; b=cVnnAcpMtMhZpoMsZVn5VSdnBZVkwl5XsRb/vY15jKLpYUwoX1Br06cldA+gsTbpmd/FMnxE7xQLi6zIEIsbVW9Luvt1ibWaVMtAyNi7QpURGqg1sOErGdM6slZiXCKxL6zE/HK+N4QbEsYjrVYMi+6w5wdS17hWwmJuzHGqa3mMFn48sfHD+bd++FlnpfjXHv5BBJxAFhLBgJo8BgY7KU8Iz8/88ZOAYPFbR5gz2u57aLervEPZhQIu/m0D28Uvc38/kTUD6qO7ORArePoE7QXdjcFq9Rer95yAqNOHvjUTXgjA1cMlpq42CV2UuQDwpOQzVqDhm6fy/m6AeJ89eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+vZSOo+rt1sBAjtaxXL11HUd8C5MzJMb0slWdSH35HM=; b=S+Redjuxjmb8fNkFwyiwPtf8Ay/i5nDUC7jWH/q++DoM9Uk8Lm5Ci/XGnApLeu5pY1R941CaWj4fOIFb6xtx3hH3YQwJl35aZnk4RQ+EL2u89G9HV9mlMEqiZZ+oUJMc0JXov9bfxaEXAP7D9HwElvogtxn5cfZx5bLNTj3sb252Bltu5K4NalGnoVrzEabxyq1p1tF3LCB6m9ZrkQ0huJnGqPtGfDMtM2PRSAB59TI5b245bQ7WBQvLGPQ5WSknMyu4KwyC9cPeE4xmreJVB2Qs4LsGqW0UXubi9ls5ULnFVg1vo2kH8zvvXUBTQjpDAi4FOecagm5SMX5xYn+SFg== Received: from BN9PR12MB5307.namprd12.prod.outlook.com (2603:10b6:408:104::5) by BN9PR12MB5291.namprd12.prod.outlook.com (2603:10b6:408:104::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Wed, 21 Apr 2021 02:49:16 +0000 Received: from BN9PR12MB5307.namprd12.prod.outlook.com ([fe80::61c8:2c29:916f:ecda]) by BN9PR12MB5307.namprd12.prod.outlook.com ([fe80::61c8:2c29:916f:ecda%7]) with mapi id 15.20.4065.020; Wed, 21 Apr 2021 02:49:16 +0000 From: Li Zhang To: Stephen Hemminger CC: "dekelp@nvidia.com" , Ori Kam , Slava Ovsiienko , Matan Azrad , Shahaf Shuler , "lironh@marvell.com" , "jasvinder.singh@intel.com" , NBU-Contact-Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Cristian Dumitrescu , "dev@dpdk.org" , Raslan Darawsheh , Roni Bar Yanai Thread-Topic: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API Thread-Index: AQHXG9TeivIzG46Y1UC/iFvR5sE4ZKq95TSAgACSfdA= Date: Wed, 21 Apr 2021 02:49:16 +0000 Message-ID: References: <20210318085815.804896-1-lizh@nvidia.com> <20210420105605.12429b88@hermes.local> In-Reply-To: <20210420105605.12429b88@hermes.local> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [139.227.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78240143-8dd9-4ba4-0c36-08d904700e1a x-ms-traffictypediagnostic: BN9PR12MB5291: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wWJ86p8saerP+1xPSUr61tP/AgMX0RUuFPTCON0kornWdBxBi6JwHQRwy1yHMRQBPle0WliRJP1+da9M/Rm1y/Q3XGbAXPkm2Ke76NwLev1zGl/darDBu7oE/Z7mb+XczDK8vtitvSyQNJxj3Fcpp32lzDkFelrfKRFjB2kDHwvgIyQTWyE/t+UnWAPvunkJTn4i39ux70XnKjZC2lx0xVGpd/6bI6MnzU0OwvinrgHh1vg2wuP3VNd3ko4ebunav5v8H3ADgObV7VmFDFcdAipSC97MHy/R5B15Hko9rCUx12wJRlGkBWKiu9rZ/r+KzZpmaY+YL7besOoMoCBZ9i1ucDWcEJFzItxSHD0juhOr2OkvVm1azsLx0Vhq+ZmJ4k7/eqd2Z4pjJv7MvJFG1Ew3uxJ4YUGOl8TqKtdeQmfd9X/VFtzW/4QFZMHM6smsmDH2Raz64zsfaO9oDyu+YQSmImxh8Eo1VcIzCaVvLp92UmC8sdf2W+sEjSrQROGDP5k9zHzptph2XoXuudnkiRq3GEZ7ft78cJgixG+L5wXZMNIAdVDQwJKnJ+JkEzs2/8+rVrXdNIKC6WrQRKbfqKF6i6B9CC3NBrtMv8vPN3rFVXHJnbjVjM+ODAR6j4Rb9OSChlwr7BVUqRb7WwItvzYqWUgzdsjLt4GXi2dEqP1SPvimfBvW+GfOy2PbT2u+ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5307.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(4326008)(5660300002)(86362001)(76116006)(186003)(53546011)(26005)(8676002)(54906003)(7696005)(66556008)(107886003)(66946007)(38100700002)(52536014)(6916009)(8936002)(66446008)(64756008)(83380400001)(6506007)(33656002)(66476007)(9686003)(966005)(478600001)(316002)(71200400001)(2906002)(55016002)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?wknNtwePzZCgHIx4vkt+3GRJBUzEFKHHoQK73MwUF/ktMdtS32pP0bIJDr9q?= =?us-ascii?Q?vhNIdAW2RMKLJ+y2il5PRY4tuc7JE5VGnIvBIchiUmZSzQoRmp03FH20fHcR?= =?us-ascii?Q?ORbNnF4GKz2ci16APSrxasi4sKqfp5TIzH0pSq62AJee8+bRsal0K8zGn1w4?= =?us-ascii?Q?DHKu3IbxuT8YepBykoV+mJUr0PE401Rp19+zVcTp4bJmu6xdAbzLLIXp7HWf?= =?us-ascii?Q?egbidoNx8pniOcq5NnTfBUAT1njLSHzkP2bmWF2dtRhBzjkZfOZiVK5n1crW?= =?us-ascii?Q?BN8qiU2h40au8DSO74FfZgKSji9CsKcHm+4rWnE/je01naItSQ89ZJBpIBjG?= =?us-ascii?Q?pLAuE17vGWTzBKkKiDJDqaVM5HOQMq6oEBSzEYIQA3aPoLxD6USKuHudnPSB?= =?us-ascii?Q?qqfzGak0rB0D80l5XWu4uGHK56DPA5BGQGOYObfLCgJDiZ7hysg99eq2eZmT?= =?us-ascii?Q?+146o3NCrgGOTKOAB9AVpjWF3e5d5b3bAKzDicwfzu6KiWF37957ULV2I8rS?= =?us-ascii?Q?WI3bPWLFT8Qp0q4gvcx0AbkDN1YosuqNKry9eW7wr9O3PWqOaomCfl6+OqFY?= =?us-ascii?Q?rMpHQnm0I0GSQU94K+tLsdCrftM+ohDjVi5mUZnykJCbyZhczHTyb3st9O5S?= =?us-ascii?Q?0qlOCxy2J6GFH2jtlb11AuzNXrrdCAuwuf9+qZlwenNVRcg5FwWLhZu8ekKD?= =?us-ascii?Q?xO+hAjc0356UbzICURyanHBv36XGP7w5xWTCW4nuZd1427xQ0NrDBeU2jb7p?= =?us-ascii?Q?fu4y28V2wXH3GaGd3NSftpetNslYcwnw1cDWzQkYLfQ8MYipwaY+w2OaR+H0?= =?us-ascii?Q?sr03n644EIwv5ezITnxgrnWxoqLswKllsqaF24xl+dFzNpCVkE9rkSy6kehq?= =?us-ascii?Q?a4SSQB6Pg4xaLWSAFdb8X3fYSre1RAsy7RH8VOhlzwAEBPWmtjU1hFW7tokG?= =?us-ascii?Q?Dzw39CMKn8aRmPzZeBRiPKQOXu5TL9Y3mZWo1r8YLrr3eBTFZkFhdoSly+7p?= =?us-ascii?Q?xcnxyu26LgY+HX9lPNqxIRJuMn0imCgB9vaolkExmuAz1ImOW5uYnBDrLbTe?= =?us-ascii?Q?BOiuEEfbZKLthILgyHvXm8Hv155d4h1YljUO+/y71l3T8S/ILpXvbD/Ey4ud?= =?us-ascii?Q?lJOGXhsAfLlKZHUjFis9s0ReMhwW3vTSqYrXpr3qIokifZMvD2fQuzonBobj?= =?us-ascii?Q?NIeh21Hxx8+BQ4VqUV21CW2zttORHhZlxUQkAhwEpVtbjbn4A4rwRxk9zyXz?= =?us-ascii?Q?kGLaPODf7tswmeKEhEtDK0K63KtlBqkut2sHnYCMmnCkBvnc3U62ClF2au63?= =?us-ascii?Q?eSiXNoA2A1NATJmTXf7Wgemy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5307.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78240143-8dd9-4ba4-0c36-08d904700e1a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 02:49:16.7359 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 47KhBWn0lYfkRyj6HHT/IHew/qeI2bE4ZGYPAYwMMX+WyaKsfy93k8LtQ3+UiCwx X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5291 Subject: Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen Thanks your comments. We already change it in the following series and please take a look: https://patchwork.dpdk.org/project/dpdk/list/?series=3D16524 + /** + * Color the packet to reflect the meter color result. + * Set the meter color in the mbuf to the selected color. + * + * See struct rte_flow_action_meter_color. + */ + RTE_FLOW_ACTION_TYPE_METER_COLOR, Regards, Li Zhang > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, April 21, 2021 1:56 AM > To: Li Zhang > Cc: dekelp@nvidia.com; Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler ; lironh@marvell.com; > jasvinder.singh@intel.com; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko ; Cristian Dumitrescu > ; dev@dpdk.org; Raslan Darawsheh > ; Roni Bar Yanai > Subject: Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter > policy API >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Thu, 18 Mar 2021 10:58:14 +0200 > Li Zhang wrote: >=20 > > + > > + /** > > + * Color the packet to reflect the meter color result. > > + * > > + * See struct rte_flow_action_color. > > + */ > > + RTE_FLOW_ACTION_TYPE_COlOR, >=20 > Why the odd use of lower case here? Shouldn't it be > RTE_FLOW_ACTION_TYPE_COLOR