From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 739A9A0C47; Thu, 7 Oct 2021 13:01:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 406C041137; Thu, 7 Oct 2021 13:01:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 80C41407FF for <dev@dpdk.org>; Thu, 7 Oct 2021 13:01:29 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1977TRcf012033; Thu, 7 Oct 2021 04:01:28 -0700 Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2045.outbound.protection.outlook.com [104.47.51.45]) by mx0a-0016f401.pphosted.com with ESMTP id 3bhvj2rtfd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Oct 2021 04:01:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IO1Ct4eBMWweVk95hf6hLjXsnaDoV51Oc6MkhX1x5qS9jqAmqS29O5vx41GHtZAZiNIPctFUIzog2xaBkQyGMdGGg5kmJoDXMJvEzYb8k4Qg8kkS5ox/YhloxdKLrMkvSva4BlME0p41dl44JrRiHjqrdY9hpWageNA8daKvqiAo2z96KunVO+JSUsP0MjuOKnXqSMdEah+Jk/0zQSUTdg+PbGdUcEfC+8S6Y8XwG3dkrudXc55pNrQBfK+B5BM+aVzoCrovupbrvTrJpxNTQB+nC5f6b7N/eP2l8bnYIxa5O9AKVOyvBrEgKsSrxcg3BtNeGqTForfXoroLh+8i7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MzAAmqoDcDNHra2kFIv6HsPNhwVTbaiuvIxm+MoTB/g=; b=IGFuzfHYKJNkNChI7JlZPfTbFUT37hGhU/vswcIFeYt6dSUQP3I3P0DsXoqK7uclKf01LmlcLvcHVkfQNaIUqIB9ZNBi6ivf3LKgsbNTbiP32uV+9xPgHP23hCynRVmlnikGNeTK9HXqAf2pn4DeSS8tnN7cuXd8OzF/+f8DC+QRdeo+coFNIeZm6FL5Xk3Dlh6kCseswRIPSHFo4ucTsYMduzJnfICp+Wr8z+DtfI9jrmM/5EWn5Sq89Ga/ONvJvj1E+m1po+lDMHZ41HCx/+shoXKhB+yiUzDF0lMXISOXWNzv2atrps1ZEr7fEhuIr4Y/X0kKAvBuFhLoDRIxOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MzAAmqoDcDNHra2kFIv6HsPNhwVTbaiuvIxm+MoTB/g=; b=ALHSuDd/NSpTVqLEq3WUk+YAZUxxzEzczK5ZVCq4eVzyS73Rzh/Io0VJLFYt2NXvdrFGTJDpdI4C0W4A2vQP0TpvsO+5wR9+e9GTjM+pZLU5wZfoiHlwcLRy3zYxCsJildwnXIdns6IicyCvA6gT0hteCsw5wU7qq3zv6lwVETA= Received: from BN9PR18MB4204.namprd18.prod.outlook.com (2603:10b6:408:119::18) by BN6PR18MB1154.namprd18.prod.outlook.com (2603:10b6:404:6a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct 2021 11:01:26 +0000 Received: from BN9PR18MB4204.namprd18.prod.outlook.com ([fe80::29f4:8e3d:264f:26b1]) by BN9PR18MB4204.namprd18.prod.outlook.com ([fe80::29f4:8e3d:264f:26b1%8]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021 11:01:26 +0000 From: Harman Kalra <hkalra@marvell.com> To: Bruce Richardson <bruce.richardson@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "ciara.power@intel.com" <ciara.power@intel.com>, Anatoly Burakov <anatoly.burakov@intel.com> Thread-Topic: [EXT] Re: [PATCH] eal: add telemetry callbacks for memory info Thread-Index: AQHXqhea/uKCAEY/v0SOSSuB1EqyL6utHBkAgAEaULCACfFcAIAPWLRA Date: Thu, 7 Oct 2021 11:01:26 +0000 Message-ID: <BN9PR18MB42044F484DEEF8ED76C9A80BC5B19@BN9PR18MB4204.namprd18.prod.outlook.com> References: <20210915095336.105635-1-hkalra@marvell.com> <YUivSrhg+LKpyhON@bricha3-MOBL.ger.corp.intel.com> <BL1PR18MB41977071EED7C2BE82307ACBC5A19@BL1PR18MB4197.namprd18.prod.outlook.com> <YVHzUIc/WAqKO6br@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <YVHzUIc/WAqKO6br@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37c0dacb-f5a6-4c7b-86d3-08d98981cefc x-ms-traffictypediagnostic: BN6PR18MB1154: x-microsoft-antispam-prvs: <BN6PR18MB1154FECF4087092684695DDEC5B19@BN6PR18MB1154.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tMChSez37Dzi9j+HiyV3PTpS0yCqBxKTCTDPTP4+XSdZkNt4qg2Mihcjq6/jCCk/jd+mfWdr2x0nlI1y8vXgQwvnehz5MhqvpYADPVbm5ayxrBPU0khSkNXt0xl3p+As6wSDo69wwZH3Lkp1m4KK2I6LFe4vwdYoUEVzZkFZzQrItUg/rjC4k8PrsNL7wKO97nfjrdgI6f++9lKbIIdRi1Wrz2wZEX2g1gfGfRylhXo+3jYfXXLtuHENSSwJr0tPi9J9eg/TgMQulIHiSfuoHl33HWWbmvvIFWzGOAgKniDiBAu9xS3Ny0rGhbHgDn7CRqCZvBXuH7esXQLENDpzR0oBLS7meyCQlEcvLk3+9J+4xIdIgrtoHOGy5mm2LNkWMQLV9IUFdWV0UrZPZMxH7178+9GlvAAlRMwnNwwRyPsyLWYAEN03TJ0hxnzju+37haGYfHhWNm86GgiFgdh+IA94J51npGE1Wydn+uek/Yi1fOjg/jbGm0gqXdm9dh8eevqO00Fh+bLKPOM1Tesz/EyOssn7XViIbnxUNlH0wlKPV0xaIQllOS1dgnpcYr4YgjzZvocjDQrsGfuIkgkPmywucARVwfsmAbPNVZoqrkqMjy4jCD9ZMb31ClD2nXv9I82ecGcEK6gRPvaN+bt/z7cUn3H03dQ20p8v5bbwWBlgPNtPrQFlg/5Z8R+nTYqULE596eVN1+PJp2ka74NKIw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR18MB4204.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6916009)(71200400001)(4326008)(508600001)(86362001)(9686003)(55016002)(66446008)(76116006)(83380400001)(66476007)(64756008)(66556008)(7696005)(66946007)(54906003)(316002)(52536014)(5660300002)(38100700002)(53546011)(122000001)(6506007)(26005)(186003)(38070700005)(33656002)(8936002)(8676002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KfiAYacQgpznLqWovFs2IxGNRXNfmIyyFW4rxtnouNwcu0o6ioNEmiIRRm9Q?= =?us-ascii?Q?LPRV+5XyqteVtL/mzKoCaEpgAi8jc/XpZbbKuYV8XvdB20bUOjfdaKbxR3gq?= =?us-ascii?Q?2q/aPkkLhLDmIiV+UApYKv2+eAXX4N9i0aerajKPXRBCfv7KfPNbpLG0zfb4?= =?us-ascii?Q?Q8Wx65m875/m+a/i22m6AgZTG+aILQYWswNOgrbeJweys2vnPbLY33tz7ear?= =?us-ascii?Q?hGQ3SUWUeKSFixpZaf+KUg1kdoO2ddDbtW75M2yajQHPfDDQ4NqbczpccIfF?= =?us-ascii?Q?oT06eAg6HA4pWdfrWPczETQXJNwI+oX2VVd+AeEMXScoVvSETrAQt/7NwcJ3?= =?us-ascii?Q?RQ6AXlaough2FsOmg2UEFs+sXZr9YetSxPDEgnLqVTuWcpT0B0sY4RWqE+zt?= =?us-ascii?Q?UEHxGX2lBUxOZ48u6Tr92cUrjQLnLFxskEWCpYOZ21XqudU8tIhmT8em/QPP?= =?us-ascii?Q?Y47JFNl9WyNAyZUq1UXQxjavifUXA88viHqlQ973bzMxvrM5qq04LOSmsFg7?= =?us-ascii?Q?IZ+CCT92Scvgx1lz4KFxjOyz7TuyfB+8TqsKryikJ4yEu5vcfiVSXvPH34VC?= =?us-ascii?Q?n0CZUOppzGjJq6YrovRwJcXn382ZtvFCa8HEB6eFBQofPR8apq5pztM6QB+W?= =?us-ascii?Q?4GsYyMhpA0Y+Zll2RFKLsNtVhRhKce5Mmn6Uehrfo713y/HllkIlhNObT0la?= =?us-ascii?Q?c8/kLPMGIEXQ5BS3hOX2GLymgvy0SUAQwdQ/eaEzdL6K537xJs0CEqrDJbZw?= =?us-ascii?Q?Kelbn+IqgkW3S5qIa9Gy20P0Qh1mS2w3uQPQmvC7Vp9xyiPbIzzB5XfZTjTi?= =?us-ascii?Q?VkUVCP3l24jWnqALtZTVg/q7B2kA0mEHYDW496YkrIJT+MWRSXiQBjgSgdwi?= =?us-ascii?Q?pvvO5YTzsznLt8N0n+X4FWwPkzuSE9mOzW9sGDItBFlAJGOQQsE4pk6+wlnP?= =?us-ascii?Q?Rj49HeRZ9ac25n+YA8HxMWxevMl9AmTL4F1tSRaFsWhMqjq3lrCAXn2iwwV3?= =?us-ascii?Q?I/cOh79dRytDZHnr0zhXeqSBjv3XibxBhLpp+f6Y3OljHIoNLespII6NM98I?= =?us-ascii?Q?JQkH24j62kPvUWt5wx1/hV4mmq377x+W+IhcyDagRIqJkI+83oRFFOn2tu6o?= =?us-ascii?Q?d/4JZK9tUtg8bqy0aAZLOCnXOYEO1LHd+vGiYUlq3qehQywIp5Y2lQxieDwO?= =?us-ascii?Q?YU8SKKebK41E8MHY+oRfoPocmrR1BU68AdWnoDiSFwHPI2la+NDbs7ArmWTd?= =?us-ascii?Q?PWU4Jwb7okoVev375ShZRGO3iLXGS+KtDIAEKi5jvkTJ5OU9jtVu2eEstMFs?= =?us-ascii?Q?lRK0+zXKbr3JJpwP0TVWZIud?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4204.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37c0dacb-f5a6-4c7b-86d3-08d98981cefc X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 11:01:26.4440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p9fX69EaoyOL0X8SI+aTlzxjDciVFnqTFf8zKSwpU/BDLF9lyhy3SX5hJTIyYmLbA2p3kXaBQBx8QsSJF+yxSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1154 X-Proofpoint-ORIG-GUID: UsGzR9rM4USYHZ7Dte3vFtCiXUUPkIaC X-Proofpoint-GUID: UsGzR9rM4USYHZ7Dte3vFtCiXUUPkIaC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-07_01,2021-10-07_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] eal: add telemetry callbacks for memory info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Bruce Richardson <bruce.richardson@intel.com> > Sent: Monday, September 27, 2021 10:08 PM > To: Harman Kalra <hkalra@marvell.com> > Cc: dev@dpdk.org; ciara.power@intel.com; Anatoly Burakov > <anatoly.burakov@intel.com> > Subject: Re: [EXT] Re: [PATCH] eal: add telemetry callbacks for memory in= fo >=20 > On Tue, Sep 21, 2021 at 09:05:29AM +0000, Harman Kalra wrote: > > > > > -----Original Message----- > > > From: Bruce Richardson <bruce.richardson@intel.com> > > > Sent: Monday, September 20, 2021 9:27 PM > > > To: Harman Kalra <hkalra@marvell.com> > > > Cc: dev@dpdk.org; ciara.power@intel.com; Anatoly Burakov > > > <anatoly.burakov@intel.com> > > > Subject: [EXT] Re: [PATCH] eal: add telemetry callbacks for memory > > > info > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > > Signed-off-by: Harman Kalra <hkalra@marvell.com> > > > > --- > > > > > > For this info, why not just send the data out as telemetry data > > > rather than writing files on the filesystem containing it? If the > > > info is too large to dump it all in a single go, a shortened form > > > could be sent via some form of list call, and additional calls could > > > be used to provide more detail on specific items in the list. > > > > > > Also, this seems more a debugging operation than a telemetry one, > > > though I don't have a strong objection to the info being exported as > > > telemetry directly (just not via filesystem). > > > > > > Regards, > > > /Bruce > > > > > > Hi Bruce, > > > > Thanks for reviewing the patch. > > I have implemented these telemetry commands as a wrapper which uses > > existing malloc/memzone debug APIs to collect the debug information, > these debug APIs are implemented in the way that they accept a file > pointer/stdout. > > to get the information. > > > > As a solution either I should make changes to these debug APIs to > > accept a buffer also? Or other way could be get the info dumped into a = file, > and inside telemetry command parse and convert the info into json format > and send it. > > But its lot of debug information so will require multiple iterations > > as you suggested. But on client (peer) side one will have to again conv= ert > json to retrieve the info. > > > > Just for my understanding, what drawback do you see in dumping the > > information to a file? Because on peer side It is very convenient to re= ad the > information from dumped file and use it. > > >=20 > Hi >=20 > The drawback is largely a philosophical one in that what you add here are > not read-operations for telemetry, but rather commands which cause the > application to make changes on the running system - i.e. write out files. > It's certainly something we could look to do, but I think we should only = do so > with some careful thought, rather than just adding it ad-hoc. Hi Bruce I have started working on this, and will come up with proper implementation= as suggested. Thanks Harman >=20 > Regards, > /Bruce