DPDK patches and discussions
 help / color / mirror / Atom feed
From: Harman Kalra <hkalra@marvell.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts: implement get set APIs
Date: Mon, 4 Oct 2021 08:51:36 +0000	[thread overview]
Message-ID: <BN9PR18MB4204C9BC5E452A4EF3A9B946C5AE9@BN9PR18MB4204.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yAK2mxHuuL93hGRh+ejXqLNvDtc9sixyQv_GkLan=CAg@mail.gmail.com>

Hi David,

Thanks for the review.
Please see my comments inline.


> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, September 28, 2021 9:17 PM
> To: Harman Kalra <hkalra@marvell.com>
> Cc: dev <dev@dpdk.org>; Ray Kinsella <mdr@ashroe.eu>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement get
> set APIs
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Fri, Sep 3, 2021 at 2:42 PM Harman Kalra <hkalra@marvell.com> wrote:
> >
> > Implementing get set APIs for interrupt handle fields.
> > To make any change to the interrupt handle fields, one should make use
> > of these APIs.
> 

> Some global comments.
> 
> - Please merge API prototype (from patch 1) and actual implementation in a
> single patch.

<HK>  Sure, will do.

> - rte_intr_handle_ seems a rather long prefix, does it really matter to have
> the _handle part?

<HK> Will fix the API names.


> - what part of this API needs to be exported to applications? Let's hide as
> much as we can with __rte_internal.

<HK> I will make all the APIs (new and some old) not used in test suite and example app as __rte_internal. 

> 
> 
> >
> > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> > Acked-by: Ray Kinsella <mdr@ashroe.eu>
> > ---
> >  lib/eal/common/eal_common_interrupts.c | 506
> +++++++++++++++++++++++++
> >  lib/eal/common/meson.build             |   2 +
> >  lib/eal/include/rte_eal_interrupts.h   |   6 +-
> >  lib/eal/version.map                    |  30 ++
> >  4 files changed, 543 insertions(+), 1 deletion(-)  create mode 100644
> > lib/eal/common/eal_common_interrupts.c
> >
> > diff --git a/lib/eal/common/eal_common_interrupts.c
> > b/lib/eal/common/eal_common_interrupts.c
> > new file mode 100644
> > index 0000000000..2e4fed96f0
> > --- /dev/null
> > +++ b/lib/eal/common/eal_common_interrupts.c
> > @@ -0,0 +1,506 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(C) 2021 Marvell.
> > + */
> > +
> > +#include <stdlib.h>
> > +#include <string.h>
> > +
> > +#include <rte_errno.h>
> > +#include <rte_log.h>
> > +#include <rte_malloc.h>
> > +
> > +#include <rte_interrupts.h>
> > +
> > +
> > +struct rte_intr_handle *rte_intr_handle_instance_alloc(int size,
> > +                                                      bool
> > +from_hugepage) {
> > +       struct rte_intr_handle *intr_handle;
> > +       int i;
> > +
> > +       if (from_hugepage)
> > +               intr_handle = rte_zmalloc(NULL,
> > +                                         size * sizeof(struct rte_intr_handle),
> > +                                         0);
> > +       else
> > +               intr_handle = calloc(1, size * sizeof(struct
> > + rte_intr_handle));
> 
> We can call DPDK allocator in all cases.
> That would avoid headaches on why multiprocess does not work in some
> rarely tested cases.
> Wdyt?
> 
> Plus "from_hugepage" is misleading, you could be in --no-huge mode,
> rte_zmalloc still works.

<HK> In mellanox 5 driver interrupt handle instance is freed in destructor 
" mlx5_pmd_interrupt_handler_uninstall()" while DPDK memory allocators
are already cleaned up in "rte_eal_cleanup". Hence I allocated interrupt
instances for such cases from normal heap. There could be other such cases
so I think its ok to keep this support.

Regarding name, I will change " from_hugepage" to "dpdk_allocator".

As per suggestion from Dmitry, I will replace bool arg with a flag variable, to 
support more such configurations in future.


> 
> 
> > +       if (!intr_handle) {
> > +               RTE_LOG(ERR, EAL, "Fail to allocate intr_handle\n");
> > +               rte_errno = ENOMEM;
> > +               return NULL;
> > +       }
> > +
> > +       for (i = 0; i < size; i++) {
> > +               intr_handle[i].nb_intr = RTE_MAX_RXTX_INTR_VEC_ID;
> > +               intr_handle[i].alloc_from_hugepage = from_hugepage;
> > +       }
> > +
> > +       return intr_handle;
> > +}
> > +
> > +struct rte_intr_handle *rte_intr_handle_instance_index_get(
> > +                               struct rte_intr_handle *intr_handle,
> > +int index) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOMEM;
> > +               return NULL;
> > +       }
> > +
> > +       return &intr_handle[index];
> > +}
> > +
> > +int rte_intr_handle_instance_index_set(struct rte_intr_handle
> *intr_handle,
> > +                                      const struct rte_intr_handle *src,
> > +                                      int index) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (src == NULL) {
> > +               RTE_LOG(ERR, EAL, "Source interrupt instance unallocated\n");
> > +               rte_errno = EINVAL;
> > +               goto fail;
> > +       }
> > +
> > +       if (index < 0) {
> > +               RTE_LOG(ERR, EAL, "Index cany be negative");
> > +               rte_errno = EINVAL;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle[index].fd = src->fd;
> > +       intr_handle[index].vfio_dev_fd = src->vfio_dev_fd;
> > +       intr_handle[index].type = src->type;
> > +       intr_handle[index].max_intr = src->max_intr;
> > +       intr_handle[index].nb_efd = src->nb_efd;
> > +       intr_handle[index].efd_counter_size = src->efd_counter_size;
> > +
> > +       memcpy(intr_handle[index].efds, src->efds, src->nb_intr);
> > +       memcpy(intr_handle[index].elist, src->elist, src->nb_intr);
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +void rte_intr_handle_instance_free(struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +       }
> > +
> > +       if (intr_handle->alloc_from_hugepage)
> > +               rte_free(intr_handle);
> > +       else
> > +               free(intr_handle);
> > +}
> > +
> > +int rte_intr_handle_fd_set(struct rte_intr_handle *intr_handle, int
> > +fd) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->fd = fd;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_fd_get(const struct rte_intr_handle *intr_handle)
> > +{
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->fd;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_type_set(struct rte_intr_handle *intr_handle,
> > +                            enum rte_intr_handle_type type) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->type = type;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +enum rte_intr_handle_type rte_intr_handle_type_get(
> > +                               const struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               return RTE_INTR_HANDLE_UNKNOWN;
> > +       }
> > +
> > +       return intr_handle->type;
> > +}
> > +
> > +int rte_intr_handle_dev_fd_set(struct rte_intr_handle *intr_handle,
> > +int fd) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->vfio_dev_fd = fd;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_dev_fd_get(const struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->vfio_dev_fd;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_max_intr_set(struct rte_intr_handle *intr_handle,
> > +                                int max_intr) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (max_intr > intr_handle->nb_intr) {
> > +               RTE_LOG(ERR, EAL, "Max_intr=%d greater than
> PLT_MAX_RXTX_INTR_VEC_ID=%d",
> > +                       max_intr, intr_handle->nb_intr);
> > +               rte_errno = ERANGE;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->max_intr = max_intr;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_max_intr_get(const struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->max_intr;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_nb_efd_set(struct rte_intr_handle *intr_handle,
> > +                                int nb_efd) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->nb_efd = nb_efd;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_nb_efd_get(const struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->nb_efd;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_nb_intr_get(const struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->nb_intr;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_efd_counter_size_set(struct rte_intr_handle
> *intr_handle,
> > +                                uint8_t efd_counter_size) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->efd_counter_size = efd_counter_size;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_efd_counter_size_get(
> > +                               const struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->efd_counter_size;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int *rte_intr_handle_efds_base(struct rte_intr_handle *intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->efds;
> > +fail:
> > +       return NULL;
> > +}
> 
> We don't need this new accessor.
> It leaks the internal representation to the API caller.
> If the internal representation is later changed, we would have to maintain
> this array thing.
> 
> The only user is drivers/raw/ifpga/ifpga_rawdev.c.
> This driver can build an array itself, and call
> rte_intr_handle_efds_index_get() as much as needed.

<HK> Yes, it’s a leak I will remove these base APIs and fix the ifpga_rawdev.c driver.

> 
> 
> 
> > +
> > +int rte_intr_handle_efds_index_get(const struct rte_intr_handle
> *intr_handle,
> > +                                  int index) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (index >= intr_handle->nb_intr) {
> > +               RTE_LOG(ERR, EAL, "Invalid size %d, max limit %d\n", index,
> > +                       intr_handle->nb_intr);
> > +               rte_errno = EINVAL;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->efds[index];
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_efds_index_set(struct rte_intr_handle *intr_handle,
> > +                                  int index, int fd) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (index >= intr_handle->nb_intr) {
> > +               RTE_LOG(ERR, EAL, "Invalid size %d, max limit %d\n", index,
> > +                       intr_handle->nb_intr);
> > +               rte_errno = ERANGE;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->efds[index] = fd;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +struct rte_epoll_event *rte_intr_handle_elist_index_get(
> > +                               struct rte_intr_handle *intr_handle,
> > +int index) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (index >= intr_handle->nb_intr) {
> > +               RTE_LOG(ERR, EAL, "Invalid size %d, max limit %d\n", index,
> > +                       intr_handle->nb_intr);
> > +               rte_errno = ERANGE;
> > +               goto fail;
> > +       }
> > +
> > +       return &intr_handle->elist[index];
> > +fail:
> > +       return NULL;
> > +}
> > +
> > +int rte_intr_handle_elist_index_set(struct rte_intr_handle *intr_handle,
> > +                                  int index, struct rte_epoll_event
> > +elist) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (index >= intr_handle->nb_intr) {
> > +               RTE_LOG(ERR, EAL, "Invalid size %d, max limit %d\n", index,
> > +                       intr_handle->nb_intr);
> > +               rte_errno = ERANGE;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->elist[index] = elist;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int *rte_intr_handle_vec_list_base(const struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               return NULL;
> > +       }
> > +
> > +       return intr_handle->intr_vec;
> > +}
> 
> 
> rte_intr_handle_vec_list_base leaks an internal representation too.
> 
> Afaics with the whole series applied, it is always paired with a
> rte_intr_handle_vec_list_alloc or rte_intr_handle_vec_list_free.
> rte_intr_handle_vec_list_alloc could do this check itself.
> And rte_intr_handle_vec_list_free should already be fine, since it sets
> intr_vec to NULL.


<HK> Yes, base API not required.

Thanks
Harman
> 
> 
> 
> 
> 
> > +
> > +int rte_intr_handle_vec_list_alloc(struct rte_intr_handle *intr_handle,
> > +                                  const char *name, int size) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       /* Vector list already allocated */
> > +       if (intr_handle->intr_vec)
> > +               return 0;
> > +
> > +       if (size > intr_handle->nb_intr) {
> > +               RTE_LOG(ERR, EAL, "Invalid size %d, max limit %d\n", size,
> > +                      intr_handle->nb_intr);
> > +               rte_errno = ERANGE;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->intr_vec = rte_zmalloc(name, size * sizeof(int), 0);
> > +       if (!intr_handle->intr_vec) {
> > +               RTE_LOG(ERR, EAL, "Failed to allocate %d intr_vec", size);
> > +                       rte_errno = ENOMEM;
> > +                       goto fail;
> > +       }
> > +
> > +       intr_handle->vec_list_size = size;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_vec_list_index_get(
> > +                       const struct rte_intr_handle *intr_handle, int
> > +index) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (!intr_handle->intr_vec) {
> > +               RTE_LOG(ERR, EAL, "Intr vector list not allocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (index > intr_handle->vec_list_size) {
> > +               RTE_LOG(ERR, EAL, "Index %d greater than vec list size %d\n",
> > +                       index, intr_handle->vec_list_size);
> > +               rte_errno = ERANGE;
> > +               goto fail;
> > +       }
> > +
> > +       return intr_handle->intr_vec[index];
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +int rte_intr_handle_vec_list_index_set(struct rte_intr_handle
> *intr_handle,
> > +                                  int index, int vec) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (!intr_handle->intr_vec) {
> > +               RTE_LOG(ERR, EAL, "Intr vector list not allocated\n");
> > +               rte_errno = ENOTSUP;
> > +               goto fail;
> > +       }
> > +
> > +       if (index > intr_handle->vec_list_size) {
> > +               RTE_LOG(ERR, EAL, "Index %d greater than vec list size %d\n",
> > +                       index, intr_handle->vec_list_size);
> > +               rte_errno = ERANGE;
> > +               goto fail;
> > +       }
> > +
> > +       intr_handle->intr_vec[index] = vec;
> > +
> > +       return 0;
> > +fail:
> > +       return rte_errno;
> > +}
> > +
> > +void rte_intr_handle_vec_list_free(struct rte_intr_handle
> > +*intr_handle) {
> > +       if (intr_handle == NULL) {
> > +               RTE_LOG(ERR, EAL, "Interrupt instance unallocated\n");
> > +               rte_errno = ENOTSUP;
> > +       }
> > +
> > +       rte_free(intr_handle->intr_vec);
> > +       intr_handle->intr_vec = NULL;
> > +}
> > diff --git a/lib/eal/common/meson.build b/lib/eal/common/meson.build
> > index edfca77779..47f2977539 100644
> > --- a/lib/eal/common/meson.build
> > +++ b/lib/eal/common/meson.build
> > @@ -17,6 +17,7 @@ if is_windows
> >              'eal_common_errno.c',
> >              'eal_common_fbarray.c',
> >              'eal_common_hexdump.c',
> > +            'eal_common_interrupts.c',
> >              'eal_common_launch.c',
> >              'eal_common_lcore.c',
> >              'eal_common_log.c',
> > @@ -53,6 +54,7 @@ sources += files(
> >          'eal_common_fbarray.c',
> >          'eal_common_hexdump.c',
> >          'eal_common_hypervisor.c',
> > +        'eal_common_interrupts.c',
> >          'eal_common_launch.c',
> >          'eal_common_lcore.c',
> >          'eal_common_log.c',
> > diff --git a/lib/eal/include/rte_eal_interrupts.h
> > b/lib/eal/include/rte_eal_interrupts.h
> > index 68ca3a042d..216aece61b 100644
> > --- a/lib/eal/include/rte_eal_interrupts.h
> > +++ b/lib/eal/include/rte_eal_interrupts.h
> > @@ -55,13 +55,17 @@ struct rte_intr_handle {
> >                 };
> >                 void *handle; /**< device driver handle (Windows) */
> >         };
> > +       bool alloc_from_hugepage;
> >         enum rte_intr_handle_type type;  /**< handle type */
> >         uint32_t max_intr;             /**< max interrupt requested */
> >         uint32_t nb_efd;               /**< number of available efd(event fd) */
> >         uint8_t efd_counter_size;      /**< size of efd counter, used for vdev */
> > +       uint16_t nb_intr;
> > +               /**< Max vector count, default
> > + RTE_MAX_RXTX_INTR_VEC_ID */
> >         int efds[RTE_MAX_RXTX_INTR_VEC_ID];  /**< intr vectors/efds
> mapping */
> >         struct rte_epoll_event elist[RTE_MAX_RXTX_INTR_VEC_ID];
> > -                                      /**< intr vector epoll event */
> > +                                               /**< intr vector epoll event */
> > +       uint16_t vec_list_size;
> >         int *intr_vec;                 /**< intr vector number array */
> >  };
> >
> > diff --git a/lib/eal/version.map b/lib/eal/version.map index
> > beeb986adc..56108d0998 100644
> > --- a/lib/eal/version.map
> > +++ b/lib/eal/version.map
> > @@ -426,6 +426,36 @@ EXPERIMENTAL {
> >
> >         # added in 21.08
> >         rte_power_monitor_multi; # WINDOWS_NO_EXPORT
> > +
> > +       # added in 21.11
> > +       rte_intr_handle_fd_set;
> > +       rte_intr_handle_fd_get;
> > +       rte_intr_handle_dev_fd_set;
> > +       rte_intr_handle_dev_fd_get;
> > +       rte_intr_handle_type_set;
> > +       rte_intr_handle_type_get;
> > +       rte_intr_handle_instance_alloc;
> > +       rte_intr_handle_instance_index_get;
> > +       rte_intr_handle_instance_free;
> > +       rte_intr_handle_instance_index_set;
> > +       rte_intr_handle_event_list_update;
> > +       rte_intr_handle_max_intr_set;
> > +       rte_intr_handle_max_intr_get;
> > +       rte_intr_handle_nb_efd_set;
> > +       rte_intr_handle_nb_efd_get;
> > +       rte_intr_handle_nb_intr_get;
> > +       rte_intr_handle_efds_index_set;
> > +       rte_intr_handle_efds_index_get;
> > +       rte_intr_handle_efds_base;
> > +       rte_intr_handle_elist_index_set;
> > +       rte_intr_handle_elist_index_get;
> > +       rte_intr_handle_efd_counter_size_set;
> > +       rte_intr_handle_efd_counter_size_get;
> > +       rte_intr_handle_vec_list_alloc;
> > +       rte_intr_handle_vec_list_index_set;
> > +       rte_intr_handle_vec_list_index_get;
> > +       rte_intr_handle_vec_list_free;
> > +       rte_intr_handle_vec_list_base;
> >  };
> >
> >  INTERNAL {
> > --
> > 2.18.0
> >
> 
> 
> --
> David Marchand


  reply	other threads:[~2021-10-04  8:51 UTC|newest]

Thread overview: 152+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 14:57 [dpdk-dev] [RFC 0/7] make rte_intr_handle internal Harman Kalra
2021-08-26 14:57 ` [dpdk-dev] [RFC 1/7] eal: interrupt handle API prototypes Harman Kalra
2021-08-31 15:52   ` Kinsella, Ray
2021-08-26 14:57 ` [dpdk-dev] [RFC 2/7] eal/interrupts: implement get set APIs Harman Kalra
2021-08-31 15:53   ` Kinsella, Ray
2021-08-26 14:57 ` [dpdk-dev] [RFC 3/7] eal/interrupts: avoid direct access to interrupt handle Harman Kalra
2021-08-26 14:57 ` [dpdk-dev] [RFC 4/7] test/interrupt: apply get set interrupt handle APIs Harman Kalra
2021-08-26 14:57 ` [dpdk-dev] [RFC 5/7] drivers: remove direct access to interrupt handle fields Harman Kalra
2021-08-26 14:57 ` [dpdk-dev] [RFC 6/7] eal/interrupts: make interrupt handle structure opaque Harman Kalra
2021-08-26 14:57 ` [dpdk-dev] [RFC 7/7] eal/alarm: introduce alarm fini routine Harman Kalra
2021-09-03 12:40 ` [dpdk-dev] [PATCH v1 0/7] make rte_intr_handle internal Harman Kalra
2021-09-03 12:40   ` [dpdk-dev] [PATCH v1 1/7] eal: interrupt handle API prototypes Harman Kalra
2021-09-03 12:40   ` [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement get set APIs Harman Kalra
2021-09-28 15:46     ` David Marchand
2021-10-04  8:51       ` Harman Kalra [this message]
2021-10-04  9:57         ` [dpdk-dev] [EXT] " David Marchand
2021-10-12 15:22           ` Thomas Monjalon
2021-10-13 17:54             ` Harman Kalra
2021-10-13 17:57               ` Harman Kalra
2021-10-13 18:52                 ` Thomas Monjalon
2021-10-14  8:22                   ` Thomas Monjalon
2021-10-14  9:31                     ` Harman Kalra
2021-10-14  9:37                       ` David Marchand
2021-10-14  9:41                       ` Thomas Monjalon
2021-10-14 10:31                         ` Harman Kalra
2021-10-14 10:35                           ` Thomas Monjalon
2021-10-14 10:44                             ` Harman Kalra
2021-10-14 12:04                               ` Thomas Monjalon
2021-10-14 10:25                       ` Dmitry Kozlyuk
2021-10-03 18:05     ` [dpdk-dev] " Dmitry Kozlyuk
2021-10-04 10:37       ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-04 11:18         ` Dmitry Kozlyuk
2021-10-04 14:03           ` Harman Kalra
2021-09-03 12:40   ` [dpdk-dev] [PATCH v1 3/7] eal/interrupts: avoid direct access to interrupt handle Harman Kalra
2021-09-03 12:40   ` [dpdk-dev] [PATCH v1 4/7] test/interrupt: apply get set interrupt handle APIs Harman Kalra
2021-09-03 12:41   ` [dpdk-dev] [PATCH v1 5/7] drivers: remove direct access to interrupt handle fields Harman Kalra
2021-09-03 12:41   ` [dpdk-dev] [PATCH v1 6/7] eal/interrupts: make interrupt handle structure opaque Harman Kalra
2021-10-03 18:16     ` Dmitry Kozlyuk
2021-10-04 14:09       ` [dpdk-dev] [EXT] " Harman Kalra
2021-09-03 12:41   ` [dpdk-dev] [PATCH v1 7/7] eal/alarm: introduce alarm fini routine Harman Kalra
2021-09-15 14:13   ` [dpdk-dev] [PATCH v1 0/7] make rte_intr_handle internal Harman Kalra
2021-09-23  8:20   ` David Marchand
2021-10-05 12:14 ` [dpdk-dev] [PATCH v2 0/6] " Harman Kalra
2021-10-05 12:14   ` [dpdk-dev] [PATCH v2 1/6] eal/interrupts: implement get set APIs Harman Kalra
2021-10-14  0:58     ` Dmitry Kozlyuk
2021-10-14 17:15       ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-14 17:53         ` Dmitry Kozlyuk
2021-10-15  7:53           ` Thomas Monjalon
2021-10-14  7:31     ` [dpdk-dev] " David Marchand
2021-10-05 12:14   ` [dpdk-dev] [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle Harman Kalra
2021-10-14  0:59     ` Dmitry Kozlyuk
2021-10-14 17:31       ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-14 17:53         ` Dmitry Kozlyuk
2021-10-05 12:14   ` [dpdk-dev] [PATCH v2 3/6] test/interrupt: apply get set interrupt handle APIs Harman Kalra
2021-10-05 12:15   ` [dpdk-dev] [PATCH v2 4/6] drivers: remove direct access to interrupt handle Harman Kalra
2021-10-05 12:15   ` [dpdk-dev] [PATCH v2 5/6] eal/interrupts: make interrupt handle structure opaque Harman Kalra
2021-10-05 12:15   ` [dpdk-dev] [PATCH v2 6/6] eal/alarm: introduce alarm fini routine Harman Kalra
2021-10-05 16:07 ` [dpdk-dev] [RFC 0/7] make rte_intr_handle internal Stephen Hemminger
2021-10-07 10:57   ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 " Harman Kalra
2021-10-18 19:37   ` [dpdk-dev] [PATCH v3 1/7] malloc: introduce malloc is ready API Harman Kalra
2021-10-19 15:53     ` Thomas Monjalon
2021-10-18 19:37   ` [dpdk-dev] [PATCH v3 2/7] eal/interrupts: implement get set APIs Harman Kalra
2021-10-18 22:07     ` Dmitry Kozlyuk
2021-10-19  8:50       ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-19 18:44         ` Harman Kalra
2021-10-18 22:56     ` [dpdk-dev] " Stephen Hemminger
2021-10-19  8:32       ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-19 15:58         ` Thomas Monjalon
2021-10-20 15:30         ` Dmitry Kozlyuk
2021-10-21  9:16           ` Harman Kalra
2021-10-21 12:33             ` Dmitry Kozlyuk
2021-10-21 13:32               ` David Marchand
2021-10-21 16:05                 ` Harman Kalra
2021-10-18 19:37   ` [dpdk-dev] [PATCH v3 3/7] eal/interrupts: avoid direct access to interrupt handle Harman Kalra
2021-10-18 19:37   ` [dpdk-dev] [PATCH v3 4/7] test/interrupt: apply get set interrupt handle APIs Harman Kalra
2021-10-18 19:37   ` [dpdk-dev] [PATCH v3 5/7] drivers: remove direct access to interrupt handle Harman Kalra
2021-10-18 19:37   ` [dpdk-dev] [PATCH v3 6/7] eal/interrupts: make interrupt handle structure opaque Harman Kalra
2021-10-18 19:37   ` [dpdk-dev] [PATCH v3 7/7] eal/alarm: introduce alarm fini routine Harman Kalra
2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 0/7] make rte_intr_handle internal Harman Kalra
2021-10-19 18:35   ` [dpdk-dev] [PATCH v4 1/7] malloc: introduce malloc is ready API Harman Kalra
2021-10-19 22:01     ` Dmitry Kozlyuk
2021-10-19 22:04       ` Dmitry Kozlyuk
2021-10-20  9:01         ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-19 18:35   ` [dpdk-dev] [PATCH v4 2/7] eal/interrupts: implement get set APIs Harman Kalra
2021-10-20  6:14     ` David Marchand
2021-10-20 14:29       ` Dmitry Kozlyuk
2021-10-20 16:15     ` Dmitry Kozlyuk
2021-10-19 18:35   ` [dpdk-dev] [PATCH v4 3/7] eal/interrupts: avoid direct access to interrupt handle Harman Kalra
2021-10-19 21:27     ` Dmitry Kozlyuk
2021-10-20  9:25       ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-20  9:52         ` Dmitry Kozlyuk
2021-10-19 18:35   ` [dpdk-dev] [PATCH v4 4/7] test/interrupt: apply get set interrupt handle APIs Harman Kalra
2021-10-19 18:35   ` [dpdk-dev] [PATCH v4 5/7] drivers: remove direct access to interrupt handle Harman Kalra
2021-10-20  1:57     ` Hyong Youb Kim (hyonkim)
2021-10-19 18:35   ` [dpdk-dev] [PATCH v4 6/7] eal/interrupts: make interrupt handle structure opaque Harman Kalra
2021-10-19 18:35   ` [dpdk-dev] [PATCH v4 7/7] eal/alarm: introduce alarm fini routine Harman Kalra
2021-10-19 21:39     ` Dmitry Kozlyuk
2021-10-22 20:49 ` [dpdk-dev] [PATCH v5 0/6] make rte_intr_handle internal Harman Kalra
2021-10-22 20:49   ` [dpdk-dev] [PATCH v5 1/6] eal/interrupts: implement get set APIs Harman Kalra
2021-10-22 23:33     ` Dmitry Kozlyuk
2021-10-22 20:49   ` [dpdk-dev] [PATCH v5 2/6] eal/interrupts: avoid direct access to interrupt handle Harman Kalra
2021-10-22 23:33     ` Dmitry Kozlyuk
2021-10-22 20:49   ` [dpdk-dev] [PATCH v5 3/6] test/interrupt: apply get set interrupt handle APIs Harman Kalra
2021-10-22 20:49   ` [dpdk-dev] [PATCH v5 4/6] drivers: remove direct access to interrupt handle Harman Kalra
2021-10-22 20:49   ` [dpdk-dev] [PATCH v5 5/6] eal/interrupts: make interrupt handle structure opaque Harman Kalra
2021-10-22 23:33     ` Dmitry Kozlyuk
2021-10-22 20:49   ` [dpdk-dev] [PATCH v5 6/6] eal/alarm: introduce alarm fini routine Harman Kalra
2021-10-22 23:33     ` Dmitry Kozlyuk
2021-10-22 23:37       ` Dmitry Kozlyuk
2021-10-24 20:04   ` [dpdk-dev] [PATCH v6 0/9] make rte_intr_handle internal David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 1/9] interrupts: add allocator and accessors David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 2/9] interrupts: remove direct access to interrupt handle David Marchand
2021-10-25  6:57       ` David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 3/9] test/interrupts: " David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 4/9] alarm: " David Marchand
2021-10-25 10:49       ` Dmitry Kozlyuk
2021-10-25 11:09         ` David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 5/9] lib: " David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 6/9] drivers: " David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 7/9] interrupts: make interrupt handle structure opaque David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 8/9] interrupts: rename device specific file descriptor David Marchand
2021-10-24 20:04     ` [dpdk-dev] [PATCH v6 9/9] interrupts: extend event list David Marchand
2021-10-25 10:49       ` Dmitry Kozlyuk
2021-10-25 11:11         ` David Marchand
2021-10-25 13:04   ` [dpdk-dev] [PATCH v5 0/6] make rte_intr_handle internal Raslan Darawsheh
2021-10-25 13:09     ` David Marchand
2021-10-25 13:34   ` [dpdk-dev] [PATCH v7 0/9] " David Marchand
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 1/9] interrupts: add allocator and accessors David Marchand
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 2/9] interrupts: remove direct access to interrupt handle David Marchand
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 3/9] test/interrupts: " David Marchand
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 4/9] alarm: " David Marchand
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 5/9] lib: " David Marchand
2021-10-28  6:14       ` Jiang, YuX
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 6/9] drivers: " David Marchand
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 7/9] interrupts: make interrupt handle structure opaque David Marchand
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 8/9] interrupts: rename device specific file descriptor David Marchand
2021-10-25 13:34     ` [dpdk-dev] [PATCH v7 9/9] interrupts: extend event list David Marchand
2021-10-25 14:27   ` [dpdk-dev] [PATCH v8 0/9] make rte_intr_handle internal David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 1/9] interrupts: add allocator and accessors David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 2/9] interrupts: remove direct access to interrupt handle David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 3/9] test/interrupts: " David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 4/9] alarm: " David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 5/9] lib: " David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 6/9] drivers: " David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 7/9] interrupts: make interrupt handle structure opaque David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 8/9] interrupts: rename device specific file descriptor David Marchand
2021-10-25 14:27     ` [dpdk-dev] [PATCH v8 9/9] interrupts: extend event list David Marchand
2021-10-28 15:58       ` Ji, Kai
2021-10-28 17:16         ` David Marchand
2021-10-25 14:32     ` [dpdk-dev] [PATCH v8 0/9] make rte_intr_handle internal Raslan Darawsheh
2021-10-25 19:24     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR18MB4204C9BC5E452A4EF3A9B946C5AE9@BN9PR18MB4204.namprd18.prod.outlook.com \
    --to=hkalra@marvell.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).