From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xuelin.shi@freescale.com>
Received: from na01-bl2-obe.outbound.protection.outlook.com
 (mail-bl2on0103.outbound.protection.outlook.com [65.55.169.103])
 by dpdk.org (Postfix) with ESMTP id 053319ABD
 for <dev@dpdk.org>; Tue, 24 Mar 2015 08:29:22 +0100 (CET)
Received: from BY1PR03MB1339.namprd03.prod.outlook.com (25.162.109.21) by
 BY1PR03MB1340.namprd03.prod.outlook.com (25.162.109.22) with Microsoft SMTP
 Server (TLS) id 15.1.118.21; Tue, 24 Mar 2015 07:29:20 +0000
Received: from BY1PR03MB1339.namprd03.prod.outlook.com ([25.162.109.21]) by
 BY1PR03MB1339.namprd03.prod.outlook.com ([25.162.109.21]) with mapi id
 15.01.0118.021; Tue, 24 Mar 2015 07:29:20 +0000
From: Xuelin Shi <xuelin.shi@freescale.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [PATCH] ixgbe: fix data access on big endian cpu
Thread-Index: AQHQZXIFXlhtH+DgoEiW82+/C/T/kp0rPR9A
Date: Tue, 24 Mar 2015 07:29:20 +0000
Message-ID: <BY1PR03MB13398AFEDC4D9B1099BF71F7860A0@BY1PR03MB1339.namprd03.prod.outlook.com>
References: <1425371224-15631-1-git-send-email-xuelin.shi@freescale.com>
 <3986979.AOFPnzYeq1@xps13>
In-Reply-To: <3986979.AOFPnzYeq1@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [199.59.231.64]
authentication-results: 6wind.com; dkim=none (message not signed)
 header.d=none;
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1340;
x-microsoft-antispam-prvs: <BY1PR03MB134063DEA4B58F8DE56E985D860A0@BY1PR03MB1340.namprd03.prod.outlook.com>
x-forefront-antispam-report: BMV:1; SFV:NSPM;
 SFS:(10019020)(6009001)(377424004)(13464003)(164054003)(51704005)(19580395003)(76576001)(92566002)(102836002)(2950100001)(66066001)(15975445007)(46102003)(19580405001)(2900100001)(77156002)(62966003)(122556002)(74316001)(76176999)(50986999)(54356999)(2656002)(33656002)(110136001)(106116001)(40100003)(87936001)(86362001)(99286002);
 DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR03MB1340;
 H:BY1PR03MB1339.namprd03.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; 
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(601004)(5005006)(5002010); SRVR:BY1PR03MB1340; BCL:0; PCL:0; RULEID:;
 SRVR:BY1PR03MB1340; 
x-forefront-prvs: 0525BB0ADF
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: freescale.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2015 07:29:20.1527 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1340
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix data access on big endian cpu
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2015 07:29:22 -0000

Hi Thomas,

Done. http://patchwork.dpdk.org/dev/patchwork/patch/4123/

Thanks,
Xuelin Shi

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, March 23, 2015 22:02
> To: Shi Xuelin-B29237
> Cc: dev@dpdk.org; konstantin.ananyev@intel.com; helin.zhang@intel.com
> Subject: Re: [PATCH] ixgbe: fix data access on big endian cpu
>=20
> 2015-03-03 16:27, xuelin.shi@freescale.com:
> > From: Xuelin Shi <xuelin.shi@freescale.com>
> >
> > enforce rules for cpu and ixgbe exchanging data.
> > 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) 2. cpu
> > fill data to ixgbe must use rte_cpu_to_le_xx(...)
> >
> > Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
>=20
> Please Xuelin, could you rebase on HEAD and fix these checkpatch errors?
>=20
> ERROR:SPACING: space prohibited after that '!' (ctx:BxW)
>=20
> ERROR:CODE_INDENT: code indent should use tabs where possible
> +^I^I ^I   ^I  IXGBE_RXDADV_STAT_DD)) {$
>=20
> Thanks