Re: [dpdk-dev] [PATCH v3] ixgbe: fix data access on big endian cpu

[Xuelin Shi <xuelin.shi@freescale.com>]

Hi Thomas,

I have worked out the new version based on dpdk v2 codebase to address the comments.
	http://www.dpdk.org/dev/patchwork/patch/6449/

thanks,
Xuelin Shi

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, July 10, 2015 22:52
> To: Shi Xuelin-B29237
> Cc: Ananyev, Konstantin; dev@dpdk.org
> Subject: Re: [PATCH v3] ixgbe: fix data access on big endian cpu
> 
> Xuelin, have you given up with that patch?
> 
> 2015-04-14 23:11, Ananyev, Konstantin:
> > From: xuelin.shi@freescale.com [mailto:xuelin.shi@freescale.com]
> > >  			txd->read.olinfo_status =
> > > -				rte_cpu_to_le_32(olinfo_status);
> > > +					rte_cpu_to_le_32(olinfo_status);
> > > +
> >
> > Not sure, what had changed here?
> 
> > > @@ -2293,7 +2314,8 @@ ixgbe_dev_rx_queue_count(struct rte_eth_dev
> *dev, uint16_t rx_queue_id)
> > >  	rxdp = &(rxq->rx_ring[rxq->rx_tail]);
> > >
> > >  	while ((desc < rxq->nb_rx_desc) &&
> > > -		(rxdp->wb.upper.status_error & IXGBE_RXDADV_STAT_DD)) {
> > > +		(rte_le_to_cpu_32(rxdp->wb.upper.status_error) &
> > > +				  IXGBE_RXDADV_STAT_DD)) {
> >
> > Why not ' rxdp->wb.upper.status_error &
> rte_cpu_to_le_32(IXGBE_RXDADV_STAT_DD)'?
> > To keep it consistent with rest of the changes?
> 
>