From: Rasesh Mody <rasesh.mody@qlogic.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>,
Harish Patil <harish.patil@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get
Date: Sat, 7 May 2016 00:14:23 +0000 [thread overview]
Message-ID: <BY1PR11MB015127ADE8DA87944802CFE6857E0@BY1PR11MB0151.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20160506144709.GC8880@bricha3-MOBL3>
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Friday, May 06, 2016 7:47 AM
>
> On Tue, May 03, 2016 at 10:38:21PM -0700, Rasesh Mody wrote:
> > Enhance the stats_get() routine to display drop counters under imissed
> > counter.
> > Added extended stats get support to provide additional info.
> > Encorporated review comment to rename some of the stats.
> >
> > Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> > Signed-off-by: Harish Patil <harish.patil@qlogic.com>
>
> Again this seems to me like it should be two patches rather than one. A first
> patch as a fix for the drop counters and then a second patch to add the xstats
> functionality.
>
> Regards,
> /Bruce
We shall split this patch into an enhancement and a bug fix.
Thanks!
Rasesh
next prev parent reply other threads:[~2016-05-07 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 5:38 [dpdk-dev] [PATCH v4 1/3] bnx2x: refactor Tx routine for single doorbell mechanism Rasesh Mody
2016-05-04 5:38 ` [dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get Rasesh Mody
2016-05-06 14:47 ` Bruce Richardson
2016-05-07 0:14 ` Rasesh Mody [this message]
2016-05-10 10:27 ` Remy Horton
2016-05-11 0:58 ` Rasesh Mody
2016-06-21 9:00 ` Remy Horton
2016-05-04 5:38 ` [dpdk-dev] [PATCH v4 3/3] bnx2x: update PMD version to 1.0.1.1 Rasesh Mody
2016-05-06 14:45 ` [dpdk-dev] [PATCH v4 1/3] bnx2x: refactor Tx routine for single doorbell mechanism Bruce Richardson
2016-05-11 5:41 ` Harish Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY1PR11MB015127ADE8DA87944802CFE6857E0@BY1PR11MB0151.namprd11.prod.outlook.com \
--to=rasesh.mody@qlogic.com \
--cc=Dept-EngDPDKDev@qlogic.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).