From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0133.outbound.protection.outlook.com [157.56.111.133]) by dpdk.org (Postfix) with ESMTP id 515B3568C for ; Wed, 4 May 2016 07:41:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qlgc.onmicrosoft.com; s=selector1-qlogic-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qFJU+IYJPw8mEsQm/g+Z5rg0Kjt1A4R5O1o4OglkZ6Q=; b=VBXBJQ5BSM0ObtWV/ZIBsoS7mgYNhbJDWE24sRgja+Fu++1mxVWxr+WVRCO9Io6Mhsl1WRGvKCtvdH7y5sor1w6eevOEOXlzowjAvW1o6g1MfGaeJZkHRdrdRpalE3vFVH65wKQvUiBLUKaqCXUkpujW6jb2YEYpY16e7J32XbQ= Received: from BY1PR11MB0151.namprd11.prod.outlook.com (10.160.202.149) by BN4PR11MB0898.namprd11.prod.outlook.com (10.164.57.28) with Microsoft SMTP Server (TLS) id 15.1.485.9; Wed, 4 May 2016 05:41:41 +0000 Received: from BY1PR11MB0151.namprd11.prod.outlook.com ([10.160.202.149]) by BY1PR11MB0151.namprd11.prod.outlook.com ([10.160.202.149]) with mapi id 15.01.0485.011; Wed, 4 May 2016 05:41:41 +0000 From: Rasesh Mody To: "Van Haaren, Harry" , "thomas.monjalon@6wind.com" CC: "dev@dpdk.org" , Ameen Rahman , Harish Patil Thread-Topic: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get Thread-Index: AQHRj5yCL0nkhvdnOkWy4+e2QyUgqZ99eIgAgCr3GNA= Date: Wed, 4 May 2016 05:41:41 +0000 Message-ID: References: <1459903028-3329-1-git-send-email-rasesh.mody@qlogic.com> <1459903028-3329-3-git-send-email-rasesh.mody@qlogic.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=qlogic.com; x-originating-ip: [2601:646:8104:7df0:81e3:e3da:5cc9:9dc0] x-ms-office365-filtering-correlation-id: 9acd8a3c-0c14-400d-d4d9-08d373dec50a x-microsoft-exchange-diagnostics: 1; BN4PR11MB0898; 5:xSdsOBL3z7BPi+dFLm3kVHIEACH+lLa0q4PDQ43qSiavZ4C3l4EXIhj0SFCAqJ5FJBHhkOB340RQP0OBxbpxT21uoeWWUn9Dv28cpJXlt9vh3gv/EiOJVU7bBQwEtsIontilMMuBjnKKoda5Wf0lOw==; 24:3E7YuwzQcjcgDjqXANfcHfMEspEJznvg0CXFurdRU3sQXPds+rUBOLrdmx/jAfwjSGTFeLRXvOQ+0QmAMeAj7WVE0TBl2qXtRIkRYjQX9TY=; 7:Ev9ZtFUfSWQEJ50c7S/++6fWjcIqRGNaYRf1Po4Rcl/m/xjVm8qEtfssVQbwreTbjwkLkUqNxSUU82PRUWlS7OaM+zznBtx7OX04cwALKvF3rSa9BIXrAo+VjuwKoz5UN4eKEPKTpr8Pd17dflDmQ3IUXdUyhCZ0VzTUjCmv4TovpTUruBLA5pvFLsB88g5+; 20:AeOa9QE2Jv1GyZggIEZ8/vx1jIuK3kXEg5GUbCQX6ThJaXLa8J8Os18DoR3X3jT8e1H6CZ+Gs6rzIfkJB4JejVAiuupsMcp3LUDcvxdfgFDvPn2J2b+Xre+doBpuW/fZK3F+wp/ilhhnebEWkrDAiq3mtB73gMD9S8dyBbw0oQs= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR11MB0898; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(9101528026)(9101521098)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BN4PR11MB0898; BCL:0; PCL:0; RULEID:; SRVR:BN4PR11MB0898; x-forefront-prvs: 093290AD39 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(377454003)(11100500001)(107886002)(189998001)(5001770100001)(122556002)(10400500002)(76576001)(4001430100002)(33656002)(77096005)(3660700001)(5002640100001)(3280700002)(2900100001)(9686002)(2950100001)(81166005)(2906002)(5008740100001)(5004730100002)(2501003)(92566002)(8936002)(5003600100002)(4326007)(54356999)(106116001)(50986999)(76176999)(586003)(6116002)(102836003)(99286002)(19580395003)(19580405001)(74316001)(86362001)(87936001)(1220700001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN4PR11MB0898; H:BY1PR11MB0151.namprd11.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2016 05:41:41.1845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR11MB0898 Subject: Re: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2016 05:41:43 -0000 > From: Van Haaren, Harry [mailto:harry.van.haaren@intel.com] > Sent: Wednesday, April 06, 2016 7:33 AM >=20 > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rasesh Mody > > Subject: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get >=20 > Hi Rasesh, >=20 > > + snprintf(xstats[num].name, sizeof(xstats[num].name), > "brb_drops"); >=20 > I don't understand what a "brb" drop is. >=20 >=20 > > + snprintf(xstats[num].name, sizeof(xstats[num].name), "tx_pfc"); >=20 > Similarly here, and with some other of the xstats strings, it doesn't bec= ome > clear to me what exactly the value represents. >=20 > "mac_filter_discard" is descriptive and readable, but the next stat has > "mf_tag_discard" - these small inconsistencies make it much harder > (impossible?) to scrap the xstats strings and retrieve useful metadata. >=20 > I'll suggest leaving the xstats implementation part of this patch until t= he next > release, and we can align on the names of the stats. >=20 > -Harry We have re-worked the patches and submitted v4. It incorporates changes to = rename some of the stats. Thanks! Rasesh