From: Rasesh Mody <rasesh.mody@qlogic.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Panu Matilainen <pmatilai@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0
Date: Sat, 14 May 2016 01:06:58 +0000 [thread overview]
Message-ID: <BY1PR11MB015131A2F62077B89721C8E585750@BY1PR11MB0151.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1831204.vI4CoI6YQS@xps13>
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, May 13, 2016 8:38 AM
>
> 2016-05-10 13:01, Panu Matilainen:
> > With gcc >= 6.0, qede base driver fails to build with:
> > drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common':
> > cc1: error: left shift of negative value
> > [-Werror=shift-negative-value]
> >
> > Since the base drivers are untouchable, work around by disabling the
> > warning.
>
> Are the qede base driver files untouchable?
>
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> [...]
> > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
> > +CFLAGS_BASE_DRIVER += -Wno-shift-negative-value endif
>
> Fixes: ec94dbc57362 ("qede: add base driver")
>
> Applied, thanks
>
> Rasesh, would you mind to fix the base driver and remove this workaround?
Sure Thomas! Will look into this.
next prev parent reply other threads:[~2016-05-14 1:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 10:01 Panu Matilainen
2016-05-13 15:37 ` Thomas Monjalon
2016-05-14 1:06 ` Rasesh Mody [this message]
2016-05-18 7:29 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY1PR11MB015131A2F62077B89721C8E585750@BY1PR11MB0151.namprd11.prod.outlook.com \
--to=rasesh.mody@qlogic.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).