[dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0

[dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0

[Panu Matilainen]

With gcc >= 6.0, qede base driver fails to build with:
drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common':
cc1: error: left shift of negative value [-Werror=shift-negative-value]

Since the base drivers are untouchable, work around by disabling
the warning.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 drivers/net/qede/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index 47e01be..884e173 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -47,6 +47,9 @@ CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
 CFLAGS_BASE_DRIVER += -Wno-missing-declarations
 CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
 CFLAGS_BASE_DRIVER += -Wno-strict-prototypes
+ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
+CFLAGS_BASE_DRIVER += -Wno-shift-negative-value
+endif
 else ifeq ($(CC), clang)
 CFLAGS_BASE_DRIVER += -Wno-format-extra-args
 CFLAGS_BASE_DRIVER += -Wno-visibility
-- 
2.5.5

Re: [dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0

[Thomas Monjalon]

2016-05-10 13:01, Panu Matilainen:
> With gcc >= 6.0, qede base driver fails to build with:
> drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common':
> cc1: error: left shift of negative value [-Werror=shift-negative-value]
> 
> Since the base drivers are untouchable, work around by disabling
> the warning.

Are the qede base driver files untouchable?

> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
[...]
> +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
> +CFLAGS_BASE_DRIVER += -Wno-shift-negative-value
> +endif

Fixes: ec94dbc57362 ("qede: add base driver")

Applied, thanks

Rasesh, would you mind to fix the base driver and remove this workaround?

Re: [dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0

[Rasesh Mody]

> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, May 13, 2016 8:38 AM
> 
> 2016-05-10 13:01, Panu Matilainen:
> > With gcc >= 6.0, qede base driver fails to build with:
> > drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common':
> > cc1: error: left shift of negative value
> > [-Werror=shift-negative-value]
> >
> > Since the base drivers are untouchable, work around by disabling the
> > warning.
> 
> Are the qede base driver files untouchable?
> 
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> [...]
> > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
> > +CFLAGS_BASE_DRIVER += -Wno-shift-negative-value endif
> 
> Fixes: ec94dbc57362 ("qede: add base driver")
> 
> Applied, thanks
> 
> Rasesh, would you mind to fix the base driver and remove this workaround?

Sure Thomas! Will look into this.

Re: [dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0

[Panu Matilainen]

On 05/14/2016 04:06 AM, Rasesh Mody wrote:
>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>> Sent: Friday, May 13, 2016 8:38 AM
>>
>> 2016-05-10 13:01, Panu Matilainen:
>>> With gcc >= 6.0, qede base driver fails to build with:
>>> drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common':
>>> cc1: error: left shift of negative value
>>> [-Werror=shift-negative-value]
>>>
>>> Since the base drivers are untouchable, work around by disabling the
>>> warning.
>>
>> Are the qede base driver files untouchable?
>>
>>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>> [...]
>>> +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
>>> +CFLAGS_BASE_DRIVER += -Wno-shift-negative-value endif
>>
>> Fixes: ec94dbc57362 ("qede: add base driver")
>>
>> Applied, thanks
>>
>> Rasesh, would you mind to fix the base driver and remove this workaround?
>
> Sure Thomas! Will look into this.

Hmm, so the base driver in qede is not holy and untouchable? That's good 
news of course. I simply assumed it was by the tell-tale signs of having 
a "base driver" in the first place, and like with those other 
untouchable base-drivers there were many warning-disablers present already.

	- Panu -