From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0116.outbound.protection.outlook.com [207.46.100.116]) by dpdk.org (Postfix) with ESMTP id B880D9AF6 for ; Sat, 14 May 2016 03:07:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qlgc.onmicrosoft.com; s=selector1-qlogic-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rFJLTl7hGogBAvcfgxdMNJ/A/VU8W/8cLDS+aWDZ0Bk=; b=Xi3LHHNvnBkd+MPCRqshN3b6/18M42kTmga0YXf4GrR5pf/sqMDwXe89Y8zAijurJR6UUlht3aGkfbQNDHXhiUhhv3VWlIiYxCA55IvNMHWoqYDS5CBp7var3LsR0EFocUFmSPlO1/aOwQoFAntLI35/yEOEYPGTB0Vbb6W+o60= Received: from BY1PR11MB0151.namprd11.prod.outlook.com (10.160.202.149) by BY1PR11MB0150.namprd11.prod.outlook.com (10.160.202.148) with Microsoft SMTP Server (TLS) id 15.1.485.9; Sat, 14 May 2016 01:06:59 +0000 Received: from BY1PR11MB0151.namprd11.prod.outlook.com ([10.160.202.149]) by BY1PR11MB0151.namprd11.prod.outlook.com ([10.160.202.149]) with mapi id 15.01.0485.018; Sat, 14 May 2016 01:06:59 +0000 From: Rasesh Mody To: Thomas Monjalon , Panu Matilainen CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0 Thread-Index: AQHRqqL3tkA68kvN4kiJBZ3L00/waJ+3BY4AgACeF7A= Date: Sat, 14 May 2016 01:06:58 +0000 Message-ID: References: <1831204.vI4CoI6YQS@xps13> In-Reply-To: <1831204.vI4CoI6YQS@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=qlogic.com; x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: 7e9c4da7-93d0-410d-0a26-08d37b940d11 x-microsoft-exchange-diagnostics: 1; BY1PR11MB0150; 5:hA6eNoPi/vM1mb3t8qPSndVnoQRHp+SH9Za37fw6Cjhh2OMDYls7YyFGaPaCtmL0VH066zHisdzTttdoULUyR2ud5NwULe+2+zqY8i/YC/FuZt3tkeCMsVQAgKa9T/s+we73mkFu37nW8LJjH0iw8A==; 24:KeQq9pDX4q3JYzICGLExWRt2Saj/ZxTOt+WEvr3EDuK15Hp+DvDFRMS4rV2KOmRwEfvqGOLQYFiBqOO56Ws2bQpNrYndAuNZacOJqSGsyx8=; 7:jdk/M4aFtFjwW1g/0vwXjzh0LlYQbbTyIoGNmAqwif/gFdCWDCNE0Q4yCT1IlJLi/DD1VG1SClFss4yNKfXxCaGvJbLgFTPUGy3hkkpusz7Z8u4LRcUn7Y/dZ/KdGVZEi56dxQvi4IfdJs9je52018j3mBv+TgBcZ1wY1RQIEmr/l9CE5pC0BMcX8CZqGSPJ; 20:KCAgU+LGdX0fct6Lj5d3zl5F2W2ssztuLER448Z00efZQSlSF7iQatLR73GA4uKTKzKcpT4p2e43LSDvTQRYxREmKQkbT7AIj2iYvZldtN6aaZrKksx04LqZx6SUenuCl3wC9a8hE+YRYB5LzRh2fv5Vy9w2e54Ik1Fb+ttLlsE= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR11MB0150; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BY1PR11MB0150; BCL:0; PCL:0; RULEID:; SRVR:BY1PR11MB0150; x-forefront-prvs: 094213BFEA x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(377424004)(377454003)(77096005)(5008740100001)(87936001)(2900100001)(19580405001)(2950100001)(5001770100001)(8676002)(8936002)(122556002)(5003600100002)(189998001)(92566002)(81166006)(19580395003)(11100500001)(5004730100002)(5002640100001)(10400500002)(9686002)(3280700002)(2906002)(76176999)(86362001)(102836003)(99286002)(3660700001)(6116002)(3846002)(586003)(106116001)(4326007)(54356999)(33656002)(1220700001)(50986999)(74316001)(66066001)(76576001); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR11MB0150; H:BY1PR11MB0151.namprd11.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2016 01:06:58.7406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB0150 Subject: Re: [dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 May 2016 01:07:01 -0000 > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, May 13, 2016 8:38 AM >=20 > 2016-05-10 13:01, Panu Matilainen: > > With gcc >=3D 6.0, qede base driver fails to build with: > > drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common': > > cc1: error: left shift of negative value > > [-Werror=3Dshift-negative-value] > > > > Since the base drivers are untouchable, work around by disabling the > > warning. >=20 > Are the qede base driver files untouchable? >=20 > > Signed-off-by: Panu Matilainen > [...] > > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) > > +CFLAGS_BASE_DRIVER +=3D -Wno-shift-negative-value endif >=20 > Fixes: ec94dbc57362 ("qede: add base driver") >=20 > Applied, thanks >=20 > Rasesh, would you mind to fix the base driver and remove this workaround? Sure Thomas! Will look into this.