From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0058.outbound.protection.outlook.com [104.47.36.58]) by dpdk.org (Postfix) with ESMTP id 740CB3777 for ; Fri, 6 Jan 2017 01:01:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onevmw.onmicrosoft.com; s=selector1-vmware-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GwHP8EoEkZNrSbpb06lHBKYUfXrtX5apdbUnIvSINIA=; b=TC4j4ca1QM6PPxvkZJqufhUVJw/L4+Im0JBzwyV6sCW3788F/rQGYHWjN8DcjTfY1VLywdddL8v5gRBeU79NSUVilntw0vMOB4Q5NZ1zePyy13+v3ydY9iB2cfStN7czZA+nmFy4X/yJzXSzqJ9GnGLZqnNsDmjSYm1JGkPvXcQ= Received: from BY2PR05MB2359.namprd05.prod.outlook.com (10.166.113.11) by BY2PR05MB2360.namprd05.prod.outlook.com (10.166.113.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.3; Fri, 6 Jan 2017 00:01:48 +0000 Received: from BY2PR05MB2359.namprd05.prod.outlook.com ([10.166.113.11]) by BY2PR05MB2359.namprd05.prod.outlook.com ([10.166.113.11]) with mapi id 15.01.0829.007; Fri, 6 Jan 2017 00:01:48 +0000 From: Yong Wang To: Ferruh Yigit , nickcooper-zhangtonghao , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA. Thread-Index: AQHSZ19d47yog0P7hUCc3ng5KKamL6Eqj5og Date: Fri, 6 Jan 2017 00:01:48 +0000 Message-ID: References: <1483617709-7088-1-git-send-email-nic@opencloud.tech> <8cb35df0-cdd6-143c-4f78-379a89f44616@intel.com> In-Reply-To: <8cb35df0-cdd6-143c-4f78-379a89f44616@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yongwang@vmware.com; x-originating-ip: [208.91.1.34] x-ms-office365-filtering-correlation-id: 1621c2e8-a1dd-4a46-7154-08d435c735cf x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY2PR05MB2360; x-microsoft-exchange-diagnostics: 1; BY2PR05MB2360; 7:qryvjEFMFDAF+hpv8ue9c2pUDNEUBD0AEssYCYHqj3dINbPBBMaZ1Kt46wROMecv19wI8o1a8mO09/ZhdK/YL62syfCWninAxlrsH9rd5dkZ1G/6evLknL2UYciXCtD+VTUp3vId0akJz1uXyg2XZPy4ge1uwAry41jZjskwPuoagCZuwZXyXDHu7OgPua7MfpiGtmVd1FHaoSFJPNf74UWkCdyJSDLC1LhMMTgF9bZk/DxBH2nLhzZG/zLM3/kpL7tTigZz+1dzhgaOP116c9fyD+MaHE5sUoA9nP1hKxXyA0Jh9vo9HN8FD6nhAwTS2pxpd8vz6gJuoppO2KZlHXJmdhTIvFcUiGi8WVmPp9JRFPhYeA15C8ElUv72rAZ0EXAw4rdpDGfU8O26+7g3j/8gL0FfhAyVwqg5nqXv6bkBhfivFENbZGnvnUqhr/BUsi4r3znD2+su3q9OkJOCaQ==; 20:YcWy9e6S/FfizZ0sbr170etC1fJQOpzF31ZfLls01EK6J0ra02Ml2mk1zm/EpeTWDQ6t/hiGcni7V8t2FKbnYwcZCT2ddfbt1tQLPqyZPHmkXgAujws+JsztRrMtMxGaOQ4VRIjeE0S79BYlVq7TVmhzFWOsmq+mgpJCkdCwnjk= x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(61668805478150)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123558021)(20161123564025)(20161123562025)(6072148); SRVR:BY2PR05MB2360; BCL:0; PCL:0; RULEID:; SRVR:BY2PR05MB2360; x-forefront-prvs: 01792087B6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(24454002)(189002)(377454003)(13464003)(199003)(107886002)(189998001)(6436002)(97736004)(74316002)(92566002)(7736002)(5001770100001)(33656002)(86362001)(305945005)(3660700001)(76176999)(122556002)(2906002)(50986999)(54356999)(3280700002)(8936002)(81166006)(106116001)(55016002)(8676002)(81156014)(105586002)(66066001)(9686002)(106356001)(6116002)(3846002)(2501003)(102836003)(6506006)(25786008)(101416001)(77096006)(2950100002)(5660300001)(229853002)(99286003)(2900100001)(38730400001)(7696004)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR05MB2360; H:BY2PR05MB2359.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2017 00:01:48.1462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR05MB2360 Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 00:01:51 -0000 > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Thursday, January 5, 2017 6:24 AM > To: nickcooper-zhangtonghao ; dev@dpdk.org; Yong > Wang > Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for syste= m > which not support NUMA. >=20 > On 1/5/2017 12:01 PM, nickcooper-zhangtonghao wrote: > > The NUMA node information for PCI devices provided through > > sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx > > on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > > > > Signed-off-by: nickcooper-zhangtonghao >=20 > Hi nickcooper-zhangtonghao, >=20 > The patches in the patchset are individual patches, right? Is there any > dependency between them? >=20 > And CC'ed vmxnet3 driver maintainer: Yong Wang Can you add the exact steps to reproduce the vmxnet3 issues to help the rev= iew and the verification. My guess is that you have stopped the device, cha= nged some ring parameters (to something larger than the previous settings) = and restarted the device. Such info should be included into the commit desc= ription in addition to just saying what the patch does. > Thanks, > ferruh >=20 > > --- > > lib/librte_eal/linuxapp/eal/eal_pci.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c > b/lib/librte_eal/linuxapp/eal/eal_pci.c > > index 4350134..5dfdbe9 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > > @@ -317,7 +317,13 @@ > > free(dev); > > return -1; > > } > > - dev->device.numa_node =3D tmp; > > + /* The NUMA node information for PCI devices provided > through > > + * sysfs is invalid for AMD Opteron(TM) Processor 62xx and > 63xx > > + * on Red Hat Enterprise Linux 6, and VMs on some > hypervisors. > > + * In the upstream linux kernel, the numa_node is an integer, > > + * which data type is int, not unsigned long. > > + */ > > + dev->device.numa_node =3D (int)tmp > 0 ? (int)tmp : 0; > > } > > > > /* parse resources */ > >