DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinj@marvell.com>
To: Nawal Kishor <nkishor@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
	Harman Kalra <hkalra@marvell.com>,
	Ashwin Sekhar T K <asekhar@marvell.com>
Cc: Nawal Kishor <nkishor@marvell.com>
Subject: RE: [PATCH] common/cnxk: fix aura offset
Date: Tue, 11 Mar 2025 13:08:58 +0000	[thread overview]
Message-ID: <BY3PR18MB47852AF2E8B1F959F5640AA0C8D12@BY3PR18MB4785.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20250304052217.796506-1-nkishor@marvell.com>



> -----Original Message-----
> From: Nawal Kishor <nkishor@marvell.com>
> Sent: Tuesday, March 4, 2025 10:52 AM
> To: dev@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>;
> Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori
> <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>; Harman Kalra <hkalra@marvell.com>; Ashwin
> Sekhar T K <asekhar@marvell.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; Nawal Kishor <nkishor@marvell.com>
> Subject: [PATCH] common/cnxk: fix aura offset
> 
> Fix aura offset in NPA_LF_POOL_OP_INT.

Please add more description.

> 
> Fixes: 620fc02bf7eb ("common/cnxk: accommodate change in aura field
> width")

Fix the following

Is it candidate for Cc: stable@dpdk.org backport?
        common/cnxk: fix aura offset

Invalid patch(es) found - checked 1 patch
check-git-log failed

### [PATCH] common/cnxk: fix aura offset

Warning in drivers/common/cnxk/roc_npa_irq.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t


> 
> Signed-off-by: Nawal Kishor <nkishor@marvell.com>
> ---
>  drivers/common/cnxk/roc_npa_irq.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/common/cnxk/roc_npa_irq.c
> b/drivers/common/cnxk/roc_npa_irq.c
> index 0a19319ebf..9505194207 100644
> --- a/drivers/common/cnxk/roc_npa_irq.c
> +++ b/drivers/common/cnxk/roc_npa_irq.c
> @@ -104,14 +104,15 @@ static inline uint8_t  npa_q_irq_get_and_clear(struct
> npa_lf *lf, uint32_t q, uint32_t off,
>  			uint64_t mask)
>  {
> -	uint64_t reg, wdata;
> +	uint64_t reg, wdata, shift;
>  	uint8_t qint;
> 
> -	wdata = (uint64_t)q << 44;
> +	shift = roc_model_is_cn20k() ? 47 : 44;
> +	wdata = (uint64_t)q << shift;
>  	reg = roc_atomic64_add_nosync(wdata, (int64_t *)(lf->base + off));
> 
>  	if (reg & BIT_ULL(42) /* OP_ERR */) {
> -		plt_err("Failed execute irq get off=0x%x", off);
> +		plt_err("Failed execute irq get off=0x%x reg=0x%lx", off, reg);
>  		return 0;
>  	}
> 
> --
> 2.34.1


      reply	other threads:[~2025-03-11 13:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04  5:22 Nawal Kishor
2025-03-11 13:08 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY3PR18MB47852AF2E8B1F959F5640AA0C8D12@BY3PR18MB4785.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=asekhar@marvell.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=nkishor@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).