RE: [EXTERNAL] [RFC v7 4/4] eventdev: documentation for atomic queue and atomic atq tests

[Jerin Jacob <jerinj@marvell.com>]

> -----Original Message-----
> From: Luka Jankovic <luka.jankovic@ericsson.com>
> Sent: Wednesday, February 19, 2025 7:13 PM
> To: luka.jankovic@ericsson.com
> Cc: dev@dpdk.org; Jerin Jacob <jerinj@marvell.com>;
> mattias.ronnblom@ericsson.com; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>
> Subject: [EXTERNAL] [RFC v7 4/4] eventdev: documentation for atomic queue
> and atomic atq tests
> 
> Add relevant documentation and figures to the tools/testeventdev page. Signed-
> off-by: Luka Jankovic <luka. jankovic@ ericsson. com> ---
> .. . /tools/img/eventdev_atomic_atq_test. svg | 1588 +++++++++++++++
> .. . /tools/img/eventdev_atomic_queue_test. svg
> 
> Add relevant documentation and figures to the tools/testeventdev page.
> 
> Signed-off-by: Luka Jankovic <luka.jankovic@ericsson.com>
> ---
>  .../tools/img/eventdev_atomic_atq_test.svg    | 1588 +++++++++++++++
>  .../tools/img/eventdev_atomic_queue_test.svg  | 1701 +++++++++++++++++
>  doc/guides/tools/testeventdev.rst             |  155 ++
>  3 files changed, 3444 insertions(+)
>  create mode 100644 doc/guides/tools/img/eventdev_atomic_atq_test.svg
>  create mode 100644 doc/guides/tools/img/eventdev_atomic_queue_test.svg
> 
> diff --git a/doc/guides/tools/img/eventdev_atomic_atq_test.svg
> b/doc/guides/tools/img/eventdev_atomic_atq_test.svg
> new file mode 100644
> index 0000000000..0459d9f649
> --- /dev/null
> +++ b/doc/guides/tools/img/eventdev_atomic_atq_test.svg
> @@ -0,0 +1,1588 @@
> +<?xml version="1.0" encoding="UTF-8" standalone="no"?>
> +<!-- Created with Inkscape (https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__www.inkscape.org_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=1DGob
> 4H4rxz6H8uITozGOCa0s5f4wCNtTa4UUKvcsvI&m=M3r2ERBtjmi60SQwe4KmEK
> enw-0hf6i8FVOIwMDD-XJGI68GEM0VHT6uaBX7LbDB&s=M_QEMF-
> 40ilGHAYdpbAk1KrRdJ_xTLerpibmujj7qxM&e=) -->
> +
> +<!--
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2017 Cavium, Inc

1) make it as Ericsson copy right with correct year in all files
2) Remove RFC tag
3)Add Tested-by: Pavan Nikhilesh <pbhagavatula@marvell.com> to all patches
4)No need to have separate doc patches, Please move the doc changes to relevant patches
5)Update release notes about this feature
6) Fix following checkpatch issues[1]

Good to merge next version.


[1]
[for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 4

### [PATCH] eventdev: atomic common for test-eventdev app

WARNING:BRACES: braces {} are not necessary for single statement blocks
#255: FILE: app/test-eventdev/test_atomic_common.h:65:
+       if (atomic_locks == NULL) {
+               evt_err("Unable to allocate memory for spinlocks.");
+       }

WARNING:BRACES: braces {} are not necessary for single statement blocks
#259: FILE: app/test-eventdev/test_atomic_common.h:69:
+       for (uint32_t i = 0; i < num_locks; i++) {
+               rte_spinlock_init(&atomic_locks[i]);
+       }

total: 0 errors, 2 warnings, 241 lines checked

### [PATCH] eventdev: add atomic queue test to test-evnetdev app

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#63: FILE: app/test-eventdev/test_atomic_queue.c:35:
+               RTE_ATOMIC(uint64_t) *const outstand_pkts,
                                     ^

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#115: FILE: app/test-eventdev/test_atomic_queue.c:87:
+                               atomic_queue_process_stage_1(t, &ev[i], nb_flows, atomic_locks, expected_flow_seq,

total: 1 errors, 1 warnings, 237 lines checked

### [PATCH] eventdev: add atomic atq to test-eventdev app

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#63: FILE: app/test-eventdev/test_atomic_atq.c:34:
+               RTE_ATOMIC(uint64_t) *const outstand_pkts,
                                     ^

total: 1 errors, 0 warnings, 223 lines checked