Re: [dpdk-dev] [EXT] Re: [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices

[Jerin Jacob Kollanukkaran <jerinj@marvell.com>]

> > 1) Please sync the doc order with flag definition order in header file[1]
> > 2) You can remove RTE_EVENT_DEV_CAP_REQUIRES_MAINT from the
> > list(*CAP_REQUIRES*) as this
> > is limitation.
> >
> >
> 
> Maybe we should negate RTE_EVENT_DEV_CAP_REQUIRES_MAINT to make it
> fit
> better with the other capabilities? To be more in line with how the API
> has been adapted to cope with various eventdev hardware limitations
> (e.g., RTE_EVENT_DEV_CAP_CARRY_FLOW_ID).
> 
> RTE_EVENT_DEV_CAP_MAINTENANCE_FREE
> 
> All event devices/drivers would set this except DSW.
> 
> If this make sense and it's not too late to tweak the API, I can create
> a patch.


Makes sense. Just add those cap in !dsw drivers.
Please send it now, I will merge it soon. 

> 
> > [1]
> > RTE_EVENT_DEV_CAP_QUEUE_QOS
> > RTE_EVENT_DEV_CAP_EVENT_QOS
> > RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED
> > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES
> > RTE_EVENT_DEV_CAP_BURST_MODE
> > RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE
> > RTE_EVENT_DEV_CAP_NONSEQ_MODE
> > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
> > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
> > RTE_EVENT_DEV_CAP_CARRY_FLOW_ID
> >
> >
> >
> >> +
> >> +;
> >> +; Features of a default adapter.
> >> +;
> >> +[Adapter Features]
> >
> > Please make this as [Eth Rx adapter Features]
> >
> >> +Eth Rx/Tx adapter on internal port         =
> > You can remove Eth Rx/Tx adapter as new subject has [Eth Rx adapter]
> >
> >> +Multiple event queues per ethdev           =
> >> +Override flow ID                           =
> >
> > Missing RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR
> >
> >
> > Add new section for Tx adapter
> > and add
> > RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT
> > RTE_EVENT_ETH_TX_ADAPTER_CAP_EVENT_VECTOR
> >
> >
> > Add new section for Crypto adapter
> >
> >> +Crypto adapter new event enqueue           =
> >> +Crypto adapter forwarded event enqueue     =
> >> +Crypto queue pair mapping to event queue   =
> >> +Crypto adapter session data store/retrieve =
> >
> >
> > Add new section for timer adapter
> >
> >> +Timer adapter support in H/W               =
> >
> > Missing RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
> >