> -----Original Message-----
> From: Pravin Pathak <pravin.pathak@intel.com>
> Sent: Friday, May 9, 2025 9:54 AM
> To: dev@dpdk.org
> Cc: Jerin Jacob <jerinj@marvell.com>; mike.ximing.chen@intel.com;
> bruce.richardson@intel.com; thomas@monjalon.net;
> david.marchand@redhat.com; nipun.gupta@amd.com; chenbox@nvidia.com;
> tirthendu.sarkar@intel.com; Pravin Pathak <pravin.pathak@intel.com>
> Subject: [EXTERNAL] [PATCH v1 4/7] event/dlb2: support managing history list
> resource
> 
> Add support for setting application specified port history Set HL equal to CQ
> depth when inflight control is enabled Added command line parameters

> 
> +/** Set inflight threshold for flow migration */ #define
> +DLB2_FLOW_MIGRATION_THRESHOLD RTE_BIT64(0)

Keep DLB2_SET_PORT_ prefix as this flag is used with this API

> +
> +/** Set port history list */
> +#define DLB2_SET_PORT_HL RTE_BIT64(1)
> +
> +struct dlb2_port_param {
> +	uint16_t inflight_threshold : 12;
> +	uint16_t port_hl;
> +};

Not used this by PMD API. Move to .c or private header file.


> +/*!

Use doxygen syntax. See html generate file


> + * @warning
> + * @b EXPERIMENTAL: this API may change, or be removed, without prior
> +notice
> + *
> + * Configure various port parameters.
> + * AUTO_POP. This function must be called before calling
> +rte_event_port_setup()
> + * for the port, but after calling rte_event_dev_configure().
> + *
> + * @param dev_id
> + *    The identifier of the event device.
> + * @param port_id
> + *    The identifier of the event port.
> + * @param flags
> + *    Bitmask of the parameters being set.
> + * @param val
> + *    Structure coantaining the values of parameters being set.
> + *
> + * @return
> + * - 0: Success
> + * - EINVAL: Invalid dev_id, port_id, or mode
> + * - EINVAL: The DLB2 is not configured, is already running, or the port is
> + *   already setup
> + */
> +__rte_experimental
> +int
> +rte_pmd_dlb2_set_port_param(uint8_t dev_id,
> +			    uint8_t port_id,
> +			    uint64_t flags,
> +			    void *val);

Is this expecting dlb2_port_param structure. If so, make rte_pmd_dlb2_port_param.
i.e prefix rte_pmd to fix name conflict as it is public API. Also
Please send separate patch to fix name space for enum dlb2_token_pop_mode and 
AUTO_POP (Change RTE_PMD_DLB2_....)


>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/drivers/event/dlb2/version.map b/drivers/event/dlb2/version.map
> index c37d2302cd..be5a8f6f2b 100644
> --- a/drivers/event/dlb2/version.map
> +++ b/drivers/event/dlb2/version.map
> @@ -7,4 +7,5 @@ EXPERIMENTAL {
> 
>  	# added in 20.11
>  	rte_pmd_dlb2_set_token_pop_mode;

Add added in 25.07

> +	rte_pmd_dlb2_set_port_param;
>  };
> --
> 2.25.1