DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd
@ 2020-07-08  9:44 Arek Kusztal
  2020-07-13 12:31 ` Dybkowski, AdamX
  0 siblings, 1 reply; 4+ messages in thread
From: Arek Kusztal @ 2020-07-08  9:44 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, fiona.trahe, Arek Kusztal

Because capability memzone of compression does not have lookup
call, second and subsequent devices cannot be created.

Fixes: 0e6fff16a7a2 ("drivers: add multi process handling of capabilities in QAT")

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/compress/qat/qat_comp_pmd.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c
index ecf972a..034abad 100644
--- a/drivers/compress/qat/qat_comp_pmd.c
+++ b/drivers/compress/qat/qat_comp_pmd.c
@@ -726,9 +726,12 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev,
 		break;
 	}
 
-	comp_dev->capa_mz = rte_memzone_reserve(capa_memz_name,
-		capa_size,
-		rte_socket_id(), 0);
+	comp_dev->capa_mz = rte_memzone_lookup(capa_memz_name);
+	if (comp_dev->capa_mz == NULL) {
+		comp_dev->capa_mz = rte_memzone_reserve(capa_memz_name,
+			capa_size,
+			rte_socket_id(), 0);
+	}
 	if (comp_dev->capa_mz == NULL) {
 		QAT_LOG(DEBUG,
 			"Error allocating memzone for capabilities, destroying PMD for %s",
-- 
2.1.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd
  2020-07-08  9:44 [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd Arek Kusztal
@ 2020-07-13 12:31 ` Dybkowski, AdamX
  2020-07-15  1:53   ` Jiang, YuX
  0 siblings, 1 reply; 4+ messages in thread
From: Dybkowski, AdamX @ 2020-07-13 12:31 UTC (permalink / raw)
  To: Kusztal, ArkadiuszX, dev; +Cc: akhil.goyal, Trahe, Fiona, Kusztal, ArkadiuszX

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Arek Kusztal
> Sent: Wednesday, 8 July, 2020 11:44
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in
> compression pmd
> 
> Because capability memzone of compression does not have lookup call,
> second and subsequent devices cannot be created.
> 
> Fixes: 0e6fff16a7a2 ("drivers: add multi process handling of capabilities in
> QAT")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>

Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd
  2020-07-13 12:31 ` Dybkowski, AdamX
@ 2020-07-15  1:53   ` Jiang, YuX
  2020-07-15 19:48     ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Jiang, YuX @ 2020-07-15  1:53 UTC (permalink / raw)
  To: Dybkowski, AdamX, Kusztal, ArkadiuszX, dev
  Cc: akhil.goyal, Trahe, Fiona, Kusztal, ArkadiuszX, Jiang, YuX

Tested-by:  Jiang, YuX <yux.jiang@intel.com> 

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dybkowski, AdamX
Sent: Monday, July 13, 2020 8:31 PM
To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
Subject: Re: [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Arek Kusztal
> Sent: Wednesday, 8 July, 2020 11:44
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; 
> Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in 
> compression pmd
> 
> Because capability memzone of compression does not have lookup call, 
> second and subsequent devices cannot be created.
> 
> Fixes: 0e6fff16a7a2 ("drivers: add multi process handling of 
> capabilities in
> QAT")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>

Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd
  2020-07-15  1:53   ` Jiang, YuX
@ 2020-07-15 19:48     ` Akhil Goyal
  0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2020-07-15 19:48 UTC (permalink / raw)
  To: Jiang, YuX, Dybkowski, AdamX, Kusztal, ArkadiuszX, dev
  Cc: Trahe, Fiona, Kusztal, ArkadiuszX

> Tested-by:  Jiang, YuX <yux.jiang@intel.com>
> 
> > Because capability memzone of compression does not have lookup call,
> > second and subsequent devices cannot be created.
> >
> > Fixes: 0e6fff16a7a2 ("drivers: add multi process handling of
> > capabilities in
> > QAT")
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> 
> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-15 19:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08  9:44 [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd Arek Kusztal
2020-07-13 12:31 ` Dybkowski, AdamX
2020-07-15  1:53   ` Jiang, YuX
2020-07-15 19:48     ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git