From: "Dybkowski, AdamX" <adamx.dybkowski@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Trahe, Fiona" <fiona.trahe@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305
Date: Tue, 6 Oct 2020 14:27:24 +0000 [thread overview]
Message-ID: <BY5PR11MB39106CB593A1D236F794A8C9ED0D0@BY5PR11MB3910.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8wYYdsONndg766839VsDYe2aTH4btNwn_6FCBBPOco_sw@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, 6 October, 2020 14:32
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Cc: dev <dev@dpdk.org>; Trahe, Fiona <fiona.trahe@intel.com>; Akhil Goyal
> <akhil.goyal@nxp.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Ray Kinsella <mdr@ashroe.eu>
> Subject: Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for
> ChaCha20-Poly1305
>
> For the title, I would suggest: "cryptodev: remove v20 ABI compatibility"
>
> You did this change using a revert, but still, we can avoid restoring coding
> style issues, see nits below.
Thanks for the review, David.
I'll fix these styling issues and send v2 later this week.
Adam Dybkowski
next prev parent reply other threads:[~2020-10-06 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 9:59 Adam Dybkowski
2020-08-25 8:18 ` Kusztal, ArkadiuszX
2020-10-06 12:32 ` David Marchand
2020-10-06 14:27 ` Dybkowski, AdamX [this message]
2020-10-07 10:41 ` Doherty, Declan
2020-10-07 12:06 ` David Marchand
2020-10-08 8:32 ` [dpdk-dev] [PATCH v2 0/1] cryptodev: remove v20 ABI compatibility Adam Dybkowski
2020-10-08 8:32 ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
2020-10-09 17:41 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB39106CB593A1D236F794A8C9ED0D0@BY5PR11MB3910.namprd11.prod.outlook.com \
--to=adamx.dybkowski@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=mdr@ashroe.eu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).