From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 477F3A034F; Wed, 13 May 2020 10:33:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 295F71D16D; Wed, 13 May 2020 10:33:18 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B58391D16B for ; Wed, 13 May 2020 10:33:15 +0200 (CEST) IronPort-SDR: xrHAy7BEkSMNEwNCglqjnDlFEGNbAQd8oY7fGXqQ/EVf1u+RQbKBKcnz31o+EoPHmvEb/72BrH 73xfcVDPmwmg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 01:33:14 -0700 IronPort-SDR: U1tmWZuOAkZNZEQKioXXuFA04qVKM3LlW92hj0hfwUa36PBs/Z4xVsNXWBhmHTT9/4gKfUu9W2 V8OBZ05fq+Mg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,387,1583222400"; d="scan'208";a="371834830" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga001.fm.intel.com with ESMTP; 13 May 2020 01:33:14 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 01:33:14 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 01:33:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GLCtp51K8+ORlqB7aygVuvQ0OHTbJLKuuiGlpPGgQ0eO8VlhN+kMp1Utj70f3hPfTFyueUo1r+EnZU3G/5/DjrMecWREayKC1wT54R/pig0UaPSfMsiIoo323EUJ/GOXWoNhfJopmByCYan1KcfOOtbld6T/F/oP2ImPv5FlAgYwxEzM1sk+ZjYk3urUi/zddR4dPBu168aXRS/bqaPAiZSUzgscoq+Rm5eqJSsWelY2kHIt5tK+QIVcX/MomluHv2X+U2OjO09NocZ9d0adggF00KZBBvz0xJOqzX/5I9OsYD0CQKsCEXEONqunDRa7it9J6SxQ9jTM3gCp+xBV6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vtBsC++zaD4N1RLNLwDxF2R2U5IuKY/+dlsc56ptrag=; b=K/1vVQvjjlNUPKaGGaIBMGJQI9zadBi9rNhvAM6Q7gDXN4S5tKptC0k5/MCJQ5XcLrYc5+sv1Kg3uMMdXfUO7rUvbhJ3rf3w9jpHmldhnUY7jomuxUMkNu0B5YXJpg4AHK+REBJZMrqOVJb30xrfSH12CCb5rMPwD7FhV0EmN1kvDXu6n+0Enbk9av7O2JDVsE83K2ckPt17HeSKQDLZMaLyjlY5MJsDhXXUxuDf6S3GPr7bX7aN86gAngBCAGLPAfCeEbtTmjlGh4Z03lIWyNXELZTGXXzbeiAFnktZ2TcNiZ7cVowPmbjqTz4276bdAt/LSjIm3L8a21KvvqJIIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vtBsC++zaD4N1RLNLwDxF2R2U5IuKY/+dlsc56ptrag=; b=Wbk9U/K8fnVe4NWBRm1utjdmrs64R47KUrXVlDj6AGrCttYqrYWaFKgRIR19iqmlS+kswZ0l+wpXtLdZ4ar61jfmHwg6NDe/urNEvJ4tM6rLep6TmUAugoPcaNc68j+IY041gcFb+LqOxXh8SX3s0PcIwO9pteyVK9qyrRZcmbE= Received: from BY5PR11MB3910.namprd11.prod.outlook.com (2603:10b6:a03:185::13) by BY5PR11MB4193.namprd11.prod.outlook.com (2603:10b6:a03:1c8::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Wed, 13 May 2020 08:33:11 +0000 Received: from BY5PR11MB3910.namprd11.prod.outlook.com ([fe80::ad60:fbb0:b236:3679]) by BY5PR11MB3910.namprd11.prod.outlook.com ([fe80::ad60:fbb0:b236:3679%6]) with mapi id 15.20.2979.033; Wed, 13 May 2020 08:33:11 +0000 From: "Dybkowski, AdamX" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" CC: Narayana Prasad Raju Athreya , Ankur Dwivedi , "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors Thread-Index: AQHWKCzuQsrCL2nw00ad6LKxx2EKwKika7zQgAAF3oCAAT/14A== Date: Wed, 13 May 2020 08:33:11 +0000 Message-ID: References: <1589267544-18134-1-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [79.184.238.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0cde0ba2-f372-4c58-8271-08d7f71845d3 x-ms-traffictypediagnostic: BY5PR11MB4193: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hMRamGW7y9//BPqx2GadoskwkYjFMjCOF2KmUMqtOcAlSwEEBKETShYFc1a2blWgMbU0eCS4rQ1uFQEszeDDpw8iKp0hVGU3YXqvnSQdxaule+BLWLVylvPLunmklKm20bvK5dSUhIfhZFL5End9hbbyOhoawoxIs+evQs/CEHOskKXgSpW51jPjb4KilR8Xluw0e/86UAWgWjAWYEp8dm8ET5h1lE9ROs7RpWhHFrSsXB6/hISMJk0HRlb8pRcXJUUA22pRkPwEo6HfbK6ojqgTm92LaZ7pibdP5xzkoWGlOMFY5ID3yIqQQZMapNFT+UtuQhcLg6PFRRRq8v/bzk4l+Lx9G5xgfRjogYjkw2YN6fLsWw37y3VDa5F8UK3mqgM/xvNNOd8Z1J+9hwWtsRz6PzciVjBNIC9DGzqamMLOM9hnN68XzoGredq4MG8J9D9LKQayMg3vArC0FEhyrDa8Ppm7il8RzBLCRmnm2Q7nXu141mPZRbTvnZiIKS1fMBQkdhMBJxaiWjkv7EyYfw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3910.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(136003)(39860400002)(346002)(376002)(396003)(33430700001)(26005)(8936002)(76116006)(7696005)(6636002)(55016002)(66946007)(478600001)(66446008)(52536014)(4326008)(66476007)(66556008)(86362001)(2906002)(186003)(64756008)(316002)(71200400001)(9686003)(33440700001)(5660300002)(6506007)(33656002)(54906003)(53546011)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: eVvzcESYYbZGVYMtK7QRA/yM7XqSB3TTchHKonLdUJdD0yGFJK+4JaYWYPLjt1QQXfPVsCjtHJ8Fp3C8fBR4+Ulz5b8XJRbhXMsvZj/TxFgDThE2iSepFVp52LO2RhyZxJ7rSnTohpKjFqWmtxWPEvewvIQ7Ukp1XXdyk+jOCoce6sDMwHhwRg6Lv/AIMBIL2C/vFy4Qi7cOFj72TMuXNIfg8MBlw7KNN3u/NFeFPWGdJhPG+iHB1Ilrk/DepAuZVK6yCXJjM8P9Ix/Y+gpNx9bNbRyyljdjVKdunAucvMKB7ac8hsBYoVwPYB6R4MR7JlUftf3cBfkrriU+UnPn2rU0kjVKvJ0OJl119vkvJYhbtpPMYr0K0dztBGwaMFPvqnMAYwiK3MM9E1YUB4tHV9fMfH7UF4RivkumjXqadK856QVaf4kTPGLD/0WdzxQBxFjO6v7sLnlewaxbAVzQGxYxP9Y+PabcqwsDUfXGKOE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0cde0ba2-f372-4c58-8271-08d7f71845d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 08:33:11.7930 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wYHyKizVWvhisIAI65OsDi3l+8TWaR9atcr9RK75X26mEJSyvMrhoGtEQi87qBAXpalZt6MHSYqZRREhkg4f0HdGruM0/zzEnWUqaMS30W0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4193 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob. Thanks for this longer explanation. I think can remove the test as intended. Acked-by: Adam Dybkowski Adam=20 > -----Original Message----- > From: Anoob Joseph > Sent: Tuesday, 12 May, 2020 15:27 > To: Dybkowski, AdamX ; Akhil Goyal > ; Doherty, Declan > Cc: Narayana Prasad Raju Athreya ; Ankur Dwivedi > ; De Lara Guarch, Pablo > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported > descriptors >=20 > Hi Adam, >=20 > The crypto library doesn't specify an upper limit for the nb_descriptors = to be > passed for queue_pair_setup. So technically all the values that you have > passed as invalid is not correct. >=20 > I did check few PMDs when I saw this issue with OCTEON TX2 crypto PMD. > QAT support max 4096 descriptors and so the invalids that is present is > exactly following that. I checked DPAA drivers, but in that the entire co= nf is > left unused. So I'm not sure whether DPAA passes these cases. I couldn't > check the entire list that you have mentioned. But it doesn't much sense = for > s/w PMDs to limit max_nb_descriptors. >=20 > If we need to have an invalid check, we should probably add > max_nb_descriptors in dev_info. And then we can have these tests. I'm ope= n > for that idea also. But I don't know whether that is allowed now or not. = I > leave that to Akhil. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Dybkowski, AdamX > > Sent: Tuesday, May 12, 2020 6:37 PM > > To: Anoob Joseph ; Akhil Goyal > > ; Doherty, Declan > > Cc: Narayana Prasad Raju Athreya ; Ankur > Dwivedi > > ; De Lara Guarch, Pablo > > ; dev@dpdk.org > > Subject: [EXT] RE: [dpdk-dev] [PATCH] test/crypto: remove tests for > > unsupported descriptors > > > > External Email > > > > ---------------------------------------------------------------------- > > Hi Anoob. > > > > What's wrong with this test? Is this unit test failing on any PMD now? > > I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, > > SCHEDULER) and it passes everywhere. Then why should we remove it > > completely? > > > > Adam > > > > > -----Original Message----- > > > From: dev On Behalf Of Anoob Joseph > > > Sent: Tuesday, 12 May, 2020 09:12 > > > To: Akhil Goyal ; Doherty, Declan > > > > > > Cc: Anoob Joseph ; Narayana Prasad > > > ; Ankur Dwivedi ; De > > > Lara Guarch, Pablo ; dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH] test/crypto: remove tests for > > > unsupported descriptors > > > > > > Cryptodev doesn't limit the number of descriptors that can be > > > supported by the PMD. > > > > > > Signed-off-by: Anoob Joseph > > > --- > > > app/test/test_cryptodev.c | 45 > > > --------------------------------------------- > > > 1 file changed, 45 deletions(-) > > > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > > index > > > c624018..1ed2df8 100644 > > > --- a/app/test/test_cryptodev.c > > > +++ b/app/test/test_cryptodev.c > > > @@ -891,36 +891,6 @@ test_queue_pair_descriptor_setup(void) > > > ts_params->valid_devs[0]); > > > } > > > > > > - /* invalid number of descriptors - max supported + 2 */ > > > - qp_conf.nb_descriptors =3D MAX_NUM_OPS_INFLIGHT + 2; > > > - > > > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) = { > > > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > > > - ts_params->valid_devs[0], qp_id, &qp_conf, > > > - rte_cryptodev_socket_id( > > > - ts_params->valid_devs[0])), > > > - "Unexpectedly passed test for " > > > - "rte_cryptodev_queue_pair_setup:" > > > - "num_inflights %u on qp %u on cryptodev > > > %u", > > > - qp_conf.nb_descriptors, qp_id, > > > - ts_params->valid_devs[0]); > > > - } > > > - > > > - /* invalid number of descriptors - max value of parameter */ > > > - qp_conf.nb_descriptors =3D UINT32_MAX-1; > > > - > > > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) = { > > > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > > > - ts_params->valid_devs[0], qp_id, &qp_conf, > > > - rte_cryptodev_socket_id( > > > - ts_params->valid_devs[0])), > > > - "Unexpectedly passed test for " > > > - "rte_cryptodev_queue_pair_setup:" > > > - "num_inflights %u on qp %u on cryptodev > > > %u", > > > - qp_conf.nb_descriptors, qp_id, > > > - ts_params->valid_devs[0]); > > > - } > > > - > > > qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT; > > > > > > for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) = { > > > @@ -935,21 +905,6 @@ test_queue_pair_descriptor_setup(void) > > > ts_params->valid_devs[0]); > > > } > > > > > > - /* invalid number of descriptors - max supported + 1 */ > > > - qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT + 1; > > > - > > > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) = { > > > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > > > - ts_params->valid_devs[0], qp_id, &qp_conf, > > > - rte_cryptodev_socket_id( > > > - ts_params->valid_devs[0])), > > > - "Unexpectedly passed test for " > > > - "rte_cryptodev_queue_pair_setup:" > > > - "num_inflights %u on qp %u on cryptodev > > > %u", > > > - qp_conf.nb_descriptors, qp_id, > > > - ts_params->valid_devs[0]); > > > - } > > > - > > > /* test invalid queue pair id */ > > > qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT; > > > /*valid */ > > > > > > -- > > > 2.7.4