DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dybkowski, AdamX" <adamx.dybkowski@intel.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Trahe, Fiona" <fiona.trahe@intel.com>,
	"Akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Cc: nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker
Date: Mon, 28 Sep 2020 10:17:59 +0000
Message-ID: <BY5PR11MB3910CB51057FF24D7747D525ED350@BY5PR11MB3910.namprd11.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0802MB2351C5B872E6286C0AD8BDE59E350@VI1PR0802MB2351.eurprd08.prod.outlook.com>

> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Sent: Monday, 28 September, 2020 04:50
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; dev@dpdk.org;
> Trahe, Fiona <fiona.trahe@intel.com>; Akhil.goyal@nxp.com; Zhang, Roy
> Fan <roy.fan.zhang@intel.com>
> Cc: nd <nd@arm.com>
> Subject: RE: [dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Adam Dybkowski
> > Sent: Wednesday, August 26, 2020 11:34 PM
> > To: dev@dpdk.org; fiona.trahe@intel.com; Akhil.goyal@nxp.com;
> > roy.fan.zhang@intel.com
> > Cc: Adam Dybkowski <adamx.dybkowski@intel.com>
> > Subject: [dpdk-dev] [PATCH] crypto/scheduler: rename slave to worker
> >
> > This patch replaces the usage of the word 'slave' with more
> > appropriate word 'worker' in QAT PMD and Scheduler PMD as well as in
> > their docs. Also the test app was modified to use the new wording.
> >
> > The Scheduler PMD's public API was modified according to the previous
> > deprecation notice:
> > rte_cryptodev_scheduler_slave_attach is now called
> > rte_cryptodev_scheduler_worker_attach,
> > rte_cryptodev_scheduler_slave_detach is
> > rte_cryptodev_scheduler_worker_detach,
> > rte_cryptodev_scheduler_slaves_get is
> > rte_cryptodev_scheduler_workers_get.
> >
> > Also, the configuration value
> > RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES
> > was renamed to RTE_CRYPTODEV_SCHEDULER_MAX_NB_WORKERS.
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > ---
> >  app/test-crypto-perf/main.c                   |   2 +-
> >  app/test/test_cryptodev.c                     |  20 +-
> >  doc/guides/cryptodevs/qat.rst                 |   2 +-
> >  doc/guides/cryptodevs/scheduler.rst           |  40 ++--
> >  doc/guides/rel_notes/deprecation.rst          |   2 +-
> >  .../scheduler/rte_cryptodev_scheduler.c       | 114 +++++-----
> >  .../scheduler/rte_cryptodev_scheduler.h       |  35 ++-
> >  .../rte_cryptodev_scheduler_operations.h      |  12 +-
> >  .../rte_pmd_crypto_scheduler_version.map      |   6 +-
> >  drivers/crypto/scheduler/scheduler_failover.c |  83 +++----
> >  .../crypto/scheduler/scheduler_multicore.c    |  54 ++---
> >  .../scheduler/scheduler_pkt_size_distr.c      | 142 ++++++------
> >  drivers/crypto/scheduler/scheduler_pmd.c      |  54 ++---
> >  drivers/crypto/scheduler/scheduler_pmd_ops.c  | 204
> > +++++++++---------  .../crypto/scheduler/scheduler_pmd_private.h  |  12 +-
> >  .../crypto/scheduler/scheduler_roundrobin.c   |  87 ++++----
> >  examples/l2fwd-crypto/main.c                  |   6 +-
> >  17 files changed, 439 insertions(+), 436 deletions(-)
> >
> 
> <snip>
> 
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 345c38d5b..24d58060f 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -341,4 +341,4 @@ Deprecation Notices
> >  * dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> >    ``make``. Given environments are too much variables for such a
> > simple script,
> >    it will be removed in DPDK 20.11.
> > -  Some useful parts may be converted into specific scripts.
> > +  Some useful parts may be converted into specific scripts.
> > \ No newline at end of file
> 
> This is not intended modification.
> What should be deleted is section 'scheduler'.
> And release note 20.11 needs update to indicate the API replacement.
> 
> Thanks.
> Ruifeng

[Adam] OK, thanks for spotting this unintended modification.
I'll send the next version together with release notes update later this week.

Adam Dybkowski


  reply	other threads:[~2020-09-28 10:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 15:34 Adam Dybkowski
2020-08-27 15:18 ` Zhang, Roy Fan
2020-09-28  2:49 ` Ruifeng Wang
2020-09-28 10:17   ` Dybkowski, AdamX [this message]
2020-09-28 14:16 ` [dpdk-dev] [PATCH v2 0/1] " Adam Dybkowski
2020-09-28 14:16   ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
2020-09-28 15:12     ` Ruifeng Wang
2020-10-06 20:49       ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB3910CB51057FF24D7747D525ED350@BY5PR11MB3910.namprd11.prod.outlook.com \
    --to=adamx.dybkowski@intel.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=nd@arm.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git