From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67DD6A0093; Tue, 19 May 2020 12:11:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7ACE91D404; Tue, 19 May 2020 12:11:46 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 58E801D176; Tue, 19 May 2020 12:11:44 +0200 (CEST) IronPort-SDR: NEZVA2xtgQXhn4XomT/HwABf2HQdP0rqb/bVNJvCdP0274mrchHkjN6sVQXyzmahMY4/rrebDs o3dKbGI8xm2g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 03:11:42 -0700 IronPort-SDR: iK9arI89Uxr1LDSNGPQ8EaRpqJP1OWm6tn9LhDx2BweLp2Q2VwOrN4NNpd6IdfYNPYOKafSd1l 444M6/9QC2Fg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,409,1583222400"; d="scan'208";a="288907475" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 19 May 2020 03:11:42 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 03:11:42 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 May 2020 03:11:39 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 19 May 2020 03:11:39 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 03:11:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sfy2CTK0t1rkyGRx0TeDNNBSz6ugM9Z3U8F4fCGm466HyJDwfxik2+aAgSB/DO3TLEQxOb0DK0YbRLcLO417Z/ik9M8AxzGPo2EPzPVED/DtUClgm8pueBMkegEGERE4nBmfTTMvK/XUc1M5LXSthYOSaZd94TtqdwhyIwPPSZPJRgwOFdd7morlFfftCe0fAl+Q2ntqO/R7WpyLZaLH0D1Xz4mH8phvI78ccQi2LKq7/YC9X8B6I2VHuuurnuRCItV7CX6McK+aYrCioFMt2Hv7lcg88jdn8JxgZDJPcHytqDCm5fVf/UVb1al14FWqTFZiS5T+5DWQ9Ros0/UrWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8QvTB+tamEg19sK661iRzg4TK1DkqoUh/VNy6ASFLeM=; b=eXncNjVnps3YpZuqwYxxJkfpvVAgqwn4uTtG+5bmGtEGT1dsxTILq7tff/7ICsxE4G2t2ao+lX5uzzGvfFFdZMNVfXCCZeDo7CJp4OXiSg52MjNa9zgIP8LIfsaXRgVYuRk0aXz7nN1hLWOSGAVpzErFEP2PKAWkwKeZLQ4fM3RFc8o9vHTwKK8UeIm0AqGeDMs3Hz4hRY0OGTyU2eNnF+SQ9zMwsZF8L02RRuvsMRiHe1YAcDeGIrBAkhCpBj1RCX83ZJf2qqurSPpbfRAXk1Rm8jnX8YO408qsYVXECYRRvikGu6AQ0bGp0zPz7yIzUoWg8lahN+Ax2gYLp61sQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8QvTB+tamEg19sK661iRzg4TK1DkqoUh/VNy6ASFLeM=; b=gblw5kxZIri1rAJYc312TfahBF+Za8UgP1upcf/8iqsvnAGQ+T9POgAdfqdbZGSUurG3PZpXBidILi5wKm4zIQ1WiC1ZwoVhTfN4L2eIfV71C8WVnPS7dFqUl2GOE6nc151cb5dcIyVjil7K7j3jhVUzRgurNa0/WGH6cSI48bs= Received: from BY5PR11MB3910.namprd11.prod.outlook.com (2603:10b6:a03:185::13) by BY5PR11MB4417.namprd11.prod.outlook.com (2603:10b6:a03:1c0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Tue, 19 May 2020 10:11:35 +0000 Received: from BY5PR11MB3910.namprd11.prod.outlook.com ([fe80::ad60:fbb0:b236:3679]) by BY5PR11MB3910.namprd11.prod.outlook.com ([fe80::ad60:fbb0:b236:3679%6]) with mapi id 15.20.3000.034; Tue, 19 May 2020 10:11:35 +0000 From: "Dybkowski, AdamX" To: Anoob Joseph , "dev@dpdk.org" , "Trahe, Fiona" , "akhil.goyal@nxp.com" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment Thread-Index: AQHWLSJA9WVDZ3fDfU2N/A1hQlliZKiu6YiAgAA79nCAAANNgIAABtKQ Date: Tue, 19 May 2020 10:11:35 +0000 Message-ID: References: <20200518142342.1987-1-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [79.184.238.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8770439f-a0f5-4c3a-0748-08d7fbdd0342 x-ms-traffictypediagnostic: BY5PR11MB4417: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 040866B734 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IVB0ozq69evxzO7+FZqeyFvmuwItj6d5pkBas+QD4tCxyJNWDRzNDpTck2/ZJOy/5svOZSo4tpiluhEN7FM/FCKSao1UVujc1e781s5/+rca7cNwMn95RVHZhi4QZnj0npXe1P6RNhM53VmShraZTPfdCPejr40z3/BgmC8zl2mAofEUUx5ONjMzHVw1+csZIzTW0LXLPbsjT07wYHIVLvwtE+OKHNGgrhCX3/M2T7qyno5W4h+M4ZoFe+3UqFa6e2ypNzxGRGUeWydlZXbyFwuEAUl3WVOTmhv+6dnW0ATdgH5sm6ZZgwUoDpFvrhI8GVWmreDZaKt9zedoVYoj243B1sWGPVbFNpnEUnyVLTZ6rozWpy33HgG0YAdpIZcehTtz8wouRgOYM7YiXvy/ssHRUe8QBtZw+36fn6/dCoftSkwgfULGR+EoRMnRS38c07xqsF9qqeoQKIhX88jCtJJnzeLRHX6VBAPGCznSy2WIQgfFSjKh7vB3zX7LzMjKQUibF93bE6IG5v0dQXkkmg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3910.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(136003)(396003)(366004)(376002)(346002)(71200400001)(478600001)(110136005)(7696005)(53546011)(6506007)(316002)(4326008)(33656002)(26005)(52536014)(5660300002)(2906002)(8936002)(186003)(8676002)(9686003)(66446008)(66946007)(76116006)(86362001)(55016002)(66476007)(64756008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: aHA+EfONyGT7bFFIArA4TBF8hIORxrsEdUTBAIpI1ehun+nOXLJ8wxYESHDcIKyZ8WGzQoWqrLTD1nCQp2TkCBkoFDL7Bqd32q6EimWr1HbKMIRYaDSIcA5ovh3kQhMeMXLV6ib+UTqv+eGaWhTBshhX6/TawwN/pMEKG5mqzN1DshxywAdgLGtx6QpKUzoJjQf/RQzCYVC8rm6F3aERm56yJRJ7u6CDwiFS/dcC086wC+5KrrVxK7lV3v86ydShriRk1bikI2aJprTgPKHAY1jwT2y/qSYtSa1J908RO4xp4Tq1m6/oKWFIf+/PDKmTK+o+BGlcEpZL8k4/9juV+WzL0OELJ4NwPTH1vC2IDE/TzOiMQwKcRR2gRsykV4ET3/Q5xPeeDGzIIjaYYt3tEXBacFG4rtPSrY2Dv6Wx38ct3XnSjYUqLnPCmJNd4avM/kYQwxKr0XCBqVKKIGkdZR5i+IPD8TLa9E9oLMY3RDg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8770439f-a0f5-4c3a-0748-08d7fbdd0342 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 10:11:35.5738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V7psviPqkbCNIZB7uocT7fEpDQmsw3wYVkO8gZPwYDJ1AStb9XFvqrJX1P5Eekl89V7qyAJ3YLCICitQIN//BSjHU5LABMQ7CZ7SVom02RE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4417 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Anoob Joseph > Sent: Tuesday, 19 May, 2020 11:40 > To: Dybkowski, AdamX ; dev@dpdk.org; > Trahe, Fiona ; akhil.goyal@nxp.com > Cc: stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment >=20 > Hi Adam, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Dybkowski, AdamX > > Sent: Tuesday, May 19, 2020 3:01 PM > > To: Anoob Joseph ; dev@dpdk.org; Trahe, Fiona > > ; akhil.goyal@nxp.com > > Cc: stable@dpdk.org > > Subject: [EXT] RE: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum > > comment > > > > External Email > > > > ---------------------------------------------------------------------- > > Hi. > > My answer below. > > > > Adam > > > > > -----Original Message----- > > > From: Anoob Joseph > > > Sent: Tuesday, 19 May, 2020 07:54 > > > To: Dybkowski, AdamX ; dev@dpdk.org; > > > Trahe, Fiona ; akhil.goyal@nxp.com > > > Cc: stable@dpdk.org > > > Subject: RE: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum > > > comment > > > > > > Hi Adam, Akhil, > > > > > > Please see inline. > > > > > > Thanks, > > > Anoob > > > > > > > -----Original Message----- > > > > From: dev On Behalf Of Adam Dybkowski > > > > Sent: Monday, May 18, 2020 7:54 PM > > > > To: dev@dpdk.org; fiona.trahe@intel.com; akhil.goyal@nxp.com > > > > Cc: Adam Dybkowski ; stable@dpdk.org > > > > Subject: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum > > > > comment > > > > > > > > This patch fixes improper SHA-1 digest size in the enum comment. > > > > > > > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Adam Dybkowski > > > > --- > > > > lib/librte_cryptodev/rte_crypto_sym.h | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > > > > b/lib/librte_cryptodev/rte_crypto_sym.h > > > > index d9585ecd6..9cea4e5f0 100644 > > > > --- a/lib/librte_cryptodev/rte_crypto_sym.h > > > > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > > > > @@ -269,9 +269,9 @@ enum rte_crypto_auth_algorithm { > > > > /**< HMAC using MD5 algorithm */ > > > > > > > > RTE_CRYPTO_AUTH_SHA1, > > > > - /**< 128 bit SHA algorithm. */ > > > > + /**< 160 bit SHA algorithm. */ > > > > RTE_CRYPTO_AUTH_SHA1_HMAC, > > > > - /**< HMAC using 128 bit SHA algorithm. */ > > > > + /**< HMAC using 160 bit SHA algorithm. */ > > > > > > [Anoob] This raises one interesting question. Is HMAC-SHA-1-96 > > > (https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__tools.ietf.or= g > > > _h > > > > > > tml_rfc2404&d=3DDwIFAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DjPfB8rwwviRSxyL > Ws2 > > n6B- > > > WYLn1v9SyTMrT5EQqh2TU&m=3DpgqB2BfFosCF_7l1SdoodgXcipf7G1ofht68ZK > Mt > > oW0&s=3DhxzUN2QfRJGaR7NQ7VKGm5oQvOZez6Z70mqOyg7gKTY&e=3D ) > treated as a > > separate algorithm or is it a digest size variant of > > RTE_CRYPTO_AUTH_SHA1_HMAC? I assume the later. > > > > [Adam] DPDK doesn't have separate enums for such variations. According > > to RFC 2104, chapter "5. Truncated output", the calculation of > > HMAC-SHA-1-96 is done using ordinary HMAC-SHA-1, but the calculation > > result is then truncated to 96 bits, or any other digest size provided = in auth > xform. >=20 > [Anoob] So it is allowed to support digest sizes 12 & 20, right? Can you > update the above comment in that case? [Adam] This depends on a particular PMD and its capabilities so we cannot w= rite here in this public header file. For example, have a look in the capab= ilities structure of QAT PMD: { /* SHA1 */ \ .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, \ {.sym =3D { \ .xform_type =3D RTE_CRYPTO_SYM_XFORM_AUTH, \ {.auth =3D { \ .algo =3D RTE_CRYPTO_AUTH_SHA1, \ .block_size =3D 64, \ .key_size =3D { \ .min =3D 0, \ .max =3D 0, \ .increment =3D 0 \ }, \ .digest_size =3D { \ .min =3D 1, \ .max =3D 20, \ .increment =3D 1 \ }, \ .iv_size =3D { 0 } \ }, } \ }, } \ }, \ It shows QAT PMD is able to truncate the output digest to any size from 1 t= o 20 bytes (160 bits). This can be different in other PMDs, for example OpenSSL and CCP PMDs allow= only 20-byte digests here while Marvell MVSAM allows 12-20 bytes. Adam