From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E01FAA04A2; Tue, 12 May 2020 15:07:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 279011BF9C; Tue, 12 May 2020 15:07:23 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C207C1BF93 for ; Tue, 12 May 2020 15:07:21 +0200 (CEST) IronPort-SDR: IuwEdI1euds0otlsh57sq0l8/dYIAfn09BjIjk4XpD9DO3xSdisdUfZOESNr1zm60IXyJBqLa/ ImwVEKTptXIw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 06:07:19 -0700 IronPort-SDR: kBS6imYyiq6P2Y6ZVrMHILYjhyOfgZx27z9YPV3IDVm2Dc1mmluXWXseigZhlZcN/UgtsO/4YH qLhz5j8QRmpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,383,1583222400"; d="scan'208";a="340896035" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga001.jf.intel.com with ESMTP; 12 May 2020 06:07:19 -0700 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 06:07:19 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX157.amr.corp.intel.com (10.22.240.23) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 06:07:18 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 06:07:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J0r2SDztEATCpmbmzAerpHrm6oQRrDzijxsTguL3eG8yJdAP+SHFEIfoy0QM+3QBndMON2RppbuujKXPVOf5P8ooKT9iFrGqwGapMMABeUdNpv5MOWKVX+9UvqYAvit7QViuD/4MEtjwdJbBQbXuNwuRRMrUqjLv2zMMWj1sXCr1DWJE9XlJK9ikvNerEL/MMAcfQpcctsmN6AExc+k6QjZ4wEMzXHSidP1K7iyYe26THxrlgIV4f3dxGCJcPi5HLk5NAzZFy7t1aQcfSdFmo7Tim7YEaGyrCJw0ziaitMYjM2revH9AeifEFSMi+jXIXAteJdO8AxjKJGJ/VMbiVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sDAGCfwY15XX1pW1atvzI6csydaA67sCIXoKLMPYWWI=; b=iQLaaACirnDjhkGwq+GiS7rC03FqIQ4NYypFy5CyBu6vUfYl4eFgXEPY72WRbvPhh5qtJqejUsCK8jWQEJZKRf4Bqi1N18pECF3GaVMHGzsaeCnNqfzbTTvzkk163ShGbBbX/Q57EZhweZFljTGof7N3Q57/Igf0tKwgz0/dqdu15Jmq77ZTPN6zcnU2+gDNZGTRG2NwvbtSoVLxocL6oJNsDPN5hDDBhzd48w7jCd0ajTMWUvIkH3dLfIskUVbKP7gt3HQmJ+RXyJl5ewjKC2eO1w7kdkcnsG7YMI/Rf50CbwKlRCSmGd3rWYy0FNOnRUyxDKfa62kSGPb9TWC24w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sDAGCfwY15XX1pW1atvzI6csydaA67sCIXoKLMPYWWI=; b=aorFWd1e7SsSx/oJwk+ZL+WFKhq+hvtwSNolY8zkrV/b/91f6AF+CpghhQlMDi2dCcqjc031OeozODfAXxVqLgjNneKN9lQZBC90lKf3q9SIDAtODLMc66s+GEHnp07+owglpty1cWjgJUVbK5EbZRbYx/52DYQFKqswHCt8ViI= Received: from BY5PR11MB3910.namprd11.prod.outlook.com (2603:10b6:a03:185::13) by BY5PR11MB4273.namprd11.prod.outlook.com (2603:10b6:a03:1c9::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Tue, 12 May 2020 13:07:17 +0000 Received: from BY5PR11MB3910.namprd11.prod.outlook.com ([fe80::ad60:fbb0:b236:3679]) by BY5PR11MB3910.namprd11.prod.outlook.com ([fe80::ad60:fbb0:b236:3679%6]) with mapi id 15.20.2979.033; Tue, 12 May 2020 13:07:17 +0000 From: "Dybkowski, AdamX" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" CC: Narayana Prasad , Ankur Dwivedi , "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors Thread-Index: AQHWKCzuQsrCL2nw00ad6LKxx2EKwKika7zQ Date: Tue, 12 May 2020 13:07:17 +0000 Message-ID: References: <1589267544-18134-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1589267544-18134-1-git-send-email-anoobj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [79.184.238.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5c63f0b-10c5-477d-dc4c-08d7f67565b8 x-ms-traffictypediagnostic: BY5PR11MB4273: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mtyvjMX9ZTuZxqgykp6gWS860/gH0YO2k6BhWVfzkLvzJBEz9RoyprIsNO4GVa+kL7DYbpqqvrvHfHuEogwCYNxHhHIdbWngOH5KWSXnjWQr+NIzWGn41qMN5L+8z8ZPAyVED8DREGtpDNFxd9MnfnyyHN7XEfr/g/1z5SNhzSWfUgc534IriKdhsPe5yMgO4kV/zaE8F4NdyFsMhr/JqUxbCBE7pfGYDQGKR0UCBBP7UAjfubKT5/aY3inYEqQmOd+JnAUojLbLq8RkJqmls6fSMUVLYcEPNLlF6iWtSGh05gh1XKMlNp31pHTTOwCg6FaSrzzu5pRo+kGCAfheo/zl4vsN0ymBt0bSKLg84ylc5vSzyHR3OgAlD/NxwVzu/R+tTYSw5FsNO8Oraxl/kZvQy/ZyLfXuoECRRLkbxDNKF5jmxmkDAcuvjOBEsiBJrZwf6pZZWCfRF+xwejQ5H+i/86J9KWHrnuB7XVfFxYaSjmJfe6cRBqsrNi3Cak0MZfRneID93v2J8j1gSUwLPg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3910.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(366004)(376002)(346002)(396003)(136003)(33430700001)(55016002)(9686003)(6506007)(53546011)(54906003)(110136005)(316002)(26005)(186003)(5660300002)(33656002)(86362001)(2906002)(7696005)(33440700001)(71200400001)(478600001)(4326008)(8936002)(66946007)(66446008)(66556008)(64756008)(76116006)(6636002)(66476007)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: VF2l4TmDgfkUr97374Naart9aFWB05YsxhORFtVnhXpY6WeFm+mhWlnl5EwVRGdLaIvo6jkCHyNn+tb3RFm9iJljx61J8fr3RqGdSADiU2RtrME8/3RV6gw+SajllNO0baMCWIemWUjLje1022OzBCRDxlvHZTahAVhh0X1jryEvi9WCE+JQndXQwH0FYpW/zT2LFTWyFnKfpTnWbFRvsw1DLvS3cO38APnevH8vqXgR5zhhcWlezPXikbswDO7rHTcLxm5YuuAO9Qqk7OqzaC0bCRHaqPFR+2QuqlcknxUh8pQjdjk5xUuLP28AUW+v3QoKXxUGSIVepbRkHdiFWTcgxr9k8sEKXuSiPN12kwhx/fdIgg14aH5mNODakTff25GQjm40JdJ/RcQfGpL9d7giYS1V8Tzu3JXzGcUz5M2SLmrEsCF4wp0AJycLlnlM4E+0i6SXtotEMtkQ9lCUinapYyjkIgY8BBhD1SQFNCE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c5c63f0b-10c5-477d-dc4c-08d7f67565b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 13:07:17.1157 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h4s9rz10LqTfOYvZP8p3y/x4p7yoQZwgTmkz7QiOzpvRyqSv6yp2Xf06rNiqJIweUXfoK9sbDbrTUxskk896hxUiyrwnQ+T0zZczAUetlyI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4273 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob. What's wrong with this test? Is this unit test failing on any PMD now? I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, SCHEDU= LER) and it passes everywhere. Then why should we remove it completely? Adam > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Tuesday, 12 May, 2020 09:12 > To: Akhil Goyal ; Doherty, Declan > > Cc: Anoob Joseph ; Narayana Prasad > ; Ankur Dwivedi ; De Lara > Guarch, Pablo ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported > descriptors >=20 > Cryptodev doesn't limit the number of descriptors that can be supported b= y > the PMD. >=20 > Signed-off-by: Anoob Joseph > --- > app/test/test_cryptodev.c | 45 -----------------------------------------= ---- > 1 file changed, 45 deletions(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > c624018..1ed2df8 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -891,36 +891,6 @@ test_queue_pair_descriptor_setup(void) > ts_params->valid_devs[0]); > } >=20 > - /* invalid number of descriptors - max supported + 2 */ > - qp_conf.nb_descriptors =3D MAX_NUM_OPS_INFLIGHT + 2; > - > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > - ts_params->valid_devs[0], qp_id, &qp_conf, > - rte_cryptodev_socket_id( > - ts_params->valid_devs[0])), > - "Unexpectedly passed test for " > - "rte_cryptodev_queue_pair_setup:" > - "num_inflights %u on qp %u on cryptodev > %u", > - qp_conf.nb_descriptors, qp_id, > - ts_params->valid_devs[0]); > - } > - > - /* invalid number of descriptors - max value of parameter */ > - qp_conf.nb_descriptors =3D UINT32_MAX-1; > - > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > - ts_params->valid_devs[0], qp_id, &qp_conf, > - rte_cryptodev_socket_id( > - ts_params->valid_devs[0])), > - "Unexpectedly passed test for " > - "rte_cryptodev_queue_pair_setup:" > - "num_inflights %u on qp %u on cryptodev > %u", > - qp_conf.nb_descriptors, qp_id, > - ts_params->valid_devs[0]); > - } > - > qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT; >=20 > for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > @@ -935,21 +905,6 @@ test_queue_pair_descriptor_setup(void) > ts_params->valid_devs[0]); > } >=20 > - /* invalid number of descriptors - max supported + 1 */ > - qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT + 1; > - > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > - ts_params->valid_devs[0], qp_id, &qp_conf, > - rte_cryptodev_socket_id( > - ts_params->valid_devs[0])), > - "Unexpectedly passed test for " > - "rte_cryptodev_queue_pair_setup:" > - "num_inflights %u on qp %u on cryptodev > %u", > - qp_conf.nb_descriptors, qp_id, > - ts_params->valid_devs[0]); > - } > - > /* test invalid queue pair id */ > qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT; > /*valid */ >=20 > -- > 2.7.4