DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"matan@mellanox.com" <matan@mellanox.com>,
	"Zawadzki, Tomasz" <tomasz.zawadzki@intel.com>,
	"Liu, Changpeng" <changpeng.liu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: fix external backends readiness
Date: Mon, 28 Sep 2020 10:55:10 +0000	[thread overview]
Message-ID: <BY5PR11MB4055511447515CAF7E30B9909C350@BY5PR11MB4055.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200923094902.216856-1-maxime.coquelin@redhat.com>


> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, September 23, 2020 5:49 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; matan@mellanox.com;
> Zawadzki, Tomasz <tomasz.zawadzki@intel.com>; Liu, Changpeng
> <changpeng.liu@intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] vhost: fix external backends readiness
> 
> Commit d0fcc38f5fa4 ("vhost: improve device readiness notifications")
> makes the assumption that every Virtio devices are considered
> ready for preocessing as soon as first queue pair is configured
> and enabled.
> 
> While this is true for Virtio-net, it isn't for Virtio-scsi
> and Virtio-blk.
> 
> This patch fixes this by only making this assumption for
> the builtin Virtio-net backend, and restores back to previous
> behaviour for other backends.
> 
> Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications")
> 
> Reported-by: Changpeng Liu <changpeng.liu@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
> ---
>  lib/librte_vhost/vhost_user.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index 501218e192..b00e1f91dc 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -1343,21 +1343,28 @@ vq_is_ready(struct virtio_net *dev, struct
> vhost_virtqueue *vq)
>  	       vq->enabled;
>  }
> 
> -#define VIRTIO_DEV_NUM_VQS_TO_BE_READY 2u
> +#define VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY 2u
> 
>  static int
>  virtio_is_ready(struct virtio_net *dev)
>  {
>  	struct vhost_virtqueue *vq;
> -	uint32_t i;
> +	uint32_t i, nr_vring = dev->nr_vring;
> 
>  	if (dev->flags & VIRTIO_DEV_READY)
>  		return 1;
> 
> -	if (dev->nr_vring < VIRTIO_DEV_NUM_VQS_TO_BE_READY)
> +	if (!dev->nr_vring)
>  		return 0;
> 
> -	for (i = 0; i < VIRTIO_DEV_NUM_VQS_TO_BE_READY; i++) {
> +	if (dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET) {
> +		nr_vring = VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY;
> +
> +		if (dev->nr_vring < nr_vring)
> +			return 0;
> +	}
> +
> +	for (i = 0; i < nr_vring; i++) {
>  		vq = dev->virtqueue[i];
> 
>  		if (!vq_is_ready(dev, vq))
> --
> 2.26.2

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

  reply	other threads:[~2020-09-28 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  9:49 Maxime Coquelin
2020-09-28 10:55 ` Xia, Chenbo [this message]
2020-09-28 15:19   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB4055511447515CAF7E30B9909C350@BY5PR11MB4055.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=changpeng.liu@intel.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=tomasz.zawadzki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).