From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C2CDA0A0C; Mon, 17 May 2021 19:53:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9AFA4014E; Mon, 17 May 2021 19:53:17 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 1618F40041 for ; Mon, 17 May 2021 19:53:15 +0200 (CEST) IronPort-SDR: 2Q6Re3d5XuJzHtEEWnUYh5xVOtex48eE9l6WHDAo3//b8Bn4ywCt/QYwJx+3Xmm+QvWUpe5raK yh3NiaExjBlA== X-IronPort-AV: E=McAfee;i="6200,9189,9987"; a="221568133" X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="221568133" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2021 10:53:15 -0700 IronPort-SDR: rMWC8wTGTv/tlHz2W9O1Velj7WwfIZ9zQcFJjejvZ2ElS4CsFn2JrUpzm3Ge6P9zSENhr/7AdJ t7B1mEs4ccKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="438239977" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 17 May 2021 10:53:14 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 17 May 2021 10:53:14 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 17 May 2021 10:53:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 17 May 2021 10:53:14 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 17 May 2021 10:53:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ntk23qmhcOzisL0F+KX4VWjhad5wd/pGYDKyzL21ANTjMOiaFqBBL6uWwegqP8vy9Tp5GOnaciNRNgrkgqQu+PPlkduKYJUAHXbUw5j2pASkDHYu3XRX4F8qze9KN27x4we9sHZW/qJdi3XI2VsxAXmHm49mdWS7xlwLeOzFzABbViU4EUMbxzk2Lzm7l6gDquVzmCR8kiBNN3zt8w9Sm1UmDM4256zMkalclJ8dLauNiXF68d3ZNDlp8SyDSKl8hLl3pHzHFLaxvPdUkL1s4BbjHnwj20bhG1CshTNlzQs3x7pPPvANLwz2rLio5LzEShtICkQ7Rd3ctiC+p7bmaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QbX5qVRQKuYHKifcqvYodY6LCe9YiVNyqQzMjYbNMjo=; b=F4GYj4yzqTox7r46PTzwV54zaPjQnRilQhlEsUhNwYb5PdbgFUOONQWxTRc8I3tA6dyYipRj+Zx4kjUGvynWl+VRdkkLQvpPYpWv5SBPj9UVb2Tg/2H+VqQY1c19mqVkaCagf6rMZMsD7tkVB0hzpwq1Xt+c/eW2gMsuBeEoc+QdWNCMPihQmPDdULnVaqAVc0+AcVcYHzxiV8QZno8ooic+GxbNjUgSOwF/I8b8XO4RPfSix1+ZeCNLY3XdGd7he6hFXtZf7PKe1UQEJ2mBqaw7NI5RptmQRmhOexlzjHl1a7Jm0+cNEi63mgJItAJ3peGWGgB7S4vqcNMnJZKkeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QbX5qVRQKuYHKifcqvYodY6LCe9YiVNyqQzMjYbNMjo=; b=qjapeyQENXHiU57LdYeODxdM2Qu3JkEC3aksQCr47ri1ZOQ5vrZb5S2MeCCjf5XELcY5VYf4TJByn4RkOM28J+0nNP70b4blN+QGfoKmz3m62GHYe1tax4+370/wIlzTTyyHQ/9NjTiYlBV9cKfcM45PVzbnj9LdRl17cKut2JQ= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BY5PR11MB3879.namprd11.prod.outlook.com (2603:10b6:a03:18f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Mon, 17 May 2021 17:53:11 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::ad33:b78f:9018:af82]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::ad33:b78f:9018:af82%3]) with mapi id 15.20.4129.031; Mon, 17 May 2021 17:53:11 +0000 From: "Chautru, Nicolas" To: Nipun Gupta , Hemant Agrawal , "dev@dpdk.org" , "gakhil@marvell.com" CC: "david.marchand@redhat.com" Thread-Topic: [PATCH v4 5/8] baseband/la12xx: add queue and modem config support Thread-Index: AQHXOPYFBeW9VsqsV0ik8LxuhpfYtKrEOvYQgB0h0ICAAD9gwIAGbi0AgAAMNGA= Date: Mon, 17 May 2021 17:53:11 +0000 Message-ID: References: <20210413051715.26430-2-hemant.agrawal@nxp.com> <20210424103700.8098-1-hemant.agrawal@nxp.com> <20210424103700.8098-6-hemant.agrawal@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [45.28.143.88] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d24f79ba-aec6-465f-3aa1-08d9195ca302 x-ms-traffictypediagnostic: BY5PR11MB3879: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qtq8//wvCbwogJwRm26VbsIgsSLi8JoGtYblY4Rv7XeOT+ZG/gbBPVskAAas8rczCeNzQBFm4aFc1baFHmwrtRVk06LGs0szRAxpnSiyBSxMk6qzwYUemhjuw0juz98Zv59ozgtVtmEJh3NYL9Az1slEmVJ9MBNg6y78YEi8rvSbiifXQhfiGcNWa3mwtd5n442L9PddG78/jiQK/njQtB6MU5MWwMl8M3lOp29Yn0NNgXbubAg5kjN9FP2lFaFqV13gk4+k4SAIvb/OC//apAt0E6T6Z6Cdg8+J9WA1IVLcR9+oF8J5rBPLhpQbPA1P5AimcsmtM+kU4ESArOzRyZgd1vF6i1lZWQPJB1MdbPJHAYaOxzy0MKVqdNBcYdOPIuWakKemYl8xgxwX3N0EOwkx8KnhhU7AD8AXbNIFcWkXXFAFc57e8UoMX480vVzlw87mo/5uaEfLN8mKZ7HbPeY7kIdYEkqlVeKoXgGwOBIXsznqX88C5JOLMqIttiP9jFyPcRcz8YxPV8RDQKY4uXTLdAaitZcXywNt80G/mN35egEsnvET3Bwc716jRzhFqGqdLBFXQ6lVR/e1rx55yiyAGQblzDKOicnjCs8vVMo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(366004)(136003)(396003)(39860400002)(8676002)(186003)(4326008)(122000001)(38100700002)(86362001)(8936002)(55016002)(2906002)(9686003)(316002)(33656002)(26005)(71200400001)(7696005)(66446008)(64756008)(6506007)(83380400001)(76116006)(66946007)(66476007)(66556008)(53546011)(478600001)(52536014)(5660300002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?nST3DuD7q2KNbquVypS9RnsZYy7yYW1K4H7IGRLBA6fCBSoEjH0UZPeph+J/?= =?us-ascii?Q?u+A0pYJpgiSwGPJGGMyBP4wbMOs8GeWuJktgvTTbhnly27KqUfdZZqMMbmfx?= =?us-ascii?Q?BPNyq5RlW1980hpJa+eQr6sZcf+/+RD4qN/dywt4InhneRdCXQc/sq6NA4uQ?= =?us-ascii?Q?EcBfCGOSx1VN7WYozmagLGr/xJbsdc2cCcJ/1RsFBPHFjMOq16eTu9jrTV2B?= =?us-ascii?Q?YjHr05IuhWK7FQq2f4a2hS5M4xNWYa/vMFKE46TEiJvAfALl4WOp66UA4Ow0?= =?us-ascii?Q?OLkbpzrG04sjT3ITplJWFc+rbMkYYNqtAbMR8RJrEYWONh/aGPJl6Jms77ID?= =?us-ascii?Q?DqkSaP90h53z/tPCVgN1PrgcDd4+IxMwYlEnA1Xb2FC3vbqssj/zW1eqGiWg?= =?us-ascii?Q?wR8sGq5KzVloygIhSQr4+aHtntzLCPIckwFYrYryDQ/2zT7bufmADRSH67d8?= =?us-ascii?Q?QIZBoVyENA8i08jYKKDN1sJrWcvVLMPS+jS6Mxl2Zb3mKH9f2Tj6DV5HJgps?= =?us-ascii?Q?zF6A2uGyWy+an2UI+Q2AAL931kCfBCXi8RUJ9HDijY32D4jusoa9HYyFu3Cm?= =?us-ascii?Q?9VtX988MQDpOcYR76J8IXzh0zDuOf2hdEqgG8ozUPxsb5zEpyEYIVHJn9hp1?= =?us-ascii?Q?aMP0JxoKjTbiY6S9hL45qN8I2mRNTYdnluLXGO56FO/GLpBFcVSuwjWeRfw+?= =?us-ascii?Q?aEfCkK+NXwZBgq1Qz07/7G9eBaZdyWKE9zkHS6GXrravNTNaLSgA5H3zgG+T?= =?us-ascii?Q?mj18lYgMN9v/iBkseTq99FjaBSHHbCKGIz8kCGUSajMTUyOzjySvAOc0JDTx?= =?us-ascii?Q?82M+5d4SF+C0kNaqwkOsg/Pm7Ro/iZgKLdJgL6qRv910AjL3zX2Xa/dU43qT?= =?us-ascii?Q?K/DyGxpBJHBAhZpxfX1Awd6qFrSzMBHUu43JwFClVVYS0WL4j/6nv2QvEz48?= =?us-ascii?Q?/J9sbfS//VE8b4ULBXqvVO43Bq7d9p4ZzNqMZCZFGQrPM2aWAcFNmqUrj5w5?= =?us-ascii?Q?Lbt5tBFSTW0hRUID5mb+Aw8R0pOeFcjmOYs9zhw7qdGGiHIPfU9ALqhp0j76?= =?us-ascii?Q?nw/pjjkydPOJb4YVSDlH+uKRNt/1RwjVuNNFfVdY0lTSN7b3H2cxzz58N7kO?= =?us-ascii?Q?IqlRJv2xJxN/4pqwzCKMVnq3FMX7FTPYRUkvrT1OqHc4WEIaIoUsUvpgaHGW?= =?us-ascii?Q?485STD8jNqcXS8kez9+xXAL6ZiHhAVUsoPnBSV+3pF1eKfdJ9IJHD+CT8kK1?= =?us-ascii?Q?k3i7fWpjhArJSZmCCzAhcaEC/IpKyquYyJZv6iHAzH8GSpd9YSs5s4ZGgRM/?= =?us-ascii?Q?M/Yekqc6hWBcfljDVed1l8K6?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d24f79ba-aec6-465f-3aa1-08d9195ca302 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2021 17:53:11.1354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Og4HFkRW1qeWx8+46M39nTvq9T+yu31Y6OT8h6Ds+absayP5qrBham7rh56vkzxQxcrl+PNikSIRnm2xuacY1gdLxK4t53/MEgZQyetvYU4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3879 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 5/8] baseband/la12xx: add queue and modem config support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nipun Gupta > Sent: Monday, May 17, 2021 10:00 AM >=20 > Hi, >=20 > > -----Original Message----- > > From: Chautru, Nicolas > > Sent: Thursday, May 13, 2021 8:21 PM > > To: Nipun Gupta ; Hemant Agrawal > > ; dev@dpdk.org; gakhil@marvell.com > > Cc: david.marchand@redhat.com > > Subject: RE: [PATCH v4 5/8] baseband/la12xx: add queue and modem > > config support > > > > Hi Nipun, > > > > > -----Original Message----- > > > From: Nipun Gupta > > > Sent: Thursday, May 13, 2021 4:02 AM > > > To: Chautru, Nicolas ; Hemant Agrawal > > > ; dev@dpdk.org; gakhil@marvell.com > > > Cc: david.marchand@redhat.com > > > Subject: RE: [PATCH v4 5/8] baseband/la12xx: add queue and modem > > > config support > > > > > > > > > > > > > > + .type =3D RTE_BBDEV_OP_LDPC_DEC, > > > > > + .cap.ldpc_dec =3D { > > > > > + .capability_flags =3D > > > > > + > RTE_BBDEV_LDPC_CRC_TYPE_24A_CHECK | > > > > > + > RTE_BBDEV_LDPC_LLR_COMPRESSION | > > > > > > > > Are you sure you support the 6bits LLR compression option? I don't > > > > see it being used in the PMD below. Nor in doc. > > > > Let me know if you are unclear what that flag really mean. > > > > > > We support LLR compression in the Hardware by default. > > > We do not need to call ' ldpc_input_llr_scaling' API in testbbdev. > > > > > > > So you always assume to pack up the input data as 6 bits back-to-back? > > You understand what that feature mean? > > My concern is that you would not support current API and many unit > > test would fail then for you PMD. > > Are you able to run the bbdev-test and see failures (all tests should > > be either skipped : missing capability) or passing >=20 > Our test vectors pass with our driver (Performance, validation, Latency a= nd > offload cost tests), provided we do not call 'ldpc_input_llr_scaling' API= . > I am not sure why this API is being called in testbbdev. Can you provide = more > insight on why this API is doing and why does it modifies the input data? What LLR numerical representation are you doing for your PMD/HW. Ie how many integer bits, how many decimals bits.=20 This is to be able to support seamless different decoder implementation whi= ch have different assumptions or implementation.=20 >=20 > > > > > > > Regards, > > > Nipun