From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FCE8A04BB; Tue, 6 Oct 2020 18:17:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A3452E81; Tue, 6 Oct 2020 18:17:10 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CFE71DE0; Tue, 6 Oct 2020 18:17:06 +0200 (CEST) IronPort-SDR: X6Qrydb1zouScP/5WKilY+OLcEvIJ4juzlcbIFapaX7e0Uiidm1ZCz1tmb7TB13aZcVIXkkEQ6 Cp0IVdhQ/gGA== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="164628578" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="164628578" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 09:14:37 -0700 IronPort-SDR: hRnWZTIsfY7yD8Bcy1/J7Wa1r2t4DjFDg0vaZdH7RDzwnI2lR62qKhHsQMhecC+0JrB1VD+x1g wbmRhy4NYWoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="342357369" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 06 Oct 2020 09:14:09 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 09:14:09 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 6 Oct 2020 09:14:09 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 6 Oct 2020 09:14:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P34/ubeRa1DINJchiN7/z+b3eL258zp32Jrlh/QbsF0LbSO4/pY5H5EZw5pc8HnYmb0R9HD5XViRl7SmbdLTIho5kz5NAiIyKTQ7fdBrCnH8n790TGH5QZ+bT+FvYp1N6IG6CRJz6amzF0yktdh8BJ8sTuDNNtfPxjUKUI4yWaexuhyt2BDCOnZyNAF/xNr/zJAihZkBnxLETzjNru6LL5gyELrfrIzZiYq4sJSRKQboh5s85Mhzhh0vqZRFku2SwMJjBHApDCThwjHCir1A7Q/TlFnMf6UFKrt8BvK5aoX8rmYIDQTBbgMewv6Tq9uvd9NnJ0OI3lAHWXOsGwKcng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RxzsFK/ekry4FKC/yop5UJEOftPBt9OtSHmJ6DMBBNI=; b=gPas3/3svD4lhYGui0mqxFv2XZWI7Ai5rrj9hC0T2y3v3mYmbXl6xtU95IHKini0wpalztOhET5q8DhTQlOaGhYwtS7V+hxU7j8BIcmcVw7U60QoHULr7gloL78CH7Uxgb01LcJRprcbZCLzHKbgN5o2bYfm2eMfl69TjaskIthErYP3mkTjumQ/VTtGAZw0TrIaJSYR9cvUPLbKMDVI+gqZoBGV8AfjBLuNu8ZjrWcT/WtA7fZ7+cwsqmiwT7qicj9tbCqZohEluvF5YwooQM4mbIi7YXrhmrG1ho3M6edIvgiVwfaQPOGgmz/fh13NRopuVwC7Sa88JYwaoHskeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RxzsFK/ekry4FKC/yop5UJEOftPBt9OtSHmJ6DMBBNI=; b=T6tEuwNSejq4kf4cs/O+pYn1HUZl4dScb3Wd1F339gl1LSSXobda0wnfmxHtHbULrq3xA5CIsTY6nhCUNxlsXhpG28hQDwL5QPW+xt8rrMz7Jm/WaxyiQEL/BXnh2mGJIeIx+4Ui8OtfpvTswAno5jPW1/iotNMMC+IovCGsYHc= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB2743.namprd11.prod.outlook.com (2603:10b6:a02:c7::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Tue, 6 Oct 2020 16:14:05 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::4162:97e1:7d04:a508]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::4162:97e1:7d04:a508%7]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 16:14:04 +0000 From: "Chautru, Nicolas" To: Maxime Coquelin , "dev@dpdk.org" , "stable@dpdk.org" , "trix@redhat.com" Thread-Topic: [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug Thread-Index: AQHWm8gksKzk6jDoL0mqMdyk7PhU5KmKujkw Date: Tue, 6 Oct 2020 16:14:03 +0000 Message-ID: References: <20201006100421.72210-1-maxime.coquelin@redhat.com> <20201006100421.72210-2-maxime.coquelin@redhat.com> In-Reply-To: <20201006100421.72210-2-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [45.28.143.88] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e86acb7f-98a0-4927-9cd5-08d86a12d819 x-ms-traffictypediagnostic: BYAPR11MB2743: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:171; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m7japM8+EEA//98JkUdhcCG3StsFpiqjc+z4gwZObqASpZ6CyfKmD64qZWVe04ksRPJJS8E/6mDaZse8MbiwZDYUETTGjeGV0JVRoyWe2ZVyR9h6Qb7dhA69AU8n11DFzacuJhGpOp94/qa1OhUkDDihGOkb61hpb5zYIC2ftjWhyjhJd/+Q8xtWNCkP64znHCbYGi5/S1zf660m5GsYiQAuIeoIywESGXqjeUpfU0JZMwEE+dzMMlWxFNZx/3+jC+S6mrzFdUAO4WVdeai4CsQwwbdDxqz30tGTSSDFHoOpxg81aHYe6C+vbXQUh14EkgkJsrmj7ndYwpwqdW8MVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(39860400002)(366004)(376002)(396003)(53546011)(6506007)(478600001)(8936002)(66446008)(71200400001)(64756008)(66556008)(66946007)(66476007)(110136005)(186003)(55016002)(26005)(7696005)(9686003)(316002)(33656002)(5660300002)(2906002)(86362001)(52536014)(8676002)(83380400001)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 0gAsxu/LBv7m7ama/mmCNrT9CT7IlMGNELhyMOeeiyZB607Avz3btYv+kevg1tC8M2GFEsh3nphWPb9PUsrsDNrIy9ZVSF2KJg28VG8WugDcTOzG6CnCfvDp2w4TFsTvxitHivQQTK8ITTjQWcES2nkiYQ3O23pRISZ/UEPWu5gpOP3oq96Y+0Z+ZeY0QHAdpwoZGM6+4MoCbPGZ85mevQQFk8fDO2ZB6z3wBGj7bmDZVpN+5jckkFqa6Lev3bXLl8iraGkhlgOvWkqBn2Tb4VMiJ6lWDq4epXNpEz1PqUqc/QY1LkwriGJO0u9MX2QJaxhQNQCZmkIrB+OcVGXgtNpfzsApzlKYolsAlEe4XrbDqoMX+QUmjmfWHBHTMrz4Qe/bx0Ia0uAD1097vq6ThmwMDJ8iwDr+DRm0NijEYBKMAOHlLE3VknycoE1UH8O8RL6RpZKfw719zlL9vF6UHTX5/TLntXT0DDZoEEMTl8rHgHUlOY/lqTvkBGZMA3e1IKsIOX5B9Mw4VcBLqsfg2VyNX5DY9Ijghb5Jq+MM1c4s0AKcMNjxc2Ov4au800RAr5bT0TzPhJ4KbEQW64MnSN8iFrlbyU5WjGv5YdSuqjtas2kD1Xwug8vanhKVnM1DUfw5egw51t5ztVV0fJonog== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e86acb7f-98a0-4927-9cd5-08d86a12d819 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 16:14:03.9168 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k0OJgPqrEQmASfarb27BkrEtgLzfx9ORCZt+3PpvzH+eXGs+HwBaL73TEwxFizjYU8zMWes79Mq4GAF/d1uQE8wHhIkw5ZeR7K9RBmHfpWI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2743 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Maxime I am not totally sure that this actually got broken in the very commit you = point to (I think that there was another pci generic commit which changed t= he assumption when this pointer was set), but it doesn't harm to change any= way for stable build.=20 Note this is already like this in the new PMD acc100. Acked-By: Nicolas Chautru > -----Original Message----- > From: Maxime Coquelin > Sent: Tuesday, October 6, 2020 3:04 AM > To: dev@dpdk.org; stable@dpdk.org; Chautru, Nicolas > ; trix@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug >=20 > When RTE_LIBRTE_BBDEV_DEBUG is enabled, rte_device's driver pointer is > dereferenced twice in fpga_5gnr_fec's probe callback. > It causes a segmentation fault because this pointer is only assigned afte= r probe > callback call. >=20 > This patch makes use of rte_pci_driver pointer instead. >=20 > Fixes: 0b5927cbcba7 ("baseband/fpga_5gnr_fec: add PMD for FPGA 5GNR > FEC") >=20 > Signed-off-by: Maxime Coquelin > --- > drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > index 61f9c04ba2..11ee4d3e10 100644 > --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > @@ -1839,7 +1839,7 @@ fpga_5gnr_fec_init(struct rte_bbdev *dev, struct > rte_pci_driver *drv) >=20 > rte_bbdev_log_debug( > "Init device %s [%s] @ virtaddr %p phyaddr %#"PRIx64, > - dev->device->driver->name, dev->data->name, > + drv->driver.name, dev->data->name, > (void *)pci_dev->mem_resource[0].addr, > pci_dev->mem_resource[0].phys_addr); > } > @@ -1895,7 +1895,7 @@ fpga_5gnr_fec_probe(struct rte_pci_driver *pci_drv, > ((uint16_t)(version_id >> 16)), ((uint16_t)version_id)); >=20 > #ifdef RTE_LIBRTE_BBDEV_DEBUG > - if (!strcmp(bbdev->device->driver->name, > + if (!strcmp(pci_drv->driver.name, Why do you have to change this one? Acked-by: Nicolas Chautru > RTE_STR(FPGA_5GNR_FEC_PF_DRIVER_NAME))) > print_static_reg_debug_info(d->mmio_base); > #endif > -- > 2.26.2