From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36692A0548; Thu, 9 Jun 2022 00:44:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11B2840689; Thu, 9 Jun 2022 00:44:34 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 12EF140220 for ; Thu, 9 Jun 2022 00:44:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654728271; x=1686264271; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WljXC9H8Jl7ljHtLfG8V4l2x6Yo3YcjF58Yy8mcYk9I=; b=HdKyMUBr7uyEnYG3J+wcOuOcCXrEh8djnkzii9etkyR7BV+7CP4cWy13 hq7mX8hptd23Bi1230J4xvwQZZbKF70vNpWe0+lzpTLl9w/H5na/lK+rb ihhtoFny+wag40bLo2j4dKVPzN8Uq7VNSryrg0bp2gCStiJxxLXhRzdXI PCk0voL4iRMR/8a2y/7JIVo+Jke6u1UDYrkxNRpwvwq81sywgWoC5u+KI ET1r3+pIB+9Y+HDh97aFU/EZ2BKyoEZrP5kOzT5ikhhJjoLf3ASxeEUIC uAwh0eb9IW9AjIO/IJg4vezmZ6XH9wrOBlGD0dDHiqfnAR/Y/eNtD68OY g==; X-IronPort-AV: E=McAfee;i="6400,9594,10372"; a="274594964" X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="274594964" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 15:44:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="609889471" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 08 Jun 2022 15:44:29 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 8 Jun 2022 15:44:28 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 8 Jun 2022 15:44:28 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 8 Jun 2022 15:44:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NszvL3grUjyn0lPVsJuzK3kJnyc3CNGjeoZ9BPd46ppS3HySkjzcZmXhcrpDRnAeOlIT3KoWG+XE9DJty+PSbEf+5c3SZrn1wnIKydcbPHCBLN7T9dMY4+EjQqnT8J1kvKf7eTDHgLQzd8XLRcx99fpgsmQdSWWdK24XeOeRLaT5XYdAu0e8otUkHarHel+COh6Wjc1gS8T8b9SObCvkTE3MelWfmSyt0HKm9ToeKS9sARNi2KNS8eK5ujWNYLwtayNt0Jc+V8dVQXS94O5+oCq+XAkTXI0MgCskPPwU44M8ff3RFv9DWBoGKljWRujGyZXGjBG5FfKfO4AL3ZZd0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UtB38jAJapzCgZUeMw+mZpG5vAIAW8dCRAheLGrhyDk=; b=VwKOfrSP4EYsgt4qd/rXnG+hm9YQ2opbJzNAusIqknRaGOG3IvbYOp+5a6keNOg8FIZrHHBHogcNjj1aVGowQsM53cEOqtdr5S7JST8KHxsvKkN9tpdRvxP7tsQ3JDHIIJv8eC8HRScEI+BJHiDsgpjiWzsqFPdwPS6lzGyXZSmuy0qGZvojVvuZr8F15Ilyw+DSdb5jO5gVi7nroaSOat6+jvVgVyG2rP7bGl+TMBM665bcJqPeqk2zQBvA/UE4SJLCwbSPeQX5Qp8mU37pknP6uQ2Puy8nA77f/0/5L9Sw9wdjTwyxSHeBQWudLLNG5q6ngD91vzMyIS4geXvlmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by SA2PR11MB5179.namprd11.prod.outlook.com (2603:10b6:806:112::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Wed, 8 Jun 2022 22:44:27 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::cd54:e1b7:e3f:4069]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::cd54:e1b7:e3f:4069%6]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 22:44:27 +0000 From: "Chautru, Nicolas" To: Stephen Hemminger , Maxime Coquelin CC: "dev@dpdk.org" , "gakhil@marvell.com" , "trix@redhat.com" , "hemant.agrawal@nxp.com" , "Vargas, Hernan" Subject: RE: [PATCH v1] bbdev: add device status info Thread-Topic: [PATCH v1] bbdev: add device status info Thread-Index: AQHYeflHmYkPLJJkcEGrPTwhGhJDNq1DEagAgADSlACAADCVwIAADEgAgAAGMICAAfGOEA== Date: Wed, 8 Jun 2022 22:44:26 +0000 Message-ID: References: <1654555808-218770-1-git-send-email-nicolas.chautru@intel.com> <1654555808-218770-2-git-send-email-nicolas.chautru@intel.com> <20220606170906.6265c598@hermes.local> <9f995dde-738e-6c56-c4ef-41c9ad0f4926@redhat.com> <20220607094247.1f4ee7b8@hermes.local> In-Reply-To: <20220607094247.1f4ee7b8@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc216369-5a6a-4a40-f5d3-08da49a0713d x-ms-traffictypediagnostic: SA2PR11MB5179:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yoNZTJfo3qkN6FFa4BnZVRsWGoh7CWsIIF3f978oOfaeDxRdqScjak6BJTlif57jH1Dc5FC9XxCC41Ez+8tduiWmAqOhu3DnqUO9sAweSGhxZi/ICwHlwA3YEVv6DgJhVS72fk+djN/9NaUyXBnxBam/Tz/B13JAu2kskkpfd6ts0AOm4QnZrZQ7WGng8DFpRCoBFl+AqTgOTAgKpsrlwCAwidpzAIa3EnpKnsLG/DPTJjgqfD0ENFyMGrpyN+jnMDhKutsFK9gzsU52iU0PjmdgiQ2b+bLNREmr49l6vFNcwpgXRQYd/tuXXFDiinliUv6/9TyxQO4IVEk+FGubCdp8TMkMK1wlgRxwf80WUPrMY9HUQNAQXjbTU+AgZr3OfPnhZhu5Vhtm92wu0Q3mx3xyxKpeVBP9bQocTOqnNK4GnxL/C614LLoiBm1/Aez9s1EtOxRT5HsvU2QloA3U2rmtmtEykCK2Pj1TEmpynTrBy4t4qL96BxkaJl5BLhExB/RE6xnTOEuA0r/HLs1YHna4JDKc40OP3SFOVplmw7UoRWAtm5EknsTQTYa0u71Cz8moV33cURZbEyUanAeUlr3nG8Mwf4vSagokqxI9BwAQHidMXTtcr6yLqgnJmVdsJnfp5oogVTeBeCXxSmZvjjRrvbV5bB59ZonAoagEG+zQUWkJ3doAFat48mjC3qkLJpXfpiKZ4I0BhGcOWJDNkyxbWWphX3uja/n7QhQWiW6ojuPKFDJFFpk9JTkjfZPwkcDdRRYJCblMYTjd6ZExSTriCHjMW3wWrcwEGJ5xKdU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(6506007)(7696005)(53546011)(186003)(82960400001)(26005)(9686003)(86362001)(83380400001)(38100700002)(122000001)(33656002)(54906003)(38070700005)(76116006)(66446008)(2906002)(4326008)(8676002)(64756008)(66946007)(66476007)(66556008)(52536014)(5660300002)(55016003)(8936002)(71200400001)(508600001)(966005)(316002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kIMUSZQrdiig/XD8Jsgq9insO9h3s74y4YU5j+0ptMRFbnjmkExVsDX8ZI0F?= =?us-ascii?Q?yap5za0PPrCMaIoFZQPCN8rqTRzGvyF6zIiP3gr/2zSZzrtYRMI/V48pEyBx?= =?us-ascii?Q?r8uSuOVHm3GwQ4odsqlaXMWohXTXXlk/Xi/YYeHNx+PCUasO82gBToA3AftK?= =?us-ascii?Q?K59OV5Mrsqtow2NAa5kNuKgXxKHG5GbX1pCClB0FqYqVZRC0TAzwSPIe8Zv9?= =?us-ascii?Q?vIRzDP7bbP5IrJJgoBLw0eJ1xMVDWyabeiFn50Zl0VHgc0EgQ1k6QHDN1YZT?= =?us-ascii?Q?RlwDqy7Y8zRIJrA4YVR7SiRuZDzdWooVfSDbBZuMiZI5zZJZlRoIg2befdjv?= =?us-ascii?Q?jnu+9Hv1LzL3k7/Uznx/PURjjpO+XcR5fVJmcREd5oPAZ0lV58+B4/pXkjg4?= =?us-ascii?Q?fX9a0AhziFkRYSvV3nnzvgd22CL4D2lakTmMnnEI4zKY6EMk0+EGAfE9H4YX?= =?us-ascii?Q?5Fr+Jc7+Ys53ZeoP5C5JjANcnkYrRzm+kRAMXlbfhvvICfFKmEyz6QMHKyG7?= =?us-ascii?Q?eqqCbVYKvhUK/Gfom+s7MlZy6pkay21aHcsDi4NFpSMKiF1GL4gDswPOWhiW?= =?us-ascii?Q?GEfOO3aD2EciT3voWao7yjS9zXDnB6Uz8xDcUhVlFoW3zykFHYeHZXiArOz0?= =?us-ascii?Q?2Fecu5oyNBwKvoUHOaUJlxKT8aLPDgI6vK2UxwYiBO3RGRqB8rGuh8iIvGUq?= =?us-ascii?Q?RZSSCinqbx6I/0A8AIpmg2BKPqtayIkAdJrSVQp/h7a2sb6bwYADzMAPemXm?= =?us-ascii?Q?4va07Fj/LAt3vN2tyMmfsqbY0IK/EnkluXbA2BXRRZBqiCuJf0aJd2XkqrYC?= =?us-ascii?Q?5dJM3QfRl1PuveoCawCCDb/g2kAeQL5+RN07NmErhN5L6NGr45MwXoohw9Fs?= =?us-ascii?Q?8GOu9rwBdXWT0LIU5qBGAoKcy4grWRl1q/nbwpExAGhEhZjzEBBzbmJ26kKn?= =?us-ascii?Q?OhDs2NSZv6E8eNO2dITgFYCJZ8hnKd1SSa0SS/lMUnpHNBsglauWTuKv+gef?= =?us-ascii?Q?51/4J/HRxdFxSia9dsKWEya5NblJFfQ5Jga6dQ7qTIL6TewZUMrqhTP6+qrh?= =?us-ascii?Q?XXc364wVfZGtVNrhO1Q5wttU5Krto3hoyEQuX73CD7k3HJgEttmdN2s/Ip4w?= =?us-ascii?Q?iVE8gxD730x5c9VjDTSEAfsmWLIxvjtrn5WvG2xBwUHysTrlZyKMPnGihkiT?= =?us-ascii?Q?IFuANmJw46/CVtC3M5vShv84YmQSz1XSECqSGeoN2yCbxeeVl6r+0QH6Cv/r?= =?us-ascii?Q?eFm675nfc4Kv4CHLgOAYE39vu/crMGaAiTdG0W4v/bugSX+rxEyfAn7aygJT?= =?us-ascii?Q?tpPBifYGCOQqRWRHtK0gzK2639UxQJqjms/SHIa/mGQam8a2e8WgprRI365k?= =?us-ascii?Q?GgJyq9tLue5SA33hBH51fMvcCjJvoWWoFQXFwptwxH4I3HzpEot8JdcS7MmZ?= =?us-ascii?Q?xxr29E7bH6HXEXFU+sC0nb0RiNSLaKKUFHYuQLfckvPFw+1qUInYBkbC86y5?= =?us-ascii?Q?9GK5/X0SQDqnGkZE+bjYJ0TCWcanoU8odOr295V7Ob+zkB5r4OBz3Qt0wFgO?= =?us-ascii?Q?24wecMrFaIu2L3ld5IX/uDt+psc99h+NMopipVOGDlRgNuKTvKzf1VMT+rh4?= =?us-ascii?Q?QiqLl081J8we0Hj48Pwb93SfS1QNpDJ1ZkgGh5Fbx6W7AYNkuSh2oLg48txD?= =?us-ascii?Q?4XnYsowWnVq1YsLavmqghOpV98wB1+8TVc0Jkk7nxxP0TAC6qdfD5vHiwnRP?= =?us-ascii?Q?Z/51r0dwiH6gAxSZNF3mLpodhMvh/O4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc216369-5a6a-4a40-f5d3-08da49a0713d X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 22:44:26.9358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6SlH34WwLL72HAFQyRH/BtzWLWEaER5LLLmbxPQjkiSjMefwyyysjwpvpg7NZsGHGxB8ma9x6Jalnh4EPdgAD3yJmqLki2X4WEWwO6s9T/E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5179 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen,=20 > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, June 7, 2022 9:43 AM > To: Maxime Coquelin > Cc: Chautru, Nicolas ; dev@dpdk.org; > gakhil@marvell.com; trix@redhat.com; hemant.agrawal@nxp.com; Vargas, > Hernan > Subject: Re: [PATCH v1] bbdev: add device status info >=20 > On Tue, 7 Jun 2022 18:20:38 +0200 > Maxime Coquelin wrote: >=20 > > Hi Nicolas, > > > > On 6/7/22 17:44, Chautru, Nicolas wrote: > > > Hi Maxime, > > > > > >> -----Original Message----- > > >> From: Maxime Coquelin > > >> Sent: Tuesday, June 7, 2022 5:43 AM > > >> To: Stephen Hemminger ; Chautru, > > >> Nicolas > > >> Cc: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com; > > >> hemant.agrawal@nxp.com; Vargas, Hernan > > > >> Subject: Re: [PATCH v1] bbdev: add device status info > > >> > > >> Hi Stephen, > > >> > > >> On 6/7/22 02:09, Stephen Hemminger wrote: > > >>> On Mon, 6 Jun 2022 15:50:08 -0700 Nicolas Chautru > > >>> wrote: > > >>> > > >>>> @@ -298,6 +313,8 @@ struct rte_bbdev_driver_info { > > >>>> const struct rte_bbdev_op_cap *capabilities; > > >>>> /** Device cpu_flag requirements */ > > >>>> const enum rte_cpu_flag_t *cpu_flag_reqs; > > >>>> + /** Device Status */ > > >>>> + enum rte_bbdev_device_status device_status; > > >>>> }; > > >>>> > > >>> > > >>> This ends up being an ABI breakage, can't change a struct like > > >>> that until 22.11 release. > > >>> > > >> > > >> Indeed, but Nicolas mentioned in the cover-letter that the patch > > >> targets v22.11; not this release. > > >> > > >> However, a deprecation notice should be sent for v22.07 if it > > >> hasn't been done yet. > > > > > > I have sent this deprecation Maxime: > > > https://patches.dpdk.org/project/dpdk/patch/1647542252-35727-2-git-s > > > end-email-nicolas.chautru@intel.com/ > > > Do you believe this needs to be extended to cover more details the > > > change and including this device status info explicitly? I can > > > update the verbiage in more details if required > > > > Thanks for the pointer, I missed it. > > Reading the deprecation notice, it is not clear to me it is about the > > device status info enum. > > > > Maybe rewording it a bit to be more specific would help. >=20 > You might want to use one the existing empty padding slots (holes) in tha= t > structure. It appears to have been laid out haphazardly. >=20 I don't see such one single hole to fill that enum but I can shuffle a bit = that structure. In that case total size would no longer change but a few of= fsets would differ and padding would be reduced. Thanks Nic