From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E526BA00C3; Wed, 21 Sep 2022 22:57:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D319A40691; Wed, 21 Sep 2022 22:57:42 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7DC0140691 for ; Wed, 21 Sep 2022 22:57:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663793860; x=1695329860; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=j+9/ARj0JgcFVPXx76G5IDtGLOMPcHzhosPxleBClD0=; b=aqTXxpD0LfxWJpJCocPgdGzGbEz0U65YbZp4qRzQ7Fhqj0QSUSYoQbn1 CJVCgDXvCKa0muTT0mal1tpA5QAA0anbwMfz7N1Q3yiYqh1axI9QqOkCW nzCgZ0wxMBUmrlGvEJeG4VWPjo+4CV/JGFSjTg6IzyzcaBqYckAJ73fgM nV3zv6GHqaemGPzvitGHHoz9yjLM+u1YrtvRB0GIfnIdG3RCkR3UWsKUW m4enSnqyEN37VuPt7jbVCCoLCWEJVODp5t3F8aqTlKjoY+f2Jf6trIe6W wFVANWNLnzk0mMlkaTlLBcRfo/cmUvRUSt9JVLDW4HWBJkpbWuH8jw+78 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10477"; a="301527372" X-IronPort-AV: E=Sophos;i="5.93,334,1654585200"; d="scan'208";a="301527372" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2022 13:57:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,334,1654585200"; d="scan'208";a="652696948" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 21 Sep 2022 13:57:37 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 13:57:34 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 21 Sep 2022 13:57:34 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 21 Sep 2022 13:57:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m0jvTd2Tnh0h5jX6aBmUZ2P1bpn//Ac5b9WKpYDBl1GlOew5Lbhsfu/Ecr+3h/OOFJkOIsF/fpw0v9ncw3Cw/eoQvifl614bSFCkTbkACZ3NoQQrRqYHtXd8wTHAORBVrEzffUZ5zB7WZOssgOVrFwviLF+Gw80+U9WlWzQFXRuYRvcOFc0MUorpYohEAOp9IPOO48znQN4d6tWJU3aJhkvYizXhpqRfvJodgGw5C5BOeT4Fnxi9GTO8rm5DhrkYuNofG4nJxboGRAdBiucXpN2B6M/9k4FdW8V+E8WHszFJ0GGr/dttvRB0yaC8xHPvq/kOahLx1GHdq6pOKgEcAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v6URksGYgQ+sPPjivpGXMINluLChcxCMtttDjlt4Q/Y=; b=R1nTK3xj5FHG+4J/42SFx8s0wd3aLPpRE/rXZrCHZBjj82icl6GyVaKAawmEMi70jqzZP1NCa9AFt1l1N5f6Li+OTxqg/Y3ltHcgxYkPbK3gItNpulZiiH8qbfCdkPDMXZxCXzfs4O+4Kj68BFpPn9x+88D0Kh/RvdKioorst/Nm1xktsdFZTW1mD0vctFJPJ3uQqkoplZCQijdv3KZbqTMOKQMBgz7aiX5Ysc7PUXvSc+coEuecm8PIzf24jxXpACkcjMoLrRzVe9GeOw4RaJXTbIJeGuUWckAdI+SBj3CPkfFtIN02AxnB21xRhyqZ23gEtrTFUtn4qLqDhFthHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by SN7PR11MB6749.namprd11.prod.outlook.com (2603:10b6:806:267::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Wed, 21 Sep 2022 20:57:32 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e6be:3feb:17fd:bdcf]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e6be:3feb:17fd:bdcf%7]) with mapi id 15.20.5654.017; Wed, 21 Sep 2022 20:57:32 +0000 From: "Chautru, Nicolas" To: Akhil Goyal , "dev@dpdk.org" , "thomas@monjalon.net" , "hemant.agrawal@nxp.com" , Ray Kinsella CC: "maxime.coquelin@redhat.com" , "trix@redhat.com" , "mdr@ashroe.eu" , "Richardson, Bruce" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "Zhang, Mingshan" Subject: RE: [EXT] [PATCH v7 6/7] bbdev: add queue related warning and status information Thread-Topic: [EXT] [PATCH v7 6/7] bbdev: add queue related warning and status information Thread-Index: AQHYu9UheYpX0UsLbUG2uEh3tuE2IK3qZwkAgAAahvA= Date: Wed, 21 Sep 2022 20:57:32 +0000 Message-ID: References: <1655491040-183649-6-git-send-email-nicolas.chautru@intel.com> <1661796438-204861-1-git-send-email-nicolas.chautru@intel.com> <1661796438-204861-7-git-send-email-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB4451:EE_|SN7PR11MB6749:EE_ x-ms-office365-filtering-correlation-id: 1e9bd534-6ba5-4638-d697-08da9c13e777 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dOaZz7ojexdqcJ0kGuf0NX5ACVoIBfQ6zOfQf0qud6F5ArqKUDN3E3x16x0fL6uYpJsE2H+iNW/fCvZSXOfh43kcayVUjaV+vmrLssa0GvyqlCcfy9UcIeo7ighFVeziJOoVZ3l3Wol2BXmjKpMyzdvCzEjTWXy23GMHfgv8dJ+KLNfES9GGxjmT3T3ABn379eHJSqMqujbaxJ7YuW3mFX4WPSrYR95fnjwKy6A9wbBwg/BG5DnKt5yolxxP8SRvIFx8lH7X8nj7Gs/Fj2sUZBnh4/H+1KUguPw6n5TstYin0CgqYckLX+YOO36ditSRsn9KduXFmcZ6jqb/K/Erupm6/Pf0KT/v9UCijfAMrvgiEyEFvTUSz7VuSJx7y1Vrdi2K7aQDRNgKu5PAS7ZXwX6PaGCDdKAAgKTZDkXqqiGak/NCghlHnSJBtz0c7TjengYd4TMOCgg85LzhrPKyXR4T+fsZCavNDh9UuEWSclGaPxTmfd0rpIee2mT63RfXOmn/zzkazmGgeo8dbypI+Mqoid9Jm43x59q7uonlVsQM72hA3F4PDiRYZp5gnlTGUAxkthElmi2cR0QR3SlDt5LTKuqj5kVPv9yDFdptUcroznRhZ+iDFGS6SlDcntDhuYqHxoTsfXnsADdvH1GyRI8+EvJsllF9su6tejJvykcMc0p5sXHcxC17IZ7RHnW2suJ8B4uPUpOqfOcXQ+3WUAzB+t0yQpWbgraxlsDg7Uc1KXgdhkZIiWVJPzFjZQGw/g2U9vb8w7qsCdM7tlmRVA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199015)(9686003)(6506007)(7696005)(26005)(110136005)(82960400001)(478600001)(38070700005)(2906002)(5660300002)(38100700002)(64756008)(66446008)(122000001)(66476007)(86362001)(33656002)(55016003)(186003)(66556008)(107886003)(41300700001)(71200400001)(83380400001)(4326008)(76116006)(52536014)(66946007)(8936002)(54906003)(316002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9x0wjXJPqKxRHTa1I04LXpKaz7j1C0QZD9ZQZMT0835ZIcSd+cNoTXQoLJAY?= =?us-ascii?Q?RODkyhYA5MXShK3u4Cckh9knoPeA81MsMGuk99OlvX75ObQX1UvHnY+H2Xmv?= =?us-ascii?Q?ukaYIZ3QnGODlPZjFndWPB3FgGidrbQ0JKTF2ApdhhFK3Pk4ph2stL4yY7Vu?= =?us-ascii?Q?tItpPtJEq1IaeCPqmqjRmYu2i4QvL5V4+J7zj/AjEj9mboQ9/Qcj4nBaMcq0?= =?us-ascii?Q?CLNdAVHFbo5FyVqaInYS/kAWBJxfhoU3JnhBaU27z0ddbKbO1EQ9zme0MV7N?= =?us-ascii?Q?iMHP6skMA0sdva3jkpIYNtzNfqJ7fzAsOERUJ0Tk94yGx/vg1JskNOVQ5PP1?= =?us-ascii?Q?6bzF6CxU2MkeBwJqyN/Qol2tCUn99A2tD/K+gKcBlx8FRBf3CFAXHEKBPg7E?= =?us-ascii?Q?jUkP4GYnTjHaoyexjvb0xpmoGE3QHBIBcd+EqpdEVgqfqK11UFdHcm/8qnEZ?= =?us-ascii?Q?XQjhW6oEFL/ZhQyjld5ZXjo9HIcrzVl49GKtO+BT2M0ctrnF7skyCbhekaJI?= =?us-ascii?Q?kt/s8b6ofwEL9Q++fog/zQrHHsQfCnVAx2bri6cbApJzoCuR1iW4tZ5S3s4i?= =?us-ascii?Q?JM0e5WBGZHxWzOlR08R+aPJviW7xozrLbjF3VFf14KX9TkK7jkyxVGX3q3lN?= =?us-ascii?Q?Elokiua/uJYa96O5gtcYTc1AviJQ0nJ5NRuMgQo6Fh7GP8AkOL9rAllBRIfQ?= =?us-ascii?Q?H1nwnTiOV4arG4Re05qcInVQbb6w8OMhpxoJ8i8EFsB6HmbO50w/DCjcTIEX?= =?us-ascii?Q?Zcyhu4uSIsJKe/p1HxjPJReGNvrYSoFf4nsbfEl//cSfJyistJI8Qnt4NehX?= =?us-ascii?Q?YfcYnQK2CSbAo0DAqsJKojH77sZtvDv2WxrP+JtH4zTQIZImO8M/CSMN+d/1?= =?us-ascii?Q?U5SZS37QCp6d07zZLZFdsleUVDXtMpzwBRxTIHgfKw+lSbjSeMFzbVdfF0N2?= =?us-ascii?Q?3TU/QxRzQt5EgMNunSzHVm3ktxPtspnuJKgiL/3I/3217+KTBkJE7In3bl8i?= =?us-ascii?Q?9aKGYdIq8SVB6nvvM1ZXYWWzw2/dyDf2IyQWJC9YQJnpvAmLJjrO2sO4QBgj?= =?us-ascii?Q?oqzTsJw8S0JgiyXmj4vOFvx7FxXQS66vHaIOIB6ak8bcOeBBySIDA9y/Ev61?= =?us-ascii?Q?ozv3kFxMVeOkp5aDJbfXGFU65jX/iwYt+d7WByNZQw4vk3jK4zKuAiQwAXdS?= =?us-ascii?Q?XQcGZzGcvTEb4oDHYQqSbs7dpsyOIw7pVtdPLskkU/xaz3EXNToqRLxrEliE?= =?us-ascii?Q?gQyoTKYLvYX2l9QbGK2aApbhg6WHDQ+sm/FWC7Wu2B3Ivcy4swwNFpqA9PQr?= =?us-ascii?Q?aND8ocbTyYJl+137cpWKx/BP8fCLpGC+0sIUcWd1US1AsMoQF7RBJG9J6ayb?= =?us-ascii?Q?dV3p9sw7kHJbkasW/R0Ewf3BEOTfZrvK7KL1DdKOF7bU8HBMvuJqKhrKYRVK?= =?us-ascii?Q?M4sKWxNMLOVgRo/m4jzeSSyhAxvMlYAIJ1SntTeRpW8yZiS5DxEZqF5pfnig?= =?us-ascii?Q?+immPHUj/VHTjMDWsyh8+MV32dc6/TeUps6LldqGx8mCl9HtB10ZiA64N8vZ?= =?us-ascii?Q?fbqGUx0hNO/QFpvTxJJFE/4bH6m97nYbpmmxzqZL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e9bd534-6ba5-4638-d697-08da9c13e777 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 20:57:32.7580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t22OZ8l7Joii+A6pjYwRdwkTL8Q6y2vSPhdTtmBH3XBw7CFlCiGHjWt94LYilgEpwSGcpgw3oJHqwAN6UKItBTaOPUZtdD7+2f9Y4gTBR8Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6749 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil,=20 > -----Original Message----- > From: Akhil Goyal >=20 > > diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index > > ed528b8..b7ecf94 100644 > > --- a/lib/bbdev/rte_bbdev.h > > +++ b/lib/bbdev/rte_bbdev.h > > @@ -224,6 +224,19 @@ struct rte_bbdev_queue_conf { > > rte_bbdev_queue_stop(uint16_t dev_id, uint16_t queue_id); > > > > /** > > + * Flags indicate the reason why a previous enqueue may not have > > + * consumed all requested operations > > + * In case of multiple reasons the latter superdes a previous one > Spell check - supersedes. Thanks, fixed in v8. >=20 > > + */ > > +enum rte_bbdev_enqueue_status { > > + RTE_BBDEV_ENQ_STATUS_NONE, /**< Nothing to report */ > > + RTE_BBDEV_ENQ_STATUS_QUEUE_FULL, /**< Not enough room > in > > queue */ > > + RTE_BBDEV_ENQ_STATUS_RING_FULL, /**< Not enough room > in > > ring */ > > + RTE_BBDEV_ENQ_STATUS_INVALID_OP, /**< Operation was > > rejected as invalid */ > > + RTE_BBDEV_ENQ_STATUS_PADDED_MAX =3D 6, /**< Maximum enq > > status number including padding */ >=20 > Are we ok to have this kind of padding across DPDK for all the enums to > avoid ABI issues? > @Ray, @Thomas: any thoughts? >=20 This was discussed at the time notably with advises from Ray. But good to c= lose the loop formally.=20