From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21C75A04C5; Fri, 4 Sep 2020 18:45:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 122BB1C0CD; Fri, 4 Sep 2020 18:45:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 09FFC1C0CA for ; Fri, 4 Sep 2020 18:44:57 +0200 (CEST) IronPort-SDR: miW0cTM66+ymHyiFB3VsCTs+tEM3crMvBw5Slo+KX89PJKIiH2jFidMsQ3c0Ww4dvu+daL/WTh S9RHSiSKuejg== X-IronPort-AV: E=McAfee;i="6000,8403,9734"; a="155289260" X-IronPort-AV: E=Sophos;i="5.76,390,1592895600"; d="scan'208";a="155289260" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 09:44:56 -0700 IronPort-SDR: rnvCvC8qg47Q1ILyxc6FYu/RwZZsM93qKItS0vOPMH4X79sd58iZCEIBhnAweo4cthKx8LW7o7 Ug59axV+NvIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,390,1592895600"; d="scan'208";a="503565267" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 04 Sep 2020 09:44:56 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 4 Sep 2020 09:44:56 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 4 Sep 2020 09:44:56 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 4 Sep 2020 09:44:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FVIX5W/whLPzKF6W7Tg781uZt0vyJgyy32NjZ+ffIZej3NTzY65sLW4iBVU0bL4iENmiQMX3wZIRImNmFH3ljiA6061HUXa7GYMlH8y6D2PwUBnVLvUTQOv3IADltgMbPFPCmf9i/AAGMvT10sU0/xAnsRAUlVWC7S1JizfDNbfXaIWXF7GpVYI7hKuXHZAD08b16ECc77Ir1kK0NWknegQJPYb5L2BFoEDjz8nJ0m2P0qCbyftLefpkVOsjZriSg0Xsy7fdjVBRJnvWLc1QDsizVfgu6cW3SZGMlNGmE35BXb3Vj0grW8NpKMpoq23Z/RJ11kQPAZRkeqm7UeFdFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCH+wBRlooKRi0l7fpaL1WIZpdZ57xl9vtdeEt51Yfs=; b=VNApk8hF0hQZxXEsOdFLLC/Pzl1vG91BZGeZSIPTlI2S4a5QGt90NhIZyRxvW46ZncDWtltBxbimTSqrRtXDzil37+VVb5Xb5Wv9LxiCWyMCJdQVFvD+5GYG66rzEEfjP6vvCt+mhyk6/vU0o/WlcNox5G6cNV5CLMzhAi6MkPTgrVxMKTu+3vYRbbSbKKj7/8W1dMGYUBg9sDoQqnjfcnFdWr0R7A61KgTeghLiFV6cLoCBiYq08MqNeROZaq36AiO1SRrF1bqOZ+l1cNhLPNc9JyCCtQbu8AwDTVlB5wfC+o5RfwIY3iAMZMQ/DPoh9k60P565JZxECUdWzbrxpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCH+wBRlooKRi0l7fpaL1WIZpdZ57xl9vtdeEt51Yfs=; b=Dvkq2BjJxADmYPL7TvxHsuW5PeZH/2a0IBBrxYeL+slH6DuLoToeEmOnazHmCibT6to9JgEwk6PQjBBpAJsugpQs7KglAADlItDBKHQ/fYm7EbwGNmsT5VsGT5mYyI57n+IYrv+K5Z0kAGMKLgEtX/kXZwdibmXhcQwGYZyOErI= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB2869.namprd11.prod.outlook.com (2603:10b6:a02:c0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Fri, 4 Sep 2020 16:44:46 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::4162:97e1:7d04:a508]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::4162:97e1:7d04:a508%7]) with mapi id 15.20.3348.016; Fri, 4 Sep 2020 16:44:46 +0000 From: "Chautru, Nicolas" To: "Xu, Rosen" , "dev@dpdk.org" , "akhil.goyal@nxp.com" CC: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 01/11] drivers/baseband: add PMD for ACC100 Thread-Index: AQHWdb+FWIJ6x67VeEKiCUVKC6j2x6lO5pGAgAnfmVA= Date: Fri, 4 Sep 2020 16:44:45 +0000 Message-ID: References: <1597796731-57841-1-git-send-email-nicolas.chautru@intel.com> <1597796731-57841-2-git-send-email-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [45.28.143.88] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd3e0f12-fa53-4e02-cca8-08d850f1d4c9 x-ms-traffictypediagnostic: BYAPR11MB2869: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D7ua82gZwYU/klxHw4fIj96sSIET+NEhWf9w5Ng5dyb6mtuSt+7VHamQ/i6rGZVmi2KJvRqQVf3bUaEnz6CbsJqSPXwUvaORJYchIvp21D09sECSFNxvWpwlQjanlfxHG+4zsUSs2jFRUri6KpQRdXWsXAJB4Jy2eQOnIzqFYbHK3DldIrT5qwibTrDqRk7Rce6wUGJ6ZGWZbVPizwsk5xaypuH7GWw0aF93sQODXbGHWDhygVZvmW+ZaH6qjY8MDHxmYt0k7eSpkgFGvTLNqUrQXJoxfopf+IitGM7lo2rpXWCxRucAYdTYWZSZWWnsOKia4mzmn0gDAHPIwF5nqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(376002)(136003)(366004)(107886003)(4326008)(55016002)(9686003)(83380400001)(33656002)(2906002)(52536014)(66946007)(5660300002)(30864003)(8676002)(8936002)(110136005)(186003)(316002)(86362001)(6506007)(71200400001)(478600001)(7696005)(53546011)(26005)(66446008)(76116006)(64756008)(66556008)(66476007)(579004)(559001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: sb2Zluz7Mg7j6ZdUeELYNkgr5SDBd342Be51R9EsvvZnyucx/XtlLc3HjcNHuo6sXMP8FkH+geWn6wMOYW92njfO5K6uFRDRzSwsqoWXU7VLRRS8C1NN0XShTccqznro9Ml9hfkU1V+TkuR4ps9mQOULj2WWmAy6lQqkveZ8nq5NNS442miJ3pNY23GdtkPG55UQPd0lROxmSiDG7LaStMDcjnfChTO5iIwJffxAX2HrgYmw9iGulT63uQ5bOZS9qw3t74OLKrPT0FKfXDptGDGOfeBK3/yk8rMJI6WXAd+EilfFcWBZbfJByQCbj2IqM7pSrDs18eTRb5b37K1a5EAdGM0Ij2leOxP41wbwndZQlh/iXrelNusKpEi+d8Zbf2PV+r16vm8WaPyNzI7pn9AOSb4Pcu8+N4H+/yE5tWmfdptcSXJFiy9+nqi3pNR8eoEOobRCRYF0R+tCBXXnwCr9sJI4rFyXUeWHo00xQHVg0n6Os6zCOhv7bZIrEohFkZuUSKjzPGH3oDOoPNzLl+SFXc7bW9jepSetZRo1vDnM/vPjn6hbz18IzJZMq6GrmgrFaT0cb8WC8fLXkw/PUalRmfBR1SRepVMvC/RGwXP1kMZwAGa4xnUzPupL2GISp2V6aWmpo4bGUobALtFoWg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd3e0f12-fa53-4e02-cca8-08d850f1d4c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2020 16:44:45.8701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wp5O+nnJ7zbDfCgdf1j8wvuemdgvGTEfg2GVTuHviTnFYUSNibvYDacT8JQzeSYAX5lrYf5qx4ZLKXVnKs25RsNlMsoL7h59Er7mGwNtFXQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2869 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 01/11] drivers/baseband: add PMD for ACC100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi,=20 > -----Original Message----- > From: Xu, Rosen >=20 > Hi, >=20 > > -----Original Message----- > > From: dev On Behalf Of Nicolas Chautru > > Sent: Wednesday, August 19, 2020 8:25 > > To: dev@dpdk.org; akhil.goyal@nxp.com > > Cc: Richardson, Bruce ; Chautru, Nicolas > > > > Subject: [dpdk-dev] [PATCH v3 01/11] drivers/baseband: add PMD for > > ACC100 > > > > Add stubs for the ACC100 PMD > > > > Signed-off-by: Nicolas Chautru > > --- > > config/common_base | 4 + > > doc/guides/bbdevs/acc100.rst | 233 +++++++++++++= ++++++++ > > doc/guides/bbdevs/index.rst | 1 + > > doc/guides/rel_notes/release_20_11.rst | 6 + > > drivers/baseband/Makefile | 2 + > > drivers/baseband/acc100/Makefile | 25 +++ > > drivers/baseband/acc100/meson.build | 6 + > > drivers/baseband/acc100/rte_acc100_pmd.c | 175 +++++++++++++= +++ > > drivers/baseband/acc100/rte_acc100_pmd.h | 37 ++++ > > .../acc100/rte_pmd_bbdev_acc100_version.map | 3 + > > drivers/baseband/meson.build | 2 +- > > mk/rte.app.mk | 1 + > > 12 files changed, 494 insertions(+), 1 deletion(-) create mode > > 100644 doc/guides/bbdevs/acc100.rst create mode 100644 > > drivers/baseband/acc100/Makefile create mode 100644 > > drivers/baseband/acc100/meson.build > > create mode 100644 drivers/baseband/acc100/rte_acc100_pmd.c > > create mode 100644 drivers/baseband/acc100/rte_acc100_pmd.h > > create mode 100644 > > drivers/baseband/acc100/rte_pmd_bbdev_acc100_version.map > > > > diff --git a/config/common_base b/config/common_base index > > fbf0ee7..218ab16 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -584,6 +584,10 @@ CONFIG_RTE_LIBRTE_PMD_BBDEV_NULL=3Dy > > # > > CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW=3Dy > > > > +# Compile PMD for ACC100 bbdev device # > > +CONFIG_RTE_LIBRTE_PMD_BBDEV_ACC100=3Dy > > + > > # > > # Compile PMD for Intel FPGA LTE FEC bbdev device # diff --git > > a/doc/guides/bbdevs/acc100.rst b/doc/guides/bbdevs/acc100.rst new file > > mode 100644 index 0000000..f87ee09 > > --- /dev/null > > +++ b/doc/guides/bbdevs/acc100.rst > > @@ -0,0 +1,233 @@ > > +.. SPDX-License-Identifier: BSD-3-Clause > > + Copyright(c) 2020 Intel Corporation > > + > > +Intel(R) ACC100 5G/4G FEC Poll Mode Driver > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + > > +The BBDEV ACC100 5G/4G FEC poll mode driver (PMD) supports an > > +implementation of a VRAN FEC wireless acceleration function. > > +This device is also known as Mount Bryce. > > + > > +Features > > +-------- > > + > > +ACC100 5G/4G FEC PMD supports the following features: > > + > > +- LDPC Encode in the DL (5GNR) > > +- LDPC Decode in the UL (5GNR) > > +- Turbo Encode in the DL (4G) > > +- Turbo Decode in the UL (4G) > > +- 16 VFs per PF (physical device) > > +- Maximum of 128 queues per VF > > +- PCIe Gen-3 x16 Interface > > +- MSI > > +- SR-IOV > > + > > +ACC100 5G/4G FEC PMD supports the following BBDEV capabilities: > > + > > +* For the LDPC encode operation: > > + - ``RTE_BBDEV_LDPC_CRC_24B_ATTACH`` : set to attach CRC24B to CB(s= ) > > + - ``RTE_BBDEV_LDPC_RATE_MATCH`` : if set then do not do Rate > > +Match > > bypass > > + - ``RTE_BBDEV_LDPC_INTERLEAVER_BYPASS`` : if set then bypass > > +interleaver > > + > > +* For the LDPC decode operation: > > + - ``RTE_BBDEV_LDPC_CRC_TYPE_24B_CHECK`` : check CRC24B from > CB(s) > > + - ``RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE`` : disable early > > termination > > + - ``RTE_BBDEV_LDPC_CRC_TYPE_24B_DROP`` : drops CRC24B bits > > appended while decoding > > + - ``RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE`` : provides an input for > > HARQ combining > > + - ``RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE`` : provides an input > > for HARQ combining > > + - ``RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_IN_ENABLE`` : HARQ > > memory input is internal > > + - ``RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_OUT_ENABLE`` : > HARQ > > memory output is internal > > + - ``RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK`` : > > loopback data to/from HARQ memory > > + - ``RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS`` : HARQ > > memory includes the fillers bits > > + - ``RTE_BBDEV_LDPC_DEC_SCATTER_GATHER`` : supports scatter-gather > > for input/output data > > + - ``RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION`` : supports > > compression of the HARQ input/output > > + - ``RTE_BBDEV_LDPC_LLR_COMPRESSION`` : supports LLR input > > +compression > > + > > +* For the turbo encode operation: > > + - ``RTE_BBDEV_TURBO_CRC_24B_ATTACH`` : set to attach CRC24B to > CB(s) > > + - ``RTE_BBDEV_TURBO_RATE_MATCH`` : if set then do not do Rate > > +Match > > bypass > > + - ``RTE_BBDEV_TURBO_ENC_INTERRUPTS`` : set for encoder dequeue > > interrupts > > + - ``RTE_BBDEV_TURBO_RV_INDEX_BYPASS`` : set to bypass RV index > > + - ``RTE_BBDEV_TURBO_ENC_SCATTER_GATHER`` : supports scatter- > > gather > > +for input/output data > > + > > +* For the turbo decode operation: > > + - ``RTE_BBDEV_TURBO_CRC_TYPE_24B`` : check CRC24B from CB(s) > > + - ``RTE_BBDEV_TURBO_SUBBLOCK_DEINTERLEAVE`` : perform subblock > > de-interleave > > + - ``RTE_BBDEV_TURBO_DEC_INTERRUPTS`` : set for decoder dequeue > > interrupts > > + - ``RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN`` : set if negative LLR > > + encoder > > i/p is supported > > + - ``RTE_BBDEV_TURBO_POS_LLR_1_BIT_IN`` : set if positive LLR > > + encoder > > i/p is supported > > + - ``RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP`` : keep CRC24B bits > > appended while decoding > > + - ``RTE_BBDEV_TURBO_EARLY_TERMINATION`` : set early early > > termination feature > > + - ``RTE_BBDEV_TURBO_DEC_SCATTER_GATHER`` : supports scatter- > > gather for input/output data > > + - ``RTE_BBDEV_TURBO_HALF_ITERATION_EVEN`` : set half iteration > > +granularity > > + > > +Installation > > +------------ > > + > > +Section 3 of the DPDK manual provides instuctions on installing and > > +compiling DPDK. The default set of bbdev compile flags may be found > > +in config/common_base, where for example the flag to build the ACC100 > > +5G/4G FEC device, ``CONFIG_RTE_LIBRTE_PMD_BBDEV_ACC100``, > > +is already set. > > + > > +DPDK requires hugepages to be configured as detailed in section 2 of > > +the > > DPDK manual. > > +The bbdev test application has been tested with a configuration 40 x > > +1GB hugepages. The hugepage configuration of a server may be examined > > using: > > + > > +.. code-block:: console > > + > > + grep Huge* /proc/meminfo > > + > > + > > +Initialization > > +-------------- > > + > > +When the device first powers up, its PCI Physical Functions (PF) can > > +be > > listed through this command: > > + > > +.. code-block:: console > > + > > + sudo lspci -vd8086:0d5c > > + > > +The physical and virtual functions are compatible with Linux UIO drive= rs: > > +``vfio`` and ``igb_uio``. However, in order to work the ACC100 5G/4G > > +FEC device firstly needs to be bound to one of these linux drivers > > +through > > DPDK. > > + > > + > > +Bind PF UIO driver(s) > > +~~~~~~~~~~~~~~~~~~~~~ > > + > > +Install the DPDK igb_uio driver, bind it with the PF PCI device ID > > +and use ``lspci`` to confirm the PF device is under use by > > +``igb_uio`` DPDK UIO > > driver. > > + > > +The igb_uio driver may be bound to the PF PCI device using one of > > +three > > methods: > > + > > + > > +1. PCI functions (physical or virtual, depending on the use case) can > > +be bound to the UIO driver by repeating this command for every functio= n. > > + > > +.. code-block:: console > > + > > + cd > > + insmod ./build/kmod/igb_uio.ko > > + echo "8086 0d5c" > /sys/bus/pci/drivers/igb_uio/new_id > > + lspci -vd8086:0d5c > > + > > + > > +2. Another way to bind PF with DPDK UIO driver is by using the > > +``dpdk-devbind.py`` tool > > + > > +.. code-block:: console > > + > > + cd > > + ./usertools/dpdk-devbind.py -b igb_uio 0000:06:00.0 > > + > > +where the PCI device ID (example: 0000:06:00.0) is obtained using > > +lspci -vd8086:0d5c > > + > > + > > +3. A third way to bind is to use ``dpdk-setup.sh`` tool > > + > > +.. code-block:: console > > + > > + cd > > + ./usertools/dpdk-setup.sh > > + > > + select 'Bind Ethernet/Crypto/Baseband device to IGB UIO module' > > + or > > + select 'Bind Ethernet/Crypto/Baseband device to VFIO module' > > + depending on driver required enter PCI device ID select 'Display > > + current Ethernet/Crypto/Baseband device settings' to confirm binding > > + > > + > > +In the same way the ACC100 5G/4G FEC PF can be bound with vfio, but > > +vfio driver does not support SR-IOV configuration right out of the > > +box, so it > > will need to be patched. > > + > > + > > +Enable Virtual Functions > > +~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +Now, it should be visible in the printouts that PCI PF is under > > +igb_uio control "``Kernel driver in use: igb_uio``" > > + > > +To show the number of available VFs on the device, read > > +``sriov_totalvfs`` > > file.. > > + > > +.. code-block:: console > > + > > + cat /sys/bus/pci/devices/0000\:\:./sriov_totalvfs > > + > > + where 0000\:\:. is the PCI device ID > > + > > + > > +To enable VFs via igb_uio, echo the number of virtual functions > > +intended to enable to ``max_vfs`` file.. > > + > > +.. code-block:: console > > + > > + echo > /sys/bus/pci/devices/0000\:\:./max_vfs > > + > > + > > +Afterwards, all VFs must be bound to appropriate UIO drivers as > > +required, same way it was done with the physical function previously. > > + > > +Enabling SR-IOV via vfio driver is pretty much the same, except that > > +the file name is different: > > + > > +.. code-block:: console > > + > > + echo > > > + /sys/bus/pci/devices/0000\:\:./sriov_numvfs > > + > > + > > +Configure the VFs through PF > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +The PCI virtual functions must be configured before working or > > +getting assigned to VMs/Containers. The configuration involves > > +allocating the number of hardware queues, priorities, load balance, > > +bandwidth and other settings necessary for the device to perform FEC > functions. > > + > > +This configuration needs to be executed at least once after reboot or > > +PCI FLR and can be achieved by using the function > > +``acc100_configure()``, which sets up the parameters defined in > > ``acc100_conf`` structure. > > + > > +Test Application > > +---------------- > > + > > +BBDEV provides a test application, ``test-bbdev.py`` and range of > > +test data for testing the functionality of ACC100 5G/4G FEC encode > > +and decode, depending on the device's capabilities. The test > > +application is located under app->test-bbdev folder and has the follow= ing > options: > > + > > +.. code-block:: console > > + > > + "-p", "--testapp-path": specifies path to the bbdev test app. > > + "-e", "--eal-params" : EAL arguments which are passed to the test ap= p. > > + "-t", "--timeout" : Timeout in seconds (default=3D300). > > + "-c", "--test-cases" : Defines test cases to run. Run all if not spe= cified. > > + "-v", "--test-vector" : Test vector path (default=3Ddpdk_path+/app/t= est- > > bbdev/test_vectors/bbdev_null.data). > > + "-n", "--num-ops" : Number of operations to process on device > > (default=3D32). > > + "-b", "--burst-size" : Operations enqueue/dequeue burst size > > (default=3D32). > > + "-s", "--snr" : SNR in dB used when generating LLRs for bler tests. > > + "-s", "--iter_max" : Number of iterations for LDPC decoder. > > + "-l", "--num-lcores" : Number of lcores to run (default=3D16). > > + "-i", "--init-device" : Initialise PF device with default values. > > + > > + > > +To execute the test application tool using simple decode or encode > > +data, type one of the following: > > + > > +.. code-block:: console > > + > > + ./test-bbdev.py -c validation -n 64 -b 1 -v ./ldpc_dec_default.data > > + ./test-bbdev.py -c validation -n 64 -b 1 -v ./ldpc_enc_default.data > > + > > + > > +The test application ``test-bbdev.py``, supports the ability to > > +configure the PF device with a default set of values, if the "-i" or > > +"- -init-device" option is included. The default values are defined > > +in > > test_bbdev_perf.c. > > + > > + > > +Test Vectors > > +~~~~~~~~~~~~ > > + > > +In addition to the simple LDPC decoder and LDPC encoder tests, bbdev > > +also provides a range of additional tests under the test_vectors > > +folder, which may be useful. The results of these tests will depend > > +on the ACC100 5G/4G FEC capabilities which may cause some testcases > > +to be > > skipped, but no failure should be reported. > > diff --git a/doc/guides/bbdevs/index.rst b/doc/guides/bbdevs/index.rst > > index a8092dd..4445cbd 100644 > > --- a/doc/guides/bbdevs/index.rst > > +++ b/doc/guides/bbdevs/index.rst > > @@ -13,3 +13,4 @@ Baseband Device Drivers > > turbo_sw > > fpga_lte_fec > > fpga_5gnr_fec > > + acc100 > > diff --git a/doc/guides/rel_notes/release_20_11.rst > > b/doc/guides/rel_notes/release_20_11.rst > > index df227a1..b3ab614 100644 > > --- a/doc/guides/rel_notes/release_20_11.rst > > +++ b/doc/guides/rel_notes/release_20_11.rst > > @@ -55,6 +55,12 @@ New Features > > Also, make sure to start the actual text at the margin. > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > +* **Added Intel ACC100 bbdev PMD.** > > + > > + Added a new ``acc100`` bbdev driver for the Intel\ |reg| ACC100 > > + accelerator also known as Mount Bryce. See the > > + :doc:`../bbdevs/acc100` BBDEV guide for more details on this new driv= er. > > + > > > > Removed Items > > ------------- > > diff --git a/drivers/baseband/Makefile b/drivers/baseband/Makefile > > index > > dcc0969..b640294 100644 > > --- a/drivers/baseband/Makefile > > +++ b/drivers/baseband/Makefile > > @@ -10,6 +10,8 @@ DIRS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_NULL) +=3D > null > > DEPDIRS-null =3D $(core-libs) > > DIRS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) +=3D turbo_sw > > DEPDIRS-turbo_sw =3D $(core-libs) > > +DIRS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_ACC100) +=3D acc100 > > +DEPDIRS-acc100 =3D $(core-libs) > > DIRS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC) +=3D fpga_lte_fec > > DEPDIRS-fpga_lte_fec =3D $(core-libs) > > DIRS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC) +=3D > fpga_5gnr_fec > > diff --git a/drivers/baseband/acc100/Makefile > > b/drivers/baseband/acc100/Makefile > > new file mode 100644 > > index 0000000..c79e487 > > --- /dev/null > > +++ b/drivers/baseband/acc100/Makefile > > @@ -0,0 +1,25 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2020 Intel > > +Corporation > > + > > +include $(RTE_SDK)/mk/rte.vars.mk > > + > > +# library name > > +LIB =3D librte_pmd_bbdev_acc100.a > > + > > +# build flags > > +CFLAGS +=3D -O3 > > +CFLAGS +=3D $(WERROR_FLAGS) > > +LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -lrte_cfgfil= e > > +LDLIBS +=3D -lrte_bbdev LDLIBS +=3D -lrte_pci -lrte_bus_pci > > + > > +# versioning export map > > +EXPORT_MAP :=3D rte_pmd_bbdev_acc100_version.map > > + > > +# library version > > +LIBABIVER :=3D 1 > > + > > +# library source files > > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_ACC100) +=3D rte_acc100_pmd.c > > + > > +include $(RTE_SDK)/mk/rte.lib.mk > > diff --git a/drivers/baseband/acc100/meson.build > > b/drivers/baseband/acc100/meson.build > > new file mode 100644 > > index 0000000..8afafc2 > > --- /dev/null > > +++ b/drivers/baseband/acc100/meson.build > > @@ -0,0 +1,6 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2020 Intel > > +Corporation > > + > > +deps +=3D ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci'] > > + > > +sources =3D files('rte_acc100_pmd.c') > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c > > b/drivers/baseband/acc100/rte_acc100_pmd.c > > new file mode 100644 > > index 0000000..1b4cd13 > > --- /dev/null > > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > > @@ -0,0 +1,175 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2020 Intel Corporation */ > > + > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include "rte_acc100_pmd.h" > > + > > +#ifdef RTE_LIBRTE_BBDEV_DEBUG > > +RTE_LOG_REGISTER(acc100_logtype, pmd.bb.acc100, DEBUG); #else > > +RTE_LOG_REGISTER(acc100_logtype, pmd.bb.acc100, NOTICE); #endif > > + > > +/* Free 64MB memory used for software rings */ static int > > +acc100_dev_close(struct rte_bbdev *dev __rte_unused) { > > + return 0; > > +} > > + > > +static const struct rte_bbdev_ops acc100_bbdev_ops =3D { > > + .close =3D acc100_dev_close, > > +}; > > + > > +/* ACC100 PCI PF address map */ > > +static struct rte_pci_id pci_id_acc100_pf_map[] =3D { > > + { > > + RTE_PCI_DEVICE(RTE_ACC100_VENDOR_ID, > > RTE_ACC100_PF_DEVICE_ID) > > + }, > > + {.device_id =3D 0}, > > +}; > > + > > +/* ACC100 PCI VF address map */ > > +static struct rte_pci_id pci_id_acc100_vf_map[] =3D { > > + { > > + RTE_PCI_DEVICE(RTE_ACC100_VENDOR_ID, > > RTE_ACC100_VF_DEVICE_ID) > > + }, > > + {.device_id =3D 0}, > > +}; > > + > > +/* Initialization Function */ > > +static void > > +acc100_bbdev_init(struct rte_bbdev *dev, struct rte_pci_driver *drv) { > > + struct rte_pci_device *pci_dev =3D RTE_DEV_TO_PCI(dev->device); > > + > > + dev->dev_ops =3D &acc100_bbdev_ops; > > + > > + ((struct acc100_device *) dev->data->dev_private)->pf_device =3D > > + !strcmp(drv->driver.name, > > + RTE_STR(ACC100PF_DRIVER_NAME)); > > + ((struct acc100_device *) dev->data->dev_private)->mmio_base =3D > > + pci_dev->mem_resource[0].addr; > > + > > + rte_bbdev_log_debug("Init device %s [%s] @ vaddr %p > > paddr %#"PRIx64"", > > + drv->driver.name, dev->data->name, > > + (void *)pci_dev->mem_resource[0].addr, > > + pci_dev->mem_resource[0].phys_addr); > > +} > > + > > +static int acc100_pci_probe(struct rte_pci_driver *pci_drv, > > + struct rte_pci_device *pci_dev) > > +{ > > + struct rte_bbdev *bbdev =3D NULL; > > + char dev_name[RTE_BBDEV_NAME_MAX_LEN]; > > + > > + if (pci_dev =3D=3D NULL) { > > + rte_bbdev_log(ERR, "NULL PCI device"); > > + return -EINVAL; > > + } > > + > > + rte_pci_device_name(&pci_dev->addr, dev_name, > > sizeof(dev_name)); > > + > > + /* Allocate memory to be used privately by drivers */ > > + bbdev =3D rte_bbdev_allocate(pci_dev->device.name); > > + if (bbdev =3D=3D NULL) > > + return -ENODEV; > > + > > + /* allocate device private memory */ > > + bbdev->data->dev_private =3D rte_zmalloc_socket(dev_name, > > + sizeof(struct acc100_device), RTE_CACHE_LINE_SIZE, > > + pci_dev->device.numa_node); > > + > > + if (bbdev->data->dev_private =3D=3D NULL) { > > + rte_bbdev_log(CRIT, > > + "Allocate of %zu bytes for device \"%s\" > > failed", > > + sizeof(struct acc100_device), dev_name); > > + rte_bbdev_release(bbdev); > > + return -ENOMEM; > > + } > > + > > + /* Fill HW specific part of device structure */ > > + bbdev->device =3D &pci_dev->device; > > + bbdev->intr_handle =3D &pci_dev->intr_handle; > > + bbdev->data->socket_id =3D pci_dev->device.numa_node; > > + > > + /* Invoke ACC100 device initialization function */ > > + acc100_bbdev_init(bbdev, pci_drv); > > + > > + rte_bbdev_log_debug("Initialised bbdev %s (id =3D %u)", > > + dev_name, bbdev->data->dev_id); > > + return 0; > > +} > > + > > +static int acc100_pci_remove(struct rte_pci_device *pci_dev) { > > + struct rte_bbdev *bbdev; > > + int ret; > > + uint8_t dev_id; > > + > > + if (pci_dev =3D=3D NULL) > > + return -EINVAL; > > + > > + /* Find device */ > > + bbdev =3D rte_bbdev_get_named_dev(pci_dev->device.name); > > + if (bbdev =3D=3D NULL) { > > + rte_bbdev_log(CRIT, > > + "Couldn't find HW dev \"%s\" to uninitialise > > it", > > + pci_dev->device.name); > > + return -ENODEV; > > + } > > + dev_id =3D bbdev->data->dev_id; > > + > > + /* free device private memory before close */ > > + rte_free(bbdev->data->dev_private); > > + > > + /* Close device */ > > + ret =3D rte_bbdev_close(dev_id); > > + if (ret < 0) > > + rte_bbdev_log(ERR, > > + "Device %i failed to close during uninit: %i", > > + dev_id, ret); > > + > > + /* release bbdev from library */ > > + rte_bbdev_release(bbdev); > > + > > + rte_bbdev_log_debug("Destroyed bbdev =3D %u", dev_id); > > + > > + return 0; > > +} > > + > > +static struct rte_pci_driver acc100_pci_pf_driver =3D { > > + .probe =3D acc100_pci_probe, > > + .remove =3D acc100_pci_remove, > > + .id_table =3D pci_id_acc100_pf_map, > > + .drv_flags =3D RTE_PCI_DRV_NEED_MAPPING }; > > + > > +static struct rte_pci_driver acc100_pci_vf_driver =3D { > > + .probe =3D acc100_pci_probe, > > + .remove =3D acc100_pci_remove, > > + .id_table =3D pci_id_acc100_vf_map, > > + .drv_flags =3D RTE_PCI_DRV_NEED_MAPPING }; > > + > > +RTE_PMD_REGISTER_PCI(ACC100PF_DRIVER_NAME, > acc100_pci_pf_driver); > > +RTE_PMD_REGISTER_PCI_TABLE(ACC100PF_DRIVER_NAME, > > pci_id_acc100_pf_map); > > +RTE_PMD_REGISTER_PCI(ACC100VF_DRIVER_NAME, > acc100_pci_vf_driver); > > +RTE_PMD_REGISTER_PCI_TABLE(ACC100VF_DRIVER_NAME, > > pci_id_acc100_vf_map); >=20 > It seems both PF and VF share same date for rte_pci_driver, it's strange = to > duplicate code. Hi Rosen,=20 These 2 small structure differs since they map different device ids to diff= erent driver names while the 2 probe/remove functions share same function c= all with differences being handled within the underlying implementation whe= n required based on the device driver being actually for PF vs VF.=20 Basically that is used to clearly expose and carry the differences of the d= river for PF and VF which have slightly different functionality and impleme= ntation, even though they share the same probe/remove actual functions to l= imit code duplication (similarly for other functions, you will see the diff= erence within the code for these related function only when required when i= t assesses whether the underlying driver is for PF or VF. There is in effec= t no duplicate code this way).=20 I believe that this is best way to limit code duplication to only the place= s where it brings value and clarity while implementation are kept as generi= c as comprehensively as possible.=20 Note also that we use the same exact model for other existing bbdev PMDs an= d I want to carry the same split moving forward when possible (existing use= rs are used to this from RTE EAL probing print notably) on top of keep the = code clean.=20 I hope this makes sense from these different aspects.=20 Thanks again for your thorough review Nic >=20 > > + > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.h > > b/drivers/baseband/acc100/rte_acc100_pmd.h > > new file mode 100644 > > index 0000000..6f46df0 > > --- /dev/null > > +++ b/drivers/baseband/acc100/rte_acc100_pmd.h > > @@ -0,0 +1,37 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2020 Intel Corporation */ > > + > > +#ifndef _RTE_ACC100_PMD_H_ > > +#define _RTE_ACC100_PMD_H_ > > + > > +/* Helper macro for logging */ > > +#define rte_bbdev_log(level, fmt, ...) \ > > + rte_log(RTE_LOG_ ## level, acc100_logtype, fmt "\n", \ > > + ##__VA_ARGS__) > > + > > +#ifdef RTE_LIBRTE_BBDEV_DEBUG > > +#define rte_bbdev_log_debug(fmt, ...) \ > > + rte_bbdev_log(DEBUG, "acc100_pmd: " fmt, \ > > + ##__VA_ARGS__) > > +#else > > +#define rte_bbdev_log_debug(fmt, ...) #endif > > + > > +/* ACC100 PF and VF driver names */ > > +#define ACC100PF_DRIVER_NAME intel_acc100_pf > > +#define ACC100VF_DRIVER_NAME intel_acc100_vf > > + > > +/* ACC100 PCI vendor & device IDs */ > > +#define RTE_ACC100_VENDOR_ID (0x8086) > > +#define RTE_ACC100_PF_DEVICE_ID (0x0d5c) > > +#define RTE_ACC100_VF_DEVICE_ID (0x0d5d) > > + > > +/* Private data structure for each ACC100 device */ struct > > +acc100_device { > > + void *mmio_base; /**< Base address of MMIO registers (BAR0) */ > > + bool pf_device; /**< True if this is a PF ACC100 device */ > > + bool configured; /**< True if this ACC100 device is configured */ }; > > + > > +#endif /* _RTE_ACC100_PMD_H_ */ > > diff --git a/drivers/baseband/acc100/rte_pmd_bbdev_acc100_version.map > > b/drivers/baseband/acc100/rte_pmd_bbdev_acc100_version.map > > new file mode 100644 > > index 0000000..4a76d1d > > --- /dev/null > > +++ b/drivers/baseband/acc100/rte_pmd_bbdev_acc100_version.map > > @@ -0,0 +1,3 @@ > > +DPDK_21 { > > + local: *; > > +}; > > diff --git a/drivers/baseband/meson.build > > b/drivers/baseband/meson.build index 415b672..72301ce 100644 > > --- a/drivers/baseband/meson.build > > +++ b/drivers/baseband/meson.build > > @@ -5,7 +5,7 @@ if is_windows > > subdir_done() > > endif > > > > -drivers =3D ['null', 'turbo_sw', 'fpga_lte_fec', 'fpga_5gnr_fec'] > > +drivers =3D ['null', 'turbo_sw', 'fpga_lte_fec', 'fpga_5gnr_fec', > > +'acc100'] > > > > config_flag_fmt =3D 'RTE_LIBRTE_PMD_BBDEV_@0@' > > driver_name_fmt =3D 'rte_pmd_bbdev_@0@' > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index a544259..a77f538 > > 100644 > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -254,6 +254,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) +=3D > > -lrte_pmd_netvsc > > > > ifeq ($(CONFIG_RTE_LIBRTE_BBDEV),y) > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_NULL) +=3D - > > lrte_pmd_bbdev_null > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_ACC100) +=3D - > > lrte_pmd_bbdev_acc100 > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC) +=3D - > > lrte_pmd_bbdev_fpga_lte_fec > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC) +=3D - > > lrte_pmd_bbdev_fpga_5gnr_fec > > > > -- > > 1.8.3.1