DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Akhil Goyal <gakhil@marvell.com>,
	"Zhang, Mingshan" <mingshan.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Subject: RE: [EXT] [PATCH -v1] bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
Date: Thu, 18 Nov 2021 15:16:44 +0000	[thread overview]
Message-ID: <BY5PR11MB445159FF42FEFDB6D64D84E9F89B9@BY5PR11MB4451.namprd11.prod.outlook.com> (raw)
In-Reply-To: <PH0PR18MB4491CE6A627331C11CDFA238D89B9@PH0PR18MB4491.namprd18.prod.outlook.com>

Hi Akhil, 
The change below from Mingshan is not for 21.11, this is targeting following release. It should have been mentioned in cover letter. 
Thanks
Nic


> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Wednesday, November 17, 2021 11:21 PM
> To: Zhang, Mingshan <mingshan.zhang@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>
> Subject: RE: [EXT] [PATCH -v1] bbdev: update num_ops type to be uint32_t in
> rte_bbdev_enc_op_alloc_bulk
> 
> > From: Mingshan Zhang <mingshan.zhang@intel.com>
> 
> Title is too big. Please run ./devtools/check-git-log.sh.
> >
> > update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
> Explain the need for this change. We only take critical fixes in the APIs for
> RC4.
> Bbdev APIs are not experimental anymore. Please rebase on TOT.
> This change is an API change which may need deprecation notice from next
> release.
> 
> >
> > Signed-off-by: Mingshan Zhang <mingshan.zhang@intel.com>
> > ---
> >  doc/guides/prog_guide/bbdev.rst | 4 ++--
> >  lib/bbdev/rte_bbdev_op.h        | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/guides/prog_guide/bbdev.rst
> > b/doc/guides/prog_guide/bbdev.rst index 70fa01a..c330e08 100644
> > --- a/doc/guides/prog_guide/bbdev.rst
> > +++ b/doc/guides/prog_guide/bbdev.rst
> > @@ -387,10 +387,10 @@ allocate bbdev operations of a specific type
> > from a given bbdev operation mempoo  .. code-block:: c
> >
> >      int rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> > -            struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> > +            struct rte_bbdev_enc_op **ops, uint32_t num_ops)
> >
> >      int rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> > -            struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> > +            struct rte_bbdev_dec_op **ops, uint32_t num_ops)
> >
> >  ``rte_bbdev_*_op_free_bulk()`` is called by the application to return
> > an  operation to its allocating pool.
> > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index
> > 5512859..f074b35 100644
> > --- a/lib/bbdev/rte_bbdev_op.h
> > +++ b/lib/bbdev/rte_bbdev_op.h
> > @@ -867,7 +867,7 @@ struct rte_mempool *  __rte_experimental  static
> > inline int  rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_enc_op **ops, uint32_t num_ops)
> >  {
> >  	struct rte_bbdev_op_pool_private *priv;
> >  	int ret;
> > @@ -904,7 +904,7 @@ struct rte_mempool *  __rte_experimental  static
> > inline int  rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_dec_op **ops, uint32_t num_ops)
> >  {
> >  	struct rte_bbdev_op_pool_private *priv;
> >  	int ret;
> > --
> > 1.8.3.1


      reply	other threads:[~2021-11-18 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  1:55 [PATCH -v1] Update " Zhang, Mingshan
2021-11-17  1:55 ` [PATCH -v1] bbdev: update " Zhang, Mingshan
2021-11-18  7:20   ` [EXT] " Akhil Goyal
2021-11-18 15:16     ` Chautru, Nicolas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB445159FF42FEFDB6D64D84E9F89B9@BY5PR11MB4451.namprd11.prod.outlook.com \
    --to=nicolas.chautru@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=mingshan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).