From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B798A0543; Mon, 13 Jun 2022 22:19:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1EDB4067C; Mon, 13 Jun 2022 22:19:44 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 89B9640223 for ; Mon, 13 Jun 2022 22:19:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655151582; x=1686687582; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=P7a4pe55A3OjKRZak6KWrA7YSnqxBod1GLmpRzgnwx8=; b=bs4L+bnib/Uiblp1AX7TrT+M8bY8/JOJ1iLDmp0fWAWd0zYWUyjdi0be 8ubioXUrqSfaOQUkD4g4VdVOQriMkJfK7V+D5RdpJWLQbRmj0mxM9odqa +/lak1ukkifUFSwXNYiB3wdX60Db0rH5UjO3D5j5X42KUjfTXOuAxwy+G YpLNEpoihuaFOQLjbxgsSgrsdV/PNcJ3/5RqilNc0C6CBljPO1V7fEXh3 fzegQlDRnRyukts0YANGs+MZK5jXGBtwAtiiJ51SAF3+nCAEFSgtNLqiP VfMGoKn8JCu+We6C2mBE2XFW6OhWOzkEu+89W5xSOrkFNrKi6zvMa2XpG Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="258231043" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="258231043" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 13:19:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="535254687" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 13 Jun 2022 13:19:41 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 13 Jun 2022 13:19:40 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 13 Jun 2022 13:19:40 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 13 Jun 2022 13:19:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GV8/EGAGUb6fc8Dd7AZJoEKTwya7ti2ucCq7e8d3qlNke/T53mElWr57tZdKqK/rYcNSXF3AT8/lxEOvO2qlFTIcsnsU9QMVCt470LTtOHsOzG8vBo1XSVggAQSvydvyHIMN0H6GRss/Jb3tvURUiutOPGCxl0WZ7Q7FDweEcT8mTH7qI/IGNYer7tIVWQO8C2cP5eUQkuNzv8hLgAw0S+DhMDA+A4oIO9j+LehqrHVqZwOivnnll9GNqntzQTVWy498qlCBIe8PJ54eKPVo9pb1oltPP0/yKK+/QUmB5shL3DBKp7WGANMj2EAeC/gNDih4AeAq8BODzXu0OuJUNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P7a4pe55A3OjKRZak6KWrA7YSnqxBod1GLmpRzgnwx8=; b=RDHsQJDi5Xpd4JFL7YixstRadifFQKtvaCggS39oVTNlg1C2Kym0EE4stAHnSYOO9kluji7OU74DLJM/au2pFnTtoGCY5FhR8cwhHfbpdKuQp8s5vz1lsh4aWAKDKluIhgwoz/HQgusISzYs4FP5Ll7TmvwUl/d6A5ppMd291fv0YLvgKWDqpSnjOgxD8Y64AxoxGWH1z6onkONzAbKLscUZFsXATBT6j5HWCUTw7re4ztpNDjD5zwmbEAEIYsrM1czGQY3Pfa40R5VqA0MnCJ081kssYmWSjSfELn03N+vbxcbi8mVsowVZvlIPevlnzlaxBYmJE3s4zvgvfzOWQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by MWHPR11MB1264.namprd11.prod.outlook.com (2603:10b6:300:27::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.14; Mon, 13 Jun 2022 20:19:38 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::cd54:e1b7:e3f:4069]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::cd54:e1b7:e3f:4069%6]) with mapi id 15.20.5332.020; Mon, 13 Jun 2022 20:19:38 +0000 From: "Chautru, Nicolas" To: Stephen Hemminger CC: "dev@dpdk.org" , "thomas@monjalon.net" , "maxime.coquelin@redhat.com" , "trix@redhat.com" , "mdr@ashroe.eu" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "david.marchand@redhat.com" Subject: RE: [PATCH v1] bbdev: allow operation type enum for growth Thread-Topic: [PATCH v1] bbdev: allow operation type enum for growth Thread-Index: AQHYf1Ru213M4cswzk+hiLnE85rzMq1NpwGAgAAXcACAAAXt4A== Date: Mon, 13 Jun 2022 20:19:38 +0000 Message-ID: References: <1655144675-14363-1-git-send-email-nicolas.chautru@intel.com> <1655144675-14363-2-git-send-email-nicolas.chautru@intel.com> <20220613124828.63705c72@hermes.local> In-Reply-To: <20220613124828.63705c72@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7305e5bd-b98c-47ab-519a-08da4d7a0a7b x-ms-traffictypediagnostic: MWHPR11MB1264:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vDZwGgzJuX0Nr0LeZN3n1f74g88SOl47wPX4+Hm1wJzRMZOXMEscsjfZldYh8k9lpLl2GuHFaLxl3rllVWOHmzXQVf/JsmvILabjC46dziip+bZfs2b+M3OH+dyZVJGf/rh1q2vKZo2sp1i2fvkc/pl3Uwgur0/Y4NskHedppNyRRWdzlXBYYDAuyYB8VcPYKK+qJXxTEOMDaymRlnQnSVdPt4nkTgkSLVVCcDl/Dr+fz0D4vtBBWfMftnbTycZGkd1lOmhSEg5xXYVByLztzjYgqpBHH6ZyO+k6JvSiZe5j1BAskyd1QB9mZ6gKjo7zG+jYCsuz7RJ96QykhN4WqTvwOn20pw08ZbpdNVLF8TgxwcNcmC47/lAv3FgdSHx1n5WjqLVcTC9fefAcOzCBJSkk3Wu5cD2lChkIYDwdlgUsfjKrnFlhR+5phoIshH0W92G9C8HGCjW952ejpRue5xYNJzNT1wxUG7RkSiuF5BhVxfTTpfWZqqeQ1T8/jM2OfvHSZFpxbCYqvGtuIidwalyXhbtary4iV9mNu4puWsWnOQujM/XpzROUsUDaKVo3eTqrGfbja085tvyfzQbqWIj7yOKrqVpwEHuaEi+N//jj5vAhoZoIb324ND0YW2A6rCAEJrPCwVgmm5KPc0JoYf5sEjzNQOuv9NiYPcKo2wWvTdViS/UdMurhvmgzhXZFULFkaXe3FohXR2KJ6QSu/A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(52536014)(8936002)(122000001)(38070700005)(64756008)(66556008)(66476007)(33656002)(9686003)(6916009)(5660300002)(26005)(82960400001)(71200400001)(38100700002)(316002)(54906003)(86362001)(76116006)(66446008)(7696005)(53546011)(2906002)(83380400001)(508600001)(6506007)(66946007)(8676002)(186003)(4326008)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5qsOy/QV668R1Q/gC8mZlN0zshj4XMqIpHTyOHqm1D2lkDdKb80ZUdz2jQUk?= =?us-ascii?Q?oMK9KE2vU5/WizSxu6oA9YWpyBmVmWgX4P1s3+lJBpZUC/Trky0sq6TNS21m?= =?us-ascii?Q?wUi+/dG4UeebGPLYx8sZF5ljI/fOH8qtw/2D7/dtHW3XUHf356QV4OQoMSIg?= =?us-ascii?Q?3857D+EFHmvaom4kKEhqPsHpa7Hz2sT7621cNK7l/PISjblO7T2fShLKlDpV?= =?us-ascii?Q?9dWWOrhOCx/qQuthDVsPZ0518tcLBLQafcX+O/MrTmm8U6tEy9cdI2tbEsIo?= =?us-ascii?Q?dJTouhbGdtyKZQoEkI/Y+fS2fYkEooqR0mO6QM8yueb1ExpbYpAVRe5zMYsB?= =?us-ascii?Q?rTTLrS+xqYtoaMz+Atuxl3JIHMVYi2mbcK0hY22Vh7H9uRE4gFXlAcN+jCV4?= =?us-ascii?Q?ntAdbXyH1AY2/EAF310WVJyE7wX34DvLX4/xd5xHMfkFPbBnKo1P5SZyMFIT?= =?us-ascii?Q?aUbeUI+DvBD0CwJ0WSzQo6ROLh4xdOHiRhj+TytIFdGFgcG62Ld/AdVkFM5A?= =?us-ascii?Q?AUbq5Q8/a3DbisuKUlC74lnTxufR6QMOOToVcry8hHyZRRwQDqokkNfXikG0?= =?us-ascii?Q?iFKQ3GXsshRcoQNGyqxMr3/58nsE2PdYH58nSGlBy3Idul9mbAAiPvTUpIIT?= =?us-ascii?Q?NQ+BXujX6BpScPtbjGEjxwopBVGqeeuT90X3jAcFaDHWsZ2y4/bsvSftWxc4?= =?us-ascii?Q?tREUUI25ex4zaBNQMfM3BIgB+vm7WLsq2nig44VIzuCImTBFym1vqlA03ptA?= =?us-ascii?Q?7Cue91SVwDO2092JkUa5Nt9k1htLaaBbs/VPRyAvyowbQOHwGFAUW6OeHsB8?= =?us-ascii?Q?Rw8w3mQ1GjTjzthd+RWCDHf6tH05XeY+WRO0isdDDSX2KSJRZjuTrJyLwbeF?= =?us-ascii?Q?j/mNXqqEoC92uZCt2bMQImnKrdB+7NYNRoCdhF+HeNGUY2yx+/N5p8Ln9eMz?= =?us-ascii?Q?r4406leY5n3HiaBFrze02vlS6+SRl1UziEQaRpCkcf5dWD9qCelFA8LXvR15?= =?us-ascii?Q?X5WUfwrS81DUYIre5HjqTRkIJUqYnadk/Xyaie9OlhYTLZTexr/pmJ1wiBh+?= =?us-ascii?Q?tt936cQLPq7HmSBOztWK5xjjKPoE0HUTOIhTGIKLowWW5gj0tGNALZnQHWO1?= =?us-ascii?Q?nyypR/7vzwndfpjBoG0tWTtACSvyA2HzsidlsnuEANNurSh+SYVjXU4V0nDk?= =?us-ascii?Q?XNbz9x8388+wnaHpqpzHaAP4dY7VZ29MKkXbERsJKaCBOPpjtumWtKWzC2bY?= =?us-ascii?Q?fk6VqqU1xUq2gx1F7IUIz726gXQYdmxm6H6uamZdBS9pYEFEOQNo5YwuiNgH?= =?us-ascii?Q?iDjwY62hPfFgTctj0cEkrW08sbWUwHbrAVOufar7EiHPM2g97YcB8nKp8KYN?= =?us-ascii?Q?kABD2ulmUV8IT2dHjY30jlA4Fo8ozpqa5b8/GVy9OIG8o8rWIg2v94gHm72A?= =?us-ascii?Q?jag3lhl1P5VK3Hb+NcYf7OM6GKvqHNYdFjwF2sywS0W2NnImaIdkUtt/q5V1?= =?us-ascii?Q?xUDB0cirvGT5GKIPAwQ2rg9C8aISrWDV4479tmaO91xYbNXMBAq+NXQzV/r+?= =?us-ascii?Q?Td/3Qmpv063gXh4GPkVYZTRJjfiapodfln5YaL0x7GyY8uXvmkQsS/GIB+/f?= =?us-ascii?Q?Emt1ifYrNXE41ktrQMA6Qiqrv7KoqlQ2RiGvBSoahpDn8F2A787OMLjLuZDF?= =?us-ascii?Q?CMu89qcdmi7lM1eatVvxSyZs+El88ApwcUHuyPDFpU3tcLon6JlcWVzojiHZ?= =?us-ascii?Q?aGWY7sgRJXdE/ERPrDh1aY+42xocSfM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7305e5bd-b98c-47ab-519a-08da4d7a0a7b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2022 20:19:38.3080 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /FhAh+FTsEZfoX5io5+DklFUFZTNgPPC1erzaDJM3FZPXh6OCQMiSxNixZjaid878Q1vtGtYmEa0C5GphdG/o3mraq1+IbPd4skF/Nzwqe0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1264 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen,=20 > -----Original Message----- > From: Stephen Hemminger > Sent: Monday, June 13, 2022 12:48 PM > To: Chautru, Nicolas > Cc: dev@dpdk.org; thomas@monjalon.net; maxime.coquelin@redhat.com; > trix@redhat.com; mdr@ashroe.eu; Richardson, Bruce > ; hemant.agrawal@nxp.com; > david.marchand@redhat.com > Subject: Re: [PATCH v1] bbdev: allow operation type enum for growth >=20 > On Mon, 13 Jun 2022 11:24:35 -0700 > Nicolas Chautru wrote: >=20 > > Updating the last enum for rte_bbdev_op_type to allow for enum > > insertion. > > > > Signed-off-by: Nicolas Chautru >=20 > Only allowed if you check now for the any of the reserved types and fail. Let me try to clarify what you mean. You would enforce such check in which = function? Do you mean in any implementation of bbdev function taking enum r= te_bbdev_op_type as argument? In that case do you mean having in effect 2 values:=20 - one for the number of supported implemented operation type =3D could be k= ept private within rte_bbdev.c implementation, purely to reject using a non= -supported operation type - and another higher value for padded maximum numbers of operations allowin= g for enumeration insertion. That would sound fine to me, but please kindly confirm this is what you are= implying.=20 I will also check for Thomas feedback as well, thanks.=20