From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D13FCA0548; Thu, 22 Apr 2021 17:20:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B567541CAF; Thu, 22 Apr 2021 17:20:36 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2485941C9D for ; Thu, 22 Apr 2021 17:20:34 +0200 (CEST) IronPort-SDR: YC/X16iS8Ct021Wi14O34L7PEYN41YI7dGbFo6oHmFIotbya+u2jbMpb/Zj1ru8asFB4kFZ0Ib FeaWBAspYlFQ== X-IronPort-AV: E=McAfee;i="6200,9189,9962"; a="196018176" X-IronPort-AV: E=Sophos;i="5.82,241,1613462400"; d="scan'208";a="196018176" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 08:20:33 -0700 IronPort-SDR: eLJ45aQMRw18/ieqchrbBL4fyTx8O4UUVRygk9U12apLVRnM6vtnvzOtM8AybuXsptgLr8XFT/ Fp7GaXkTjpzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="401868956" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 22 Apr 2021 08:20:33 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 22 Apr 2021 08:20:32 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 22 Apr 2021 08:20:32 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 22 Apr 2021 08:20:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hrOBHj7rLYBOQys7I8wvqf92qvc4GerBzDcwfVRLHIb718RXsBytErggD0db5obvuPcRJkLyFsMSeunIp1hODf/W8Ujn4JSJyKmpSFNHFVX4d7XH51Gn+yimvUE46ebtWTU39J0FkrQQRRwW9SMbn9rsdM9XUg60kIMO9c5Sx00l+tdkD8VsZeBbpunDz3EZcTcdJC0hL/rSdaGM75gjsZio6Ld8eCLu+zGx9e2eRg3zsLuPDFxtCKaE84feICX3iuZOz65Njepp0IfKXBnYVNLGCqpBOhX3E6gKTQ9Zmy9LFW7lHDreD93iv7QpurU3jyeRAiY56k9733TrlALa2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l0xMXZmlHuVM3EEBQd7bqDWOuRONj0u2lAuRIIvpPbo=; b=VuMHl4Z+a7KPv6o4XxSQ60t0W12AdEjw534W3IXfvwkX25Fro6xqQRkxkElD05w0N1vLFMEQzsSQihVy01TG91O1I8uoFdR3hE5o/z9fXsVaTkg9ilKinZGJPKAFYLU2f+DHtoLc8qDni04/4SqpQYac/K8dcGySQle/FrAZcbX68qXgC2K8HcPoQYFkHmq/V3GHFjsHnH5W8DmuJCQOuggVwshLeaEm5K9XFSzarqs+5Gv/ESycbN8EYV0ywJXyPQ3rSFOWoOIiKuse2fOyNzOvPpeDH8a2oGQudfYFdUBTN698nXQAoVdoEA5IuDXcq5EXNHUOtVtAkHsnmxrLaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l0xMXZmlHuVM3EEBQd7bqDWOuRONj0u2lAuRIIvpPbo=; b=RennL4fLp4+v94S8/Rb/KpAZme9jyHVz2zBtsw3n/MMJvTrTQrCnONuGNxZnSmdtG79lDXncJ/Lei0f6LgNUa57vOkh6M7pJzP950Eqp8nYS9wZkWXnPJi3O6o3T2+TW4RoKkIhiGSSh2QIP2ivtRIQrbRbtH54Vpz3Eov+7uSY= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB3286.namprd11.prod.outlook.com (2603:10b6:a03:79::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 22 Apr 2021 15:20:27 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::756a:2aef:40b1:11c8]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::756a:2aef:40b1:11c8%5]) with mapi id 15.20.4065.021; Thu, 22 Apr 2021 15:20:27 +0000 From: "Chautru, Nicolas" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH] baseband/turbo_sw: fix dereference of null Thread-Index: AQHXN1l0fPKVmW/LLEiev5kZbIQHl6rApxOw Date: Thu, 22 Apr 2021 15:20:27 +0000 Message-ID: References: <1619083505-65454-1-git-send-email-humin29@huawei.com> In-Reply-To: <1619083505-65454-1-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [45.28.143.88] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a875280e-b0ae-4f8a-4dc0-08d905a228a4 x-ms-traffictypediagnostic: BYAPR11MB3286: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:40; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /iOrPxykVINKgIESx+IszPbkBoqHTwD6TbZ4YX1BcN2UJA5BkCmR4ctmnLlfzuZDVq4krcPeBFM7SdFmP6Jg9o0D/hdin1ui/Lt7gSDPpRO7lpP0lnrV5LfFL+Znjdtd4Wzikf4Pn1cZPN5/KxuXoY0R0nT0VQl1aKR9CK7AG03NwrRBhjNJUD4R1UOQNVSS4TLlp6Oyk9MkjW1//FvYGCTpaY0Ywn7FfQjnP+9nHszC7yYze8umsqaITGIpYtJZn1AZ0lXu+k9u0O9k+MKTBp8Wh9YSkYjop09eoKMhCrj4X6HPu+/GH0yghxzpllvlVI3eS0Z07V4vv1SmNvp174Gb2/pH7ECOBD33SODaltkPzKm+KMoj2wyliATXJpHvzRTs9NfGuSCZl8Plz4NwriQbjEooFcZKIDA2R9RLPwbVcYPZrDffHja0EK/jiRjCfa0HizOAUGrLrQYa4p2ZTGZS1dPuv0i+WfhWqTkPNUMPjGjIXyN1IejHCDxRi63BdY+Sv4LL1zD0SxTXPWxklg3aCXbfrH20alJb+V0We3JjtV86rm/8JptF0Ctx/Tn7OEbLSQOc0k8TOuYTTd3HtB68RjpC1+UvnIaxyeXeDRI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(136003)(39860400002)(366004)(9686003)(38100700002)(66446008)(33656002)(52536014)(2906002)(110136005)(66556008)(66476007)(76116006)(8676002)(122000001)(6506007)(7696005)(4326008)(478600001)(83380400001)(186003)(316002)(71200400001)(5660300002)(8936002)(26005)(107886003)(86362001)(64756008)(66946007)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?RejO8h/hOGscgZ5c6kmuY5SuRsq479ltY1mRgGg4FqLV44xONjA3bD6idmkT?= =?us-ascii?Q?AI9MTJkzC7M20kwCWjc2wxpDSObOqAHg0hPlFtBmaqCv0h/v1XBgisrSOm+X?= =?us-ascii?Q?d0ngEvfKJXhiqyD0bZ2lK2pEGaWNNp4nOztVjNSIdPvs7sYRgdJYVaSJC6xt?= =?us-ascii?Q?LQ4pH7vV0THUzFlNgIvP9AQxh3KXqHqtWKluBT1r3wTK/mU/C4tVp9Ox58rh?= =?us-ascii?Q?jfYrR/EPyjsr2YHbV9jG3iPorQp1w2GFDluW97orJlhhyvzGFVhrxk+R/h8B?= =?us-ascii?Q?7nq0O5Uqz1gy39qNL6bv73WLmJKABuHcngOoA+THjMGQxDJ0OWN25Yh64EBq?= =?us-ascii?Q?b5vbIfCHIqMxpYGqB+3VXbT9ebV1EhtJ/lBZP8qKad7/FU+efxFeElIVy3C4?= =?us-ascii?Q?mhHnr93LrWj2PTPT/F4O89PvKtW7jpsXAZy81c7Az7+NOk4QIDdFveLmrGel?= =?us-ascii?Q?+zBuz+3TGkHTBFeR5YG0YLPT0bHhzUyxUpxJxDIK9f10HVcIZBy4fiZsPXYY?= =?us-ascii?Q?3wXbkLUaJax56B0QITaGQ7he/PGmGeC4aC/48zPMzPDXAUDbyuJXLgpzh16M?= =?us-ascii?Q?+PAlf6xTbfp8XpqrbP2fTkVoCMkDqTg365LIxAiTToXzgs09dMJnd0sfuoLi?= =?us-ascii?Q?ZTQfNK1PMgzLLiwf3eKbbRgygh3QDeEyu1bn8Nhmma+/naYoq8VS7vToYuKw?= =?us-ascii?Q?KtWMfrc6r5tGEscsuYcJPnpzzdkuYMNO7tdDvrJXaC5YZEdHP1wsq2oSx4YT?= =?us-ascii?Q?5G3E3uBogL/TXIM6uNJJtdhzW1MAk+uydGH9AFelRlbq02pnRwu1MMThnPuF?= =?us-ascii?Q?I3CosotgNc/Sstsw2H4t1ES/j9ZxsLBI2oigUSgYNC/WrE2ozaOL8U83ej/Z?= =?us-ascii?Q?boEU9JzapQkXHj4Mk7qr0O0BhUaUCLCXJrXZ/eRsjHGnu2Lv1WQy+I0JsFfu?= =?us-ascii?Q?0/+ecopexdk3Nea30buoRBUxXE91KlPs902cEwm6ToECb0J5DGIbyG8o3FNw?= =?us-ascii?Q?GgsMubFfsrxs3DT0VoxzjPJfvciRPLc7E7nQsMrdcmysejN1PGhpWRCcwlb9?= =?us-ascii?Q?/joiurNdaMyGJ2CdKUlFIBlCds8B0ymfrixSTRpcygQQZypubn9QjqiV+IGb?= =?us-ascii?Q?bOjTLkfFv0ErTIgpDG/EoL/exmGeJLL7L62sr7SmtQzzrgqbixNRwhMyj+zl?= =?us-ascii?Q?6GHbIinmuoRGPBYe7Kd2OuLKKtm6n1UNezVsHxIdq5LuAd/gX7/mzKgz6c0I?= =?us-ascii?Q?FYfY96WNfxC/bJIBg0xyUtMEaXo67yAANtcNVMStCjwDfdO3t0SHiH9szf5G?= =?us-ascii?Q?/UcSlKfxI78EuBr1rM4jHla4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a875280e-b0ae-4f8a-4dc0-08d905a228a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2021 15:20:27.3443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yGK+7dXwH09e5ehkmSa69i6woP+X214aPUqgi7zF65jdaQFCtgqSAjCUINVXRTFOoNMgrMVmu9t0tbRhZ89lR/KITt29Z2/yjndAzBl/ZJU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3286 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] baseband/turbo_sw: fix dereference of null X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Min Hu (Connor) > Sent: Thursday, April 22, 2021 2:25 AM >=20 > Return value of a function 'rte_malloc' is dereferenced without checking, > and may result in segmetation fault. >=20 > This patch fixed it. >=20 > Fixes: 31a7853d1ed9 ("baseband/turbo_sw: support large size code block") > Cc: stable@dpdk.org >=20 > Signed-off-by: Min Hu (Connor) Acked-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test- > bbdev/test_bbdev_perf.c > index 45b85b9..f94e2a9 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -957,6 +957,9 @@ init_op_data_objs(struct rte_bbdev_op_data *bufs, > if ((op_type =3D=3D DATA_INPUT) && large_input) { > /* Allocate a fake overused mbuf */ > data =3D rte_malloc(NULL, seg->length, 0); > + TEST_ASSERT_NOT_NULL(data, > + "rte malloc failed with %u bytes", > + seg->length); > memcpy(data, seg->addr, seg->length); > m_head->buf_addr =3D data; > m_head->buf_iova =3D > rte_malloc_virt2iova(data); > -- > 2.7.4