From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BB98A00C4; Tue, 8 Nov 2022 00:53:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4593B400D7; Tue, 8 Nov 2022 00:53:00 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D694C4003C for ; Tue, 8 Nov 2022 00:52:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667865179; x=1699401179; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4nFB/p/3rQ51W/ZSTUBOEhu+QTf/UTldLoaaZ5l20GA=; b=AWC6mWW21jBiz5h263va4OaTYNRMMEdhNZA1fVrRmIZ94ku/INASWXLi x1l+xU5aVDIXMg2+WELsfZAGehlOBx1kLMfoow0ydYN8KSdRIRVc/J5yy TGmxydMIq4L506dkf1d9RMpWky9ZC67VITStZHY7WYBOnymbFlWA+FEQw 0vzq8QPh4WqBOQ7MykMQNf5JAyfQrFRCe6MkBIhQMMQxVRaZ6xyx7HRow 5yL8alBDxk6tt8naG1+6YmZKdquOgbcE5O+KL41h/SvWS/jm0zBNgYB1D XIFcRa6bxKtE+E/uVzqlbgZzQq7JwZytCnFUw9qF3Fde2l44fqHGNszuc A==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="290275942" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="290275942" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 15:52:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="778696805" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="778696805" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 07 Nov 2022 15:52:57 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 15:52:57 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 15:52:57 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 7 Nov 2022 15:52:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FunTOolr4N75mVgtDZT+O8ia5jujul2SVZRUfKnuXPuawHmvjevH9wKrhMndgg6HBtbcTdwi9n6th7+2anz3I2ikfuU1zKWEggfrYP8RhfjqfIcnGizEQ/LiXpzwvU2BW50biGp9Vh907L6k2FdpPPAQFXHC398Mwb9sRkGdFU7VgkplESS6rtDEPKLTAmEj86HMgJM3rRBsX0iqcRVdCSLIbNhosBcpXrVmmxiugNePnpBBUj2K/zNU9kVo818dLfIeDvDn0nD09SThU1bshNUSAC+1nv4mlb1sYAuy3AIASmQQeQJrTXsQrjOg94JtDG/SgTk+KXGE2EV6TcLEZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W0F1H6BwpQwGIaTBAS/siqMkZ9PBsi6BywZ+iw0EiE4=; b=Tr9eTOEGIXJmxc+1RNMXIHjB9/7jr9CTWRXeDIejLrO2XxzPBHbe9pyCW0YfrKamOiuZA061tz2AqJ3F+rm8HvtPsNBZLueboti6VBhFKYc6uOS/KQiBNELqg4hYHpsL2cbATDWdxpGOgIm2LYgZgWiqZxvxIpp6r56O3dTN7L0uFqF7XbK45QPDg68vT+x9ZoWYxw5EvrxGFeNvNUdKCPGMkS+NcJn2e4TQmVE4Lwb8mFjrbgYR3ZylOz1HoW6uiJzDpLpCETo8usDp/DRzDYkGxnk96SQtpm+8SaDeJ7yincBW/ORt/qommBFPTu8RMcmt13Og1By3zpTNaR1G8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by SN7PR11MB6947.namprd11.prod.outlook.com (2603:10b6:806:2aa::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Mon, 7 Nov 2022 23:52:55 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::de48:e4af:4bd1:b30c]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::de48:e4af:4bd1:b30c%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 23:52:55 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon CC: "dev@dpdk.org" , "gakhil@marvell.com" , "maxime.coquelin@redhat.com" , "trix@redhat.com" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "Vargas, Hernan" Subject: RE: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Thread-Topic: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Thread-Index: AQHY3mR/OJU5Izo8vEyVyrRhEklaea4nNV6AgAGKGiCAAAWagIAAValwgAswTiA= Date: Mon, 7 Nov 2022 23:52:55 +0000 Message-ID: References: <20221012175930.7560-1-nicolas.chautru@intel.com> <3141057.vfdyTQepKt@thomas> <2968027.687JKscXgg@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB4451:EE_|SN7PR11MB6947:EE_ x-ms-office365-filtering-correlation-id: cc1c19d2-d6c4-45b8-5d12-08dac11b30b2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b25qH5yDsSn1QhdcxPmPwIhLklfVkPh4lEdkSCw06LQzAv/3fYs+8+9I/QcDnYPZURr4A3Vsnjnwkag/U7eKDr4rgVIRCouT4aATV8HCBtO+1s+4n2AsjSKp3f7BKZgNngF7RXEWl0JcB6vuuDiJ0lBJH/aMXmtS8ED9UO461eOupW6VrO4yLNWr1qng2v/rQmNgW+tIxrtlhkMUd5fnKx2vAG0sjuyd92eMeDV0qNi9MnveNoJ+GVVR0T7TtlyCOkrt5NuLTolV3zzsiTyRBoodGpAWL3igfhOBvd9ASKSCXWH9KLvUhJ90vmTpmV/xi9izz5XLTRuZWOB5zm/31xWliiRsoA8iOS5CC66HsEc8BA9pJt7ukmi9AHvyrDoSl89ShMfcDd6waZM3zcyJ1q54qs+98cAxAaMeuojzxpV/tJUR1+7iFQogUY6it+1P8wA989nrzIHa5zoSjQUkfvJQaORBHKU96nSu3OAHDNA6s7ZaOenASl3NQJ69Uv4hn5wNH92Z7sv+InCzSle4zHwZaSc6miWp1bck219vWYxA6n5cYpBZWkrPHnDyXx1d4eDlKYynG9c4AWnrEq7XemyQdNfGMDiYwZqoBqSFVbLoNXwb2zbfZsf8Wlod5Vmx2bELh0xLjxouFDdiSw5ZkQtfb2dbSmZc4vgUPziY18y6V5+9usv59eCZS+QDeFKEc36KuDsT3giCb7Qk6gviMZ3ZJy95f5Pbo9afSzIyfOfejg8QBGzokZo2g/q6o3AIl934+FLZOS25F5fsDRVisVvGBtaXUNzyWKCY+xxnkmo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(136003)(366004)(376002)(346002)(39860400002)(451199015)(52536014)(186003)(966005)(55016003)(107886003)(54906003)(6916009)(316002)(38100700002)(122000001)(33656002)(38070700005)(86362001)(82960400001)(26005)(83380400001)(6506007)(7696005)(9686003)(53546011)(41300700001)(478600001)(5660300002)(76116006)(66556008)(66476007)(8676002)(66446008)(8936002)(4326008)(66946007)(64756008)(71200400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Yvqm0etKi1y6YKhn2/VRuWlq097VIakS4muZ+SoV9jkAcOd0HHdBoSFmLrCm?= =?us-ascii?Q?545yWEF7mDU+S/jXrSudMR1t3e63WG7ICEQd/MUAu+AeIwgKhOFlt5NiuEzu?= =?us-ascii?Q?6H5EKNK8hZya0E8sIH4YQt5x950B/0GKZcC3+5YVtxAlnA4AM2w6heB+BfKN?= =?us-ascii?Q?To+mlaVd93NszUPY++8JXdPYtkVOKs4Vd92VH63g9dJkkZ1r1FIoTxBYV5br?= =?us-ascii?Q?2/MzSdLPGVqJgWrqjWP+uT0AbCdogTfwJpXx9UKcgGwnQNgo1noWtCOu1Pvh?= =?us-ascii?Q?mYROqIoG3JpaUbfH9WxHsgjddMHaPWpbbMQ2MySea3J/TkKSUIeF8nHs6To3?= =?us-ascii?Q?Phw7Xil6aru9o4meMSfbnSPnJhKGxQzMzvujFUjiV+S/2Ow5RO7JmMmf081s?= =?us-ascii?Q?LQUglPQC6c/HkeaDqWWKXAE8NnKKN1S2yYA1fVcUFGZp0QZr+YYuHMjE6xgU?= =?us-ascii?Q?h1tvGQnnW9rh1A9y/zNABVDxphhN+mRFkwxc4wnqMSWGAP9pffl5VkWOceUo?= =?us-ascii?Q?+kBhmuqvtmDWmFj9gU3PEBlXEAHqTsc0a1lPA05xWNXShyeetRlAC/iYcn0f?= =?us-ascii?Q?GxogQLvCGu8/exWcfzagrwmKkW3oNmyd56yRwORPXbJYIhSIgHBxLFr1Mli/?= =?us-ascii?Q?o72GFmsuzQZc9rWJZXDq7HjvVJMr6jq2hwdlI2jbir42IVUEnvLD4IlHeEIN?= =?us-ascii?Q?Sg5KnSfBwsRoii9PpMCARljRT9utQK1DxvmMAXwXC1EoK03DsaXW64x2lSsN?= =?us-ascii?Q?h9mNEsHPQDtT+MYD6aym+z3QZXvVpSVNLVcvkhJ+Uvuie4oMECSehYVHp2ZL?= =?us-ascii?Q?4o90fGkFqHuqZMCpDakQ/wyoVyIRDjec7izrGe3rJTVCFsF6oVL5Px++J2gL?= =?us-ascii?Q?AJVpBoV0p8VwSGxgA28LV4S0UtXxgfZ+G9mp80LQvqHkoSGboeMre0eQhqL/?= =?us-ascii?Q?CXY2Sw+E2YoPUmGEFIayAOQyLqa22jpXetcN60jEAC91wU+qia4Zp7JuQPNg?= =?us-ascii?Q?USdVYdXKG0ptHG/GoFmC+y4Rts9W6xkYSPP1OrBRym5fHv+nQKDSatONMiYt?= =?us-ascii?Q?wDWs0gbiFd7AJUdhG3H0PV5pU+Uq4VV/KJlbJBKTZRS6lcHWa8NcHSXnMDOX?= =?us-ascii?Q?JmST1nb+O7JsWjBXc5Lx/zqZJJaTGL7jxhlNZ9pXHwYW5jW+86cYg2toVasP?= =?us-ascii?Q?CsQhNx5KPZ5EdmbNKt9pjW2iliKxSGsqCIVo0aGhhVDfvs0zsHJuokQrIpr1?= =?us-ascii?Q?gNBXUqvzhg0umHIzDnY7UfkTOVV1lap/hpIY/TEqHtcBAKhE8hSNS5V8yvM+?= =?us-ascii?Q?XICcgjlXE8xwcgc2yKTgC6Ou1DMlEyRP2Pe4jH7cjJpwbaK6zr59zqgAR/Nv?= =?us-ascii?Q?HRxQ316kriCkqEFeKXU+sZwzZsCWCjf/3s8ob0oar59Iw5AsSqtxuzvgb9mD?= =?us-ascii?Q?QTp6bctBoINq7X3QT7OfMI4EHjBUilPjBTRX/U+Ycl/8EZpX/sM2lZOJZbH5?= =?us-ascii?Q?U/Sb7xaibwTCvpQGYtrdwgx+4/Vgm71WSvSdq+oWOV+FbiB/utprSwN5IUR9?= =?us-ascii?Q?j9HSlCnkNBN54zwKIGwWo/Iuj/9oGP0jDq2Sh/dw?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc1c19d2-d6c4-45b8-5d12-08dac11b30b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 23:52:55.1151 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H3yED31BTNA677lZt5J+kReBHQkvAnvNUn9HzgIiODfIr8e60GebwpPaULyIWVCNji6eQ5AIhEYKvfTgJFuhHCO2QiUOwK/vsAGoNNopr8U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6947 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas,=20 Reminder : do you mind kindly clarifying/confirming below. Then we can upda= te the docs accordingly. Thanks.=20 > -----Original Message----- > From: Chautru, Nicolas > Sent: Monday, October 31, 2022 2:41 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; gakhil@marvell.com; maxime.coquelin@redhat.com; > trix@redhat.com; Richardson, Bruce ; > hemant.agrawal@nxp.com; david.marchand@redhat.com; > stephen@networkplumber.org; Vargas, Hernan > Subject: RE: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 >=20 > Hi Thomas, >=20 > > -----Original Message----- > > From: Thomas Monjalon > > 31/10/2022 16:43, Chautru, Nicolas: > > > From: Thomas Monjalon > > > > 12/10/2022 19:59, Nicolas Chautru: > > > > > +Bind PF UIO driver(s) > > > > > +~~~~~~~~~~~~~~~~~~~~~ > > > > > + > > > > > +Install the DPDK igb_uio driver, bind it with the PF PCI device > > > > > +ID and use ``lspci`` to confirm the PF device is under use by > > > > > +``igb_uio`` DPDK > > > > UIO driver. > > > > > > > > igb_uio is not recommended. > > > > Please focus on VFIO first. > > > > > > > > > +The igb_uio driver may be bound to the PF PCI device using one > > > > > +of two methods for ACC200: > > > > > + > > > > > + > > > > > +1. PCI functions (physical or virtual, depending on the use > > > > > +case) can be bound to the UIO driver by repeating this command > > > > > +for every > > function. > > > > > + > > > > > +.. code-block:: console > > > > > + > > > > > + cd insmod ./build/kmod/igb_uio.ko > > > > > + echo "8086 57c0" > /sys/bus/pci/drivers/igb_uio/new_id > > > > > + lspci -vd8086:57c0 > > > > > + > > > > > + > > > > > +2. Another way to bind PF with DPDK UIO driver is by using the > > > > > +``dpdk-devbind.py`` tool > > > > > + > > > > > +.. code-block:: console > > > > > + > > > > > + cd ./usertools/dpdk-devbind.py -b > > > > > + igb_uio 0000:f7:00.0 > > > > > + > > > > > +where the PCI device ID (example: 0000:f7:00.0) is obtained > > > > > +using lspci -vd8086:57c0 > > > > > > > > This binding is not specific to the driver. > > > > It would be better to refer to the Linux guide instead of > > > > duplicating it again and again. > > > > > > > > > +In a similar way the PF may be bound with vfio-pci as any PCIe d= evice. > > > > > > > > You could mention igb_uio here. > > > > Is there any advantage in using igb_uio? > > > > > > > > > > Igb_uio is arguably easier to use to new user tend to start with it > > > or specific > > ecosystem. This is typically the entry point (no iommu, no flr below > > the bonnet, no vfio token...) hence good to have a bit of handholding > > with a couple of lines capturing how to easily run a few tests. I > > don't believe this is too redundant to have these few lines compared > > to the help in bring to the user not having to double guess their steps= . > > > More generally there are a number of module drivers combinations > > > that are > > supported based on different deployments. We don't document in too > > much details for the details since that is not too ACC specific and > > there is more documentation no pf_bb_config repo for using the PMD from > the VF.. > > > > > > Basically Thomas let us know more explicitly what you are suggesting > > > as > > documentation update. You just want more emphasis on vfio-pci flow > > (which is fair, some of it documented on pf_bb_config including the > > vfio token passing but we can reproduce here as well) or something else= ? > > > > There are 2 things to change: > > 1/ igb_uio is going to be deprecated, so we must emphasize on VFIO >=20 > Is there a date for deprecation? Do you mean to EOL the dpdk-kmods > repository itself; or something more specific for DPDK code like removing > RTE_PCI_KDRV_IGB_UIO; or last to just take out from documentation? > It tends to be historical but uio has value notably for ease of use. >=20 > 2/ for doc > > maintenance, it is better to have common steps described in one place. > > If needed, you can change the common doc and refer to it. >=20 > Do you mean to remove these sections and just add a pointer to > https://doc.dpdk.org/guides/linux_gsg/linux_drivers.html instead in all t= hese > bbdev PMDS? > Please kindly confirm. I see specific steps for binding in many other PMD= s docs > in DPDK, a bit redundant but provides simple steps specific to a PMD in o= ne > place. I don't mind either way. >=20 > Thanks > Nic >=20