From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01755A0C45; Mon, 13 Sep 2021 20:39:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 838DB40151; Mon, 13 Sep 2021 20:39:53 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 2CDBC4014F for ; Mon, 13 Sep 2021 20:39:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="208862376" X-IronPort-AV: E=Sophos;i="5.85,290,1624345200"; d="scan'208";a="208862376" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 11:39:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,290,1624345200"; d="scan'208";a="471665469" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 13 Sep 2021 11:39:50 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 11:39:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 13 Sep 2021 11:39:49 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 13 Sep 2021 11:39:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hvAu/enz8MrZwQOektetFQ79MoBoXLgI6MwuwLdrvmNJ0qXfF4gwXvsI86fdO+xOy8DF/NGM69N0ZHazR31w407kJCy7MyF48wUSyOOkC19eMYaDWYgxQSaA2i64MKuhvKhlXmFGuJmPbuzsbk6DXXOLytHa60iaDswPOHY8pBw7ib1nSX1qGCCvWoavNnX86NRp7j1Sd5Urd/u8gr+ehTRc3mIqKlbyC2rmCxk6FEGHm/8wrjhv+FhkWkFV9TVNLkbB+VEYqiuBmuITSwBeSHAPbHzapea9ZUxwq5DlMgVIPepqPrIsoOP8t3zhgMTjlnIbZqb6HcN5lF0z7eXwTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BE2imBrILAVDMHskDURzeCIcFVOgkg4FNARHAlTE1vk=; b=aZdgTswdDQV66ZJvhSFLf1u+hdGVTnOC9wnxeyFdyM5qxnMyKjNMVGHopbQkiPbyc9RpbDbhFE05A2wy3puOO6XxXkwyn/FrrjuzBFh8exkkTh5k+N77ClTYmsJRSK4ys5j5KX0I8hgDNbWZCjB/6EpgmqWv4OQHOItM27VbugjX38DwmrapYNHcTG+5e6GCVzyEF5GgzbzTPA0t9g78k8UWoLd8XEopWAbcYz/IUxbk1ICMMVsiin6l/NgF1wuJ8CIhwQOOgY/PDjxXX+mRgvV2TesCodhtCnEJNexKXJzdiNSL6VtJQSQN7FsfTS+01HJNwIFUOnRbhf+4FlM4oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BE2imBrILAVDMHskDURzeCIcFVOgkg4FNARHAlTE1vk=; b=xf1d57DyHAjOGttDJyYj7z41i+k1p1o6ia1b+Rwlf5WEwlVihLr5s4mcvymdcQSvha7VW71zaEM/orLu/8dAkm6K9LzJXwfthDhVxDoVbfcJpGX8PaT4vuMYAFjwosIvMAR7XVkRmPgELWn24htXTWM4ARQyD629TGQb6AQbudM= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BY5PR11MB4136.namprd11.prod.outlook.com (2603:10b6:a03:192::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Mon, 13 Sep 2021 18:39:41 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::4821:5aee:4cc4:75c9]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::4821:5aee:4cc4:75c9%5]) with mapi id 15.20.4500.018; Mon, 13 Sep 2021 18:39:41 +0000 From: "Chautru, Nicolas" To: Nipun Gupta , "dev@dpdk.org" , "gakhil@marvell.com" CC: "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Tom Rix Thread-Topic: [PATCH v5 1/9] bbdev: add big endian processing data capability Thread-Index: AQHXp8/qWmQWjx/GoEOAq8ATtEm/xauiTFQg Date: Mon, 13 Sep 2021 18:39:41 +0000 Message-ID: References: <20210318063421.14895-1-hemant.agrawal@nxp.com> <20210912121510.22699-1-nipun.gupta@nxp.com> <20210912121510.22699-2-nipun.gupta@nxp.com> In-Reply-To: <20210912121510.22699-2-nipun.gupta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5fc6162-c38c-4273-97ff-08d976e5d940 x-ms-traffictypediagnostic: BY5PR11MB4136: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xMzxvKHWtVECP3hT0cSDn1cSrwVAwvwDln3rwok4k1L42jp2vuI3t5paAhBirO7x8xbQ2/owwge0YJl5k0f+a2YTCHceqHnk9FWhozBwgm2xaGZGkJlfLHalr439SB0EdQcdtgndZK06vCGBWayYnkIAiJgMnudqefzGAtJsEznlz0J8wxFYoQuoWGIgmcHnupPMIGut5qDOMD2m2DraUBw/bbFZHOs2nAXN7nwriiay2xHV8GI3RRo5YiyuItqsj51z/cOmlyGoXvVmwnCZ4L1WsAtSa1r17VsB+sRh/xxeYcaThhclxNTi8KQ7gm21gdo/qoEpqo9IJDhlZDC8AlIYp0hzpUfsfL6gI7dv6aV+VXyK2gBb1ZEbJtk2dnGUwaxfMQBj7vuJkHYJtZrHnCfLBw4+UAtEmuPv9jh8/FUwZ/MdXYOzJ60IHxvR4A2kWH5jCE4do4t4QB0d2iFBALrIxN9pJVcEgEZLeJQepNOfMcdRkL+YKe43PnFH3FQy3YXikgjEy8effPETu/Wr6DBhnex6+q9NNzdvIxiMh5un4LwS/AZls9R+jFo2p5kGyhO3DjpxEuZ8SyMneuJets+331UnqpuINYQDbvdNZZ/25L9ITNHp4cxrhrPSBgmw+c9IUOSCQ1lNCE/GnoqHcphDd6S+xYIxw2QZgbcJH4bmppypkcxLhXGaVWa+Em7rnpH+T7N8DbcIioX0+NYvYg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(376002)(39860400002)(396003)(136003)(38100700002)(2906002)(7696005)(66446008)(55016002)(64756008)(6506007)(66946007)(53546011)(83380400001)(9686003)(8936002)(66476007)(66556008)(186003)(5660300002)(478600001)(110136005)(52536014)(26005)(33656002)(86362001)(316002)(122000001)(38070700005)(54906003)(4326008)(8676002)(76116006)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+m/GZFKp3JTiMor6yTT5qZXIIyGsgYv6GPZ0PuR1sfhQlQIhNaZYwvwoJ7OA?= =?us-ascii?Q?DjmwARV0CkSonpMEwEC9nIGDtA1gCV+Q7Q/1s2+ziLGMw/yVTleGVd9E0E/G?= =?us-ascii?Q?dRjcDqvqu9ZsQFIrmTb3ZiVoTAG4hrRBW+J0PhNZnMq59q1xirPbTPMDTNGn?= =?us-ascii?Q?JgneoSbWPE+QUKS42z2Xk09lQmH0V2OX9NooWTBIovZe7QhQAIr87ba+Pra1?= =?us-ascii?Q?hPXufGtKlzWNKM5PJRn7fqzx7qRieHxe4GEqkDTZbSsAe7uNRl2smeyA4U/h?= =?us-ascii?Q?SxMqppx7OiyOZMc/xpnnFYim09cCZtVQqhZ6ePRdZ0+dne1uOzKjSwUBAg0B?= =?us-ascii?Q?BvDclvHL3nKYKzdTTJW37qZNUJGTv6Xsyt9iATvBOD1RkyKi9cgCx42lbV7e?= =?us-ascii?Q?tjpRCcuSMo2fKzlGzC/DmYhY+WnUzEZinxigB1f2RdaoFyTUG/kdUP+2jpnP?= =?us-ascii?Q?GHPh8GEKhmKr7XNcdQTRi9VQNg4GKIvHtnyujb7p6oKeUXp6khiWJi96+3Cs?= =?us-ascii?Q?h+nB6mrM/MoorUMoEHQ6vdgip+qaQGWgNXVaY7dY7keVFHZKLWLh1ThN+Q8A?= =?us-ascii?Q?hUntD7gYdWohXN0LBvrRhLhqAL8f18Kk+X1QHEnZpKs9xDlOCVd+/awy+Inv?= =?us-ascii?Q?LNiudThGxl5uGGpmWFHM7VCf6diPIlkkwApBGZyzOpD9uXoMP5i+Hcm0ljZU?= =?us-ascii?Q?JaCOxp84WRQGU4K5sO79rCFRlHzk45YXZcymDK/U509TllGhBMtzb/2HrVu8?= =?us-ascii?Q?P3sUeZkdk3qoX/zNbLCEj6NgscLaisnfsdWtvXSaYuKIpHzFMuwN51AHug/O?= =?us-ascii?Q?IFZbq25+vXiTto4U0LwLosmwBvYyiiQ+P6+fd3DxwLO0tTNNB5FsyGy3+6Ti?= =?us-ascii?Q?qg8KH8393EUptePGs1QMW9E/iewtAO/Zu0nTGXtgg44cQez9Ol00snl1lLA9?= =?us-ascii?Q?vMIOI2ohWzLC7OXFEtU3jU3hPGHbqe/7ah6OAxbdHmnjhu5MF9K8SOM2IqlG?= =?us-ascii?Q?BwnnMMz/CJvy6EBU9uTunVDnlAxN5PKhWAcjUrO8ScyQpR7zouuIY766pEFs?= =?us-ascii?Q?bp1dxAcy42QlRVbfQ8LZdL+r3KiuAzxvm0gPzeD/cbNZKUwETtecxRJc8GZJ?= =?us-ascii?Q?qhrUU5ScoDP1ho2H28rSnQf4t/yP7H8+EawKDKlzEO5DSqXSXZ5bzyf9EbjI?= =?us-ascii?Q?XVnOgSTZxMC+3cZzNAB3iSv6aMKb3M9hYqb9nftaAE7+Ybf71/EYjKQaW4tL?= =?us-ascii?Q?qdbeIRrmoewFTuTFrONaaJfWpqw2Iq1F0JHYi6HE834zVsfB6b2Ch0yUwH97?= =?us-ascii?Q?vmAzaZk3CMA4hBeT4OLXK/Nl?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5fc6162-c38c-4273-97ff-08d976e5d940 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2021 18:39:41.3293 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CveJZHfwzKvNUO2it8iAupMBCKmB4D5h+87MEJpY8k5D4WPCAf2kQf2VksPbW1rvG7MyZHqPyNTtkpgCQyvOQ4LL47rpOcTaQ+fvhWFNWXo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4136 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 1/9] bbdev: add big endian processing data capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nipun Gupta > Sent: Sunday, September 12, 2021 5:15 AM > To: dev@dpdk.org; gakhil@marvell.com; Chautru, Nicolas > > Cc: david.marchand@redhat.com; hemant.agrawal@nxp.com; Nipun Gupta > > Subject: [PATCH v5 1/9] bbdev: add big endian processing data capability >=20 > This patch intoduces a new capability of the bbdev device to process the > LDPC data in big endian order. Hi Gupta,=20 As mentioned in previous patch iteration earlier this year I believe this i= s not really an operation flag but more a different device capability.=20 ie. you would have the same formalism for all operation (5GDL, 5GUL, 4GDL, = ...) for that PMD/hw and that is not something you will change dynamically = as an option. I would suggest to add this under "struct rte_bbdev_driver_info" which can = be used to capture device specific capability and information. In term of p= rocessing and operation, everything is the same except endianness assumptio= n for the input/output data.=20 >=20 > Signed-off-by: Hemant Agrawal > Signed-off-by: Nipun Gupta > --- > doc/guides/bbdevs/features/default.ini | 1 + > doc/guides/prog_guide/bbdev.rst | 6 ++++++ > lib/bbdev/rte_bbdev_op.h | 14 ++++++++++++-- > 3 files changed, 19 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/bbdevs/features/default.ini > b/doc/guides/bbdevs/features/default.ini > index 5fe267a625..ae5aacf8f7 100644 > --- a/doc/guides/bbdevs/features/default.ini > +++ b/doc/guides/bbdevs/features/default.ini > @@ -14,3 +14,4 @@ LLR/HARQ Compression =3D > External DDR Access =3D > HW Accelerated =3D > BBDEV API =3D > +Big Endian Processing =3D > diff --git a/doc/guides/prog_guide/bbdev.rst > b/doc/guides/prog_guide/bbdev.rst index 9619280ffc..6540b514bb 100644 > --- a/doc/guides/prog_guide/bbdev.rst > +++ b/doc/guides/prog_guide/bbdev.rst > @@ -747,6 +747,9 @@ given below. > |RTE_BBDEV_LDPC_ENC_CONCATENATION | > | Set if a device supports concatenation of non byte aligned output | = +------ > --------------------------------------------------------------+ > +|RTE_BBDEV_LDPC_ENC_BIG_ENDIAN | > +| Set if a device supports Big Endian data processing | > ++--------------------------------------------------------------------+ >=20 > The structure passed for each LDPC encode operation is given below, wit= h > the operation flags forming a bitmask in the ``op_flags`` field. > @@ -942,6 +945,9 @@ given below. > |RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK | > | Set if a device supports loopback access to HARQ internal memory | > +--------------------------------------------------------------------+ > +|RTE_BBDEV_LDPC_DEC_BIG_ENDIAN | > +| Set if a device supports Big Endian data processing | > ++--------------------------------------------------------------------+ >=20 > The structure passed for each LDPC decode operation is given below, wit= h > the operation flags forming a bitmask in the ``op_flags`` field. > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index > f946842727..9e9b5be81f 100644 > --- a/lib/bbdev/rte_bbdev_op.h > +++ b/lib/bbdev/rte_bbdev_op.h > @@ -186,7 +186,12 @@ enum rte_bbdev_op_ldpcdec_flag_bitmasks { > * for HARQ memory. If not set, it is assumed the filler bits are not > * in HARQ memory and handled directly by the LDPC decoder. > */ > - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS =3D (1ULL << > 18) > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS =3D (1ULL << > 18), > + /** Set if a device supports Big Endian data processing. > + * If not set Little Endian data processing is supported by > + * default. > + */ > + RTE_BBDEV_LDPC_DEC_BIG_ENDIAN =3D (1ULL << 8) > }; >=20 > /** Flags for LDPC encoder operation and capability structure */ @@ -206= ,7 > +211,12 @@ enum rte_bbdev_op_ldpcenc_flag_bitmasks { > /** Set if a device supports scatter-gather functionality. */ > RTE_BBDEV_LDPC_ENC_SCATTER_GATHER =3D (1ULL << 6), > /** Set if a device supports concatenation of non byte aligned output > */ > - RTE_BBDEV_LDPC_ENC_CONCATENATION =3D (1ULL << 7) > + RTE_BBDEV_LDPC_ENC_CONCATENATION =3D (1ULL << 7), > + /** Set if a device supports Big Endian data processing > + * If not set Little Endian data processing is supported by > + * default. > + */ > + RTE_BBDEV_LDPC_ENC_BIG_ENDIAN =3D (1ULL << 8) > }; >=20 > /** Flags for the Code Block/Transport block mode */ > -- > 2.17.1