From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BD5943885; Wed, 10 Jan 2024 18:17:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1E964025E; Wed, 10 Jan 2024 18:17:20 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id C20E54021E for ; Wed, 10 Jan 2024 18:17:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704907040; x=1736443040; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MoLmMgmXdt4zVR+lXALtazkE+Y1DnsUoUgubffuQfWw=; b=ND7fsdiNCD0/KYnmsGCkIM31u0Rv5ujhmlYv8G0legey5pmD/YQRV7Qi aNhQxRIYIZvWt+Q1ZxPF1yNq7OTGFUQzZP0ZNRoDTN6TRTn8BlTn6YIua BwcoOxt+cxEy25fTwMvgV9cddaqZe/V+jl+dvUHWhJh6cg0bUuU4TwSS2 6Xz8dflpcF+o6XA2MfSxf123tKPvn2GTDbyx6darLqVP13EcMFiL4eecY BL1F4LpQaZ2iG7cNgR1LazEFZA9XjnIT7YWdzAyGgz0I4LooX1ndIyvFq 4y4gO3kwUFOdDOkHswBsLFhdU9TyqsJb0V3F2MMM7O0FkgPhU6OSbJm3u A==; X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="5670549" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="5670549" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2024 09:17:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="775287952" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="775287952" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Jan 2024 09:17:04 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Jan 2024 09:17:04 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Jan 2024 09:17:04 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Jan 2024 09:17:04 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Jan 2024 09:17:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VwZG6yrS+Lv7zC1V+/pNp5exFVpRlaGeTo1+pHLvgUQqrKmX4xOkRBslwRatFLtZx0HmpPed0jrjXJq2D1PNPRwfjHEhUylA3144dUj7fpZotMwH8ev/BQ//u03L4Vx4elIInVXii8MR2ENFq2oR0OC+HnpcXEMtMHkVBVLCUsDoSedaIj9aNOianJEQAAurki9YA5KPbjfDvzVgIWR+fdABo0fJpeR76aNC47E+YpW3kCDW0YIS1nxcEYlovzxyc/+QzdfaK1QS2CDBjwiddyZ2p/OE0ZcPrOUK//ziQVuYcDQGaQRLsTb98ku3JFtYaG5O/B0K2ITTSYbsmymW3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gcHBBdwuYSN/d6ZINqaw6j/wVgTZuva6niBdVmpJpZo=; b=iRhoXnOn64THJi/ADXwCF8KEXZOTzdDJQPcuBQb4FZd14xeWMGZ3899i6oKFx/r+Rm+mBFiHPm8kDzqzWXkR72FomkoR8gHZuAhds+DOPIW0L0ycHIP5JTH+AORd8kUqe8kHZpdQe0OtOQSjqz6F5vTDxFB7UK6T0CBotZd0+A3yNUzdE4wD7TRSuy5PfY4gN3t70q2Lv+SM03zt+dYX41BFKl4NaSLB/90mXOmG/gGJJlzYiQu2VG6LuZfUPHl/b8FrwDCzrzoVmU2bes/wtozDxKsZO5qsGMagpw8hYZlN8UnfJpJWuUVB+1Y/yaTDFM7Cq2nGvOahj8hmKr7MaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by DS0PR11MB8070.namprd11.prod.outlook.com (2603:10b6:8:12d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 17:17:01 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::1837:7a0c:f8e0:2354]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::1837:7a0c:f8e0:2354%4]) with mapi id 15.20.7159.020; Wed, 10 Jan 2024 17:17:01 +0000 From: "Chautru, Nicolas" To: Stephen Hemminger , "Vargas, Hernan" CC: "dev@dpdk.org" , "gakhil@marvell.com" , "Rix, Tom" , "maxime.coquelin@redhat.com" , "Zhang, Qi Z" Subject: RE: [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes Thread-Topic: [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes Thread-Index: AQHaQBzLFvRJuluiwUG+88lGdDU8I7DLxRkAgAeL6FA= Date: Wed, 10 Jan 2024 17:17:00 +0000 Message-ID: References: <20240105211519.185086-1-hernan.vargas@intel.com> <20240105211519.185086-5-hernan.vargas@intel.com> <20240105140058.14b6b08b@hermes.local> In-Reply-To: <20240105140058.14b6b08b@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB4451:EE_|DS0PR11MB8070:EE_ x-ms-office365-filtering-correlation-id: b439db57-8d94-4ae4-53b1-08dc11fff532 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ee0gkzaTmu8WNO622jf/IIexj2dpf1Wwu2UzPgp8O2F4y7cYbhsOu/7VV8G/UncL1MuJ7vJx9NDf6zNBGSnCEdmvlHrjIalstKDQryPNbU2GMrH4oBLJu1Jis/zdwsFp+GXVa5OqifIXaKLoF73GYGxcP6mUDku1rE5Jpk6+tvEoWUEBaWzFsoDkh+QysdaJ/D6m29Mr/IVsN5G46DpXkxDFgWnI45Y+P+uYkaQ+TF9cLJhGbsFdQih/VLAWpBWwiYmu9miwFFDuRvL49WnjjiPmZvNykXrqiKLwEQhhweniZ4pUiNWSY/WGkmXy8aloZwZOQdJI8P2IJZ0Fpi3gjWL8PQ6yAx0IgTAdssfi4RYreuCThWM37+Ke369h4f/k5+qfDG3oJ3vg1FQecTUM0esvLk2I7cYyQeO7Zd1OPS8pUMl8XJ+mzP1CXBtB3EWN9OJwhE/ksjm1smeiFDgcu1yKPMdnHY6lIKV97KmoYVEO61uq2I5wOX0mT3ucjEjqiWS5Xm5grluPmdSFZS0H2B4KUEGvvcIUKa8kIpZ50xN7IFMVFp6DZINvSwN2EqyDvE6zbWgOgoQN9+zsyTloU+Hbvcf9NtSd2WE0qhaEB1Dn2OBADuOhjlgpd+n7U4cy x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(376002)(346002)(366004)(136003)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(38100700002)(83380400001)(71200400001)(122000001)(66446008)(55016003)(64756008)(8676002)(8936002)(52536014)(66556008)(66476007)(54906003)(4326008)(6636002)(76116006)(316002)(66946007)(110136005)(82960400001)(53546011)(9686003)(107886003)(26005)(7696005)(86362001)(33656002)(6506007)(478600001)(4744005)(2906002)(5660300002)(38070700009)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YNn45rIx2fzxp0N+AUrdE/fFb7u2qDqOU0DnynjPDBwD2DTM+h78TvQAElZm?= =?us-ascii?Q?QzqKhbJh5ggT/PPJLe7PMiJPovSueJU7AeN5OBT4VKED4DtXGpa2gjRhDjaW?= =?us-ascii?Q?kLIuZWXKFJKPiT2J+lAT1Ps18IwUhSmcp+2Wbn0Fh6W3lZWHNy/7VlwNakcb?= =?us-ascii?Q?GU48+p8PHwq3f7KuS/drxMBpEJewZ+9amQh8HHwgz0LUHS2O29+nXpuhY463?= =?us-ascii?Q?b4mHK705pKv0Om3v6acfLAW4zEKIMF17XLRfuWBpPaxQTnazROLDw9uu9cLm?= =?us-ascii?Q?S1Sua0R+ziJrkyXoiAVjAPj3txsVX8Z8RLc9xajAvPhIWuOmtkp05sdqmQhc?= =?us-ascii?Q?hvcyfYz3F1GOXWHL7xdN0WMtBCb+N1jQqLiLTTS+/Uw7Jw14HoHwElJWM3fX?= =?us-ascii?Q?hJo/9CLzu/A+SevfpttM0fj36CHcpoMf+qypT6/LB1+fMkaENkpbGSso5F9N?= =?us-ascii?Q?352O9a9MJATvsXGOJnbtdE/BwBFqdfITmJQngcfz6H2Q3XR3fpawvhbO79wd?= =?us-ascii?Q?QrqqZSHb1q7iBNOadCY4p/6Nc57euv6A9i8u+QjyXDcyzQJ4sWce5D6pjL/B?= =?us-ascii?Q?0FiMVWcZQVnW2HctFImzIwRLplo/O1SO6sJTujY8Whasj97RySsuMQ9QM2FO?= =?us-ascii?Q?yCPGS0SXmr2vdClQUZo6DSvdnl0w6Do34UCuoO3slOwO4g+LYnut1cUVJiXh?= =?us-ascii?Q?dQJZZXhzN//QK5U2UN0jth/hNeZlnp99/fycpv3nHk1jSDe/wLqI1jRkbsG0?= =?us-ascii?Q?Debgoe0P7UPlmRPLKCHq5sXsbZvjfura/6KPTwDe2tuOln1MCV3RpWaShSlW?= =?us-ascii?Q?HmQ69KG0fPzlkh0Bdial26PMmOm66VI/G8qNk58pLmJtYSizDCv3wdLd1XwT?= =?us-ascii?Q?DpsigU74JWppaV9reFH92a7hM54gjadwQrwVQ1YJF0rQKe0Ls0RZoyht3uX7?= =?us-ascii?Q?h+KDZjDivYs74NmkxXkiLCCRuRyD6+PDgU1MQ5E5pkVIkLDJ1qv+VD74lx37?= =?us-ascii?Q?kozfP2sbldju+vG8HCkhDUxYnbrtcxE2VyzvoTx6MU3n3DVpY5NW2T9agmt3?= =?us-ascii?Q?+zm6JPFQ1duak2SPEQ47WtxfPs1uKvN6hSOBkx+7r+aJkU6askz1ptY/0hDu?= =?us-ascii?Q?EHpSK+4k6bHtMDRwue1v903ZY7EKssYvoPuFXJniN0ho/ljvQLN/4GFvL6sl?= =?us-ascii?Q?bVXnvtEMZ0BEJAlm0nd3yWf1SFIVJ422P9Dg2IcD78X4LLlZq7keLowmFvhl?= =?us-ascii?Q?kSH8eGAYPOad6LwTL3XPiveNA7ufSWLOyLZ9rcXbbC9mpBVUttzNVHGvkyRq?= =?us-ascii?Q?hw8zqGzVFEilprNJp2IyF+kGExwMsBZBt8uPSl33buaLAoP0+viS7Us19CYB?= =?us-ascii?Q?nS1lDFskBpsxLVn6Yp236gQ5QoQ6WFLhBiMHv5g9fju6FVWw1l4/Kd8nmmfO?= =?us-ascii?Q?z4dj3eo+AKNQtn0hg5U88LHDdpnXmL17y2IhC4hwe48cAVvoy9Ci8XGF9xLG?= =?us-ascii?Q?8ZuvjoZAXIRVuJrcE6H5x9pBoIAL0AHh92AogYGpy+0D2AQkaPMbrgnuyjYe?= =?us-ascii?Q?SZxIOYTEY43esO0NZwwKsIudP0bntg2wxOdcAjrw?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b439db57-8d94-4ae4-53b1-08dc11fff532 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 17:17:00.7734 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 56TVd3JfPFzFkZanMExAPcwBQKvEqBujrv0pkxVcroPMTZKuqNefdvm7s97ymM9zCcDRFT0QwPyqQOdKdHKBCmvhAMO2n/1L5tQjwyREIIY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8070 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen,=20 We got that feedback from a couple of maintainers, so now we adhere to that= rule. In the coding guideline this is not said explicitly but all the examples ha= ve periods at the end. So now we just follow that recommendation as gospel. Possibly it would help to say more explicitly in DPDK coding guidelines wha= t is expected. Thanks Nic > -----Original Message----- > From: Stephen Hemminger > Sent: Friday, January 5, 2024 2:01 PM > To: Vargas, Hernan > Cc: dev@dpdk.org; gakhil@marvell.com; Rix, Tom ; > maxime.coquelin@redhat.com; Chautru, Nicolas ; > Zhang, Qi Z > Subject: Re: [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment > changes >=20 > On Fri, 5 Jan 2024 13:15:19 -0800 > Hernan Vargas wrote: >=20 > > Cosmetic changes for comments. > > No functional impact. > > > > Signed-off-by: Hernan Vargas > > --- >=20 > This is not helpful, there is no need for periods on every comment senten= ce.